On Thu, 7 Nov 2024 13:17:33 GMT, Kevin Rushforth wrote:
>> As specified in the security manager removal CSR,
>> [JDK-8341858](https://bugs.openjdk.org/browse/JDK-8341858), JavaFX now
>> checks at startup whether the security manager is enabled and fails fast
>> with an `UnsupportedOperationExc
On Thu, 7 Nov 2024 14:13:16 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/SecurityUtil.java line 48:
>>
>>> 46: * @throws UnsupportedOperationException if the security manager is
>>> enabled
>>> 47: */
>>> 48: public static void checkSecurityManag
On Tue, 5 Nov 2024 17:42:53 GMT, Ambarish Rapte wrote:
> Remove `doPrivileged` calls in the javafx.base module.
> The changes are straight forward.
> 1. Remove doPrivileged calls, with keeping the lambda expression.
> 2. Remove SuppressWarnings annotations
> 3. Remove unused imp
On Tue, 5 Nov 2024 21:47:54 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> us
On Tue, 5 Nov 2024 18:51:34 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
> Remove `doPrivileged` calls in the javafx.base module.
> The changes are straight forward.
> 1. Remove doPrivileged calls, with keeping the lambda expression.
> 2. Remove SuppressWarnings annotations
> 3. Remove unused imports
Ambarish Rapte has updated the pull request with a
On Tue, 5 Nov 2024 20:13:58 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unr
Remove `doPrivileged` calls in the javafx.base module.
The changes are straight forward.
1. Remove doPrivileged calls, with keeping the lambda expression.
2. Remove SuppressWarnings annotations
3. Remove unused imports
-
Commit messages:
- rm doPrivileged in javafx.base
Changes: htt
On Fri, 1 Nov 2024 15:01:10 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
On Fri, 18 Oct 2024 09:50:41 GMT, Ambarish Rapte wrote:
> Effectively a clean backport to update copyright year in doc files.
This pull request has now been integrated.
Changeset: cceddcf4
Author: Ambarish Rapte
URL:
https://git.openjdk.org/jfx23u/com
Effectively a clean backport to update copyright year in doc files.
-
Commit messages:
- doc copyright year update
Changes: https://git.openjdk.org/jfx23u/pull/27/files
Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=27&range=00
Issue: https://bugs.openjdk.org/browse/JDK-834
On Thu, 17 Oct 2024 05:58:31 GMT, Ambarish Rapte wrote:
> Update Copyright year in these 3 doc files to 2025.
This pull request has now been integrated.
Changeset: c4b1e1c0
Author: Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit/c4b1e1c019c98e97c64df8b11ee2f9635c67256d
St
Update Copyright year in these 3 doc files to 2025.
-
Commit messages:
- doc copyright year update
Changes: https://git.openjdk.org/jfx/pull/1602/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1602&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8341686
Stats: 3 li
On Tue, 4 Jun 2024 12:33:06 GMT, Marius Hanl wrote:
>> you are right: I see the focus rectangle jitter at 175% scale on win 11 (w/o
>> the fix), so it must be a different issue. At this scale, it merely shows a
>> thinner line, perhaps that's why I did not notice it earlier.
>
>> you are right
On Mon, 7 Oct 2024 20:03:49 GMT, Kevin Rushforth wrote:
> This PR removes support for running JavaFX applications with the Java
> Security Manager.
>
> The initial work was done in 4 separate commits as follows:
>
> * Fail fast at startup if the Security Manager is enabled
> * Remove `-Djava.s
On Fri, 11 Oct 2024 18:52:37 GMT, Kevin Rushforth wrote:
>> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
>> by the JDK, but will be terminally-deprecated in JDK 24 by
>> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
>> review at op
On Thu, 10 Oct 2024 12:31:53 GMT, Kevin Rushforth wrote:
>> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
>> by the JDK, but will be terminally-deprecated in JDK 24 by
>> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
>> review at op
On Wed, 2 Oct 2024 14:44:26 GMT, Kevin Rushforth wrote:
> This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 22.
>
> In order for JavaFX to be able to use newer JDK features, such as FFM, we
> need to increase the minimum version of the JDK required run the latest
> JavaF
On Tue, 8 Oct 2024 09:10:50 GMT, Michael Strauß wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Let `createGraphics` fail if called after dispose
>
> Marked as reviewed by mstrauss (Committer).
@mstr2 @l
On Tue, 8 Oct 2024 14:59:07 GMT, Thiago Milczarek Sayao
wrote:
>> When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When
>> scene changes, this is called on `WindowStage.java`:
>>
>> `QuantumRenderer.getInstance().disposePresentable(painter.presentable); //
>> latched on R
On Mon, 7 Oct 2024 16:50:59 GMT, Thiago Milczarek Sayao
wrote:
>> When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When
>> scene changes, this is called on `WindowStage.java`:
>>
>> `QuantumRenderer.getInstance().disposePresentable(painter.presentable); //
>> latched on R
On Fri, 4 Oct 2024 21:44:25 GMT, Kevin Rushforth wrote:
>> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
>> by the JDK, but will be terminally-deprecated in JDK 24 by
>> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
>> review at ope
On Thu, 3 Oct 2024 14:46:58 GMT, Andy Goryachev wrote:
> Are you on mac or windows? Are you testing the latest code (can you tell me
> the git commit hash?) Also, could you take a screenshot when this happens,
> I'd like to see the settings on the right pane.
Tested it on Mac by fetching this
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote:
> Update the boot JDK to version 23.
>
> Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle
> to the latest release, version 8.10.2, which supports JDK 23.
> It is advised to upgrade directly t
On Tue, 1 Oct 2024 19:16:06 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> us
On Thu, 3 Oct 2024 06:23:06 GMT, Michael Strauß wrote:
> Running `gradle wrapper --gradle-version 8.10.2
> --gradle-distribution-sha256-sum
> 31c55713e40233a8303827ceb42ca48a47267a0ad4bab9177123121e71524c26` on my
> Windows machine changes `gradlew` and `gradlew.bat` as follows:
This is not o
On Wed, 2 Oct 2024 23:15:41 GMT, Kevin Rushforth wrote:
> Doing this will ensure that gradlew and gradlew.bat are up-to-date with the
> latest version, which is not the case for this PR.
On a Mac machine, I had executed the command: `sh gradlew wrapper
--gradle-version 8.10.2`
It makes two cha
Update the boot JDK to version 23.
Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle to
the latest release, version 8.10.2, which supports JDK 23.
It is advised to upgrade directly to Gradle 8.10.2 rather than 8.10. refer to
[the release notes](https://docs.gradle.org/
On Fri, 27 Sep 2024 13:07:15 GMT, Kevin Rushforth wrote:
>> This PR modifies the header and footer of the javadoc-generated API docs to
>> add "DRAFT $VER-ea+$BLD" to clearly identify an ea build of the docs, and
>> also to make it clear which build number the docs refer to. This matches was
>
On Mon, 23 Sep 2024 15:48:00 GMT, Ambarish Rapte wrote:
> Requirement:
> We want to be able to test a JavaFX SDK built somewhere else other than on
> current machine or current repo on same machine. Which means we should be
> able to run the unit and system tests with a diff
On Tue, 24 Sep 2024 13:10:22 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - disable swt compileTestJava
>> - review: rename vars
>
> Looks good. I ra
avafx.graphics/build/classes/java/main/javafx.graphics/javafx
> It is fixed by change on line 2722
>
> 3. Base test: test.com.sun.javafx.runtime.VersionInfoTest
> It required path: build/module-lib/javafx.properties
> VersionInfoTest is specific to the local build of JavaFX. So, It
On Mon, 23 Sep 2024 23:03:54 GMT, Kevin Rushforth wrote:
> disable the compileTestJava task in the :swt project if IS_TEST_JAVAFX_SDK
> is true.
disabled the task accordingly.
Thanks for the review, updated the PR as per comments.
The names TEST_SDK_PATH and IS_TEST_SDK seem better.
> build.
avafx.graphics/build/classes/java/main/javafx.graphics/javafx
> It is fixed by change on line 2722
>
> 3. Base test: test.com.sun.javafx.runtime.VersionInfoTest
> It required path: build/module-lib/javafx.properties
> VersionInfoTest is specific to the local build of JavaFX. So, It
On Fri, 20 Sep 2024 20:47:06 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
Requirement:
We want to be able to test a JavaFX SDK built somewhere else other than on
current machine or current repo on same machine. Which means we should be able
to run the unit and system tests with a different JavaFX SDK.
Change:
# Run tests using a specified JavaFX SDK:
- I
On Thu, 19 Sep 2024 14:15:23 GMT, Kevin Rushforth wrote:
> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
> have an explicit `@Timeout` on either the methods or the class, and a default
> timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
> `@BeforeA
On Thu, 19 Sep 2024 23:17:31 GMT, Andy Goryachev wrote:
>> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose
>> hangs when called from the QuantumToolkit shutdown hook. A shutdown hook
>> should never run indefinitely, so the fix is to call dispose from a
>> background th
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote:
> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
> when called from the QuantumToolkit shutdown hook. A shutdown hook should
> never run indefinitely, so the fix is to call dispose from a background
> threa
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [
On Wed, 18 Sep 2024 15:25:47 GMT, Lukasz Kostyra wrote:
>> This PR migrates RenderPerf performance test application from jfx-sandbox
>> metal branch:
>> https://github.com/openjdk/jfx-sandbox/tree/metal/tests/performance/animation/RenderPerfTest/src/renderperf
>>
>> RenderPerf is a performance
On Mon, 16 Sep 2024 16:34:39 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Tue, 17 Sep 2024 13:48:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 12:01:41 GMT, Marius Hanl wrote:
>> In this case, keeping the values as instance variables is more reliable.
>> Since all the tests pass when hashValue and expected are instance variables
>> and some of them fail when I adding parameter to
>> testScriptTagWithCorrectHashV
On Mon, 16 Sep 2024 23:03:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 15:18:33 GMT, Andy Goryachev wrote:
>> Further additions to the MonkeyTester application:
>>
>> - tree/table view column property sheets ✔
>> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
>> button, canvas, split menu button, dnd ✔
>> - properties.
On Mon, 16 Sep 2024 15:35:19 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
On Fri, 13 Sep 2024 19:35:26 GMT, Andy Goryachev wrote:
>> Further additions to the MonkeyTester application:
>>
>> - tree/table view column property sheets ✔
>> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
>> button, canvas, split menu button, dnd ✔
>> - properties.
On Thu, 12 Sep 2024 12:51:27 GMT, Kevin Rushforth wrote:
>> When running JavaFX tests and apps with JDK 24, we now get illegal access
>> warnings of the following form:
>>
>>
>> WARNING: A restricted method in java.lang.System has been called
>> WARNING: java.lang.System::load has been called
On Mon, 9 Sep 2024 19:36:29 GMT, Andy Goryachev wrote:
> Further additions to the MonkeyTester application:
>
> - tree/table view column property sheets ✔
> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
> button, canvas, split menu button, dnd ✔
> - properties... cont
On Mon, 9 Sep 2024 16:47:21 GMT, Ambarish Rapte wrote:
> Following 2 warnings are observed with the JavaFX build.
> These warnings need to be addressed for updating to Gradle 9.0 in future.
>
> 1. The org.gradle.api.plugins.JavaPluginConvention type has been deprecated.
> This
On Tue, 10 Sep 2024 08:13:44 GMT, Ambarish Rapte wrote:
>> Following 2 warnings are observed with the JavaFX build.
>> These warnings need to be addressed for updating to Gradle 9.0 in future.
>>
>> 1. The org.gradle.api.plugins.JavaPluginConvention type has been
d.
>
> Verification:
> 1. Verify that build completes successfully
> 2. Above two warnings are not observed in build log.
> 3. This warning message is NOT observed in build log: Deprecated Gradle
> features were used in this build, making it incompatible with Gradle 9.0.
Ambari
Following 2 warnings are observed with the JavaFX build.
These warnings need to be addressed for updating to Gradle 9.0 in future.
1. The org.gradle.api.plugins.JavaPluginConvention type has been deprecated.
This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for
further
On Thu, 29 Aug 2024 21:02:41 GMT, Alexander Matveev
wrote:
> - Added support for libavcodec 61.
> - Updated AV plugins to use new APIs instead of APIs which were removed in 61.
> - We still using some deprecated APIs.
> - `reordered_opaque` replacement exist in 61 which is used to pass user data
On Fri, 30 Aug 2024 11:34:56 GMT, Oliver Schmidtmer wrote:
>> FileSystemJava had no valid implementation for pathFileName since the
>> function was renamed from pathGetFileName to pathFileName in the
>> FileSystem.h from WebKit
>
> Oliver Schmidtmer has updated the pull request incrementally wi
On Thu, 29 Aug 2024 14:11:01 GMT, Oliver Schmidtmer wrote:
>> FileSystemJava had no valid implementation for pathFileName since the
>> function was renamed from pathGetFileName to pathFileName in the
>> FileSystem.h from WebKit
>
> Oliver Schmidtmer has updated the pull request incrementally wi
On Thu, 22 Aug 2024 16:09:29 GMT, Ambarish Rapte wrote:
> Update copyright year in files updated in year 2024.
> This update is done specifically to update the year in webkit files, so that
> the webkit source shows no diff.
This pull request has now been integrated.
Changeset:
On Thu, 22 Aug 2024 17:09:10 GMT, Kevin Rushforth wrote:
> Looks good except for two media files. One definitely must be reverted (the
> legal file) and the other probably should be.
Thanks Kevin, Reverted both the files.
-
PR Comment: https://git.openjdk.org/jfx/pull/1543#issueco
> Update copyright year in files updated in year 2024.
> This update is done specifically to update the year in webkit files, so that
> the webkit source shows no diff.
Ambarish Rapte has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year in files updated in year 2024.
This update is done specifically to update the year in webkit files, so that
the webkit source shows no diff.
-
Commit messages:
- copyright year 2024
Changes: https://git.openjdk.org/jfx/pull/1543/files
Webrev: https://webrevs
On Tue, 20 Aug 2024 02:59:00 GMT, Ambarish Rapte wrote:
> Gradle 8.8 released on May 31, 2024, supports JDK 22.
> On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest
> gradle 8.9
>
> This gradle update is required in order to update the boot jdk t
On Tue, 20 Aug 2024 12:03:23 GMT, Kevin Rushforth wrote:
> The gradle update looks good. You missed updating the boot JDK for Windows in
> the GHA build. Also, can you merge in the latest master?
Thanks Kevin, Updated the GHA and merged with latest master.
-
PR Comment: https://gi
nges were required.
>
> This PR also includes the boot jdk update.
Ambarish Rapte has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains six additional
nges were required.
>
> This PR also includes the boot jdk update.
Ambarish Rapte has updated the pull request incrementally with one additional
commit since the last revision:
win bootjdk gha
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1539/files
- new: https://git.o
Gradle 8.8 released on May 31, 2024, supports JDK 22.
On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest
gradle 8.9
This gradle update is required in order to update the boot jdk to 22.0.2.
The changes are minimal, no source code changes were required.
This PR also inc
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote:
> The test in the bug report crashes reliably with JDK 22 on retina.
> It coincides with an update to the macOS compilers which seem likely to
> eagerly invalidate the target of a CFRelease on the native CTFontRef.
> Adding a ReachabilityFence t
On Mon, 5 Aug 2024 16:02:00 GMT, Lukasz Kostyra wrote:
> In modern graphics APIs having the knowledge of Shader's name can be
> necessary - whether it is because of a different Shader storage/loading
> behavior, or to fetch some additional metadata generated upon Shader
> precompilation. A goo
On Mon, 5 Aug 2024 16:02:00 GMT, Lukasz Kostyra wrote:
> In modern graphics APIs having the knowledge of Shader's name can be
> necessary - whether it is because of a different Shader storage/loading
> behavior, or to fetch some additional metadata generated upon Shader
> precompilation. A goo
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev
wrote:
> - For some reason H.265 decoder on Windows accepts proposed media format
> without error, but does not actually change output format.
> - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we
> proposed NV12, but decode
On Thu, 1 Aug 2024 22:41:05 GMT, Alexander Zuev wrote:
>> Initial implementation of the protocol.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing methods that supposed to generate attributed strings. String
> at
On Fri, 26 Jul 2024 23:00:33 GMT, Kevin Rushforth wrote:
>> This PR fixes a bad assumption in a few places in `build.gradle`, which
>> assumes that the module name can be derived from the name of the gradle
>> project name by prepending `"javafx."` to the name rather than using the
>> `moduleN
On Tue, 23 Jul 2024 14:55:49 GMT, Andy Goryachev wrote:
>> Minor clarifications in Javadoc
>>
>> **AccessibleAttribute**:
>> - Point2D and Bound values uses screen coordinates. Example: `BOUNDS`,
>> `BOUNDS_FOR_RANGE`, `OFFSET_AT_POINT`, ...
>> - clarified the meaning of `SELECTION_END`, `SELEC
On Wed, 17 Jul 2024 05:34:31 GMT, Alexander Zuev wrote:
>> Initial implementation of the protocol.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add comment about AccessibleRole enuM
I observed a crash in Ensemble.
1.
On Tue, 23 Jul 2024 14:52:02 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java
>> line 694:
>>
>>> 692: /**
>>> 693: * Returns the text selection start offset for the node.
>>> 694: * Selection start corresponds to the smalle
On Tue, 23 Jul 2024 14:45:19 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java line
>> 486:
>>
>>> 484: * {@link AccessibleAction#SET_TEXT}
>>> 485: * {@link AccessibleAction#SET_TEXT_SELECTION}
>>> 486: * {@link AccessibleA
On Thu, 18 Jul 2024 19:00:06 GMT, Andy Goryachev wrote:
> Minor clarifications in Javadoc
>
> **AccessibleAttribute**:
> - Point2D and Bound values uses screen coordinates. Example: `BOUNDS`,
> `BOUNDS_FOR_RANGE`, `OFFSET_AT_POINT`, ...
> - clarified the meaning of `SELECTION_END`, `SELECTION_S
On Tue, 9 Jul 2024 09:06:58 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one additiona
On Tue, 9 Jul 2024 14:48:30 GMT, Kevin Rushforth wrote:
>> I manually reverted the add/remove part, and replaced it with `git mv`. I
>> assume/hope that by squashing the commits, the add/remove will not be part
>> of the change.
>
> git doesn't actually track renames and copies, so there is ult
On Thu, 11 Jul 2024 22:56:18 GMT, Kevin Rushforth wrote:
> Updates for the beginning of the 23.0.1 release.
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx23u/pull/1#pullrequestreview-2176869193
On Wed, 10 Jul 2024 17:04:55 GMT, Ambarish Rapte wrote:
> Update the copyright year in files modified in year 2024.
This pull request has now been integrated.
Changeset: a41dcf3c
Author: Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit/a41dcf3cb7259af0b5feac404aa94c3c1b247
Update the copyright year in files modified in year 2024.
-
Commit messages:
- 8336110: Update copyright header for files modified in 2024
Changes: https://git.openjdk.org/jfx/pull/1500/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1500&range=00
Issue: https://bugs.open
On Mon, 8 Jul 2024 13:39:49 GMT, Ambarish Rapte wrote:
> The parameter "offset" is not validated in the 2 native methods getRGBImpl()
> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
> The PR adds the "offset < 0" check to both the
On Tue, 9 Jul 2024 17:10:07 GMT, Andy Goryachev wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> const vars
>
> modules/javafx.graphics/src/main/native-prism-sw/JAbstractSurface.c l
On Mon, 8 Jul 2024 13:31:03 GMT, Ambarish Rapte wrote:
> A quick fix to correct the created copyright year.
> The created year in the header was unintentionally modified previously from
> 2021 to 2017.
This pull request has now been integrated.
Changeset: dbda2cce
Author: Ambar
On Mon, 8 Jul 2024 22:51:47 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 24. I will integrate this to `master` as
> part of forking the `jfx23` stabilization branch, which is scheduled for
> Thursday, July 11, 2024 at 16:00 UTC.
Marked as reviewed by arapte (Reviewer).
-
> The parameter "offset" is not validated in the 2 native methods getRGBImpl()
> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
> The PR adds the "offset < 0" check to both the methods.
Ambarish Rapte has updated the pull request i
The parameter "offset" is not validated in the 2 native methods getRGBImpl()
and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
The PR adds the "offset < 0" check to both the methods.
-
Commit messages:
- add missing check
Changes: https://git.openjdk.org/j
A quick fix to correct the created copyright year.
The created year in the header was unintentionally modified previously from
2021 to 2017.
-
Commit messages:
- correct copyright year
Changes: https://git.openjdk.org/jfx/pull/1496/files
Webrev: https://webrevs.openjdk.org/?repo
On Thu, 4 Jul 2024 08:06:39 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor is
On Wed, 3 Jul 2024 20:26:35 GMT, Ambarish Rapte wrote:
>> eduardsdv has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - JDK-8322619: Move to the test.robot.com.sun.prism package and use
>> TOLERANCE w
On Wed, 3 Jul 2024 16:26:39 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor is
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
On Mon, 6 May 2024 14:14:05 GMT, eduardsdv wrote:
> This is an alternative solution to the PR:
> https://github.com/openjdk/jfx/pull/1310.
>
> This solution is based on the invariant that if a node is marked as dirty,
> all ancestors must also be marked as dirty and that if an ancestor is mark
On Wed, 12 Jun 2024 21:57:32 GMT, Kevin Rushforth wrote:
> This PR is a follow-on to #1474.
>
> Enable `javac -Werror` so that javac warnings, including but not limited to
> javac lint warnings, will cause the build to fail. As with the fix for
> [JDK-8327255](https://bugs.openjdk.org/browse/J
On Sat, 22 Jun 2024 13:37:30 GMT, Kevin Rushforth wrote:
>> This PR updates `build.gradle` to define javac lint options for three
>> different types of java compilation tasks: sdk classes, test classes
>> (including shims), and tool classes (including JSLC). The defaults for these
>> three gro
On Fri, 21 Jun 2024 12:50:45 GMT, Kevin Rushforth wrote:
> This PR enables two warnings that are now (or soon will be) enabled in the
> [jdk](https://github.com/openjdk/jdk) repo:
>
> 1. Binary file check -- this will alert the reviewers of a PR that the patch
> being reviewed includes one or
On Thu, 13 Jun 2024 20:07:32 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with two addition
1 - 100 of 510 matches
Mail list logo
