Integrated: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-06-27 Thread Ao Qi
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote: > This problem has been fixed > [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges > the fix in advance. > > Error log: > > > /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wt

Re: RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-06-27 Thread Ao Qi
On Fri, 21 Jun 2024 11:24:34 GMT, Kevin Rushforth wrote: >> This problem has been fixed >> [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges >> the fix in advance. >> >> Error log: >> >> >>

RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-06-21 Thread Ao Qi
This problem has been fixed [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges the fix in advance. Error log: /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: error: #error "Unsupported platform: need implementation of

Integrated: 8325093: Update CONTRIBUTING.md for build jdk version

2024-02-02 Thread Ao Qi
On Thu, 1 Feb 2024 06:36:51 GMT, Ao Qi wrote: > [JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK > to 19.0.1 from 18.0.2, and > [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK > to 21.0.1. `CONTRIBUTING.md` shoul

Re: RFR: 8325093: Update CONTRIBUTING.md for build jdk version

2024-02-02 Thread Ao Qi
On Fri, 2 Feb 2024 13:37:15 GMT, Kevin Rushforth wrote: >> [JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK >> to 19.0.1 from 18.0.2, and >> [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK >> to 21.0.1. `CONTRIBUTING.md` should be updated

RFR: 8325093: Update CONTRIBUTING.md for build jdk version

2024-01-31 Thread Ao Qi
[JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK to 19.0.1 from 18.0.2, and [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK to 21.0.1. `CONTRIBUTING.md` should be updated correspondingly. - Commit messages: - 8325093: Update

[jfx17u] Integrated: 8293214: Add support for Linux/LoongArch64

2023-02-04 Thread Ao Qi
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. This pull request has now been integrated. Changeset: 1b99a5b2 Author: Ao Qi Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx17u/com

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-03 Thread Ao Qi
On Fri, 3 Feb 2023 08:44:53 GMT, Johan Vos wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > I'm ok with this. > Apart from the functionality, this BP also makes it easier to backport future > changes in build.gradle (because it backports a structural

[jfx17u] Integrated: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON

2023-02-03 Thread Ao Qi
On Mon, 9 Jan 2023 13:29:27 GMT, Ao Qi wrote: > Clean backport. Verified on (after #102): > - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering > this problem) > - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`) > - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`) Th

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Ao Qi
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. RFC and RFR. Thanks. Should I take this PR out of Draft? - PR: https://git.openjdk.org/jfx17u/pull/102

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Ao Qi
On Mon, 9 Jan 2023 13:41:49 GMT, Kevin Rushforth wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > Backports to `jfx17u` require prior approval. You will need to seek such > approval from one of the project leads before taking this PR out of Draft. > >

[jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Ao Qi
Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. - Commit messages: - 8293214: Add support for Linux/LoongArch64 Changes: https://git.openjdk.org/jfx17u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u=102=00 Issue:

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Ao Qi
On Thu, 26 Jan 2023 05:30:56 GMT, Glavo wrote: > `List.of` is cleaner, and can slightly reduce the memory footprint for lists > of one or two elements. > > Because `List.of` can only store non-null elements, I have only replaced a > few usage. > > Can someone open an Issue on JBS for me?

[jfx17u] RFR: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON

2023-01-31 Thread Ao Qi
Clean backport. Verified on (after #102): - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering this problem) - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`) - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`) - Commit messages: - 8293375: add_definitions

Re: [jfx17u] RFR: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON

2023-01-31 Thread Ao Qi
On Mon, 9 Jan 2023 13:29:27 GMT, Ao Qi wrote: > Clean backport. Verified on (after #102): > - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering > this problem) > - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`) > - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off

Integrated: 8293214: Add support for Linux/LoongArch64

2022-09-16 Thread Ao Qi
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote: > LoongArch is a new RISC ISA. This issue proposes adding support for > Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but > the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit >

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]

2022-09-16 Thread Ao Qi
On Fri, 16 Sep 2022 14:09:39 GMT, Kevin Rushforth wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64 > > The changes look good.

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]

2022-09-15 Thread Ao Qi
On Thu, 15 Sep 2022 13:31:54 GMT, Johan Vos wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64 > > It looks good. I'll do a build an

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]

2022-09-15 Thread Ao Qi
On Thu, 15 Sep 2022 13:31:54 GMT, Johan Vos wrote: > It looks good. I'll do a build and then hopefully I can approve (those > ifeq/ifneq changes often need more than a few pair of eyes) Yes. We need to check it carefully:) I did some tests like: ifneq (,$(findstring $(ARCH), x64 x32

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]

2022-09-15 Thread Ao Qi
On Wed, 7 Sep 2022 12:02:37 GMT, Johan Vos wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> revert > > This PR looks safe to me. I don't see a scenario where this can cause > regress

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]

2022-09-08 Thread Ao Qi
On Wed, 7 Sep 2022 11:59:42 GMT, Johan Vos wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> revert > > build.gradle line 313: > >> 311: } else if (IS_MAC && OS_ARCH != "

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]

2022-09-08 Thread Ao Qi
nd graphics tests, {Release,Debug}, without > WebKit on Linux/loongarch64 Ao Qi has updated the pull request incrementally with one additional commit since the last revision: disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64 - Changes: - all: https://git.openjdk.o

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]

2022-09-06 Thread Ao Qi
On Tue, 6 Sep 2022 23:00:22 GMT, Alexander Matveev wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> revert > > Media changes looks good. Thanks for the review, @sashamatveev.

Re: RFR: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON

2022-09-06 Thread Ao Qi
On Tue, 6 Sep 2022 01:19:07 GMT, Leslie Zhai wrote: > Hi, > > jfx web failed to build when `USE_SYSTEM_MALLOC` is `ON`: > > > jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Platform.h:58, > jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Assertions.h:28, >

Re: RFR: 8293214: Add support for Linux/LoongArch64

2022-09-01 Thread Ao Qi
On Thu, 1 Sep 2022 12:51:34 GMT, Kevin Rushforth wrote: > The easiest way is to push an empty commit to your branch. Thanks, @kevinrushforth . The GHA tests passed. Some additional test results were updated in the PR description. - PR: https://git.openjdk.org/jfx/pull/888

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]

2022-09-01 Thread Ao Qi
> LoongArch is a new RISC ISA. This issue proposes adding support for > Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but > the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit > is updated to OpenJFX, it is supposed to work. Ao Qi

Re: RFR: 8293214: Add support for Linux/LoongArch64 [v2]

2022-09-01 Thread Ao Qi
> LoongArch is a new RISC ISA. This issue proposes adding support for > Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but > the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit > is updated to OpenJFX, it is supposed to work. Ao Qi

Re: RFR: 8293214: Add support for Linux/LoongArch64

2022-09-01 Thread Ao Qi
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote: > LoongArch is a new RISC ISA. This issue proposes adding support for > Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but > the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit >

RFR: 8293214: Add support for Linux/LoongArch64

2022-09-01 Thread Ao Qi
LoongArch is a new RISC ISA. This issue proposes adding support for Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit is updated to OpenJFX, it is supposed to work. - Commit