On Thu, 15 Sep 2022 13:31:54 GMT, Johan Vos <j...@openjdk.org> wrote:

> It looks good. I'll do a build and then hopefully I can approve (those 
> ifeq/ifneq changes often need more than a few pair of eyes)

Yes. We need to check it carefully:) I did some tests like:

ifneq (,$(findstring $(ARCH), x64 x32 loongarch64))
    CFLAGS += -msse2
endif

and it did cause errors like:

make: *** Waiting for unfinished jobs....
gcc: error: unrecognized command line option '-msse2'

-------------

PR: https://git.openjdk.org/jfx/pull/888

Reply via email to