On Wed, 3 Jul 2024 14:27:19 GMT, Ambarish Rapte wrote:
>> eduardsdv has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> s
On Wed, 3 Jul 2024 14:55:16 GMT, Kevin Rushforth wrote:
>> eduardsdv has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>>
On Wed, 3 Jul 2024 15:05:50 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/com/sun/prism/impl/NGNodeDirtyFlagTest.java
>> line 68:
>>
>>> 66: root = new StackPane();
>>> 67: primaryStage.setScene(new Scene(root, 500, 400));
>>> 68:
>>
>> Please add `pri
On Mon, 1 Jul 2024 18:24:36 GMT, Ambarish Rapte wrote:
>> eduardsdv has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> s
On Wed, 3 Jul 2024 14:30:45 GMT, Ambarish Rapte wrote:
>> eduardsdv has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> s
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
On Fri, 28 Jun 2024 10:25:58 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor i
> This is an alternative solution to the PR:
> https://github.com/openjdk/jfx/pull/1310.
>
> This solution is based on the invariant that if a node is marked as dirty,
> all ancestors must also be marked as dirty and that if an ancestor is marked
> as clean, all descendants must also be marked
On Wed, 13 Mar 2024 09:13:20 GMT, Florian Kirmaier
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> reverted accidental change in the .idea folder
>
> *push*
> It's still a important bug.
> If someone can guide
On Tue, 23 Jan 2024 11:51:52 GMT, Florian Kirmaier
wrote:
>> In some situations, a part of the SG is no longer rendered.
>> I created a test program that showcases this problem.
>>
>> Explanation:
>>
>> This can happen, when a part of the SG, is covered by another Node.
>> In this part, one no
On Wed, 13 Mar 2024 09:13:20 GMT, Florian Kirmaier
wrote:
> Maybe we could make snapshot based tests? That should work on all platforms,
> right?
We have a whole suite of tests which use similar methods to perform checks,
called robot tests. Since you want to check if a node was properly upda
On Tue, 23 Jan 2024 11:51:52 GMT, Florian Kirmaier
wrote:
>> In some situations, a part of the SG is no longer rendered.
>> I created a test program that showcases this problem.
>>
>> Explanation:
>>
>> This can happen, when a part of the SG, is covered by another Node.
>> In this part, one no
> In some situations, a part of the SG is no longer rendered.
> I created a test program that showcases this problem.
>
> Explanation:
>
> This can happen, when a part of the SG, is covered by another Node.
> In this part, one node is totally covered, and the other node is visible.
>
> When the
16 matches
Mail list logo
