[devel] [PATCH 0 of 1] Review Request for IMMTOOL: Cleanup the code and fix memory problem [#552]

2013-08-27 Thread Zoran Milinkovic
Summary: IMMTOOL: Cleanup the code and fix memory problem [#552] Review request for Trac Ticket(s): 552 Peer Reviewer(s): Neel Pull request to: Zoran Affected branch(es): default(4.4) Development branch: default(4.4) Impacted area Impact y/n -

Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOL: Cleanup the code and fix memory problem [#552]

2013-08-29 Thread Neelakanta Reddy
Hi zoran, Reviewed and tested the patch. Ack with minor comment. comment: Adding "\0" at the end of the string is not required. The imma saImmOmCcbObjectDelete will take care of adding "\0" at the end of the object, objectName.value[objectName.length] = 0; your patch worked because you sent

Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOL: Cleanup the code and fix memory problem [#552]

2013-08-29 Thread Neelakanta Reddy
Hi Zoran, yes, it is Ack for #549, #550 and #552(while pushing remove the two lines). /Neel. On Thursday 29 August 2013 06:51 PM, Neelakanta Reddy wrote: > Hi Zoran, > > yes, it is Ack for #549, #550 and #552(while pushing remove the two > lines). > > /Neel. > > > On Thursday 29 August 2013 06:

Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOL: Cleanup the code and fix memory problem [#552]

2013-08-29 Thread Neelakanta Reddy
Hi Zoran, yes, it is Ack for #549, #550 and #552(while pushing remove the two lines). /Neel. On Thursday 29 August 2013 06:51 PM, Neelakanta Reddy wrote: > Hi Zoran, > > yes, it is Ack for #549, #550 and #552(while pushing remove the two > lines). > > /Neel. > > > On Thursday 29 August 2013 06: