[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: add multi-socket testing

2025-06-23 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/919?usp=email to look at the new patch set (#6). The following approvals got outdated and were remov

[Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL

2025-06-23 Thread comododragon (Code Review)
Attention is currently required from: comododragon, flichtenheld. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email to look at the new patch set (#3). Change subject: Added PQE to WolfSSL ..

[Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL

2025-06-23 Thread comododragon (Code Review)
Attention is currently required from: comododragon, flichtenheld. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email to look at the new patch set (#2). Change subject: Added PQE to WolfSSL ..

[Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL

2025-06-23 Thread cron2 (Code Review)
Attention is currently required from: comododragon, flichtenheld. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email ) Change subject: Added PQE to WolfSSL .. Patch Set 3: Code-Rev

[Openvpn-devel] [PATCH applied] Re: dco linux: avoid redefining ovpn enums

2025-06-23 Thread Gert Doering
Patch looks good, and passes compile & smoke tests on Ubuntu 20.04 (with and without --disable-dco) & Gentoo. No other platforms affected. BB fails are due to infra issues (socks server refusing v6), unrelated to this patch. Your patch has been applied to the master branch. commit 1d3c2b67a73a0

[Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid redefining ovpn enums

2025-06-23 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1064?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by ordex Change subject: dco linux: avoid redefining ovpn enums ..

[Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid redefining ovpn enums

2025-06-23 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1064?usp=email ) Change subject: dco linux: avoid redefining ovpn enums .. dco linux: avoid redefining ovpn enums Starting with Linux kernel version 6.16,

[Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid redefining ovpn enums

2025-06-23 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1064?usp=email to review the following change. Change subject: dco linux: avoid redefining ovpn enums

[Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid redefining ovpn enums

2025-06-23 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1064?usp=email to look at the new patch set (#2). Change subject: dco linux: avoid redefining ovpn enums ...

[Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL

2025-06-23 Thread plaisthos (Code Review)
Attention is currently required from: comododragon, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email ) Change subject: Added PQE to WolfSSL .. Patch Set 3: (1

[Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid redefining ovpn enums

2025-06-23 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1064?usp=email ) Change subject: dco linux: avoid redefining ovpn enums

[Openvpn-devel] [PATCH v2] dco linux: avoid redefining ovpn enums

2025-06-23 Thread Gert Doering
From: Ralf Lici Starting with Linux kernel version 6.16, a couple of ovpn-related enum definitions were introduced in the `include/uapi/linux/if_link.h` header. Redefining them in openvpn when they are already present in the system headers can lead to conflicts or build issues. This commit ensur

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: add multi-socket testing

2025-06-23 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/919?usp=email ) Change subject: t_server_null: add multi-socket testing ..