-off-by: Flavio Leitner
---
lib/dpif-netlink.c | 8 +++
lib/dpif-netlink.h | 1 +
lib/netdev-linux.c | 64 +-
3 files changed, 67 insertions(+), 6 deletions(-)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 2ba05d7b1..f8da077bb
The netlink notification's ancillary data contains the network
namespace id (netnsid) needed to identify the device correctly.
Signed-off-by: Flavio Leitner
---
configure.ac | 3 +-
lib/automake.mk| 1 +
lib/dpif-netlink.c | 6 +--
lib/netdev-linux.c
- Fixed testsuite to run without openvswitch module loaded. (Ben)
* V3:
- Fixed long line (Greg)
- Rewrote assuming that the kernel will not send negative
numbers as valid network namespace id. (Ben, Flavio, Jiri)
* V2:
- report and close unexpected file descriptors (Ben)
*** BL
al Deep Ajmera
> Sent: Friday, February 23, 2018 12:49 AM
> To: d...@openvswitch.org
> Cc: Vishal Deep Ajmera ; Flavio Leitner
>
> Subject: [PATCH] rhel: Avoid losing bridge configuration after adding DPDK
> ports
>
> Whenever a DPDK port is added to or deleted from an O
used in a RHEL
> deployment
> to trigger post-up operations on the bridge device after a change of MAC
> address.
>
> Signed-off-by: Vishal Deep Ajmera
> Signed-off-by: Flavio Leitner
>
> ---
Thanks Vishal!
Acked-by: Flavio Leitner
t;
> [ Open vSwitch team ]
> --
> 2.7.4
>
> _______
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Acked-by: Flavio Leitner
--
Flavio
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ersion
>
> - -- Open vSwitch team Tue, 26 Sep 2017 13:34:23 -0700
> + -- Open vSwitch team Mon, 19 Feb 2018 11:12:33 -0700
>
> openvswitch (2.8.1-1) unstable; urgency=medium
>
> --
> 2.7.4
>
> ___
> dev mail
.9.0-1) unstable; urgency=low
> >
> > * New upstream version
> >
> > - -- Open vSwitch team Wed, 17 Jan 2018 09:49:31
> > -0700
> > + -- Open vSwitch team Wed, 19 Feb 2018 11:03:12
> > -0700
>
> Just a nit - 19 Feb is a Mon. :)
&
On Mon, Jan 29, 2018 at 02:59:42PM +0800, Yuanhan Liu wrote:
> Hi,
>
> Here is a joint work from Mellanox and Napatech, to enable the flow hw
> offload with the DPDK generic flow interface (rte_flow).
>
> The basic idea is to associate the flow with a mark id (a unit32_t number).
> Later, we then
31th January 2018
Attendees: Flavio, Johann, Olga, Aaron, Ben, Michael, Jan, Ian, Frikkie,
Sugesh, Yipeng
===
GENERAL
===
OVS 2.9 Release
- New features deadline for 2.9: 31/Jan.
- Patches on DPDK_MERGE_2_9
-- VHost Zero Copy (Experimental)
Potential patches for DPDK_MERGE_2_9
Outstand
On Fri, Jan 26, 2018 at 10:03:53AM -0800, Gregory Rose wrote:
> On 1/26/2018 5:30 AM, Flavio Leitner wrote:
> > Regarding to change --add-modules to --add-kernel, well, I don't see
> > how that is helping. Maybe I am missing something, but every time a
> > kernel is i
Hi Ben,
On Wed, Jan 10, 2018 at 04:07:38PM -0800, Ben Pfaff wrote:
> Thanks for the series. I actually think that it's pretty close. For
> me, this series falls into the category of "obviously the right
> direction but impossible to fully validate before applying it". It
> builds fine and I wa
el is installed, it will run weak-modules --add-kernel which
should create the weak-updates links accordingly, unless the kernel
is not compatible.
You can verify what the kernel's post install scripts does with this
command:
# rpm -q kernel --scripts
You should find this snippet:
if [ -x /sbin/weak
24th January 2018
Attendees: Flavio, Thomas, Jan, satananda, Michael, Ian, Zoltan, John, Aaron,
Ben, Johann, Pradeep, Simon, Olga, Frikkie,
===
GENERAL
===
OVS 2.9 Release
- New features deadline for 2.9: 31/Jan.
- Pull requests on a weekly basis, on Friday.
- Patches on DPDK_MERGE_2_9
On Tue, Jan 23, 2018 at 12:31:53PM -0800, Ben Pfaff wrote:
> On Wed, Jan 17, 2018 at 10:09:58PM -0200, Flavio Leitner wrote:
> > Today OVS pushes packets to the TAP interface ignoring its
> > current state. That works because the kernel will return -EIO
> > when it'
VLOG_WARN("%s: unsupported MTU %d\n", dev->up.name, mtu);
> return EINVAL;
We got a bug report for another related MTU issue because in older
OVS/DPDK, the i40e driver didn't include the 2 VLAN headers overhead,
so if the packet length is the ma
On Fri, Jan 19, 2018 at 10:51:59AM +, Stokes, Ian wrote:
> > Keepalive feature is aimed at achieving Fastpath Service Assurance in OVS-
> > DPDK deployments. It adds support for monitoring the packet processing
> > threads by dispatching heartbeats at regular intervals.
> >
>
> Hi All,
>
> T
On Wed, Jan 17, 2018 at 10:15:31PM -0200, Flavio Leitner wrote:
> On Wed, Jan 17, 2018 at 01:24:21PM -0800, Greg Rose wrote:
> > On minimal install RHEL 7 servers (and perhaps other types of installs)
> > you need to enable a couple of optional repositories for the yum-builddep
>
On Wed, Jan 17, 2018 at 01:24:21PM -0800, Greg Rose wrote:
> On minimal install RHEL 7 servers (and perhaps other types of installs)
> you need to enable a couple of optional repositories for the yum-builddep
> utility to work correctly. This patch documents those two optional
> repositories.
>
On Wed, Jan 17, 2018 at 10:10:17AM -0800, Ben Pfaff wrote:
> On Wed, Jan 17, 2018 at 04:51:20PM +, Vishal Deep Ajmera wrote:
> > > You mean add more details to NEWS file explaining that change?
> >
> > I am not much familiar with documentation part of ovs. It will help if
> > others can commen
WN). That would stop the traffic
breaking the use-case. This patch relies on netlink notifications
to find out if the device is local or not. When it's local, the
device state is checked otherwise it will behave as before.
Signed-off-by: Flavio Leitner
---
NEWS | 2 ++
lib/n
On Wed, Jan 17, 2018 at 09:42:34AM -0800, Guru Shetty wrote:
> On 17 January 2018 at 07:57, Flavio Leitner wrote:
>
> >
> > Hi,
> >
> > One of the reasons is to clean up a bit because today it is not
> > obvious that openvswitch.spec uses initscripts and shou
r OVS kernel modules...")
> CC: Ansis Atteka
> CC: Flavio Leitner
> Signed-off-by: Greg Rose
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi,
One of the reasons is to clean up a bit because today it is not
obvious that openvswitch.spec uses initscripts and shouldn't be
used for Fedora or RHEL-7.
Then we have openvswitch-fedora.spec which is not obvious if it
works or not in RHEL-7 too.
We could document that somehow, but it would
On Wed, Jan 17, 2018 at 12:43:08PM +, Vishal Deep Ajmera wrote:
> Hi Flavio,
Hi Vishal,
> I was testing your patch and comparing the stats of tap port for both
> ovs-master
> and your patch. The drop stats are now matching with master.
Thanks for doing that work, I appreciate it!
> Ho
On Wed, Jan 17, 2018 at 11:44:08AM +, Stokes, Ian wrote:
> > -Original Message-
> > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> > boun...@openvswitch.org] On Behalf Of Flavio Leitner
> > Sent: Tuesday, January 16, 2018 4:22 AM
> > To: d...@ope
On Tue, Jan 16, 2018 at 10:31:29AM -0800, Gregory Rose wrote:
> On 1/16/2018 10:15 AM, Flavio Leitner wrote:
> > On Tue, Jan 16, 2018 at 08:44:15AM -0800, Greg Rose wrote:
> > > Add post install and post un-install scripts to make sure that the
> > > openvswitch k
witch kernel modules from a previous installation will
> be found by the depmod search path.
>
> Suggested-by: Flavio Leitner
> Signed-off-by: Greg Rose
>
> ---
LGTM, though I have not tested.
Acked-by: Flavio Leitner
___
dev mai
WN). That would stop the traffic
breaking the use-case. This patch relies on netlink notifications
to find out if the device is local or not. When it's local, the
device state is checked otherwise it will behave as before.
Signed-off-by: Flavio Leitner
---
NEWS | 2 ++
lib
WN). That would stop the traffic
breaking the use-case. This patch relies on netlink notifications
to find out if the device is local or not. When it's local, the
device state is checked otherwise it will behave as before.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 16
Expose relevant vhost-user information in status.
Signed-off-by: Flavio Leitner
---
NEWS | 1 +
lib/netdev-dpdk.c | 62 +--
2 files changed, 61 insertions(+), 2 deletions(-)
Changelog:
V2 - Dropped the custom appctl command in
urich
> Sent: Monday, January 15, 2018 5:56 PM
> To: Vishal Deep Ajmera ; Flavio Leitner
> ; d...@openvswitch.org
> Cc: Rohith Basavaraja
> Subject: RE: [ovs-dev] [PATCH] netdev-linux: do not send packets to down tap
> ifaces.
>
> Hi Vishal,
>
> I assume you wan
in openvswitch vport-gre vport-stt vport-geneve \
+vport-lisp vport-vxlan; do
+ echo "/lib/modules/%{kernel}/extra/$m.ko"
+ done | /sbin/weak-modules --remove-modules
+ fi
+fi
%files
%defattr(0644,root,root)
fbl
>
> Suggested-by: Flavio Leitne
Hi,
Sorry to jump on this at v6 only, but I skimmed over the code and I am
struggling to understand what problem you're trying to solve. Yes, I
realize you want some sort of feedback about the PMD processing,
but it's not clear to me what exactly you want from it.
This last patchset uses a sepa
On Sat, Jan 13, 2018 at 10:59:25AM -0800, Gregory Rose wrote:
> On 1/12/2018 7:05 PM, Flavio Leitner wrote:
> > On Fri, Jan 12, 2018 at 03:46:16PM -0800, Gregory Rose wrote:
> > > On 1/12/2018 12:30 PM, Gregory Rose wrote:
> > > > On 1/12/2018 11:53 AM, Flavio Leitne
On Fri, Jan 12, 2018 at 03:46:16PM -0800, Gregory Rose wrote:
> On 1/12/2018 12:30 PM, Gregory Rose wrote:
> > On 1/12/2018 11:53 AM, Flavio Leitner wrote:
> > > On Fri, Jan 12, 2018 at 11:38:05AM -0800, Gregory Rose wrote:
> > > > On 1/12/2018 11:32 AM, Flavio Leitne
On Fri, Jan 12, 2018 at 11:38:05AM -0800, Gregory Rose wrote:
> On 1/12/2018 11:32 AM, Flavio Leitner wrote:
> > On Fri, Jan 12, 2018 at 08:37:43AM -0800, Greg Rose wrote:
> > > From: Gurucharan Shetty
> > >
> > > There are occasions when an openvswitch ke
On Fri, Jan 12, 2018 at 08:37:44AM -0800, Greg Rose wrote:
> A bug in RHEL 7.2 has been found in which a customer who installed
> a RHEL 7.2 openvswitch kernel module rpm with a slightly different
> minor build number than the running kernel found that the kernel
> modules were installed to the wro
On Fri, Jan 12, 2018 at 08:37:43AM -0800, Greg Rose wrote:
> From: Gurucharan Shetty
>
> There are occasions when an openvswitch kernel module rpm which does
> not match the exact build number of the running kernel. In that
> case the openvswitch kernel modules will be installed to the
> "weak-u
mentation that describes the new feature.
Sounds good.
Thanks,
fbl
>
> Thanks,
>
> Ben.
>
> On Fri, Jan 05, 2018 at 11:05:05AM -0200, Flavio Leitner wrote:
> >
> > Hi,
> >
> > I know this change is not easy to review, but at the same time
> > we
On Wed, Jan 10, 2018 at 03:09:30PM -0800, Ben Pfaff wrote:
> On Wed, Jan 10, 2018 at 02:06:43PM -0200, Flavio Leitner wrote:
> > Today OVS pushes packets to the TAP interface ignoring its
> > current state. That works because the kernel will return -EIO
> > when it'
WN). That would stop the traffic
breaking the use-case. This patch relies on netlink notifications
to find out if the device is local or not. When it's local, the
device state is checked otherwise it will behave as before.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 13 +
Thu, Dec 07, 2017 at 12:22:18AM -0200, Flavio Leitner wrote:
> Today Open vSwitch doesn't know about network namespaces (netns), but
> users are moving internal ports to other namespaces. Although packets
> are still flowing, the daemon fails to find out basic port information,
> li
I missed this one when I reviewed V1, but looks like some comments
still applies.
fbl
On Mon, Dec 11, 2017 at 08:00:08AM -0800, Darrell Ball wrote:
> Fix up some instances where variable declarations were not close
> enough to their use, as these were missed before. This is the
> preferred ar
Hi Darrell,
I am coming back from vacations, sorry the delay.
The patch doesn't apply anymore, but I reviewed anyways.
On Sun, Nov 19, 2017 at 01:02:19PM -0800, Darrell Ball wrote:
> Fix up some instances where variable declarations were not close
> enough to their use, as these were missed be
.
>
> Could be used for debugging mbuf leaks and other mempool related
> issues. Most useful in pair with `grep -v "cache_count.*=0"`.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d..
On Mon, Dec 11, 2017 at 04:18:42PM +0300, Ilya Maximets wrote:
> netdev-dpdk appctl commands added to man pages.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
Thanks!
___
dev mailing list
d...@openvswit
t; +free(response);
> +netdev_close(netdev);
> +}
> +
> /*
> * Set virtqueue flags so that we do not receive interrupts.
> */
> @@ -2816,6 +2866,10 @@ netdev_dpdk_class_init(void)
> "pci address of device", 1, 1,
>
s to pmds in the datapath \fIdp\fR based on their current usage.
> .
> +.so lib/netdev-dpdk-unixctl.man
> .so ofproto/ofproto-dpif-unixctl.man
> .so ofproto/ofproto-unixctl.man
> .so lib/vlog-unixctl.man
> --
> 2.7.4
>
I had the same feedback as Mark, and I reworded a bit to
When the netdev is in another namespace and the operation doesn't
support network namespaces, return the correct error.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 134 +++--
1 file changed, 120 insertions(+), 14 deletions(-)
kernel 4.2 or newer.
Signed-off-by: Flavio Leitner
---
lib/daemon-unix.c| 3 ++-
lib/daemon.man | 6 +++---
lib/daemon.xml | 8
lib/netdev-linux.c | 1 +
lib/netlink-protocol.h | 6 ++
lib/netlink-socket.c | 27
Signed-off-by: Flavio Leitner
---
utilities/nlmon.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/utilities/nlmon.c b/utilities/nlmon.c
index d38a70b6f..448b5eb5d 100644
--- a/utilities/nlmon.c
+++ b/utilities/nlmon.c
@@ -25,6 +25,7 @@
#include
#include
The ioctl interface doesn't support network namespaces, so
try updating the netdev using netlink message instead.
To provide backwards compatibility, fall back to the previous
method if netlink isn't supported or fails.
Signed-off-by: Flavio Leitner
---
lib/netdev-lin
-off-by: Flavio Leitner
---
datapath/linux/compat/include/linux/openvswitch.h | 2 +
lib/dpif-netlink.c| 8 +++
lib/dpif-netlink.h| 1 +
lib/netdev-linux.c| 63 ---
4 files changed
The netlink notification's ancillary data contains the network
namespace id (netnsid) needed to identify the device correctly.
Signed-off-by: Flavio Leitner
---
configure.ac | 3 +-
lib/automake.mk| 1 +
lib/dpif-netlink.c | 6 +--
lib/netdev-linux.c
- Fixed long line (Greg)
- Rewrote assuming that the kernel will not send negative
numbers as valid network namespace id. (Ben, Flavio, Jiri)
* V2:
- report and close unexpected file descriptors (Ben)
Flavio Leitner (6):
netlink: provide network namespace id from a msg.
netnsid: u
On Fri, 1 Dec 2017 13:15:06 -0800
Ben Pfaff wrote:
> On Thu, Nov 09, 2017 at 03:31:01PM -0200, Flavio Leitner wrote:
> > A port might be already in another netns, so initialize it
> > as invalid to force a state update.
> >
> > Signed-off-by: Flavio Leitner
>
On Tue, 14 Nov 2017 10:55:44 -0800
Gregory Rose wrote:
> On 11/9/2017 9:31 AM, Flavio Leitner wrote:
> > Recent kernels provide the network namespace ID of a port,
> > so use that to discover where the port currently is.
> >
> > Signed-off-by: Flavio Leitner
> >
On Fri, 1 Dec 2017 13:14:07 -0800
Ben Pfaff wrote:
> On Thu, Nov 09, 2017 at 03:31:00PM -0200, Flavio Leitner wrote:
> > The netlink notification's ancillary data contains the network
> > namespace id (netnsid) needed to identify the device correctly.
> > (ifindex and
On Fri, 1 Dec 2017 11:22:59 -0800
Ben Pfaff wrote:
> The coding style has never been explicit about this. This commit adds some
> explanation of why one position or the other might be favored in a given
> situation.
>
> Suggested-by: Flavio Leitner
> Sugg
On Mon, 20 Nov 2017 08:48:10 -0800
Ben Pfaff wrote:
> On Mon, Nov 20, 2017 at 11:42:43AM -0200, Flavio Leitner wrote:
> > On Sun, 19 Nov 2017 10:58:11 -0800 Ben Pfaff wrote:
> > > The other technical issue here is about whether && and || should be
> > > at t
x 0857c070c8ac..8752061d6439 100644
> --- a/ofproto/ofproto-dpif.h
> +++ b/ofproto/ofproto-dpif.h
> @@ -178,7 +178,10 @@ struct group_dpif *group_dpif_lookup(struct ofproto_dpif
> *,
> DPIF_SUPPORT_FIELD(size_t, sample_nesting, "Sample nesting") \
>
Hi Ben,
On Sun, 19 Nov 2017 10:58:11 -0800
Ben Pfaff wrote:
> On Fri, Nov 17, 2017 at 03:51:34PM -0200, Flavio Leitner wrote:
> > No functional change, just fixing coding style.
> >
> > Signed-off-by: Flavio Leitner
>
> I see from the thread that there's
On Sun, 19 Nov 2017 11:18:25 -0800
Ben Pfaff wrote:
[...]
> I tend to take this patch as a kind of bug report against the coding
> style document. The right response to that might be to explain why the
> coding style document is wrong and the history behind it, and to thank
> the submitter (thank
On Sat, 18 Nov 2017 00:41:27 +
Darrell Ball wrote:
> On 11/17/17, 3:01 PM, "Flavio Leitner" wrote:
>
> On Fri, 17 Nov 2017 19:34:49 +
> Darrell Ball wrote:
>
> > This patch mostly breaks OVS coding style in many instances and also
>
On Thu, 26 Oct 2017 15:30:42 -0400
Eric Garver wrote:
> This supports using the ct_clear action in the kernel datapath. To
> preserve compatibility with current ct_clear behavior on old kernels, we
> only pass this action down to the datapath if a probe reveals the
> datapath actually supports it
gt; +dnl (OVS maps to ESTABLISHED) means the initial frame was committed, but not
> a
> +dnl second time after the FIP translation (because ct_clear didn't occur).
> +NS_CHECK_EXEC([at_ns1], [echo "foobar" |nc $NC_EOF_OPT 10.254.254.1 1234])
> +OVS_WAIT_UNTIL([[ovs-
gt; # OVS_CHECK_IPROUTE_ENCAP()
> m4_define([OVS_CHECK_IPROUTE_ENCAP],
> [AT_SKIP_IF([! ip route help 2>&1 |grep encap >/dev/null])])
> +
> +# OVS_CHECK_CT_CLEAR()
> +m4_define([OVS_CHECK_CT_CLEAR],
> +[AT_SKIP_IF([! grep -q "Datapath supports ct_clear a
but I did not check carefully.
> There is some missed extra newlines after declarations, which generally looks
> ok; I’ll check more however.
> I also see some extra newlines removed which looked ok, but I’ll check more.
>
> I’ll submit my own patch since I don’t agree with “1” and
ifindex, prio, handle);
> del_ufid_tc_mapping(ufid);
>
> netdev_close(dev);
>
> -if (stats) {
> -memset(stats, 0, sizeof *stats);
> -}
> return error;
> }
>
Thanks for the V2 :-)
Acked-by: Flavio Leitner
--
Flavio
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
No functional change, just fixing coding style.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c | 335 +++-
1 file changed, 188 insertions(+), 147 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index f5a3aa9fa..022a0737b 100644
On Tue, 14 Nov 2017 14:54:20 -0800
Gregory Rose wrote:
> On 11/9/2017 9:30 AM, Flavio Leitner wrote:
> > Today Open vSwitch doesn't know about network namespaces (netns), but
> > users are moving internal ports to other namespaces. Although packets
> > are still fl
On Wed, 15 Nov 2017 11:17:42 -0500
Aaron Conole wrote:
> Flavio Leitner writes:
>
> > On Wed, 15 Nov 2017 02:20:16 -0500
> > Aaron Conole wrote:
> >
> >> Flavio Leitner writes:
> >>
> >> > Instead of listing all the dependencies
On Wed, 15 Nov 2017 02:20:16 -0500
Aaron Conole wrote:
> Flavio Leitner writes:
>
> > Instead of listing all the dependencies, use the RPM group
> > 'Development Tools' and the builddep tool to find specific
> > ones.
> >
> > Signed-off-by: Fl
On Wed, 8 Nov 2017 12:18:36 -0800
Ben Pfaff wrote:
> On Wed, Nov 08, 2017 at 03:31:48PM -0200, Flavio Leitner wrote:
> > On Wed, 01 Nov 2017 13:21:22 -0400
> > Aaron Conole wrote:
> >
> > > Guru Shetty writes:
> > >
> > > &g
Instead of listing all the dependencies, use the RPM group
'Development Tools' and the builddep tool to find specific
ones.
Signed-off-by: Flavio Leitner
---
Documentation/intro/install/fedora.rst | 54 +++---
Documentation/intro/install/rhel.
When the netdev is in another namespace and the operation doesn't
support network namespaces, return the correct error.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 134 +++--
1 file changed, 120 insertions(+), 14 deletions(-)
Signed-off-by: Flavio Leitner
---
utilities/nlmon.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/utilities/nlmon.c b/utilities/nlmon.c
index d38a70b6f..8d9d20f97 100644
--- a/utilities/nlmon.c
+++ b/utilities/nlmon.c
@@ -41,6 +41,7 @@ main(int argc OVS_UNUSED, char
kernel 4.2 or newer.
Signed-off-by: Flavio Leitner
---
lib/daemon-unix.c| 3 ++-
lib/daemon.man | 6 +++---
lib/daemon.xml | 8
lib/netdev-linux.c | 1 +
lib/netlink-protocol.h | 6 ++
lib/netlink-socket.c | 27
The ioctl interface doesn't support network namespaces, so
try updating the netdev using netlink message instead.
To provide backwards compatibility, fall back to the previous
method if netlink isn't supported or fails.
Signed-off-by: Flavio Leitner
---
lib/netdev-lin
Recent kernels provide the network namespace ID of a port,
so use that to discover where the port currently is.
Signed-off-by: Flavio Leitner
---
datapath/linux/compat/include/linux/openvswitch.h | 2 ++
lib/dpif-netlink.c| 6 ++
lib/dpif-netlink.h
A network device in another network namespace could have the
same name, so once the socket starts listening to other network
namespaces, it is necessary to confirm the netns id.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 50 +++---
1 file
A port might be already in another netns, so initialize it
as invalid to force a state update.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 184822816..c31334ce1 100644
--- a/lib/netdev
The netlink notification's ancillary data contains the network
namespace id (netnsid) needed to identify the device correctly.
(ifindex and netnsid).
Signed-off-by: Flavio Leitner
---
ChangeLog:
* V2
- report and close unexpected file descriptors.
configure.ac | 3 +-
to all netlink messages from all netns which has an ID assigned
into it. This and the previous change allows the userspace to track ports
in other network namespaces.
If any of the APIs aren't available, it falls back to the older APIs to
not break backwards compatibility.
Flavio Leitner (8)
Hi Ilya,
This patch is doing two things. If we need to revert the
mempool stuff, it will impact on everything on top of the
documentation refactoring.
I think the refactoring looks easier for Ian to get in.
I could ack just the refactoring because I haven't reviewed
the mempool change.
fbl
-vswitchd in order to avoid systemd to restart the other
> components due to dependencies (as explained in rhel/README.RHEL.rst).
>
> Signed-off-by: Timothy Redaelli
> ---
> v1->v2:
> * Renamed the script from ovs-reload to ovs-systemd-reload
>(as sug
On Wed, 01 Nov 2017 13:21:22 -0400
Aaron Conole wrote:
> Guru Shetty writes:
>
> > On 31 October 2017 at 13:06, Aaron Conole wrote:
> >
> > Ben Pfaff writes:
> >
> > > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
> > >> Ben Pfaff writes:
> > >>
> > >> > On Fri, Oc
>
> Implementation comments inline.
>
> Best regards, Ilya Maximets.
>
> On 06.11.2017 17:20, Flavio Leitner wrote:
> > Add a command to dump vhost-user's information.
> >
> > Signed-off-by: Flavio Leitner
> > ---
> > lib/netdev-dpdk.c
On Tue, 7 Nov 2017 07:34:24 -0400
"Raymond Burkholder" wrote:
> >
> > > > Add a command to dump vhost-user's information.
> > > >
> > >
> > > Thanks for the patch Flavio, I'll take a look in greater depth and test
> later
> > this week. On a first pass through though, I'd like to see the c
On Fri, 3 Nov 2017 11:26:47 -0700
Ben Pfaff wrote:
> On Thu, Nov 02, 2017 at 05:05:02PM -0200, Flavio Leitner wrote:
> > The netlink notification's ancillary data contains the network
> > namespace id (netnsid) needed to identify the device correctly.
> > (ifindex and
exposes internal information which is subjected
to change from version to version, so I wouldn't add to those
regular user facing guides.
fbl
>
> Ian
>
>
> > Signed-off-by: Flavio Leitner
> > ---
> > lib/netdev-dpdk.c | 124
> > ++
Add a command to dump vhost-user's information.
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 124 -
vswitchd/ovs-vswitchd.8.in | 4 ++
2 files changed, 126 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/n
On Tue, 31 Oct 2017 12:11:32 +0100
Timothy Redaelli wrote:
> The reload procedure will trigger a script that saves the flows and tlv
> maps (using ovs-save) then it restarts ovsdb-server, it stops ovs-vswitchd,
> it sets other_config:flow-restore-wait=true (to wait till flow restore is
> finished
Signed-off-by: Flavio Leitner
---
utilities/nlmon.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/utilities/nlmon.c b/utilities/nlmon.c
index 08a117b58..609b152f9 100644
--- a/utilities/nlmon.c
+++ b/utilities/nlmon.c
@@ -41,6 +41,7 @@ main(int argc OVS_UNUSED, char
When the netdev is in another namespace and the operation doesn't
support network namespaces, return the correct error.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 134 +++--
1 file changed, 120 insertions(+), 14 deletions(-)
kernel 4.2 or newer.
Signed-off-by: Flavio Leitner
---
lib/daemon-unix.c| 3 ++-
lib/daemon.man | 6 +++---
lib/daemon.xml | 8
lib/netdev-linux.c | 1 +
lib/netlink-protocol.h | 6 ++
lib/netlink-socket.c | 27
The ioctl interface doesn't support network namespaces, so
try updating the netdev using netlink message instead.
To provide backwards compatibility, fall back to the previous
method if netlink isn't supported or fails.
Signed-off-by: Flavio Leitner
---
lib/netdev-lin
A network device in another network namespace could have the
same name, so once the socket starts listening to other network
namespaces, it is necessary to confirm the netns id.
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 50 +++---
1 file
Recent kernels provide the network namespace ID of a port,
so use that to discover where the port currently is.
Signed-off-by: Flavio Leitner
---
datapath/linux/compat/include/linux/openvswitch.h | 2 ++
lib/dpif-netlink.c| 6 ++
lib/dpif-netlink.h
801 - 900 of 1046 matches
Mail list logo
