Allow passing different DEB_BUILD_OPTIONS to make debian-deb.
Signed-off-by: Roi Dayan
---
Notes:
v3
- Remove unneeded export call.
- Move assignment to an existing DPDK_NETDEV check.
v2
- Fix export of DEB_BUILD_OPTIONS in the Makefile
debian/automake.mk | 9
On 30/09/2024 17:16, Roi Dayan wrote:
>
>
> On 30/09/2024 12:42, Eelco Chaudron wrote:
>>
>>
>> On 29 Sep 2024, at 11:06, Roi Dayan wrote:
>>
>>> Allow passing different DEB_BUILD_OPTIONS to make debian-deb.
>>
>> Hi Roi,
>>
>>
On 30/09/2024 12:42, Eelco Chaudron wrote:
>
>
> On 29 Sep 2024, at 11:06, Roi Dayan wrote:
>
>> Allow passing different DEB_BUILD_OPTIONS to make debian-deb.
>
> Hi Roi,
>
> I did some experiments and it does not need the export part (or is it needed
> for
Allow passing different DEB_BUILD_OPTIONS to make debian-deb.
Signed-off-by: Roi Dayan
---
Notes:
v2
- Fix export of DEB_BUILD_OPTIONS in the Makefile
debian/automake.mk | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/debian/automake.mk b/debian
On 29/09/2024 9:47, Roi Dayan wrote:
>
>
> On 29/09/2024 9:33, Roi Dayan wrote:
>>
>>
>> On 27/09/2024 14:38, Eelco Chaudron wrote:
>>>
>>>
>>> On 26 Sep 2024, at 9:24, Roi Dayan via dev wrote:
>>>
>>>> Allow passing d
On 29/09/2024 9:33, Roi Dayan wrote:
>
>
> On 27/09/2024 14:38, Eelco Chaudron wrote:
>>
>>
>> On 26 Sep 2024, at 9:24, Roi Dayan via dev wrote:
>>
>>> Allow passing different DEB_BUILD_OPTIONS to make debian-deb.
>>>
>>> Signed-of
On 27/09/2024 14:38, Eelco Chaudron wrote:
>
>
> On 26 Sep 2024, at 9:24, Roi Dayan via dev wrote:
>
>> Allow passing different DEB_BUILD_OPTIONS to make debian-deb.
>>
>> Signed-off-by: Roi Dayan
>
> Hi Roy,
>
> Not sure if you noticed, but the
Allow passing different DEB_BUILD_OPTIONS to make debian-deb.
Signed-off-by: Roi Dayan
---
debian/automake.mk | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/debian/automake.mk b/debian/automake.mk
index 7b2afafae1a2..ebdcb022b3ef 100644
--- a/debian/automake.mk
Add ovsdb-idl prefix for tests in ovsdb-idl.at.
Add ovsdb-log prefix for tests in ovsdb-log.at.
Add ovsdb prefix for the rest of the ovsdb tests.
Signed-off-by: Roi Dayan
---
tests/ovsdb-execution.at | 4 +--
tests/ovsdb-idl.at | 62
tests/ovsdb
Some ovsdb tests were missing keywords that exists in all
other ovsdb tests.
Signed-off-by: Roi Dayan
---
tests/ovsdb-idl.at| 4 ++--
tests/ovsdb-server.at | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at
index 74ccaccdd2e9
maybe being ignored.
With this change I can install the policy file in RHEL8.2 and RHEL9.1.
Signed-off-by: Roi Dayan
---
selinux/openvswitch-custom.te.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/selinux/openvswitch-custom.te.in b/selinux/openvswitch-custom.te.i
the datapath flow no longer
exists, and the ukey can be deleted.
Reported-by: Roi Dayan
Co-authored-by: Han Zhou
Co-authored-by: Roi Dayan
Signed-off-by: Han Zhou
Signed-off-by: Roi Dayan
Signed-off-by: Eelco Chaudron
Signed-off-by: Aaron Conole
(cherry picked from commit
the datapath flow no longer
exists, and the ukey can be deleted.
Reported-by: Roi Dayan
Co-authored-by: Han Zhou
Co-authored-by: Roi Dayan
Signed-off-by: Han Zhou
Signed-off-by: Roi Dayan
Signed-off-by: Eelco Chaudron
Signed-off-by: Aaron Conole
NOTE: Backported a portion of
600125b2c380
the datapath flow no longer
exists, and the ukey can be deleted.
Reported-by: Roi Dayan
Co-authored-by: Han Zhou
Co-authored-by: Roi Dayan
Signed-off-by: Han Zhou
Signed-off-by: Roi Dayan
Signed-off-by: Eelco Chaudron
Signed-off-by: Aaron Conole
NOTE: Backported a portion of
600125b2c380
the datapath flow no longer
exists, and the ukey can be deleted.
Reported-by: Roi Dayan
Co-authored-by: Han Zhou
Co-authored-by: Roi Dayan
Signed-off-by: Han Zhou
Signed-off-by: Roi Dayan
Signed-off-by: Eelco Chaudron
Signed-off-by: Aaron Conole
NOTE: Backported a portion of
600125b2c380
the datapath flow no longer
exists, and the ukey can be deleted.
Reported-by: Roi Dayan
Co-authored-by: Han Zhou
Co-authored-by: Roi Dayan
Signed-off-by: Han Zhou
Signed-off-by: Roi Dayan
Signed-off-by: Eelco Chaudron
Signed-off-by: Aaron Conole
NOTE: Backported a portion of
600125b2c380
that the datapath flow no longer
exists, and the ukey can be deleted.
Reported-by: Roi Dayan
Co-authored-by: Han Zhou
Co-authored-by: Roi Dayan
Signed-off-by: Han Zhou
Signed-off-by: Roi Dayan
Signed-off-by: Eelco Chaudron
---
Thanks all, applied.
Hi,
Can we get this merged into 3.x
tive missed dumps. If four dumps
> are missed in a row, it is assumed that the datapath flow no longer
> exists, and the ukey can be deleted.
>
> Reported-by: Roi Dayan
> Co-authored-by: Han Zhou
> Co-authored-by: Roi Dayan
> Signed-off-by: Han Zhou
> Signed-off-by: R
eleted.
>
> Roi can you make sure the test passes on your system? I did 1024+ runs on my
> system and it passes each time. Also on GitHub it works, but your machine
> might be different, as it failed their in the past.
>
> Thanks,
>
> Eelco
Hi,
Everything seems to be work
On 10/07/2024 18:35, Eelco Chaudron wrote:
>
>
> On 9 Jul 2024, at 23:38, Ilya Maximets wrote:
>
>> On 7/3/24 12:28, Roi Dayan via dev wrote:
>>>
>>>
>>> On 03/07/2024 13:16, Eelco Chaudron wrote:
>>>>
>>>>
>>&g
r_sweep__ ?
>
>
> Regards,
>
>
> LIU Yulong
>
>
Hi,
It doesn't look like the same issue. from the dump there is looks
like the state of the ukey did get update to be UKEY_DELETE.
>
>
> -- Original --
> From: "Eelc
On 03/07/2024 13:16, Eelco Chaudron wrote:
>
>
> On 3 Jul 2024, at 9:33, Roi Dayan wrote:
>
>> It is observed in some environments that there are much more ukeys than
>> actual DP flows. For example:
>>
>> $ ovs-appctl upcall/show
>> system@ovs-syste
On 03/07/2024 13:01, Eelco Chaudron wrote:
>
>
> On 3 Jul 2024, at 9:31, Roi Dayan wrote:
>
>> On 18/06/2024 11:53, Eelco Chaudron wrote:
>>>
>>>
>>> On 18 Jun 2024, at 8:05, Roi Dayan wrote:
>>>
>>>> On 03/06/2024 16:29, Ee
Signed-off-by: Roi Dayan
---
ofproto/ofproto-dpif-upcall.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 83609ec62b63..08b3c70411aa 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif
On 18/06/2024 11:53, Eelco Chaudron wrote:
>
>
> On 18 Jun 2024, at 8:05, Roi Dayan wrote:
>
>> On 03/06/2024 16:29, Eelco Chaudron wrote:
>>>
>>>
>>> On 3 Jun 2024, at 10:07, Roi Dayan wrote:
>>>
>>>> On 03/06/2024 10
On 03/06/2024 16:29, Eelco Chaudron wrote:
>
>
> On 3 Jun 2024, at 10:07, Roi Dayan wrote:
>
>> On 03/06/2024 10:18, Roi Dayan wrote:
>>>
>>>
>>> On 30/05/2024 18:48, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On
TX queue ID 0 for port 'v1_r'.
Fix it.
Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering)
implementation.")
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
---
lib/dpif-netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif
2024 11:56
To: Roi Dayan
Cc: Ilya Maximets; d...@openvswitch.org; Maor Dickman
Subject: Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for
vlan ethertype.
On Thu, May 30, 2024 at 09:31:06AM +0300, Roi Dayan via dev wrote:
>
>
> On 28/05/2024 20:12, Ilya Maximets wrot
On 03/06/2024 10:18, Roi Dayan wrote:
>
>
> On 30/05/2024 18:48, Eelco Chaudron wrote:
>>
>>
>> On 23 May 2024, at 12:46, Roi Dayan via dev wrote:
>>
>>> It is observed in some environments that there are much more ukeys than
>>> actual DP f
On 30/05/2024 18:48, Eelco Chaudron wrote:
>
>
> On 23 May 2024, at 12:46, Roi Dayan via dev wrote:
>
>> It is observed in some environments that there are much more ukeys than
>> actual DP flows. For example:
>>
>> $ ovs-appctl upcall/show
>> system
On 28/05/2024 20:12, Ilya Maximets wrote:
> On 5/26/24 10:31, Roi Dayan via dev wrote:
>> From: Maor Dickman
>>
>> The cited commit reserved lower tc priorities for IP ethertypes in order
>> to give IP traffic higher priority than other management traffic.
>>
On 29/05/2024 17:35, Mike Pattrick wrote:
> On Thu, May 23, 2024 at 6:47 AM Roi Dayan via dev
> wrote:
>>
>> It is observed in some environments that there are much more ukeys than
>> actual DP flows. For example:
>>
>> $ ovs-appctl upcall/show
>> syst
Getting the following message while trying to build a debian package.
debian/openvswitch-switch.init
debian/openvswitch-switch.postinst
See above for files that use tabs for indentation.
Please use spaces instead.
Fix it.
Signed-off-by: Roi Dayan
---
debian/openvswitch-switch.init | 22
On 27/05/2024 15:44, Ilya Maximets wrote:
> On 5/27/24 13:00, Roi Dayan via dev wrote:
>> Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
>> lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized
>> in this function [-Werror=maybe-unini
Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
Signed-off-by: Roi Dayan
---
cmd;
| ~~^
lib/netdev-linux.c:2411:7: note: while referencing ‘sset_info’
2411 | } sset_info;
| ^
Fixes: 6c59c195266c ("netdev-linux: Use ethtool to detect offload support.")
Signed-off-by: Roi Dayan
---
lib/netdev-linux.c | 1 +
1 file changed, 1 inser
.
Fixes: c230c7579c14 ("netdev-offload-tc: Reserve lower tc prios for ip
ethertypes")
Signed-off-by: Maor Dickman
Acked-by: Roi Dayan
---
lib/netdev-offload-tc.c | 2 ++
lib/tc.h| 1 +
2 files changed, 3 insertions(+)
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-of
d-off-by: Han Zhou
Signed-off-by: Roi Dayan
---
ofproto/ofproto-dpif-upcall.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 83609ec62b63..e9520ebdf910 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b
On 06/05/2024 14:05, Ilya Maximets wrote:
> On 5/5/24 08:42, Roi Dayan via dev wrote:
>> From: Eli Britstein
>>
>> In case of a malformed packet, its parsing fails. Instead of continuing
>> and possible form a wrong flow, drop the packet.
>
> Hi, Eli and Roi.
From: Eli Britstein
Parsing of the packet has some validity checks. Return it as a return
value.
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
---
lib/flow.c | 6 +-
lib/flow.h | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index
From: Eli Britstein
In case of a malformed packet, its parsing fails. Instead of continuing
and possible form a wrong flow, drop the packet.
Relevant tests changed to send valid packets.
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
---
lib/dpif-netdev.c| 7 ++-
tests/mpls
When failing to get flow control parameters use VLOG_WARN_BUF()
to expose the error string in ovs-vsctl show.
Signed-off-by: Roi Dayan
Suggested-by: Simon Horman
Acked-by: Eli Britstein
---
lib/netdev-dpdk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev
On 16/04/2024 18:48, Simon Horman wrote:
> On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote:
>> VLOG_WARN_BUF() is allocating memory for the error string and should
>> e used if the configuration cannot continue and error is being returned
>> so the cal
("netdev-dpdk: Add option to configure VF MAC address.")
Signed-off-by: Roi Dayan
Acked-by: Gaetan Rivet
Acked-by: Eli Britstein
---
lib/netdev-dpdk.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 21
s Mi wrote:
>>>>
>>>>> Add three sFlow offload test cases:
>>>>>
>>>>>3: offloads - sflow with sampling=1 - offloads enabled ok
>>>>>4: offloads - sflow with sampling=2 - offloads enabled ok
>>>>>5: of
On 18/12/2023 9:45, Roi Dayan wrote:
>
>
> On 14/12/2023 15:25, Aaron Conole wrote:
>> Eelco Chaudron writes:
>>
>>> On 15 Nov 2023, at 3:33, Aaron Conole wrote:
>>>
>>>> Eelco Chaudron writes:
>>>>
>>>>> On
On 14/12/2023 15:25, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 15 Nov 2023, at 3:33, Aaron Conole wrote:
>>
>>> Eelco Chaudron writes:
>>>
>>>> On 14 Nov 2023, at 8:49, Roi Dayan wrote:
>>>>
>>>
On 13/11/2023 19:08, Aaron Conole wrote:
> Roi Dayan writes:
>
>> codespell dictionary contains a list of widely used words
>> which enchant alone could fail on. for an example:
>> refcount, pthread, enqueuing, etc.
>> Load that dictionary, if exists, into encha
On 13/11/2023 12:52, Roi Dayan wrote:
> Him
>
> The first patch is for using enchant add_to_session() to add
> words to current session only.
> The second patch is for improving the spell checker by adding
> the codespell dictionary of words.
>
> v2
> - Load cod
codespell dictionary contains a list of widely used words
which enchant alone could fail on. for an example:
refcount, pthread, enqueuing, etc.
Load that dictionary, if exists, into enchant spell checker.
Signed-off-by: Roi Dayan
---
utilities/checkpatch.py | 19 +++
1 file
From: Gaetan Rivet
The enchant dictionary synchronizes additions to the source file.
Keep the two word source separate by adding the extra words only
to the current session.
Signed-off-by: Gaetan Rivet
Acked-by: Roi Dayan
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1
session
instead of adding the entire dictionary.txt into the repo.
Gaetan Rivet (1):
checkpatch: Fix personal word list storage.
Roi Dayan (1):
checkpatch.py: Load codespell dictionary.
utilities/checkpatch.py | 21 -
1 file changed, 20 insertions(+), 1 deletion
codespell dictionary contains a list of widely used words
which enchant alone could fail on. for an example:
refcount, pthread, enqueuing, etc.
Load that dictionary, if exists, into enchant spell checker.
Signed-off-by: Roi Dayan
---
utilities/checkpatch.py | 19 +++
1 file
dictionary.txt into the repo.
Roi Dayan (1):
checkpatch.py: Load codespell dictionary.
utilities/checkpatch.py | 19 +++
1 file changed, 19 insertions(+)
--
2.38.0
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org
On 13/11/2023 11:46, Eelco Chaudron wrote:
>
>
> On 12 Nov 2023, at 8:22, Roi Dayan wrote:
>
>> On 10/11/2023 16:23, Aaron Conole wrote:
>>> Roi Dayan writes:
>>>
>>>> On 08/11/2023 21:04, Aaron Conole wrote:
>>>>> Roi Dayan vi
On 10/11/2023 16:23, Aaron Conole wrote:
> Roi Dayan writes:
>
>> On 08/11/2023 21:04, Aaron Conole wrote:
>>> Roi Dayan via dev writes:
>>>
>>>> On 02/11/2023 16:11, Eelco Chaudron wrote:
>>>>>
>>>>> On 2 Nov 2023, at
On 08/11/2023 21:04, Aaron Conole wrote:
> Roi Dayan via dev writes:
>
>> On 02/11/2023 16:11, Eelco Chaudron wrote:
>>>
>>> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>>>
>>>> Add personal words list as spellcheck.txt and load it
>
On 08/11/2023 20:50, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>>
>>> From: Gaetan Rivet
>>>
>>> The enchant dictionary synchronizes additions to the source file.
>>> Keep the t
From: Salem Sol
Introduce --skip-committer-signoff arg that can be used internally
by groups using gerrit for code reviews and gerrit maintainers could
do the rebase instead of the author or push upstream commits to be
merged through gerrit.
Signed-off-by: Salem Sol
Acked-by: Roi Dayan
First case without the skip flag should fail.
Second case uses the skip flag and should pass.
Signed-off-by: Roi Dayan
---
tests/checkpatch.at | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/tests/checkpatch.at b/tests/checkpatch.at
index
Hi,
This v2 is just adding checkpatch.at case to verify the flag.
Thanks,
Roi
Roi Dayan (1):
checkpatch.at: Add cases to verify skip committer check.
Salem Sol (1):
checkpatch: Add argument to skip committer signoff check.
tests/checkpatch.at | 26
On 02/11/2023 15:22, Eelco Chaudron wrote:
>
>
> On 2 Nov 2023, at 13:37, Roi Dayan via dev wrote:
>
>> From: Salem Sol
>>
>> Introduce --skip-committer-signoff arg that can be used internally
>> by groups using gerrit for code reviews and gerrit mainta
On 02/11/2023 16:07, Eelco Chaudron wrote:
>
>
> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>
>> From: Gaetan Rivet
>>
>> The enchant dictionary synchronizes additions to the source file.
>> Keep the two word source separate by adding the extra
On 02/11/2023 16:11, Eelco Chaudron wrote:
>
> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>
>> Add personal words list as spellcheck.txt and load it
>> into enchant spell checker. This file is generated from
>> codespell dictionary.txt and contains words use
On 02/11/2023 15:56, Eelco Chaudron wrote:
>
>
> On 2 Nov 2023, at 13:59, Roi Dayan via dev wrote:
>
>> From: Eli Britstein
>>
>> Fixes tag quotes another commit that might fail in a spell check. Don't
>> fail it.
>>
>>
From: Gaetan Rivet
The enchant dictionary synchronizes additions to the source file.
Keep the two word source separate by adding the extra words only
to the current session.
Signed-off-by: Gaetan Rivet
Acked-by: Roi Dayan
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1
On 02/11/2023 14:59, Roi Dayan wrote:
> From: Eli Britstein
>
> Fixes tag quotes another commit that might fail in a spell check. Don't
> fail it.
>
> Signed-off-by: Eli Britstein
> Acked-by: Roi Dayan
> ---
> utilities/checkpatch.py | 3 +++
> 1 file
From: Eli Britstein
Fixes tag quotes another commit that might fail in a spell check. Don't
fail it.
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
---
utilities/checkpatch.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
From: Salem Sol
Introduce --skip-committer-signoff arg that can be used internally
by groups using gerrit for code reviews and gerrit maintainers could
do the rebase instead of the author or push upstream commits to be
merged through gerrit.
Signed-off-by: Salem Sol
Acked-by: Roi Dayan
On 16/10/2023 19:27, Mike Pattrick wrote:
> On Mon, Oct 16, 2023 at 4:08 AM Roi Dayan via dev
> wrote:
>>
>>
>> On 16/10/2023 11:00, Roi Dayan wrote:
>>>
>>> On 16/10/2023 10:42, Eelco Chaudron wrote:
>>>>
>>>>
>>>>
On 16/10/2023 14:02, Eelco Chaudron wrote:
>
>
> On 16 Oct 2023, at 12:52, Roi Dayan wrote:
>
>> On 16/10/2023 11:31, Eelco Chaudron wrote:
>>>
>>>
>>> On 16 Oct 2023, at 10:07, Roi Dayan wrote:
>>>
>>>> On 16/10/2023 11:00
On 16/10/2023 11:31, Eelco Chaudron wrote:
>
>
> On 16 Oct 2023, at 10:07, Roi Dayan wrote:
>
>> On 16/10/2023 11:00, Roi Dayan wrote:
>>>
>>> On 16/10/2023 10:42, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 16 Oct 2023, a
On 16/10/2023 11:00, Roi Dayan wrote:
>
> On 16/10/2023 10:42, Eelco Chaudron wrote:
>>
>>
>> On 16 Oct 2023, at 9:09, Roi Dayan wrote:
>>
>>> On 09/10/2023 15:05, Roi Dayan wrote:
>>>> The cited commit fixed missing mirror packets by rese
On 16/10/2023 10:42, Eelco Chaudron wrote:
>
>
> On 16 Oct 2023, at 9:09, Roi Dayan wrote:
>
>> On 09/10/2023 15:05, Roi Dayan wrote:
>>> The cited commit fixed missing mirror packets by reset mirror when
>>> packets are modified but setting geneve option
On 09/10/2023 15:05, Roi Dayan wrote:
> The cited commit fixed missing mirror packets by reset mirror when
> packets are modified but setting geneve options was also treated as
> a modified packet but should be treated as a part of set_tunnel
> which doesn't reset m
On 09/10/2023 15:05, Roi Dayan wrote:
> Test geneve options mirror flow doesn't add redundant mirror.
>
> Signed-off-by: Roi Dayan
> ---
>
> Notes:
> v3:
> - use AT_CHECK for configuring the mirror port.
>
> v2:
> - add do
Use test title prefix according to filename the test is in
for tunnel.at and ofproto-dpif.at.
Signed-off-by: Roi Dayan
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
---
Notes:
v2:
- add prefix to bond cases.
tests/ofproto-dpif.at | 10 +-
tests/tunnel.at | 2 +-
2
s that are modified.")
Signed-off-by: Roi Dayan
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
---
Notes:
v2:
- user correct sha in fixes line.
ofproto/ofproto-dpif-xlate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofpro
Test geneve options mirror flow doesn't add redundant mirror.
Signed-off-by: Roi Dayan
---
Notes:
v3:
- use AT_CHECK for configuring the mirror port.
v2:
- add dot in title.
tests/tunnel.at | 29 +
1 file changed, 29 insertions(+)
diff --
Hi,
The first commit removing the redundant mirror when using tunnel options.
The second is a test to verify it stays like this and doesn't break again.
The third commit is just updating prefixes of tests to match the file their in.
Thanks,
Roi
Roi Dayan (3):
ofproto-dpif-upcall
On 09/10/2023 12:56, Eelco Chaudron wrote:
>
>
> On 8 Oct 2023, at 9:08, Roi Dayan wrote:
>
>> On 05/10/2023 15:36, Eelco Chaudron wrote:
>>>
>>>
>>> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote:
>>>
>>>> Test geneve opti
On 05/10/2023 15:36, Eelco Chaudron wrote:
>
>
> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote:
>
>> Test geneve options mirror flow doesn't add redundant mirror.
>>
>> Signed-off-by: Roi Dayan
>
> In general this patch looks good, some small nit
Use test title prefix according to filename the test is in
for tunnel.at and ofproto-dpif.at.
Signed-off-by: Roi Dayan
---
Notes:
v2:
- add prefix to bond cases.
tests/ofproto-dpif.at | 10 +-
tests/tunnel.at | 2 +-
2 files changed, 6 insertions(+), 6 deletions
Test geneve options mirror flow doesn't add redundant mirror.
Signed-off-by: Roi Dayan
---
Notes:
v2:
- add dot in title.
tests/tunnel.at | 29 +
1 file changed, 29 insertions(+)
diff --git a/tests/tunnel.at b/tests/tunnel.at
index ddeb66b
s that are modified.")
Signed-off-by: Roi Dayan
Acked-by: Simon Horman
---
Notes:
v2:
- user correct sha in fixes line.
ofproto/ofproto-dpif-xlate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
ind
Hi,
The first commit removing the redundant mirror when using tunnel options.
The second is a test to verify it stays like this and doesn't break again.
The third commit is just updating prefixes of tests to match the file their in.
Thanks,
Roi
Roi Dayan (3):
ofproto-dpif-upcall
On 04/10/2023 12:46, Simon Horman wrote:
> On Tue, Oct 03, 2023 at 05:03:20PM +0300, Roi Dayan via dev wrote:
>> Use test title prefix according to filename the test is in
>> for tunnel.at and ofproto-dpif.at.
>>
>> Signed-off-by: Roi Dayan
>> ---
>> tes
Use test title prefix according to filename the test is in
for tunnel.at and ofproto-dpif.at.
Signed-off-by: Roi Dayan
---
tests/ofproto-dpif.at | 6 +++---
tests/tunnel.at | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
On 03/10/2023 16:54, Roi Dayan wrote:
> Test geneve options mirror flow doesn't add redundant mirror.
>
> Signed-off-by: Roi Dayan
> ---
> tests/tunnel.at | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/tests/tunnel
On 03/10/2023 15:22, Ilya Maximets wrote:
> On 10/3/23 10:33, Roi Dayan wrote:
>> The cited commit fixed missing mirror packets by reset mirror when
>> packets are modified but setting geneve options was also treated as
>> a modified packet but should be treated as a part o
Test geneve options mirror flow doesn't add redundant mirror.
Signed-off-by: Roi Dayan
---
tests/tunnel.at | 29 +
1 file changed, 29 insertions(+)
diff --git a/tests/tunnel.at b/tests/tunnel.at
index ddeb66bc9fb7..c0b932110446 100644
--- a/tests/tunnel.at
On 03/10/2023 13:36, Simon Horman wrote:
> On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote:
>> The cited commit fixed missing mirror packets by reset mirror when
>> packets are modified but setting geneve options was also treated as
>> a modified packet but
s that are modified.")
Signed-off-by: Roi Dayan
---
ofproto/ofproto-dpif-xlate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index be4bd6657688..e243773307b7 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofpro
On 27/09/2023 16:36, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 27 Sep 2023, at 15:05, Ilya Maximets wrote:
>>
>>> On 9/27/23 14:34, Roi Dayan wrote:
>>>>
>>>> On 18/06/2020 21:17, Roi Dayan wrote:
>>>>> This is to ma
On 18/06/2020 21:17, Roi Dayan wrote:
> This is to match a recent kernel checkpatch change that
> also increased it to 100 line length.
>
> Signed-off-by: Roi Dayan
> Reviewed-by: Simon Horman
> Acked-by: Aaron Conole
> ---
>
> Notes:
> v2
> - updat
On 10/08/2023 15:26, Ilya Maximets wrote:
> On 8/10/23 09:59, Roi Dayan wrote:
>> Hi,
>>
>> We noticed a possible memory leak in netdev_tc_init_flow_api()
>> as we allocate memory for meter_police_ids with id_pool_create()
>> but we never destroy it.
>
>
Hi,
We noticed a possible memory leak in netdev_tc_init_flow_api()
as we allocate memory for meter_police_ids with id_pool_create()
but we never destroy it.
I added a code to refcount netdev_tc_init_flow_api and so in
netdev_tc_uninit_flow_api() to destroy it and noticed some behavior
about ovs-s
On 29/06/2023 11:50, Eelco Chaudron wrote:
>
>
> On 27 Jun 2023, at 12:48, Roi Dayan wrote:
>
>> From: Gavin Li
>>
>> Add a vxlan gbp offload test case:
>>
>> vxlan offloads with gbp extention - ping between two ports - offloads
>> enabled
On 29/06/2023 11:50, Eelco Chaudron wrote:
>
>
> On 27 Jun 2023, at 12:48, Roi Dayan wrote:
>
>> From: Gavin Li
>>
>> Add TC offload support for vxlan encap with gbp option
>>
>> Signed-off-by: Gavin Li
>> Reviewed-by: Gavi Teitz
>>
:57, Simon Horman wrote:
>>>
>>>> On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote:
>>>>>
>>>>> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
>>>>>
>>>>>> From: Gavin Li
>>>>>&
1 - 100 of 1012 matches
Mail list logo
