https://bugzilla.redhat.com/show_bug.cgi?id=561
Ondrej Oprala oopr...@redhat.com changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #20 from Kevin Fenzi ke...@scrye.com ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=561
Kevin Fenzi ke...@scrye.com changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=561
Christopher Meng i...@cicku.me changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #2 from Ondrej Oprala oopr...@redhat.com ---
What do you mean? There's 'BuildArch: noarch' in the spec.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=561
Christopher Meng i...@cicku.me changed:
What|Removed |Added
Flags||fedora-review?
---
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #4 from Ondrej Oprala oopr...@redhat.com ---
All corrected. Thank you for your review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #5 from Florian der-flo Lehner d...@der-flo.net ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]:
https://bugzilla.redhat.com/show_bug.cgi?id=561
Björn besser82 Esser bjoern.es...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #7 from Ondrej Oprala oopr...@redhat.com ---
(In reply to Florian der-flo Lehner from comment #5)
[!]: Uses parallel make %{?_smp_mflags} macro.
I don't think that's appropriate here, given that we only install 3 files (and
build
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #8 from Christopher Meng i...@cicku.me ---
(In reply to Florian der-flo Lehner from comment #5)
Stop leaving any review template if this bug is already assigned to someone(and
being reviewed).
(In reply to Björn besser82 Esser
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #9 from Ondrej Oprala oopr...@redhat.com ---
All fixed now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #10 from Christopher Meng i...@cicku.me ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #11 from Ondrej Oprala oopr...@redhat.com ---
1. Your hack is pointless, as now the interpreter is %{__python2}.
Are you sure? The substitution is ok when I extract the rpm.
2. Missing hg-git test, please BR hg-git packaged by
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #12 from Michael Schwendt bugs.mich...@gmx.net ---
if you mark it as noarch, no need to write:
%global debug_package %{nil}
in the spec.
Wrong.
https://fedoraproject.org/wiki/Packaging:Debuginfo#Missing_debuginfo_packages
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #13 from Björn besser82 Esser bjoern.es...@gmail.com ---
(In reply to Ondrej Oprala from comment #11)
1. Your hack is pointless, as now the interpreter is %{__python2}.
Are you sure? The substitution is ok when I extract the
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #14 from Ondrej Oprala oopr...@redhat.com ---
You will need to add `BuildRequires: python2-devel` to have that macro
correctly expanded inside the mock-chroot. ;)
Aah, thanks for the tip :)
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=561
Christopher Meng i...@cicku.me changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
---
https://bugzilla.redhat.com/show_bug.cgi?id=561
Ondrej Oprala oopr...@redhat.com changed:
What|Removed |Added
Flags||fedora-cvs?
---
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #17 from Michael Schwendt bugs.mich...@gmx.net ---
I still don't understand why I'm wrong here.
BuildArch: noarch _implicitly_ disables generation of -debuginfo packages.
--
You are receiving this mail because:
You are on the
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #18 from Christopher Meng i...@cicku.me ---
(In reply to Michael Schwendt from comment #17)
I still don't understand why I'm wrong here.
BuildArch: noarch _implicitly_ disables generation of -debuginfo packages.
Ondrej wrote
https://bugzilla.redhat.com/show_bug.cgi?id=561
--- Comment #19 from Michael Schwendt bugs.mich...@gmx.net ---
Yeah, sorry, a proper %changelog entry would have helped here to understand
what has been changed since the initial spec file. I misread the no need to
write in your comment 3 as
22 matches
Mail list logo
