pgsql: pg_upgrade: Improve one log message

2023-08-23 Thread Peter Eisentraut
pg_upgrade: Improve one log message The parenthesized plural is unnecessary here and inconsistent with nearby similar messages. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8fa09a11c994b85a4f4e6c09c5465f561b17c22b Modified Files -- src/bin/pg_

pgsql: pg_upgrade: Improve one log message

2023-08-23 Thread Peter Eisentraut
pg_upgrade: Improve one log message The parenthesized plural is unnecessary here and inconsistent with nearby similar messages. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f9f3bea168496990037c55dd6961010e1acbba92 Modified Files -- src/bin/pg_upgrade

pgsql: do: PG 16 relnotes: clarify last seq/index view names

2023-08-23 Thread Bruce Momjian
do: PG 16 relnotes: clarify last seq/index view names Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7d8e7036177a9fce94a6b99a5a12d65568556fde Modified Files -- doc/src/sgml/release-16.sgml | 4 ++-- 1 file changed, 2

pgsql: Meson: check for pg_config_paths.h left over from make

2023-08-23 Thread David Rowley
Meson: check for pg_config_paths.h left over from make The meson build scripts attempt to find files left over from configure and fail, mentioning that "make maintainer-clean" should be run to remove these. This seems to have been done for files generated from configure. pg_config_paths.h is gene

pgsql: Meson: check for pg_config_paths.h left over from make

2023-08-23 Thread David Rowley
Meson: check for pg_config_paths.h left over from make The meson build scripts attempt to find files left over from configure and fail, mentioning that "make maintainer-clean" should be run to remove these. This seems to have been done for files generated from configure. pg_config_paths.h is gene

pgsql: ci: Make compute resources for CI configurable

2023-08-23 Thread Andres Freund
ci: Make compute resources for CI configurable See prior commit for an explanation for the goal of the change and why it had to be split into two commits. Reviewed-by: Daniel Gustafsson Reviewed-by: Nazir Bilal Yavuz Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qm...@awork3.anaraz

pgsql: ci: Prepare to make compute resources for CI configurable

2023-08-23 Thread Andres Freund
ci: Prepare to make compute resources for CI configurable cirrus-ci will soon restrict the amount of free resources every user gets (as have many other CI providers). For most users of CI that should not be an issue. But e.g. for cfbot it will be an issue. To allow configuring different resources

pgsql: ci: Prepare to make compute resources for CI configurable

2023-08-23 Thread Andres Freund
ci: Prepare to make compute resources for CI configurable cirrus-ci will soon restrict the amount of free resources every user gets (as have many other CI providers). For most users of CI that should not be an issue. But e.g. for cfbot it will be an issue. To allow configuring different resources

pgsql: ci: Make compute resources for CI configurable

2023-08-23 Thread Andres Freund
ci: Make compute resources for CI configurable See prior commit for an explanation for the goal of the change and why it had to be split into two commits. Reviewed-by: Daniel Gustafsson Reviewed-by: Nazir Bilal Yavuz Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qm...@awork3.anaraz

pgsql: ci: Prepare to make compute resources for CI configurable

2023-08-23 Thread Andres Freund
ci: Prepare to make compute resources for CI configurable cirrus-ci will soon restrict the amount of free resources every user gets (as have many other CI providers). For most users of CI that should not be an issue. But e.g. for cfbot it will be an issue. To allow configuring different resources

pgsql: ci: Make compute resources for CI configurable

2023-08-23 Thread Andres Freund
ci: Make compute resources for CI configurable See prior commit for an explanation for the goal of the change and why it had to be split into two commits. Reviewed-by: Daniel Gustafsson Reviewed-by: Nazir Bilal Yavuz Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qm...@awork3.anaraz

pgsql: Bump catversion for to_bin() and to_oct().

2023-08-23 Thread Nathan Bossart
Bump catversion for to_bin() and to_oct(). Missed in 260a1f18da. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d7f249020a11a87cedad04fb071f3287321d5f20 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

pgsql: Cache by-reference missing values in a long lived context

2023-08-23 Thread Andrew Dunstan
Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version of

pgsql: ci: Move execution method of tasks into yaml templates

2023-08-23 Thread Andres Freund
ci: Move execution method of tasks into yaml templates This is done in preparation for making the compute resources for CI configurable. It also looks cleaner. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qm...@awork3.anarazel.de Backpatch: 15-, where

pgsql: ci: Don't specify amount of memory

2023-08-23 Thread Andres Freund
ci: Don't specify amount of memory The number of CPUs is the cost-determining factor. Most instance types that run tests have more memory/core than what we specified, there's no real benefit in wasting that. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/20230808021541.7lbzdefvm

pgsql: ci: Don't specify amount of memory

2023-08-23 Thread Andres Freund
ci: Don't specify amount of memory The number of CPUs is the cost-determining factor. Most instance types that run tests have more memory/core than what we specified, there's no real benefit in wasting that. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/20230808021541.7lbzdefvm

pgsql: ci: Use VMs for SanityCheck and CompilerWarnings

2023-08-23 Thread Andres Freund
ci: Use VMs for SanityCheck and CompilerWarnings The main reason for this change is to reduce different ways of executing tasks, making it easier to use custom compute resources for cfbot. A secondary benefit is that the tasks seem slightly faster this way, apparently the increased startup overhea

pgsql: ci: Don't specify amount of memory

2023-08-23 Thread Andres Freund
ci: Don't specify amount of memory The number of CPUs is the cost-determining factor. Most instance types that run tests have more memory/core than what we specified, there's no real benefit in wasting that. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/20230808021541.7lbzdefvm

pgsql: ci: Use VMs for SanityCheck and CompilerWarnings

2023-08-23 Thread Andres Freund
ci: Use VMs for SanityCheck and CompilerWarnings The main reason for this change is to reduce different ways of executing tasks, making it easier to use custom compute resources for cfbot. A secondary benefit is that the tasks seem slightly faster this way, apparently the increased startup overhea

pgsql: ci: Move execution method of tasks into yaml templates

2023-08-23 Thread Andres Freund
ci: Move execution method of tasks into yaml templates This is done in preparation for making the compute resources for CI configurable. It also looks cleaner. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qm...@awork3.anarazel.de Backpatch: 15-, where

pgsql: ci: Use VMs for SanityCheck and CompilerWarnings

2023-08-23 Thread Andres Freund
ci: Use VMs for SanityCheck and CompilerWarnings The main reason for this change is to reduce different ways of executing tasks, making it easier to use custom compute resources for cfbot. A secondary benefit is that the tasks seem slightly faster this way, apparently the increased startup overhea

pgsql: ci: Move execution method of tasks into yaml templates

2023-08-23 Thread Andres Freund
ci: Move execution method of tasks into yaml templates This is done in preparation for making the compute resources for CI configurable. It also looks cleaner. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qm...@awork3.anarazel.de Backpatch: 15-, where

Re: pgsql: Add to_bin() and to_oct().

2023-08-23 Thread David Rowley
On Thu, 24 Aug 2023 at 02:50, Nathan Bossart wrote: > > Add to_bin() and to_oct(). src/include/catalog/pg_proc.dat | 12 + Did this maybe miss a catversion bump? David

pgsql: Avoid use of Perl getprotobyname

2023-08-23 Thread Peter Eisentraut
Avoid use of Perl getprotobyname getprotobyname returns undefined on some CI machines. It's not clear why. The code overall still works, but it raises a warning. In PostgreSQL C code, we always call socket() with 0 for the protocol argument, so we should be able to do the same in Perl (since th

pgsql: Fix _bt_allequalimage() call within critical section.

2023-08-23 Thread Heikki Linnakangas
Fix _bt_allequalimage() call within critical section. _bt_allequalimage() does complicated things, so it's not OK to call it in a critical section. Per buildfarm failure on 'prion', which uses -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE options. Discussion: https://www.postgresql.org/messa

pgsql: Fix _bt_allequalimage() call within critical section.

2023-08-23 Thread Heikki Linnakangas
Fix _bt_allequalimage() call within critical section. _bt_allequalimage() does complicated things, so it's not OK to call it in a critical section. Per buildfarm failure on 'prion', which uses -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE options. Discussion: https://www.postgresql.org/messa

pgsql: Add to_bin() and to_oct().

2023-08-23 Thread Nathan Bossart
Add to_bin() and to_oct(). This commit introduces functions for converting numbers to their equivalent binary and octal representations. Also, the base conversion code for these functions and to_hex() has been moved to a common helper function. Co-authored-by: Eric Radman Reviewed-by: Ian Barwic

pgsql: Use the buffer cache when initializing an unlogged index.

2023-08-23 Thread Heikki Linnakangas
Use the buffer cache when initializing an unlogged index. Some of the ambuildempty functions used smgrwrite() directly, followed by smgrimmedsync(). A few small problems with that: Firstly, one is supposed to use smgrextend() when extending a relation, not smgrwrite(). It doesn't make much differ

pgsql: Use the buffer cache when initializing an unlogged index.

2023-08-23 Thread Heikki Linnakangas
Use the buffer cache when initializing an unlogged index. Some of the ambuildempty functions used smgrwrite() directly, followed by smgrimmedsync(). A few small problems with that: Firstly, one is supposed to use smgrextend() when extending a relation, not smgrwrite(). It doesn't make much differ

pgsql: doc: Replace list of drivers and PLs with wiki link

2023-08-23 Thread Daniel Gustafsson
doc: Replace list of drivers and PLs with wiki link The list of external language drivers and procedural languages was never complete or exhaustive, and rather than attempting to manage it the content has migrated to the wiki. This replaces the tables altogether with links to the wiki as we regul

pgsql: doc: Replace list of drivers and PLs with wiki link

2023-08-23 Thread Daniel Gustafsson
doc: Replace list of drivers and PLs with wiki link The list of external language drivers and procedural languages was never complete or exhaustive, and rather than attempting to manage it the content has migrated to the wiki. This replaces the tables altogether with links to the wiki as we regul

pgsql: doc: Replace list of drivers and PLs with wiki link

2023-08-23 Thread Daniel Gustafsson
doc: Replace list of drivers and PLs with wiki link The list of external language drivers and procedural languages was never complete or exhaustive, and rather than attempting to manage it the content has migrated to the wiki. This replaces the tables altogether with links to the wiki as we regul

pgsql: doc: Replace list of drivers and PLs with wiki link

2023-08-23 Thread Daniel Gustafsson
doc: Replace list of drivers and PLs with wiki link The list of external language drivers and procedural languages was never complete or exhaustive, and rather than attempting to manage it the content has migrated to the wiki. This replaces the tables altogether with links to the wiki as we regul

pgsql: doc: Replace list of drivers and PLs with wiki link

2023-08-23 Thread Daniel Gustafsson
doc: Replace list of drivers and PLs with wiki link The list of external language drivers and procedural languages was never complete or exhaustive, and rather than attempting to manage it the content has migrated to the wiki. This replaces the tables altogether with links to the wiki as we regul

pgsql: doc: Replace list of drivers and PLs with wiki link

2023-08-23 Thread Daniel Gustafsson
doc: Replace list of drivers and PLs with wiki link The list of external language drivers and procedural languages was never complete or exhaustive, and rather than attempting to manage it the content has migrated to the wiki. This replaces the tables altogether with links to the wiki as we regul

pgsql: doc: Replace list of drivers and PLs with wiki link

2023-08-23 Thread Daniel Gustafsson
doc: Replace list of drivers and PLs with wiki link The list of external language drivers and procedural languages was never complete or exhaustive, and rather than attempting to manage it the content has migrated to the wiki. This replaces the tables altogether with links to the wiki as we regul

Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

2023-08-23 Thread Peter Eisentraut
On 22.08.23 22:08, Jeff Davis wrote: Fix pg_dump assertion failure when dumping pg_catalog. Commit 396d348b04 did not account for the default collation. Also, use pg_log_warning() instead of Assert(). Looking at this: pg_log_warning("invalid collation \"%s\"", qcollname); qcollname is a

pgsql: doc: Add more ICU rules examples

2023-08-23 Thread Peter Eisentraut
doc: Add more ICU rules examples In particular, add an example EBCDIC collation. Author: Daniel Verite Discussion: https://www.postgresql.org/message-id/flat/35cc1684-e516-4a01-a256-351632d47...@manitou-mail.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/17e

pgsql: doc: Add more ICU rules examples

2023-08-23 Thread Peter Eisentraut
doc: Add more ICU rules examples In particular, add an example EBCDIC collation. Author: Daniel Verite Discussion: https://www.postgresql.org/message-id/flat/35cc1684-e516-4a01-a256-351632d47...@manitou-mail.org Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitd

pgsql: Fix wording in comment

2023-08-23 Thread Daniel Gustafsson
Fix wording in comment The comment for the DSM_OP_CREATE paramater read "the a new handle" which is confusing. Fix by rewording to indicate what the parameter means for DSM_OP_CREATE. Reported-by: Junwang Zhao Discussion: https://postgr.es/m/caeg8a3j2bc197ym-m_ykoxb9ox2enn-qnkneosaohysw2nc...@m

pgsql: pg_upgrade: Avoid shadowing global var in function

2023-08-23 Thread Daniel Gustafsson
pg_upgrade: Avoid shadowing global var in function The new_cluster parameter in check_for_new_tablespace_dir was shadowing the globally defined new_cluster variable, causing compiler warnings when running with -Wshadow. The function is only applicable to the new cluster, so remove the parameter ra