Hi All,
Just a reminder that Commitfest 2023-01 has started.
There are many patches based on the latest run from [1] which require
a) Rebased on top of head b) Fix compilation failures c) Fix test
failure, please have a look and rebase it so that it is easy for the
reviewers and committers:
1. TAP
On Tue, Jan 3, 2023 at 12:58 PM Michael Paquier wrote:
>
> On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
>
> # Use larger ccache cache, as this task compiles with multiple compilers
> /
> # flag combinations
> -CCACHE_MAXSIZE: "1GB"
> +CCACHE_MAXSIZE: "1G"
>
> I
On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
# Use larger ccache cache, as this task compiles with multiple compilers /
# flag combinations
-CCACHE_MAXSIZE: "1GB"
+CCACHE_MAXSIZE: "1G"
In 0006, I am not sure how much this matters. Perhaps somebody more
fluent
On 03/01/23 08:21, David Rowley wrote:
On Mon, 26 Dec 2022 at 02:04, Ankit Kumar Pandey wrote:
Point #1
In the above query Oracle 10g performs 2 sorts, DB2 and Sybase perform 3
sorts. We also perform 3.
This shouldn't be too hard to do. See the code in
select_active_windows(). You'll likel
On Tue, 27 Dec 2022 at 14:59, Hayato Kuroda (Fujitsu)
wrote:
> Note that more than half of the modifications are done by Osumi-san.
1) This global variable can be removed as it is used only in
send_feedback which is called from maybe_delay_apply so we could pass
it as a function argument:
+ * del
On 03/01/23 08:38, David Rowley wrote:
I'm with Tom on this. I've never once used this feature to try to
figure out why a certain plan was chosen or not chosen.
I'd really rather not see us compiling all that debug code in by
default unless it's actually going to be useful to a meaningful num
On Mon, Jan 2, 2023 at 6:42 PM Justin Pryzby wrote:
> On Mon, Jan 02, 2023 at 06:14:48PM +0300, Alexander Korotkov wrote:
> > I'm going to push this if no objections.
>
> I also suggest that meson.build should not copy regress_args.
Good point, thanks.
--
Regards,
Alexander Korotkov
0001-m
On Wed, Dec 7, 2022 at 11:42 PM Nathan Bossart wrote:
>
> On Wed, Dec 07, 2022 at 02:07:11PM +0300, Melih Mutlu wrote:
> > Do we also need to wake up all sync workers too? Even if not, I'm not
> > actually sure whether doing that would harm anything though.
> > Just asking since currently the patc
Hi,
On Mon, Jan 02, 2023 at 09:45:27AM -0500, Andrew Dunstan wrote:
>
> On 2023-01-01 Su 18:31, Andrew Dunstan wrote:
> > Let's see how we fare with this patch.
> >
> >
>
> Not so well :-(. This version tries to make the tests totally
> independent, as they should be. That's an attempt to get the
On Thu, Dec 15, 2022 at 4:47 AM Nathan Bossart wrote:
>
> On Wed, Dec 14, 2022 at 02:02:58PM -0500, Tom Lane wrote:
> > Maybe we could have workers that are exiting for that reason set a
> > flag saying "please restart me without delay"?
>
> That helps a bit, but there are still delays when starti
Hi,
Here's a draft patch to tackle a couple of TODOs in the RADIUS code in auth.c.
The first change is to replace select() with a standard latch loop
that responds to interrupts, postmaster death etc promptly. It's not
really too much of a big deal because the timeout was only 3 seconds
(hardcod
On Mon, 26 Dec 2022 at 08:05, Ankit Kumar Pandey wrote:
> Also, inputs from other hackers are welcomed here.
I'm with Tom on this. I've never once used this feature to try to
figure out why a certain plan was chosen or not chosen.
Do you actually have a need for this or are you just trying to t
On Mon, 26 Dec 2022 at 02:04, Ankit Kumar Pandey wrote:
> Point #1
>
> In the above query Oracle 10g performs 2 sorts, DB2 and Sybase perform 3
> sorts. We also perform 3.
This shouldn't be too hard to do. See the code in
select_active_windows(). You'll likely want to pay attention to the
DISTIN
On Tue, 3 Jan 2023 at 07:52, Michael Paquier wrote:
>
> On Wed, Dec 28, 2022 at 10:52:38AM +0530, vignesh C wrote:
> > If no one has volunteered for the upcoming (January 2023) commitfest.
> > I would like to volunteer for it.
>
> If you want to be up to the task, that would be great, of course.
Michael Paquier writes:
> FYI, here is the failure:
> [21:23:10.814] In file included from pg_prng.c:27:
> [21:23:10.814] ../../src/include/utils/float.h:46:16: error: ‘struct
> Node’ declared inside parameter list will not be visible outside of
> this definition or declaration [-Werror]
> [21:23
On Mon, 2023-01-02 at 11:45 -0800, Peter Geoghegan wrote:
> What do you think of the wording adjustments in the attached patch?
> It's based on your suggested wording.
Great, thank you.
--
Jeff Davis
PostgreSQL Contributor Team - AWS
On Fri, Dec 30, 2022 at 09:58:04PM -0600, Justin Pryzby wrote:
> This is still failing tests - did you enable cirrusci on your own github
> account to run available checks on the patch ?
FYI, here is the failure:
[21:23:10.814] In file included from pg_prng.c:27:
[21:23:10.814] ../../src/include/u
On Wed, Dec 28, 2022 at 10:52:38AM +0530, vignesh C wrote:
> If no one has volunteered for the upcoming (January 2023) commitfest.
> I would like to volunteer for it.
If you want to be up to the task, that would be great, of course. For
now, I have switched the CF as in progress.
--
Michael
sig
On Fri, Dec 30, 2022 at 10:32:57AM -0800, Nathan Bossart wrote:
> This looks correct to me. The only thing that stood out to me was the loop
> through 'tles' in XLogFileReadyAnyTLI. With this change, we'd loop through
> the timelines for both XLOG_FROM_PG_ARCHIVE and XLOG_FROM_PG_WAL, whereas
> n
On 2023-01-02 15:46:36 -0800, Andres Freund wrote:
> On 2022-12-29 13:40:13 -0800, Andres Freund wrote:
> > > > Should we backpatch this? Given the volume of warnings it's probably a
> > > > good
> > > > idea. But I'd let it step in HEAD for a few days of buildfarm coverage
> > > > first.
> > >
I have another patch, this one adds validations to operations that
return intervals and updated error messages. I tried to give all of the
error messages meaningful text, but I'm starting to think that almost all
of them should just say "interval out of range". The current approach
may reveal some
Hi,
Attached is a patch: contrib_v1.patch
It modifies Appendix F, the contrib directory.
It adds brief text into the titles shown in the
table of contents so it's easier to tell what
each module does. It also suffixes [trusted] or [obsolete]
on the relevant titles.
I added the word "extension"
Hi,
On 2022-12-29 13:40:13 -0800, Andres Freund wrote:
> > > Should we backpatch this? Given the volume of warnings it's probably a
> > > good
> > > idea. But I'd let it step in HEAD for a few days of buildfarm coverage
> > > first.
> >
> > +1 to both points.
>
> Pushed to HEAD.
I haven't see
Sorry about the latest unfinished email - don't know what key
combination I managed to hit there.
Alvaro Herrera writes:
> Hello
>
> On 2022-Dec-23, Dag Lem wrote:
>
[...]
>
> So, yes, I'm proposing that we returns those as array elements and that
> @> is used to match them.
>
Looking into th
Alvaro Herrera writes:
> Hello
>
> On 2022-Dec-23, Dag Lem wrote:
>
[...]
> So, yes, I'm proposing that we returns those as array elements and that
> @> is used to match them.
Looking into the array operators I guess that to match such arrays
directly one would actually use && (overlaps) rathe
Hi,
This is a follow-up to commit d2a44904 from the 2022-11 CF [1]
The TAP tests were left out with the suggestion to use Perl instead of
cat (Unix) / findstr (Windows) as the program to pipe into.
PFA a patch implementing that suggestion.
[1] https://commitfest.postgresql.org/40/4000/
Best re
Richard Guo writes:
> On Thu, Dec 22, 2022 at 2:02 PM Richard Guo wrote:
>> If it is an empty grouping set, its length will be zero, and accessing
>> phasedata->eqfunctions[length - 1] is not right.
> Attached is a trivial patch for the fix.
Agreed, that's a latent bug. It's only latent becaus
On Fri, Jul 15, 2022 at 11:21 AM Maciek Sakrejda wrote:
> On Fri, Jul 1, 2022 at 10:26 AM Andres Freund wrote:
> > On 2022-07-01 01:23:01 -0700, Lukas Fittl wrote:
> >...
> > > Known WIP problems with this patch version:
> > >
> > > * There appears to be a timing discrepancy I haven't yet worked
Hi David,
Thanks for continuing to work on this patch, and my apologies for silence
on the patch.
Its been hard to make time, and especially so because I typically develop
on an ARM-based macOS system where I can't test this directly - hence my
tests with virtualized EC2 instances, where I ran in
On Sat, Dec 31, 2022 at 12:45 PM Peter Geoghegan wrote:
> On Sat, Dec 31, 2022 at 11:46 AM Jeff Davis wrote:
> > "We have no freeze plans to execute, so there's no cost to following
> > the freeze path. This is important in the case where the page is
> > entirely frozen already, so that the page
Dave Cramer writes:
> I see in v15 there is a note that there is a new category for "char"
> however it is categorized as "internal use"
> I would think that char and char(n) would be used by external programs as a
> user type.
"char" (with quotes) is not at all the same type as char without
quot
I see in v15 there is a note that there is a new category for "char"
however it is categorized as "internal use"
I would think that char and char(n) would be used by external programs as a
user type.
Dave Cramer
On Mon, Jan 2, 2023 at 1:21 PM Joseph Koshakow wrote:
>
> On Sat, Dec 31, 2022 at 12:09 AM jian he wrote:
> > In float8, select float8 'inf' / float8 'inf' return NaN. Now in your patch
> > select interval 'infinity' / float8 'infinity'; returns infinity.
> > I am not sure it's right. I found t
On Sat, Dec 31, 2022 at 4:53 PM Peter Geoghegan wrote:
> The first patch makes sure that the snapshotConflictHorizon cutoff
> (XID cutoff for recovery conflicts) is never a special XID, unless
> that XID is InvalidTransactionId, which is interpreted as a
> snapshotConflictHorizon value that will n
On Fri, 30 Dec 2022 at 16:56, Dean Rasheed wrote:
>
> Attached is a WIP patch.
>
Updated patch attached, now with updated docs and some other minor tidying up.
Regards,
Dean
diff --git a/doc/src/sgml/mvcc.sgml b/doc/src/sgml/mvcc.sgml
new file mode 100644
index b87ad5c..1482ede
--- a/doc/src/sgm
On Sat, Dec 31, 2022 at 12:09 AM jian he wrote:
> In float8, select float8 'inf' / float8 'inf' return NaN. Now in your patch
> select interval 'infinity' / float8 'infinity'; returns infinity.
> I am not sure it's right. I found this related post
> (https://math.stackexchange.com/questions/181
Hamid Akhtar writes:
> I wasn't aware of the meson.build file. Attached is the latest version of
> the patch that contains the updated meson.build.
Pushed with minor corrections, plus one major one: you missed the
point of aeaaf520f, that pageinspect functions that touch relations
need to be para
Hi all,
A question, may I wrong.
I've a Rocky Linux 8 with OpenSSL 1.1.1 FIPS and Intel cpu with aes
support (cat /proc/cpuinfo | grep aes)
Test made with openssl gives me a huge performance with aes enabled vs not:
"openssl speed -elapsed -evp aes-128-cbc" is about 5 time faster than
"ope
> On Sun, Dec 25, 2022 at 06:55:02PM +0100, Pavel Stehule wrote:
> there are some problems with stability of regress tests
>
> http://cfbot.cputube.org/dmitry-dolgov.html
Looks like this small change predates moving to meson, the attached
version should help.
>From 1b19af29b4a71e008d9d4ac7ca39d06d
Corey Huinker writes:
> The proposed changes are as follows:
> CAST(expr AS typename)
> continues to behave as before.
> CAST(expr AS typename ERROR ON ERROR)
> has the identical behavior as the unadorned CAST() above.
> CAST(expr AS typename NULL ON ERROR)
> will use error-safe functi
Andrew Dunstan writes:
> I've been wondering if it might be a good idea to have a third parameter
> for pg_input_error_message() which would default to false, but which if
> true would cause it to emit the detail and hint fields, if any, as well
> as the message field from the error_data.
I don't
On Mon, Jan 02, 2023 at 06:14:48PM +0300, Alexander Korotkov wrote:
> I'm going to push this if no objections.
I also suggest that meson.build should not copy regress_args.
--
Justin
I've been wondering if it might be a good idea to have a third parameter
for pg_input_error_message() which would default to false, but which if
true would cause it to emit the detail and hint fields, if any, as well
as the message field from the error_data.
Thoughts?
cheers
andrew
--
Andrew
Justin, Tom, Pavel, thank you for catching this.
On Mon, Jan 2, 2023 at 11:54 AM Pavel Borisov wrote:
> I completely agree with your analysis. Fixes by 3f0e786ccbf5 to oat
> and the other modules tests came just a couple of days before
> committing the main pg_db_role_setting commit 096dd80f3c so
On 2023-01-01 Su 18:31, Andrew Dunstan wrote:
> On 2023-01-01 Su 14:02, Thomas Munro wrote:
>> On Mon, Jan 2, 2023 at 3:04 AM Andrew Dunstan wrote:
>>> On 2022-12-19 Mo 11:16, Andrew Dunstan wrote:
There is currently no test for the use of ldapbindpasswd in the
pg_hba.conf file. This pa
Hi,
I re-based again on master and applied the following changes:
I removed the fallback for obtaining the TSC frequency from /proc/cpu as
suggested by Andres. Worst-case we fall back to clock_gettime().
I added code to obtain the TSC frequency via CPUID when under a
hypervisor. I had to use
On Wed, Dec 28, 2022 at 4:52 PM Michail Nikolaev
wrote:
>
> Hello.
>
> > None of these entries are from the point mentioned by you [1]
> > yesterday where you didn't find the corresponding data in the
> > subscriber. How did you identify that the entries corresponding to
> > that timing were missi
Re-reading my latest MERGE patch, I realised there is a trivial,
pre-existing bug in the check for unreachable WHEN clauses, which
means it won't spot an unreachable WHEN clause if it doesn't have an
AND condition.
So the checks need to be re-ordered, as in the attached.
Regards,
Dean
diff --git
On Wed, Dec 28, 2022 at 4:17 PM Peter Eisentraut
wrote:
>
> Most callers of BufFileRead() want to check whether they read the full
> specified length. Checking this at every call site is very tedious.
> This patch provides additional variants BufFileReadExact() and
> BufFileReadMaybeEOF() that in
Hi,
Since EXPLAIN ANALYZE with TIMING ON still carries noticeable overhead on
modern hardware (despite time sources being faster), I'd like to propose a
new setting EXPLAIN ANALYZE, called "TIMING SAMPLING", as compared to
TIMING ON.
This new timing mode uses a timer on a fixed recurring frequenc
On 30.11.22 23:34, Melanie Plageman wrote:
I have attached a patchset with only the code changes contained in the
previous patch 0003. I have broken the refactoring down into many
smaller pieces for ease of review.
To keep this moving along a bit, I have committed your 0002, which I
think is a
Hi, Justin!
On Wed, 28 Dec 2022 at 21:28, Justin Pryzby wrote:
>
> On Tue, Dec 27, 2022 at 11:29:40PM -0500, Tom Lane wrote:
> > Justin Pryzby writes:
> > > This fails when run more than once:
> > > time meson test --setup running --print
> > > test_pg_db_role_setting-running/regress
> >
> > Ah
On 08.12.22 03:30, Peter Smith wrote:
PSA patches for v9*
v9-0001 - Now the table rows are ordered per PeterE's suggestions [1]
committed
v9-0002 - All the review comments from DavidJ [2] are addressed
I'm not sure about this one. It removes the "see [link] for details"
phrases and inste
On Wed, 7 Dec 2022 at 17:50, Alvaro Herrera wrote:
>
> I think this patch is split badly.
>
> You have:
>
> 0001 an enormous patch including some required infrastructure, plus the
> DDL deparsing bits themselves.
>
> 0002 another enormous (though not as much) patch, this time for
> DDL replication
54 matches
Mail list logo
