On Wed, Sep 29, 2021 at 9:07 AM houzj.f...@fujitsu.com
wrote:
>
> On Tues, Sep 28, 2021 10:46 PM vignesh C wrote:
> > Attached v34 patch has the changes for the same.
>
> Thanks for updating the patch.
> Here are a few comments.
>
> 1)
> + *
On Tue, Sep 28, 2021 at 4:35 PM tanghy.f...@fujitsu.com
wrote:
>
> On Monday, September 27, 2021 1:32 PM, vignesh C wrote:
>
> >Attached v33 patch has the preprocess_pubobj_list review comment fix
> >suggested by Alvaro at [1]. The
> >v33-0006-Alternate-grammar-for
On Mon, Sep 27, 2021 at 4:51 PM Greg Nancarrow wrote:
>
> On Mon, Sep 27, 2021 at 2:32 PM vignesh C wrote:
> >
> > Attached v33 patch has the preprocess_pubobj_list review comment fix
> > suggested by Alvaro at [1].
>
> In the v33-0003 patch, there's a couple
On Mon, Sep 27, 2021 at 2:46 PM Greg Nancarrow wrote:
>
> On Mon, Sep 27, 2021 at 2:32 PM vignesh C wrote:
> >
> > Attached v33 patch has the preprocess_pubobj_list review comment fix
> > suggested by Alvaro at [1].
>
> A minor point I noticed in the v33
On Mon, Sep 27, 2021 at 4:41 PM Amit Kapila wrote:
>
> On Sat, Sep 25, 2021 at 1:15 PM vignesh C wrote:
> >
> > On Fri, Sep 24, 2021 at 6:55 PM Alvaro Herrera
> > wrote:
> > >
> > > On 2021-Sep-23, Amit Kapila wrote:
> > >
> > >
On Fri, Sep 24, 2021 at 6:55 PM Alvaro Herrera wrote:
>
> On 2021-Sep-23, Amit Kapila wrote:
>
> > Alvaro, do you have any thoughts on these proposed grammar changes?
>
> Yeah, I think pubobj_name remains a problem in that you don't know its
> return type -- could be a String or a RangeVar, and
On Thu, Sep 23, 2021 at 12:32 PM houzj.f...@fujitsu.com
wrote:
>
> On Thur, Sep 23, 2021 11:06 AM Greg Nancarrow wrote:
> > On Wed, Sep 22, 2021 at 9:33 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > >
> > > > How do you suggest changing it?
> > >
> > > Personally, I think we'd better move
On Thu, Sep 23, 2021 at 12:22 PM houzj.f...@fujitsu.com
wrote:
>
> From Thurs, Sep 23, 2021 12:09 PM Amit Kapila wrote:
> > On Wed, Sep 22, 2021 at 5:03 PM Hou Zhijie wrote:
> > >
> > > Personally, I think we'd better move the code about changing publication's
> > > tablelist into
On Wed, Sep 22, 2021 at 11:31 AM Amit Kapila wrote:
>
> On Tue, Sep 21, 2021 at 11:39 PM vignesh C wrote:
> >
> > On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
> > >
> > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> > > >
>
On Wed, Sep 22, 2021 at 11:27 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, September 22, 2021 11:22 AM Masahiko Sawada
> wrote:
> >
> > ---
> > + if (!IsA(node, String))
> > + ereport(ERROR,
> > +
On Wed, Sep 22, 2021 at 8:52 AM Masahiko Sawada wrote:
>
> On Wed, Sep 22, 2021 at 3:02 AM vignesh C wrote:
> >
> >
> > Attached v30 patch has the fixes for the same.
> >
>
> Thank you for updating the patches.
>
>
On Fri, Sep 24, 2021 at 8:40 AM Amit Kapila wrote:
>
> On Fri, Sep 24, 2021 at 12:45 AM Tomas Vondra
> wrote:
> >
> > Hi,
> >
> > I wanted to do a review of this patch, but I'm a bit confused about
> > which patch(es) to review. There's the v5 patch, and then these two
> > patches - which seem
On Tue, Sep 21, 2021 at 6:05 PM Greg Nancarrow wrote:
>
> On Tue, Sep 21, 2021 at 4:12 PM vignesh C wrote:
> >
> > > (1)
> > > In get_object_address_publication_schema(), the error message:
> > >
> > > + errmsg("publication tables of sch
On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
>
> On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> >
> > Attached v29 patch has the fixes for the same.
> >
>
> Some minor comments on the v29-0002 patch:
>
> (1)
> In get_object_address_
On Mon, Sep 20, 2021 at 4:20 PM vignesh C wrote:
>
> On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote:
> >
> > On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote:
> > >
> > > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila
> > > wrote:
> > &g
On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
>
> On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> >
> > Attached v29 patch has the fixes for the same.
> >
>
> Some minor comments on the v29-0002 patch:
>
> (1)
> In get_object_address_
On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote:
>
> On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote:
> >
> > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote:
> > >
> > > I think there is one more similar locking problem.
> > > AlterPublicati
On Thu, Sep 16, 2021 at 11:24 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 4:45 PM Greg Nancarrow wrote:
> >
> > On Tue, Sep 14, 2021 at 6:38 PM vignesh C wrote:
> > >
> > > I have handled this in the patch attached.
> > >
> >
> &g
On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 12:30 PM Amit Kapila wrote:
> >
> > On Tue, Sep 14, 2021 at 2:08 PM vignesh C wrote:
> > >
> > > I have handled this in the patch attached.
> >
On Thu, Sep 16, 2021 at 8:59 AM houzj.f...@fujitsu.com
wrote:
>
> On Tuesday, September 14, 2021 4:39 PM vignesh C wrote:
> >
> > I have handled this in the patch attached.
>
> Thanks for updating the patch.
> Here are some comments.
>
> 1)
> +st
On Thu, Sep 16, 2021 at 7:20 PM Alvaro Herrera wrote:
>
> On 2021-Sep-16, vignesh C wrote:
>
> > diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
> > index e3068a374e..c50bb570ea 100644
> > --- a/src/backend/parser/gram.y
> > +++ b/src/backend/p
On Thu, Sep 16, 2021 at 8:45 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 6:06 PM Alvaro Herrera
> wrote:
> >
> > On 2021-Sep-15, vignesh C wrote:
> > > The patch
> > > Generic_object_type_parser_002_table_schema_publication.patch has the
> > &
On Wed, Sep 15, 2021 at 5:20 PM Alvaro Herrera wrote:
>
> On 2021-Sep-15, Amit Kapila wrote:
>
> > On Mon, Sep 6, 2021 at 11:21 PM Alvaro Herrera
> > wrote:
> > >
> > > I pushed the clerical part of this -- namely the addition of
> > > PublicationTable node and PublicationRelInfo struct.
> >
>
On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com
wrote:
>
> From Tues, Sep 7, 2021 12:02 PM Amit Kapila wrote:
> > On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > I can reproduce this bug.
> > >
> > > I think the reason is it didn't invalidate all the leaf
On Tue, Sep 14, 2021 at 6:31 AM houzj.f...@fujitsu.com
wrote:
>
> From Sun, Sept 12, 2021 11:13 PM vignesh C wrote:
> > On Fri, Sep 10, 2021 at 11:21 AM Hou Zhijie wrote:
> > > Attach the without-flag version and add comments about the pubobj_name.
> >
> > Than
On Mon, Sep 13, 2021 at 7:06 PM tanghy.f...@fujitsu.com
wrote:
>
> On Sunday, September 12, 2021 11:13 PM vignesh C wrote:
> >
> > Thanks for the changes, the suggested changes make the parsing code
> > simpler. I have merged the changes to the main patch. Attached v27
&
On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com
wrote:
>
> From Thur, Sep 2, 2021 2:33 PM vignesh C wrote:
> > On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Here are some other co
On Tue, Sep 7, 2021 at 5:10 PM Amit Kapila wrote:
>
> On Tue, Sep 7, 2021 at 12:45 PM vignesh C wrote:
> >
> > On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote:
> > >
> >
> > > 5.
> > > If I modify the search path to remove public schema then
On Fri, Sep 3, 2021 at 4:06 PM Amit Kapila wrote:
>
> On Wed, Sep 1, 2021 at 12:05 PM Amit Kapila wrote:
> >
> > On Wed, Sep 1, 2021 at 8:52 AM Greg Nancarrow wrote:
> > >
> >
> > > I'd expect a lot of users to naturally think that "ALTER PUBLICATION
> > > pub1 DROP ALL TABLES IN SCHEMA sc1;"
On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote:
>
> On Thu, Sep 2, 2021 at 5:12 PM Amit Kapila wrote:
> >
> > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote:
> > >
> >
> > Below are few comments on v23. If you have already addressed anything
> >
On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com
wrote:
>
> From Thur, Sep 2, 2021 7:42 PM Amit Kapila wrote:
> > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote:
> > >
> >
> > Below are few comments on v23. If you have already addressed anything in
>
On Fri, Sep 3, 2021 at 3:12 PM Amit Kapila wrote:
>
> On Mon, Aug 30, 2021 at 8:56 PM vignesh C wrote:
> >
> > On Mon, Aug 30, 2021 at 9:10 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> >
> > > 5)
> > > +
On Wed, Sep 1, 2021 at 11:14 AM tanghy.f...@fujitsu.com
wrote:
>
> > On Monday, August 30, 2021 11:28 PM vignesh C wrote:
> >
> > I have fixed these comments as part of v23 patch attached at [1].
> > [1] - https://www.postgresql.org/message-
> > id/CALDaN
On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com
wrote:
>
> Here are some other comments for v23-000x patches.
>
> 1)
>
> @@ -6225,6 +6342,9 @@ describePublications(const char *pattern)
> boolhas_pubtruncate;
> boolhas_pubviaroot;
>
> +
On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote:
>
> Don't you think some users might want to know all the schema names for
> a publication? I am not completely sure on this point but I think it
> is good to have information for users. It might be also useful to have
> pg_publication_objects
On Tue, Aug 31, 2021 at 2:00 PM Kyotaro Horiguchi
wrote:
>
> At Tue, 31 Aug 2021 08:31:05 +0530, vignesh C wrote in
> > On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com
> > wrote:
> > Thanks for the comment, I have slightly modified the test case which
> &g
On Tue, Aug 31, 2021 at 4:27 PM Amit Kapila wrote:
>
> On Tue, Aug 31, 2021 at 10:50 AM Greg Nancarrow wrote:
> >
> > On Tue, Aug 31, 2021 at 1:41 PM vignesh C wrote:
> > >
> > > >
> > > > I notice that "CREATE PUBLICATION pub1 FOR ALL T
On Mon, Aug 30, 2021 at 12:12 PM Amit Kapila
wrote:
>
>
> Okay, I got it but let's add few comments in the code related to it.
> Also, I noticed that the code in InvalidatePublicationRels() already
> exists in AlterPublicationOptions(). You can try to refactor the
> existing code as a separate
On Mon, Aug 30, 2021 at 2:14 PM Greg Nancarrow wrote:
>
> On Fri, Aug 27, 2021 at 4:13 PM vignesh C wrote:
> >
> > I have implemented this in the 0003 patch, I have kept it separate to
> > reduce the testing effort and also it will be easier if someone
> > disagrees
On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com
wrote:
>
> From Tuesday, August 31, 2021 1:10 AM vignesh C wrote:
> > Hi,
> >
> > Relation invalidation was missing in case of create publication and drop
> > publication of "FOR ALL TABLES" pu
gnesh
From fd58e547c22723856a2f18c306b17ab6e59cddb1 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Mon, 30 Aug 2021 22:29:07 +0530
Subject: [PATCH v1] Added missing invalidations for all tables publication.
Relation invalidation was missing in case of create publication and drop
publication of "FOR ALL TABL
On Mon, Aug 30, 2021 at 1:31 PM tanghy.f...@fujitsu.com
wrote:
>
> On Friday, August 27, 2021 2:13 PM vignesh C wrote:
> >
> > I have implemented this in the 0003 patch, I have kept it separate to
> > reduce the testing effort and also it will be easier if someone
>
On Mon, Aug 30, 2021 at 9:10 AM houzj.f...@fujitsu.com
wrote:
>
> On Friday, August 27, 2021 2:13 PM vignesh C wrote:
> >
> > I have implemented this in the 0003 patch, I have kept it separate to
> > reduce the
> > testing effort and also it will
On Mon, Aug 30, 2021 at 8:23 AM Greg Nancarrow wrote:
>
> On Fri, Aug 27, 2021 at 4:13 PM vignesh C wrote:
> >
> > I have implemented this in the 0003 patch, I have kept it separate to
> > reduce the testing effort and also it will be easier if someone
> > disagrees
On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote:
>
> On Fri, Aug 27, 2021 at 6:09 PM vignesh C wrote:
> >
> > On Fri, Aug 27, 2021 at 4:57 PM Amit Kapila wrote:
> > >
> > > On Fri, Aug 27, 2021 at 11:43 AM vignesh C wrote:
> > > >
> >
On Fri, Aug 27, 2021 at 4:57 PM Amit Kapila wrote:
>
> On Fri, Aug 27, 2021 at 11:43 AM vignesh C wrote:
> >
> > On Wed, Aug 25, 2021 at 3:07 PM vignesh C wrote:
> >
> > I have implemented this in the 0003 patch, I have kept it separate to
> >
On Thu, Aug 26, 2021 at 7:52 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, August 25, 2021 5:37 PM vignesh C wrote:
> >
> > Attached v21 patch has the changes based on the new syntax and fixes
> > few of the other review comments provided by reviewers.
> >
&g
On Fri, Jul 16, 2021 at 10:51 PM vignesh C wrote:
>
> On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote:
> >
> > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote:
> > >
> > > Yeah, this looks like a bug. I will look at the patch.
> > >
> >
On Wed, Jul 21, 2021 at 10:56 PM vignesh C wrote:
>
> On Wed, Jul 21, 2021 at 3:52 PM Bharath Rupireddy
> wrote:
> >
> > On Tue, Jul 13, 2021 at 9:03 PM vignesh C wrote:
> > >
> > > On Wed, May 12, 2021 at 2:27 AM Robert Haas wrote:
>
On Thu, Jul 15, 2021 at 5:57 PM vignesh C wrote:
>
> On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote:
> >
> > On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
> > >
> > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> > > >
> &g
On Sat, Aug 14, 2021 at 3:02 PM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
>
> On 13.08.21 04:59, Amit Kapila wrote:
> >> Even if we drop all tables added to the publication from it, 'pubkind'
> >> doesn't go back to 'empty'. Is that intentional behavior? If we do
> >> that, we
On Tue, Aug 17, 2021 at 6:55 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > On Tue, Aug 17, 2021 at 6:40 AM Peter Smith
wrote:
> >> On Mon, Aug 16, 2021 at 11:31 PM Tom Lane wrote:
> >>> Abstractly it'd be
> >>>
> >>> createpub := CREATE PUBLICATION pubname FOR cpitem [, ... ] [ WITH
... ]
>
On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote:
> >
> > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila
wrote:
> > >
> > >
> > > Few more comments:
> > > ===
> > >
On Mon, Aug 9, 2021 at 10:23 AM Amit Kapila wrote:
>
> On Sun, Aug 8, 2021 at 2:52 PM vignesh C wrote:
> >
> > On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila
wrote:
> > >
> > > On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote:
> > > >
> >
On Thu, Aug 12, 2021 at 5:54 PM Masahiko Sawada
wrote:
>
> On Fri, Aug 6, 2021 at 5:33 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v19 patch has the fixes for the
comments.
>
> Thank you for updating the patch!
>
> Here
On Tue, Aug 10, 2021 at 1:40 PM Greg Nancarrow wrote:
>
> On Fri, Aug 6, 2021 at 6:32 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v19 patch has the fixes for the
comments.
> >
>
> Some more review comments, this time for the v19 patch:
>
&
On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger
wrote:
>
>
>
> > On Aug 6, 2021, at 1:32 AM, vignesh C wrote:
> >
> > the attached v19 patch
>
> With v19 applied, a schema owner can publish the contents of a table
regardless of ownership or permissions on that table:
On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger wrote:
>
>
>
> > On Aug 6, 2021, at 1:32 AM, vignesh C wrote:
> >
> > the attached v19 patch
>
> With v19 applied, a schema owner can publish the contents of a table
> regardless of ownership or permissions o
On Fri, Aug 6, 2021 at 2:00 PM Masahiko Sawada wrote:
>
> On Wed, Aug 4, 2021 at 12:08 AM vignesh C wrote:
> >
> > On Tue, Aug 3, 2021 at 12:00 PM tanghy.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, August 2, 2021 11:40 PM vignesh C wrote:
> &g
On Fri, Aug 6, 2021 at 3:33 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi
>
> I saw some inaccurate comments for AlterPublicationStmt structure when
> reviewing patches related to publication[1].
>
> The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE',
> but the comments only
On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote:
> >
> > On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila wrote:
> > >
> > > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote:
> >
> > > 6.
> >
On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote:
> >
> > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote:
> > >
> > >
> > > Few more comments:
> > > ===
> > >
On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote:
>
> On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila
wrote:
> >
> > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote:
> > >
> > > Thanks for reporting this, this is fixed in the v18 patch attached.
> > >
&
On Wed, Aug 4, 2021 at 8:08 PM tanghy.f...@fujitsu.com <
tanghy.f...@fujitsu.com> wrote:
>
> On Tuesday, August 3, 2021 11:08 PM vignesh C wrote:
> >
> > Thanks for reporting this, this is fixed in the v18 patch attached.
>
> Thanks for fixing it.
>
> Few sugge
On Tue, Aug 3, 2021 at 8:36 AM tanghy.f...@fujitsu.com
wrote:
>
> On Monday, August 2, 2021 11:56 PM vignesh C wrote:
> >
> > Few minor suggestions:
> > 1) Should we change below to "fail - tables can't be added, dropped or
> > set to "FOR ALL TABLES
On Tue, Aug 3, 2021 at 12:20 PM Masahiko Sawada wrote:
>
> On Mon, Aug 2, 2021 at 12:21 PM Amit Kapila wrote:
> >
> > On Mon, Aug 2, 2021 at 7:45 AM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 30, 2021 at 12:52 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Jul 29, 2021 at 11:18
On Tue, Aug 3, 2021 at 12:32 PM Amit Kapila wrote:
>
> On Tue, Aug 3, 2021 at 6:17 AM Peter Smith wrote:
> >
> > Please find attached the latest patch set v102*
> >
>
> I have made minor modifications in the comments and docs, please see
> attached. Can you please check whether the names of
On Mon, Aug 2, 2021 at 1:13 PM Masahiko Sawada wrote:
>
> On Mon, Aug 2, 2021 at 2:52 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Thursday, July 29, 2021 10:50 AM Masahiko Sawada
> > wrote:
> > > On Thu, Jul 8, 2021 at 3:55 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > > When the
On Mon, Aug 2, 2021 at 3:31 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi Hackers
>
> When review and test another patch at [1], I found some comments in existing
> test code of " src/test/regress/sql/publication.sql " is a little bit
> confused.
> Attached a patch to fix them, please take a check.
On Mon, Aug 2, 2021 at 9:10 PM Tom Lane wrote:
>
> Peter Smith writes:
> > I agree. The specified value looks better when it comes first, as you did
> > it.
>
> Actually, it looks to me like we don't have to resolve the question of
> which should come first, because I don't see any cases where
On Sun, Aug 1, 2021 at 4:11 PM Peter Smith wrote:
>
> On Sat, Jul 31, 2021 at 7:00 AM Tom Lane wrote:
> >
> > vignesh C writes:
> > [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ]
> >
> > I see what you want to do here, but the way yo
On Sat, Jul 31, 2021 at 2:30 AM Tom Lane wrote:
>
> vignesh C writes:
> [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ]
>
> I see what you want to do here, but the way you did it seems quite
> detrimental to the readability of the field description
On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian wrote:
>
> On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila wrote:
>
> > Here, the test is expecting 2 prepared transactions corresponding to
> > two subscriptions but it waits for just one subscription via
> > appname_copy. It should wait for the second
On Fri, Jul 30, 2021 at 9:32 AM Peter Smith wrote:
>
> Please find attached the latest patch set v100*
>
> v99-0002 --> v100-0001
>
> Differences:
>
> * Rebased to HEAD @ today (needed because some recent commits [1][2] broke
> v99)
>
The patch applies neatly, tests passes and documentation
On Tue, Jul 27, 2021 at 5:11 AM Greg Nancarrow wrote:
>
> On Mon, Jul 26, 2021 at 3:21 PM vignesh C wrote:
> >
> > Thanks for the comment, this is modified in the v15 patch attached.
> >
>
> I have several minor review comments.
>
> (1) src/backend/catalog/ob
On Mon, Jul 26, 2021 at 7:41 AM tanghy.f...@fujitsu.com <
tanghy.f...@fujitsu.com> wrote:
>
> On Friday, July 23, 2021 8:18 PM vignesh C wrote:
> >
> > I have changed it to not report any error, this issue is fixed in the
> > v14 patch attached at [1].
> > [1]
On Fri, Jul 23, 2021 at 3:23 AM Peter Smith wrote:
>
> I think the patch maybe is not quite correct for all the flags.
>
> For example,
>
> @@ -7607,44 +7615,44 @@ are available since protocol version 3.
>
> Int8
>
> -Flags; currently unused (must be 0).
> +
On Fri, Jul 23, 2021 at 6:26 AM tanghy.f...@fujitsu.com
wrote:
>
> On Thursday, July 22, 2021 1:30 AM vignesh C wrote:
> >
> > Thanks for reporting this issue, this issue is fixed in the attached v13
> > patch.
> > I have changed relation name pg_publication_schem
On Thu, Jul 22, 2021 at 9:38 AM Greg Nancarrow wrote:
>
> On Thu, Jul 22, 2021 at 1:42 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Personally, the new name pg_publication_sch is not very easy to
understand.
> > (Maybe it's because I am not a native english speaker. If others feel
ok,
> > please
On Sat, Jun 12, 2021 at 1:59 PM Julien Rouhaud wrote:
>
> On Tue, Jun 08, 2021 at 12:16:48PM +0800, Julien Rouhaud wrote:
> > On Sun, Jun 06, 2021 at 02:50:19PM +0800, Julien Rouhaud wrote:
> > > On Sat, May 01, 2021 at 03:24:58PM +0800, Julien Rouhaud wrote:
> > > >
> > > > I'm attaching some
On Thu, Jul 15, 2021 at 5:12 PM vignesh C wrote:
>
> On Thu, Jul 15, 2021 at 1:40 PM Dean Rasheed wrote:
> >
> > On Tue, 13 Jul 2021 at 15:30, vignesh C wrote:
> > >
> > > On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed
> > > wrote:
> > >
On Tue, Jun 29, 2021 at 7:10 PM Peter Eisentraut
wrote:
>
> Here is an updated patch with some merge conflicts resolved, to keep it
> fresh. It's still pending in the commit fest from last time.
>
> My focus right now is to work on the "psql - add SHOW_ALL_RESULTS
> option" patch
On Thu, Jul 1, 2021 at 9:42 PM Mark Dilger wrote:
>
>
>
> > On Jun 29, 2021, at 6:25 PM, Mark Dilger
> > wrote:
> >
> > Please find attached a new set of patches.
>
> And again, this time attaching a fifth patch which includes the work to allow
> users who belong to the right security role to
On Thu, Jul 1, 2021 at 6:41 AM Gurjeet Singh wrote:
>
> The proposed patch is attached.
There is one compilation warning:
xid.c:165:1: warning: no previous prototype for
‘FullTransactionIdToStr’ [-Wmissing-prototypes]
165 | FullTransactionIdToStr(FullTransactionId fxid)
|
On Fri, Jul 2, 2021 at 7:35 AM Amit Langote wrote:
>
> On Fri, Jul 2, 2021 at 1:39 AM Tom Lane wrote:
> >
> > Amit Langote writes:
> > > [ v6-0001-Allow-batching-of-inserts-during-cross-partition-.patch ]
> >
> > Per the cfbot, this isn't applying anymore, so I'm setting it back
> > to Waiting
On Fri, Jul 16, 2021 at 9:19 AM Justin Pryzby wrote:
>
> rebased.
>
> Also, there were two redundant checks for multiple SET ACCESS METHOD commands.
> But one of them wasn't hit if the ALTER was setting the current AM due to the
> no-op test.
>
> I think it's better to fail in every case, and not
On Wed, Jul 21, 2021 at 3:14 PM Rahila Syed wrote:
>
>
>
> On Mon, Jul 19, 2021 at 2:41 PM Greg Nancarrow
wrote:
>>
>> On Fri, Jul 16, 2021 at 8:13 PM vignesh C wrote:
>> >
>> > Modified.
>> >
>> > Thanks for the comments, these issu
On Mon, Jul 19, 2021 at 2:41 PM Greg Nancarrow wrote:
>
> On Fri, Jul 16, 2021 at 8:13 PM vignesh C wrote:
> >
> > Modified.
> >
> > Thanks for the comments, these issues are fixed as part of the v12 patch
> > posted at [1].
> > [1] -
On Mon, Jul 19, 2021 at 9:32 AM tanghy.f...@fujitsu.com <
tanghy.f...@fujitsu.com> wrote:
>
> On Friday, July 16, 2021 6:10 PM vignesh C
> > On Wed, Jul 14, 2021 at 6:25 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Wednesday, July 14, 2021 6:17 P
On Wed, Jul 21, 2021 at 3:52 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Tue, Jul 13, 2021 at 9:03 PM vignesh C wrote:
> >
> > On Wed, May 12, 2021 at 2:27 AM Robert Haas
wrote:
> > >
> > > Maybe we should have a role
On Mon, 19 Jul 2021, 09:16 Michael Paquier, wrote:
>
> On Sun, Jul 18, 2021 at 12:37:48PM +0900, Michael Paquier wrote:
> > Indeed, good catch. The other commands document that, so let's fix
> > it.
>
> Applied.
Thanks for committing this patch.
Regards,
Vignesh
On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote:
>
> On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote:
> >
> > Yeah, this looks like a bug. I will look at the patch.
> >
>
> While looking into this, I think the main cause of the problem is that
> schema rename does not invalidate the
On Fri, Jul 9, 2021 at 1:06 PM Peter Smith wrote:
>
> I found that the psql tab auto-complete was not working for some cases
> of CREATE PUBLICATION [1].
>
> CREATE PUBLICATION name
> [ FOR TABLE [ ONLY ] table_name [ * ] [, ...]
> | FOR ALL TABLES ]
> [ WITH ( publication_parameter
Hi,
Cascade and restrict options are supported for drop statistics syntax:
drop statistics stat1 cascade;
drop statistics stat2 restrict;
The documentation for this was missing, attached a patch which
includes the documentation for these options.
Regards,
Vignesh
From
On Tue, Jul 13, 2021 at 9:16 PM Wu Haotian wrote:
>
> > 2) I felt pg_dump will include the cascade option for plain format and
> > pg_restore will include the cascade option from pg_restore for other
> > formats. If my understanding is correct, should we document this?
>
> I may not understand it
On Fri, Jul 16, 2021 at 8:52 AM Peter Smith wrote:
>
> Hi Vignesh.
>
> FYI - Because the other patch [1] was pushed ahead of this one, I
> think your patch now needs to be updated for the new message types
> that were introduced.
Thanks, I have made the changes for the same in the v5 patch
On Fri, Jul 16, 2021 at 9:25 AM Greg Nancarrow wrote:
>
> On Wed, Jul 14, 2021 at 8:17 PM vignesh C wrote:
> >
> > Thanks for your comments, the attached v11 patch fixes the issues.
> >
>
> Thanks for your work on this.
>
> I have some minor review comments
On Wed, Jul 14, 2021 at 2:03 PM Peter Smith wrote:
>
> On Wed, Jul 14, 2021 at 4:23 PM Amit Kapila wrote:
> >
> > On Mon, Jul 12, 2021 at 9:14 AM Peter Smith wrote:
> > >
> > > On Sun, Jul 11, 2021 at 8:20 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Fri, Jul 9, 2021 at 4:43 AM Peter Smith
On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote:
>
> On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
> >
> > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> > >
> > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> > > >
> > >
On Tue, Jun 22, 2021 at 2:37 AM Heikki Linnakangas wrote:
>
> On 17/06/2021 02:00, Andres Freund wrote:
> > On 2021-06-16 16:30:45 +0300, Heikki Linnakangas wrote:
> >> That's a fairly clean split. StartupXLOG() stays in xlog.c, but much of
> >> the
> >> code from it has been moved to new
901 - 1000 of 1528 matches
Mail list logo
