Re: [HACKERS] Add YAML option to explain

2009-11-29 Thread Itagaki Takahiro
Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp wrote: My rewrite is relatively large. Please reversely-review the patch. I rethink the code cleanup should be done with another patch even if needed. Here is a lite version of yaml YAML explan patch. All of the logic for indent is done in

Re: [HACKERS] Add YAML option to explain

2009-11-15 Thread Itagaki Takahiro
Greg Sabino Mullane g...@turnstep.com wrote: On 08/28/2009 02:16 PM, Greg Sabino Mullane wrote: Attached patch adds YAML output option to explain: explain (format YAML) select * from information_schema.columns; Updated version of the patch attached, fixes two small errors. I've reviewed

Re: [HACKERS] Add YAML option to explain

2009-08-31 Thread Greg Sabino Mullane
On 08/28/2009 02:16 PM, Greg Sabino Mullane wrote: Attached patch adds YAML output option to explain: explain (format YAML) select * from information_schema.columns; Updated version of the patch attached, fixes two small errors. -- Greg Sabino Mullane g...@turnstep.com PGP Key: 0x14964AC8

Re: [HACKERS] Add YAML option to explain

2009-08-31 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 Greg, can we see a few examples of the YAML output compared to both json and text? Sure. Be warned it will make this email long. Because email may

Re: [HACKERS] Add YAML option to explain

2009-08-31 Thread Kevin Grittner
Greg Sabino Mullane g...@turnstep.com wrote: - Plan: Node Type: Index Scan Scan Direction: Forward Index Name: pg_class_relname_nsp_index Relation Name: pg_class Alias: pg_class Startup Cost: 0.00 Total Cost: 8.27 Plan Rows: 1 Plan

Re: [HACKERS] Add YAML option to explain

2009-08-31 Thread daveg
On Mon, Aug 31, 2009 at 02:15:08PM -, Greg Sabino Mullane wrote: Greg, can we see a few examples of the YAML output compared to both json and text? ... greg=# explain (format json, analyze on) select * from pg_class where relname ~ 'x' order by 1,2,3; QUERY PLAN

[HACKERS] Add YAML option to explain

2009-08-28 Thread Greg Sabino Mullane
Attached patch adds YAML output option to explain: explain (format YAML) select * from information_schema.columns; -- Greg Sabino Mullane g...@turnstep.com PGP Key: 0x14964AC8 200908281414 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 Index:

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Andrew Dunstan
Greg Sabino Mullane wrote: Attached patch adds YAML output option to explain: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? cheers andrew -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. By the

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Florian Weimer
* Greg Sabino Mullane: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. But YAML is much more difficult to

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Josh Berkus
On 8/28/09 1:13 PM, Greg Sabino Mullane wrote: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. How many

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Joshua D. Drake
On Fri, 2009-08-28 at 14:23 -0700, Josh Berkus wrote: On 8/28/09 1:13 PM, Greg Sabino Mullane wrote: I thought the consensus was that we didn't want to get into supporting more formats. What does YAML provide that JSON does not? Readability and easy editing. All the power of JSON

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Peter Eisentraut
On fre, 2009-08-28 at 20:13 +, Greg Sabino Mullane wrote: Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. But these are supposed to be machine-readable formats. So readability and editability are not high priority criteria. -- Sent

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 How many lines of code does YAML support add to the codebase? About 80. While I personally like YAML, it's not like it has broad industry support. And people wouldn't interface with the XML or JSON directly; they'd use a library for

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Stephen Frost
* Greg Sabino Mullane (g...@turnstep.com) wrote: Attached patch adds YAML output option to explain: explain (format YAML) select * from information_schema.columns; +1 from me. I've read the other comments and just plain don't agree with them. It's a small patch, adds a useful format for

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread David E. Wheeler
On Aug 28, 2009, at 3:45 PM, Stephen Frost wrote: +1 from me. I've read the other comments and just plain don't agree with them. It's a small patch, adds a useful format for EXPLAIN, and would be used. One of the best things about PG is the flexibility and usability. I agree, I tend to

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread Ron Mayer
Peter Eisentraut wrote: On fre, 2009-08-28 at 20:13 +, Greg Sabino Mullane wrote: Readability and easy editing. All the power of JSON without the annoying quotes, braces, and brackets. But these are supposed to be machine-readable formats. So readability and editability are not high

Re: [HACKERS] Add YAML option to explain

2009-08-28 Thread daveg
On Fri, Aug 28, 2009 at 04:37:41PM -0700, David E. Wheeler wrote: On Aug 28, 2009, at 3:45 PM, Stephen Frost wrote: +1 from me. I've read the other comments and just plain don't agree with them. It's a small patch, adds a useful format for EXPLAIN, and would be used. One of the best