Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Andreas Pflug
Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. Andreas is asking. Please commit ASAP. Is I stated several times, I'll do the win32 as soon as I get a chance to. It's not a

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Peter Eisentraut
Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. How is logging typically handled on Windows? -- Peter Eisentraut http://developer.postgresql.org/~petere/

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Andreas Pflug
Peter Eisentraut wrote: Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. How is logging typically handled on Windows? It is done using the eventlog service (which is supported as

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Dave Page
It's better than no patch I think. /D -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Sat 7/31/2004 5:33 AM To: Dave Page Cc: Tom Lane; Andreas Pflug; PostgreSQL Patches Subject: Re: [PATCHES] Admin functions contrib Do people want the server file logging

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Tom Lane
Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. I'm slightly worried that we might be painting ourselves into a corner, ie implementing functionality that will never work on Windows. Personally,

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Andreas Pflug
Tom Lane wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. I'm slightly worried that we might be painting ourselves into a corner, ie implementing functionality that will never work on Windows.

Re: [PATCHES] Admin functions contrib

2004-07-31 Thread Bruce Momjian
This logging issue has drained a lot of time during feature freeze when we should be getting existing patches in and completed. I am willing to apply a perfect patch but I am not willing to spend anymore time on this than I have to. This is all something that shouldn't be happening during

Re: [PATCHES] Admin functions contrib

2004-07-30 Thread Dave Page
-Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 29 July 2004 18:41 To: Andreas Pflug Cc: Bruce Momjian; PostgreSQL Patches; Dave Page Subject: Re: [PATCHES] Admin functions contrib Andreas Pflug [EMAIL PROTECTED] writes: Bruce Momjian wrote: So, I

Re: [PATCHES] Admin functions contrib

2004-07-30 Thread Andreas Pflug
Dave Page wrote: As Bruce has seen, this is some pretty nice functionality that Andreas has added to pga3, and is one of the few areas that we lag behind SQL Server etc. in on the management front. If you're curious what Bruce has seen, it was this:

Re: [PATCHES] Admin functions contrib

2004-07-30 Thread Bruce Momjian
Andreas Pflug wrote: Dave Page wrote: As Bruce has seen, this is some pretty nice functionality that Andreas has added to pga3, and is one of the few areas that we lag behind SQL Server etc. in on the management front. If you're curious what Bruce has seen, it was this:

Re: [PATCHES] Admin functions contrib

2004-07-30 Thread Bruce Momjian
Dave Page wrote: Also, what happens if you find that the contrib package doesn't do everything you need? You'll be stuck for another PG release cycle, whereas rejiggering a plperl function that pgadmin is defining for itself is no problem. pgAdmin I used to create helper functions

Re: [PATCHES] Admin functions contrib

2004-07-30 Thread Bruce Momjian
- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 29 July 2004 18:41 To: Andreas Pflug Cc: Bruce Momjian; PostgreSQL Patches; Dave Page Subject: Re: [PATCHES] Admin functions contrib Andreas Pflug [EMAIL PROTECTED] writes: Bruce Momjian wrote: So, I suggest we get the logging code

Re: [PATCHES] Admin functions contrib

2004-07-29 Thread Andreas Pflug
Bruce Momjian wrote: I talked to Tom about this today. First, I want to apologize for running you around in circles in this. I don't think we are giving it the attention it needs because of our schedule. I also think the functionality is drifting into the new features territory and this is also

Re: [PATCHES] Admin functions contrib

2004-07-29 Thread Bruce Momjian
Andreas Pflug wrote: So, I suggest we get the logging code into the backend, and you can code anything you want pgadmin to do in plperlu, and Win32 supports plperlu too. The big advantage is that you can improve the plperlu functions with every release of pgadmin. I do not agree on

Re: [PATCHES] Admin functions contrib

2004-07-29 Thread Andreas Pflug
Bruce Momjian wrote: Basically I think we are converging on an answer that we can't do any of this for 7.5. If it's not going into the distribution as contrib or core, I'll package that as additional admin pack. I'm quite sure I can convince the win32 installer packager guys to include that as

Re: [PATCHES] Admin functions contrib

2004-07-29 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: Bruce Momjian wrote: So, I suggest we get the logging code into the backend, and you can code anything you want pgadmin to do in plperlu, and Win32 supports plperlu too. The big advantage is that you can improve the plperlu functions with every release

Re: [PATCHES] Admin functions contrib

2004-07-28 Thread Bruce Momjian
I talked to Tom about this today. First, I want to apologize for running you around in circles in this. I don't think we are giving it the attention it needs because of our schedule. I also think the functionality is drifting into the new features territory and this is also part of the delay