Re: [Piglit] [PATCH] Add shader_runner GLSL version specification via requirements section.

2012-08-27 Thread Paul Berry
On 27 August 2012 17:23, Stuart Abercrombie wrote: > Thanks for the detailed response. I had various other changes bundled > up with this but I thought it best to get some feedback before going > too far. > > 1. I got ESSL from gles2_shader_runner.c. I wanted to use a more > obvious string but

[Piglit] [PATCH] egl-util: Add call to piglit_dispatch_default_init()

2012-08-27 Thread Matt Turner
Fixes egl-nok-swap-region and makes egl-nok-texture-from-pixmap not crash (but still fails). --- tests/egl/egl-util.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/egl/egl-util.c b/tests/egl/egl-util.c index 440e720..20cd699 100644 --- a/tests/egl/egl-util.c +++ b

[Piglit] [PATCH] egl_khr_create_context: Allow forward-compatible contexts to be rejected

2012-08-27 Thread Matt Turner
This reworks the test to test whether 1) forward-compatible contexts can be created, or 2) the correct error is generated when they can't. Previously the test did only the first and would fail if forward-compatible contexts couldn't be created. --- .../valid-flag-forward-compatibl

Re: [Piglit] [PATCH] Add shader_runner GLSL version specification via requirements section.

2012-08-27 Thread Paul Berry
On 24 August 2012 16:09, Stuart Abercrombie wrote: > The idea is to allow different GLSL versions for GL vs GL ES. There > shouldn't be a functional change until shader scripts are altered too. > > Added ES GLSL version string parsing. > I like where you're going with this. A few comments befor

Re: [Piglit] [PATCH 4/6] Get rid of reshape funcs

2012-08-27 Thread Chad Versace
On 08/26/2012 12:43 PM, Paul Berry wrote: > On 25 August 2012 01:12, Chris Forbes > wrote: > > Converts most of the custom reshape funcs to set the projection > in either piglit_init or piglit_display, depending on whether > it depends on the size. > > Si

Re: [Piglit] [PATCH] texturing: add full "round trip" test of array depth textures.

2012-08-27 Thread Ian Romanick
On 08/23/2012 05:00 PM, Paul Berry wrote: This test provokes a bug in Mesa as of 8/23/12 (commit 1cb07bd): when fast depth clears are performed on multiple layers of a multilayer depth texture (such as a 2D array or a cubemap texture), the implementation doesn't properly track the need for depth

Re: [Piglit] [PATCH] texturing: add full "round trip" test of array depth textures.

2012-08-27 Thread Chad Versace
On 08/23/2012 05:00 PM, Paul Berry wrote: > This test provokes a bug in Mesa as of 8/23/12 (commit 1cb07bd): when > fast depth clears are performed on multiple layers of a multilayer > depth texture (such as a 2D array or a cubemap texture), the > implementation doesn't properly track the need for

Re: [Piglit] [PATCH 6/6] Convert some raw glReadPixels to use piglit probes

2012-08-27 Thread Brian Paul
On Mon, Aug 27, 2012 at 12:26 PM, Matt Turner wrote: > On Sun, Aug 26, 2012 at 12:55 PM, Paul Berry wrote: >> Minor nit-pick: Our usual convention is to make "pass" a bool, and to write >> this as "pass = piglit_probe_pixel_rgba(...) && pass", just so that it's >> clear that there aren't any bit

Re: [Piglit] [PATCH 6/6] Convert some raw glReadPixels to use piglit probes

2012-08-27 Thread Matt Turner
On Sun, Aug 26, 2012 at 12:55 PM, Paul Berry wrote: > Minor nit-pick: Our usual convention is to make "pass" a bool, and to write > this as "pass = piglit_probe_pixel_rgba(...) && pass", just so that it's > clear that there aren't any bitwise shenanigans going on. Note that it > would probably m