Reviewed-by: Brian Paul
On 03/22/2014 12:20 PM, Marek Olšák wrote:
From: Marek Olšák
Instead of offsetting the vertex position for the second half of the screen,
setup both halves as separate viewports.
---
tests/general/primitive-restart-draw-mode.c | 10 --
1 file changed, 8
Y, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file fbo-tex-rgbx.c
+ * \author Brian Paul
+ *
+ * Test texturing from an RGB texture after we've rendered so
components);
@@ -2024,6 +2026,7 @@ piglit_init(int argc, char **argv)
&gl_max_vertex_uniform_components);
gl_max_fragment_uniform_components *= 4;
gl_max_vertex_uniform_components *= 4;
+ gl_max_clip_planes = 0;
#endif
if
xtension("GL_EXT_texture_shared_exponent");
+ format = GL_RGB9_E5;
+ }
+ else {
+ assert(0);
+ }
+ }
It might be nice if you could pass other internal formats to the test,
GL_RGB5, GL_RGB32F, etc. b
On 03/15/2014 10:53 AM, Marek Olšák wrote:
From: Marek Olšák
---
tests/all.py | 6 +
tests/fbo/CMakeLists.gl.txt| 1 +
tests/fbo/fbo-generatemipmap-cubemap.c | 499 +
3 files changed, 506 insertions(+)
create mode
On 03/17/2014 09:00 AM, Marek Olšák wrote:
On Mon, Mar 17, 2014 at 3:41 PM, Brian Paul wrote:
On 03/15/2014 10:53 AM, Marek Olšák wrote:
From: Marek Olšák
---
tests/spec/ext_framebuffer_multisample/formats.cpp | 14 +++-
tests/util/piglit-util-gl-common.h | 1
bits[0] = 32; bits[1] = 32; bits[2] = 32; bits[3] = 32;
+ return true;
+ }
Do you want to set bits[0..3] = 0 here just to be safe?
+ return false;
+}
+
/**
* Read a pixel from the given location and compare its RGBA value to the
* given expected valu
On 03/12/2014 12:56 PM, Anuj Phogat wrote:
On Wed, Mar 12, 2014 at 6:24 AM, Brian Paul mailto:bri...@vmware.com>> wrote:
On 03/11/2014 06:51 PM, Anuj Phogat wrote:
This patch is to verify a bug fix in mesa commit 079bff5. This
commit
allowed GL_DEPTH_COM
+ pass = test_pos_and_sizes() && pass;
- if (!test_pos_and_sizes())
- return PIGLIT_FAIL;
-
- return PIGLIT_PASS;
+ return pass ? PIGLIT_PASS: PIGLIT_FAIL;
}
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.free
On 03/11/2014 06:51 PM, Anuj Phogat wrote:
This patch is to verify a bug fix in mesa commit 079bff5. This commit
allowed GL_DEPTH_COMPONENT and GL_DEPTH_STENCIL combinations in
glTexImage{123}D functions.
Signed-off-by: Anuj Phogat
---
tests/texturing/teximage-errors.c | 73 ++
On 02/27/2014 08:04 AM, Brian Paul wrote:
Has anyone else here build piglit on Ubuntu 13.10? Starting with a
basically fresh installation, I'm trying to install python-numpy:
"""
$ sudo apt-get install python-numpy
Reading package lists... Done
Building dependenc
Before, we used maxSide/2 which could be very large, causing us to
allocate large amounts of memory with calloc(). This could sometimes
fail.
---
tests/texturing/max-texture-size.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/tests/texturing/max-text
Finally getting back to this one...
On 02/16/2014 04:31 PM, Kenneth Graunke wrote:
On 02/11/2014 07:59 AM, Brian Paul wrote:
On 02/10/2014 07:49 PM, Ian Romanick wrote:
On 02/07/2014 03:34 PM, Brian Paul wrote:
Save the max texture size found with the proxy targets. Then use
that max size
Checks a Mesa bug in glGetTexImage(GL_DEPTH_STENCIL/GL_UNSIGNED_INT_24_8)
v2: fix the extensions checks
---
tests/all.py |1 +
.../ext_packed_depth_stencil/CMakeLists.gl.txt |1 +
tests/spec/ext_packed_depth_stencil/getteximage.c | 200 +
On 02/28/2014 12:49 AM, Eric Anholt wrote:
Brian Paul writes:
+void
+piglit_init(int argc, char **argv)
+{
+ bool pass;
+
+ if (piglit_get_gl_version() < 30
+ && !(piglit_is_extension_supported("GL_EXT_pack
Checks a Mesa bug in glGetTexImage(GL_DEPTH_STENCIL/GL_UNSIGNED_INT_24_8)
---
tests/all.py |1 +
.../ext_packed_depth_stencil/CMakeLists.gl.txt |1 +
tests/spec/ext_packed_depth_stencil/getteximage.c | 196
3 files changed, 1
Has anyone else here build piglit on Ubuntu 13.10? Starting with a
basically fresh installation, I'm trying to install python-numpy:
"""
$ sudo apt-get install python-numpy
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be instal
- bool is_compressed;
- GLuint compressed_size;
- GLenum format;
+ GLint is_compressed;
+ GLint compressed_size;
+ GLint format;
glPixelStorei(GL_UNPACK_SKIP_PIXELS, 0);
glPixelStorei(GL_UNPACK_SKIP_ROWS, 0);
Reviewed-by
On 02/25/2014 01:47 PM, Ken Phillis Jr wrote:
On Mon, Feb 24, 2014 at 1:41 PM, Eric Anholt wrote:
I'd really like to get this in soon -- Fabian just spent what was
probably quite a bit of time building a new piglit-private dispatch
builder due to the .spec files no longer being updated, and I'd
On 02/10/2014 07:49 PM, Ian Romanick wrote:
On 02/07/2014 03:34 PM, Brian Paul wrote:
Save the max texture size found with the proxy targets. Then use
that max size when we test the regular/non-proxy targets with
glTexImage and glTexSubImage().
The whole point of proxy textures is to be able
There's a typo in the subject line: "s3rc" -> "s3tc"
-Brian
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
bool pass = false;
int dy, y = piglit_height / 2;
glClear(GL_COLOR_BUFFER_BIT);
Reviewed-by: Brian Paul
Thanks, Vinson!
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 02/08/2014 12:59 PM, Vinson Lee wrote:
Fixes "Uninitialized scalar variable" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
tests/general/line-flat-clip-color.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/general/line-flat-clip-color.c
b/test
Save the max texture size found with the proxy targets. Then use
that max size when we test the regular/non-proxy targets with
glTexImage and glTexSubImage().
The whole point of proxy textures is to be able to probe the maximum
texture size. So let's use that size when we try the real textures.
All the other texture targets test glTexSubImage(), so do it for
this target too.
---
tests/texturing/max-texture-size.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/texturing/max-texture-size.c
b/tests/texturing/max-texture-size.c
index 60ebc15..49bf766 100644
--- a/tests/text
If texInitData() failed, it was with maxSide/2, not maxSide.
---
tests/texturing/max-texture-size.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/texturing/max-texture-size.c
b/tests/texturing/max-texture-size.c
index 49bf766..45e01c9 100644
--- a/tests/texturing/ma
Hi Kenneth,
In addition to a couple patches which I just posted, I think there's
some more loose ends in this test.
Basically, the test_proxy_texture_size test determines the maximum
texture size that passes the proxy test. I think we want to use that
info when we do the test_non_proxy_text
ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+/*
+ * Test flat-shaded clipped line color.
+ * Exercises provoking vertex, line smooth, line width, etc.
+ *
+ * Author: Brian Paul
+ */
+
+
+#include "piglit-util-gl-common.h&quo
ite this
test too but never carried through on it.
Reviewed-by: Brian Paul
One issue I recall is the width*height*depth calculation overflowing a
32-bit int/size_t somewhere, causing invalid results on 32-bit systems.
That might still need to be addressed.
-Brian
___
eck_gl_error(GL_NO_ERROR);
> + if (!piglit_check_gl_error(GL_NO_ERROR)) {
> + piglit_report_result(PIGLIT_FAIL);
> + }
>
> return vbo;
> }
>
I think I had those calls in there just as sanity checks during
development. They coul
#define WIN32_LEAN_AND_MEAN
+#endif
#include
#endif
All 7 patches look OK to me.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
return pass ? PIGLIT_PASS : PIGLIT_FAIL;
}
For all six patches: Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
bo.c
+++ b/tests/texturing/cubemap-getteximage-pbo.c
@@ -38,6 +38,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
PIGLIT_GL_TEST_CONFIG_END
+#undef NUMCOLORS
#define NUMCOLORS7
#define TEX_WIDTH32
#define TEX_HEIGHT 32
Reviewed-by:
TexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, width, height, depth,
0,
For both: Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Brian Paul
On 01/13/2014 02:34 PM, Ilia Mirkin wrote:
ping^2?
On Fri, Dec 20, 2013 at 3:04 PM, Ilia Mirkin wrote:
ping?
On Sun, Dec 8, 2013 at 2:48 AM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
tests/texturing/array-texture.c | 12
1 file changed
t_init(int argc, char **argv)
{
- GLenum internal_format;
+ GLenum internal_format = GL_NONE;
const char *fmt;
if ((argc == 1) || (strncmp(argv[1], "GL_R", 4) != 0))
This and the other 6 piglit patches look fine to me.
Rev
Just minor nits below but looks good otherwise.
Reviewed-by: Brian Paul
On 01/08/2014 10:17 AM, Marek Olšák wrote:
From: Marek Olšák
---
tests/all.tests| 8 +
.../spec/arb_framebuffer_object/CMakeLists.gl.txt | 1 +
.../arb_framebuffer_object/fbo
xt
index df2ea70..6745a2f 100644
--- a/tests/util/CMakeLists.txt
+++ b/tests/util/CMakeLists.txt
@@ -1,6 +1,6 @@
add_definitions(-DSOURCE_DIR="${piglit_SOURCE_DIR}/")
-if(PIGLIT_HAS_POSIX_CLOCK_MONOTONIC)
+if(PIGLIT_HAS_POSIX_CLOCK_MONOTONIC AND HAVE_LIBRT)
link_libraries(rt)
endi
exture_cube_map_array")
&& piglit_get_gl_version() < 40) {
- piglit_report_subtest_result(PIGLIT_SKIP, subtest_name);
+ piglit_report_subtest_result(PIGLIT_SKIP, "%s", subtest_name);
return true;
}
Reviewed
basetype)
type = GL_FLOAT;
} else {
assert(0);
+ format = GL_NONE;
+ type = GL_NONE;
}
} else {
tex = piglit_rgbw_
L_INCLUDES
${CMAKE_CURRENT_BINARY_DIR}
${CMAKE_CURRENT_SOURCE_DIR}
Thanks. This fixes a problem I saw on one of my systems. I'll push
this patch soon.
Tested-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freed
1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=B9FQT9xPZisThoztsRIIsb2v4JD4DAjsVwrD7xgTBvg%3D%0A&s=4d821799162f254b69415e626d846674a60f45ae0fc42617cc5a630985b94365
#ifndef INFINITY
That seems to work on my system.
On 12/21/2013 05:01 PM, Marek Olšák wrote:
This test is wrong. The section 3.8.7 (page 160) of the GL 3.2 core
specification says:
"Depth textures and the depth components of depth/stencil textures can
be treated as RED textures during texture filtering and application
(see section 3.8.15). The
xtures and the depth components of depth/stencil textures can
+ * be treated as RED textures during texture filtering and application
+ * (see section 3.8.15). The initial state for depth and depth/stencil
+ * textures treats them as RED textures."
*
* Brian Paul
* 5 Dec 2013
@@ -181,14 +175
On 12/21/2013 05:01 PM, Marek Olšák wrote:
This test is wrong. The section 3.8.7 (page 160) of the GL 3.2 core
specification says:
"Depth textures and the depth components of depth/stencil textures can
be treated as RED textures during texture filtering and application
(see section 3.8.15). The
On 12/20/2013 04:33 PM, Brian Paul wrote:
On 12/19/2013 05:39 PM, Vinson Lee wrote:
MinGW provides asprintf in stdio.h.
Bugzilla:
https://urldefense.proofpoint.com/v1/url?u=https://bugs.freedesktop.org/show_bug.cgi?id%3D72556&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp
i-errors.c
@@ -48,7 +48,9 @@
* implementation is not overly aggressive in flagging errors.
*/
+#ifndef _GNU_SOURCE
#define _GNU_SOURCE
+#endif
#include "piglit-util-gl-common.h"
PIGLIT_GL_TEST_CONFIG_BEGIN
Reviewed-by: Brian Paul
___
est_result(subtest_result, "%s",
all_subtests[i].name);
piglit_merge_result(&result, subtest_result);
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
be on the alert for any regressions here.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 12/19/2013 12:37 PM, Ian Romanick wrote:
From: Ian Romanick
Signed-off-by: Ian Romanick
---
tests/texturing/depthstencil-render-miplevels.cpp | 5 +
1 file changed, 5 insertions(+)
For the series, quick review, LGTM.
Reviewed-by: Brian Paul
On 12/17/2013 07:06 PM, Huang, JunX A wrote:
Hi Paul,
Thanks for your correcting!
But I still can not follow your following saying, could you be more specific?
"Also, maybe it should be structured so that the floating point matrix is first
constructed from the mantisa & exponent arrays first.
On 12/14/2013 10:02 AM, Pi Tabred wrote:
- clear-buffer-sub: test if buffer subregions are correctly cleared
- clear-buffer: test if entire buffer is correctly cleared
- negative-already-mapped: test if buffer or buffer range is already mapped
- negative-bad-format-type: test - combinat
On 12/12/2013 07:42 AM, Huang Jun wrote:
---
tests/all.tests|4 +
tests/spec/CMakeLists.txt |1 +
tests/spec/oes_query_matrix/CMakeLists.gles1.txt |7 +
tests/spec/oes_query_matrix/CMakeLists.txt |1 +
te
On 12/05/2013 06:56 PM, Eric Anholt wrote:
---
tests/spec/arb_sync/sync-initialize.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
On 12/05/2013 10:55 AM, Marek Olšák wrote:
From: Marek Olšák
Only 0 to MAX_DRAW_BUFFERS-1 is allowed. If you want to clear GL_BACK,
call glDrawBuffers(GL_BACK) and then glClearBuffer(GL_COLOR, 0, ..).
---
For the series:
Reviewed-by: Brian Paul
ion, page 332:
+ * "Depth texture mode - DEPTH_TEXTURE_MODE. Section 3.8.15 is to be
+ * changed so that r is returned to texture samplers directly, and
+ * the OpenGL Shading Language 1.30 Specification is to be changed
+ * so that (r,r,r,1) is alwa
@@
+include_directories (
+ ${GLEXT_INCLUDE_DIR}
+ ${OPENGL_INCLUDE_PATH}
+)
+
link_libraries (
piglitutil_${piglit_target_api}
${OPENGL_gl_LIBRARY}
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
Looks OK to me. Tested on NVIDIA (fails some cases due to apparent
driver bug). Pushed with minor whitespace change.
-Brian
On 12/02/2013 10:15 AM, Jon Ashburn wrote:
Can anyone review this patch from a week ago?
Thanks,
Jon Ashburn
On 11/25/13, 5:43 PM, Jon Ashburn wrote:
Add test case f
---
tests/all.tests |1 +
tests/spec/gl-1.0/CMakeLists.gl.txt |1 +
tests/spec/gl-1.0/long-dlist.c | 92 +++
3 files changed, 94 insertions(+)
create mode 100644 tests/spec/gl-1.0/long-dlist.c
diff --git a/tests/all.tests b/tests
try:
Tested-by: Brian Paul
Thanks, Dylan!
-Brian
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On two Mint systems I'm seeing this problem:
$ ./piglit-run.py -t kil tests/all.tests results/kil
Traceback (most recent call last):
File "./piglit-run.py", line 148, in
main()
File "./piglit-run.py", line 118, in main
json_writer.write_dict_item(key, value)
File "/home/brian/pigli
If we're running an ARB_vertex/fragment_program test, there will be
no GLSL shader program and 'prog' will be zero. Return early to avoid
generating an error from the GL_ACTIVE_UNIFORM_BLOCKS query.
---
tests/shaders/shader_runner.c |5 +
1 file changed, 5 insertions(+)
diff --git a/test
Passing a negative value for GL_UNPACK_SKIP_PIXELS raises a GL error
that we don't want. Just pass 0 for both SKIP_PIXELS and SKIP_ROWS.
---
tests/texturing/s3tc-errors.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/texturing/s3tc-errors.c b/tests/texturing/s3t
---
tests/glean/tpixelformats.cpp | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/tests/glean/tpixelformats.cpp b/tests/glean/tpixelformats.cpp
index 3518ed1..27881bf 100644
--- a/tests/glean/tpixelformats.cpp
+++ b/tests/glean/tpixelformats.cpp
@@ -156
---
tests/spec/gl-1.0/rendermode-feedback.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/spec/gl-1.0/rendermode-feedback.c
b/tests/spec/gl-1.0/rendermode-feedback.c
index 8691c96..eb48bce 100644
--- a/tests/spec/gl-1.0/rendermode-feedback.c
+++ b/tests/
NG
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * Check for a glScissorIndexed() bug found in MacOS AMD driver.
+ * Passes with NVIDIA's Linux driver.
+ *
+ * Brian Paul and others at VMware
+ * 15 Nov 2013
+ */
+
+
+
---
tests/glean/tpointatten.cpp | 16
1 file changed, 16 insertions(+)
diff --git a/tests/glean/tpointatten.cpp b/tests/glean/tpointatten.cpp
index 08076ca..0dee922 100644
--- a/tests/glean/tpointatten.cpp
+++ b/tests/glean/tpointatten.cpp
@@ -169,11 +169,19 @@ PointAttenuation
---
tests/glean/tblend.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/glean/tblend.cpp b/tests/glean/tblend.cpp
index 6611729..a0f67b7 100644
--- a/tests/glean/tblend.cpp
+++ b/tests/glean/tblend.cpp
@@ -800,7 +800,7 @@ BlendFuncTest::runOne(BlendFuncResult& r, Wi
To get more reasonable run times.
---
framework/gleantest.py |1 +
1 file changed, 1 insertion(+)
diff --git a/framework/gleantest.py b/framework/gleantest.py
index 88432e0..7bfc62e 100644
--- a/framework/gleantest.py
+++ b/framework/gleantest.py
@@ -35,6 +35,7 @@ class GleanTest(ExecTest):
On 11/18/2013 01:59 PM, Brian Paul wrote:
If we build waffle w/out ES support and we run all.tests, quick.tests,
etc. we get lots of 'fail' results for the ES tests. This change causes
those tests to be reported as 'skip' instead.
---
tests/util/piglit-util-waffle.c
On 11/19/2013 11:54 AM, Eric Anholt wrote:
Brian Paul writes:
Since the test is in the spec/gl-3.0/ directory, we should probably
require GL 3.0 or later.
The check for GL_ARB_texture_float for GL_DEPTH32F_STENCIL8 was
incorrect. The format is part of GL 3.0, not GL_ARB_texture_float.
Or
GL_DEPTH24_STENCIL8 is defined by GL_EXT_packed_depth_stencil.
GL_DEPTH32F_STENCIL8 is from GL_ARB_depth_buffer_float, not
GL_ARB_texture_float.
---
tests/spec/gl-3.0/api/genmipmap-errors.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/gl-3.0/api/genmipmap-e
**argv)
if (piglit_get_gl_version() < 32) {
piglit_require_extension("GL_ARB_draw_elements_base_vertex");
+ piglit_require_GLSL_version(130);
}
/* Create program */
Reviewed-b
Since the test is in the spec/gl-3.0/ directory, we should probably
require GL 3.0 or later.
The check for GL_ARB_texture_float for GL_DEPTH32F_STENCIL8 was
incorrect. The format is part of GL 3.0, not GL_ARB_texture_float.
---
tests/spec/gl-3.0/api/genmipmap-errors.c |4 ++--
1 file changed
On 11/18/2013 04:02 PM, Dylan Baker wrote:
On Monday, November 18, 2013 03:33:34 PM Marek Olšák wrote:
From: Marek Olšák
The usefulness of this is questionable to say the least.
---
framework/core.py | 72
--- framework/exectest.py |
2 --
If we build waffle w/out ES support and we run all.tests, quick.tests,
etc. we get lots of 'fail' results for the ES tests. This change causes
those tests to be reported as 'skip' instead.
---
tests/util/piglit-util-waffle.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
ter discussed in real time, many piglit
+developers can also be found in the #dri-devel channel on Freenode
+IRC.
Thanks, Paul! Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
ror is set.
Reviewed-by: Brian Paul
Signed-off-by: Jon Ashburn
---
tests/spec/arb_texture_view/targets.c | 53 +++
1 file changed, 41 insertions(+), 12 deletions(-)
diff --git a/tests/spec/arb_texture_view/targets.c
b/tests/spec/arb_texture_view/targets.c
index 2c2e5c
extension("GL_ARB_draw_elements_base_vertex");
> }
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 11/08/2013 01:40 PM, Jon Ashburn wrote:
The "targets" test is extended to include testing of
GL_TEXTURE_2D_MULTISAMPLE and GL_TEXTURE_2D_MULTISAMPLE_ARRAY.
This will test making valid and invalid texture views of these two
multisample targets and ensuring the correct GL error is set.
---
te
Typos below.
On 11/04/2013 08:15 AM, Jon Ashburn wrote:
Tests rendering into a single framebuffer surface with multiple viewports
via a geometry shader. Scissoring is used to restrict quads to a smaller
area on the surface. Confirm that each area of the surface delineated by
a scissor rectangl
th, height).
Tested with Nvidia Quadro 600. All tests pass except Scissor Box with a
negative height fails to return a gl error.
Reviewed-by: Brian Paul
Signed-off-by: Jon Ashburn
---
tests/all.tests | 1 +
tests/spec/arb_viewport_array/CMakeLists.gl.txt | 1
Just some formatting issues on this one and the same for patch 3/4.
On 11/01/2013 04:51 PM, Jon Ashburn wrote:
Tests GL_ARB_viewport_array validity for indices. Use both valid and
invalid parameters (index, first, count) for all these new API entry points:
glDepthRangeArrayv, glDepthRangeInde
Before, the test always drew green rects for all the target buffers.
Now we draw a different color into each buffer to be more thorough.
Plus, replace 16 with MAX_TARGETS, add some comments, etc.
Note: the test now fails with Mesa's swrast because swrast errantly
writes the same color to all rend
This passes w/ Mesa but crashes NVIDIA's driver.
---
.../declarations/bad-variable-redeclaration.frag | 29
1 file changed, 29 insertions(+)
create mode 100644
tests/spec/glsl-1.10/compiler/declarations/bad-variable-redeclaration.frag
diff --git
a/tests/spec/glsl-1.10/
On 11/02/2013 09:02 PM, Dylan Baker wrote:
Could you add a note about python code?
Just something like: "All python code should conform to python's PEP8
standard, using only spaces and no tabs" would be great.
Go for it!
-Brian
___
Piglit mailing
I've tried to describe Piglit's coding style and conventions in more
detail. Hopefully, new contributors will read this and it'll save
some some time and effort for the reviewers.
Please feel free to add/update this info.
---
HACKING | 57 ---
Exercises an NVIDIA driver bug related to glGetTexImage and sRGB
texture views.
---
tests/all.tests|1 +
tests/spec/arb_texture_view/CMakeLists.gl.txt |1 +
tests/spec/arb_texture_view/getteximage-srgb.c | 119
3 files changed, 121
Exercises an NVIDIA driver bug.
---
tests/all.tests |1 +
tests/texturing/CMakeLists.gl.txt |1 +
tests/texturing/cubemap-getteximage-pbo.c | 157 +
3 files changed, 159 insertions(+)
create mode 100644 tests/texturing/cubemap
+ reportError("Error generated when DeleteQueries called "
+ "in the progress of another.");
pass = false;
}
}
Reviewed-by: Brian Paul
__
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tested GLenums are GL_MAX_VIEWPORT_DIMS, GL_MAX_VIEWPORTS,
GL_VIEWPORT_SUBPIXEL_BITS, GL_VIEWPORT_BOUNDS_RANGE, GL_LAYER_PROVOKING_VERTEX,
GL_VIEWPORT_INDEX_PROVOKING_VERTEX.
Tested on Nvidia Quadro 600, test passes.
---
tests/all.tests
+
+void
+piglit_init(int argc, char **argv)
+{
+ GLuint program;
+
+ piglit_require_extension("GL_ARB_viewport_array");
+
+ program = piglit_build_simple_program_multiple_shaders(
+ GL_VERTEX_SHADER, vsSource,
+
printf("mismatched valf and vali for %s\n",
+ piglit_get_gl_enum_name(indexedTokens[i]));
+ printf("valf[0-3]= %f %f %f %f\n", valf[0], valf[1],
+
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tests rendering into a single framebuffer surface with multiple viewports
via a geometry shader. Scissoring is used to restrict quads to a smaller
area on the surface. Confirm that each area of the surface delineated by
a scissor rectangle for viewport
\
+ } while (0)
Insert a couple blank lines here.
+void
+piglit_init(int argc, char **argv)
+{
+ bool pass= true;
+ GLint maxVP;
+
+ piglit_require_extension("GL_ARB_viewport_array");
+
+ glGetIntegerv(GL_MAX_VIEWPORTS, &maxVP);
+
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tests GL_ARB_viewport_array regarding the validity for the indices.
Use both valid and invalid parameters (index, first, count) for these new
API entry points:
glViewportArrayv, glViewportIndexedf, glViewportIndexedfv, glGetFloati_v.
Also test that w
+ piglit_require_extension("GL_ARB_viewport_array");
+
+ program = piglit_build_simple_program_multiple_shaders(
+ GL_VERTEX_SHADER, vsSource,
+ GL_GEOMETRY_SHADER, gsSource,
+ GL_FRAGMENT_SHADER, fsSource,
+ 0);
+ glUseProgram(program);
+ colorLoc = glGetUniformLocation(program, "color");
+ vpIndexLoc = glGetUniformLocation(program, "idx");
+}
With above fixes: Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 10/28/2013 12:16 PM, Jon Ashburn wrote:
Tests texture views with data format changes. 1D textures only.
Uses multiple simultaneous views with different lifetimes and
check results via glGetTexImage().
Tested on Nvidia Quadro 600, all subtests pass.
Signed-off-by: Jon Ashburn
---
tests/al
On 10/28/2013 12:16 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view rendering with various texture targets.
Creates texture maps with different solid colors for each level or layer
reads the framebuffer to ensure the rendered color is correct.
Tested on Nvidia Quadro 600, all subtests pass.
S
On 10/28/2013 05:53 PM, Zack Rusin wrote:
Increase the subpixel precision to 8 bits. This requires
changing some of the code to 64 bits to avoid overflows.
Signed-off-by: Zack Rusin
---
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit
901 - 1000 of 1411 matches
Mail list logo
