D12102: Port Language KCM to Qt Quick

2018-04-20 Thread Andres Betts
abetts added a comment. In D12102#250486 , @rkflx wrote: > Hm, I could imagine regular users will have a hard time selecting their preferred language. They'll see a list of languages, and look for some kind of checkbox to "select what they want"

D12102: Port Language KCM to Qt Quick

2018-04-20 Thread Andres Betts
abetts added a comment. I can make more REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-20 Thread Andres Betts
abetts added a comment. In D12311#250637 , @bruns wrote: > If you really want to save some space (and probably make it easier for users to understand the dialog without getting lost), I think the whole > > > An application is attempting to pe

D12102: Port Language KCM to Qt Quick

2018-04-20 Thread Andres Betts
abetts added a comment. Here are additional mockups for thought.F5815917: Screen Shot 2018-04-20 at 10.54.07 PM.png F5815920: AddLanguageAnimation.mov REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D12278: WIP: [Colors KCM] Port to new design

2018-04-22 Thread Andres Betts
abetts added a comment. In D12278#251722 , @ngraham wrote: > In D12278#251602 , @broulik wrote: > > > > I also don't like "Default" either. What does that even mean to a regular user? > > > > Th

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2018-04-22 Thread Andres Betts
abetts added a comment. In D7934#147843 , @davidedmundson wrote: > F3921193: Spectacle.n23639.png Maybe I can help with this? Also, following the idea of simple, can we add explanatory text to these

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2018-04-22 Thread Andres Betts
abetts added a comment. In D7934#251775 , @davidedmundson wrote: > You can, but given it's intended audience and how hidden it now is, it really isn't worth putting a lot of time into. > > If you don't know what a render loop is, you most def

D12459: WIP: [Icon KCM] Port to new design

2018-04-22 Thread Andres Betts
abetts added a comment. Love it! I like how convenient the configure button is. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12459 To: broulik, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12468 To: ktatunov, #plasma, davidedmundson Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

2018-04-23 Thread Andres Betts
abetts added a comment. In D12278#252314 , @ngraham wrote: > Hmm, I'm not sure those white strips communicate "This is what text looks like." I think some sort of placeholder text would work better. To be honest I kinda liked the first one bette

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

2018-04-23 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2018-04-24 Thread Andres Betts
abetts added a comment. Can it say something like "Unlocking failed. Check your keyboard layout" ? I feel it is more generic. Also, will this message show even though there is only one keyboard layout enabled? Or will it only show when there are multiple layouts? REPOSITORY R120 Plasma Wo

D12515: QML applets need to manage padding by themselves

2018-04-25 Thread Andres Betts
abetts added a comment. What does this look like now? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12515 To: mart, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2018-04-30 Thread Andres Betts
abetts added a comment. What does this look like now after the changes? Screenshot? Video? :D REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik, #plasma, #vdg, ngraham Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragr

D12685: Fix calendar view: hide unused start/end time labels in day events list

2018-05-07 Thread Andres Betts
abetts added a comment. I think this is a good idea. Maybe the execution is a bit rough but we can work in making the looks better. Can you take a look at this calendar list and see if there are some things we can use? https://www.google.com/search?q=fantastical&source=lnms&tbm=isch&sa=

D12102: Port Language KCM to Qt Quick

2018-05-07 Thread Andres Betts
abetts added a comment. In D12102#254322 , @hein wrote: > New screenshot: > > F5823188: Screenshot_20180427_001323.png Is the Add Languages button able to be right aligned? Did we want to in

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

2018-05-14 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12859 To: Zren, #plasma, apol Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

2018-05-14 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12849: Improve layout of fonts kcm

2018-05-14 Thread Andres Betts
abetts added a comment. In D12849#262088 , @rkflx wrote: > The checkboxes wildly floating around on the left look a bit weird to me. How about this (I guess your original intention was to avoid having checkboxes under the wrong text label?): >

D12849: Improve layout of fonts kcm

2018-05-14 Thread Andres Betts
abetts added a comment. In D12849#262405 , @progwolff wrote: > You mean like this? > F5848305: Screenshot_fonts_layout_nocheckableitems.png > > Not sure if I like this better... This way "Exclude ran

D12849: Improve layout of fonts kcm

2018-05-15 Thread Andres Betts
abetts added a comment. In D12849#262693 , @progwolff wrote: > How about joining the options instead? > > F5849093: Screenshot_fonts_layout_radio.png I like that! REPOSITORY R119 Plasma Deskt

D12852: Added the option to display date in the same line of clock

2018-05-16 Thread Andres Betts
abetts added a comment. Where would this be used? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12852 To: astevanato, #plasma_workspaces, #vdg Cc: abetts, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12849: Improve layout of fonts kcm

2018-05-16 Thread Andres Betts
abetts added a comment. In D12849#263364 , @progwolff wrote: > In D12849#263302 , @broulik wrote: > > > We were always told by VDG that tabs are bad and a 5 km vertically scrolling list is better n

D12960: Drag handle to reorder items in a ListView

2018-05-18 Thread Andres Betts
abetts added a comment. In D12960#264657 , @rkflx wrote: > F5855884: drag-handles.png I think with this image we are trying to convey too much. Users in general, will understand that if you have a co

D12960: Drag handle to reorder items in a ListView

2018-05-18 Thread Andres Betts
abetts added a comment. In D12960#264734 , @ngraham wrote: > Regardless of what icon we choose, for a drag handle, I think it has to be a very light gray. We previously had a 4x3 dot grid, but because it was black, it looked very heavy and when

D13042: Do not show activity switcher during fast switches

2018-05-23 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

2018-05-23 Thread Andres Betts
abetts added a comment. In D13064#267117 , @hpereiradacosta wrote: > I am not particularly excited by the change, because on how it breaks the spacing between buttons in a toolbar. > I am also not completely convinced that it is important to

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

2018-05-23 Thread Andres Betts
abetts added a comment. In D13064#267356 , @ngraham wrote: > 'Fraid I gotta disagree with you on this one, @abetts. I think it's important to signal that these buttons will bring up a menu because without that, there is no way to distinguish it

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

2018-05-23 Thread Andres Betts
abetts added a comment. In D13064#267368 , @ngraham wrote: > In D13064#267358 , @hpereiradacosta wrote: > > > Should we also add a symbol on icons to say that they are non-dangerous ? (even if not a

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-05-25 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts, hein Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-26 Thread Andres Betts
abetts added a comment. In D13141#268862 , @ngraham wrote: > As for wanting to making this non-scrollable: in general, we should aspire for the main views of our KCMs to never require scrolling (subviews like tables are okay, of course). It's ve

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-05-29 Thread Andres Betts
abetts added a comment. Could a different approach work here? No change on hover, but just on click? The user controls the entire action. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, abetts, hein Cc: rkflx, hein, cfeck, plasma-d

D13202: Circular user avatar for Kickoff

2018-05-29 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, plasma-devel Cc: abetts, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13202: Circular user avatar for Kickoff

2018-05-29 Thread Andres Betts
abetts added a comment. In D13202#270391 , @ngraham wrote: > Nice work! Will test it out later today. > > There's no reason to have the appearance user-selectable, IMHO. Part of the goal here is a consistent visual appearance. I vote for alwa

D13202: Circular user avatar for Kickoff

2018-05-29 Thread Andres Betts
abetts added a comment. In D13202#270398 , @sharvey wrote: > > The one visual improvement I could think of is adding a thin light gray outline around the circle to help separate it from the background. This is done on the login and lock screens;

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

2018-05-29 Thread Andres Betts
abetts added a comment. Could a different approach work here? No change on hover, but just on click? The user controls the entire action. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13192 To: hein, ngraham, davidedmundson, rkflx, cfeck Cc: abetts, zzag, p

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

2018-05-29 Thread Andres Betts
abetts added a comment. In D13192#270492 , @ngraham wrote: > If we removed the hover interactivity, I would want to see the buttons' appearance become distinctly more button-like or tab-like so that people can figure out that they're clickable.

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

2018-05-29 Thread Andres Betts
abetts added a comment. In D13192#270517 , @ngraham wrote: > While that's true, it would represent a significant change to the interaction pattern. I'm not totally against it, but I think we should try out the triangle filter here first and see

D13202: Circular user avatar for Kickoff

2018-05-29 Thread Andres Betts
abetts added a comment. In D13202#270528 , @sharvey wrote: > AA option not set > F5875999: Screenshot_20180529_131810.png > > AA option set > F5876003: Screenshot_20180529_155151.png

D13202: Circular user avatar for Kickoff

2018-05-29 Thread Andres Betts
abetts added a comment. In D13202#270530 , @sharvey wrote: > In D13202#270529 , @abetts wrote: > > > It doesn't look any different to me. They are both the same. Maybe the screenshot is too small? I

D13278: Keep default border value in line with KWin's setting

2018-06-01 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R31 Breeze BRANCH match-new-kwin-default-border-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D13278 To: ngraham, #breeze, abetts Cc: abetts,

D13334: When using a different background color, use highlightedText as text color

2018-06-04 Thread Andres Betts
abetts added a comment. Looks great! I don't have any suggestions. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D13334 To: apol, #kirigami, mart, ngraham Cc: abetts, colomar, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13141: Touchpad KCM Redesign Using Kirigami

2018-06-04 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham, romangg, abetts Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Andres Betts
abetts added a comment. +1 I feel this is a must. We are trying to convey that the user needs to enable Bluetooth in order to make it work. There is real issue there. In fact, could we maybe change the color message from RED to something more informational? REPOSITORY R97 Bluedevil R

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Andres Betts
abetts added a comment. In D13346#274427 , @ngraham wrote: > Red is for errors, orange is for warnings, and blue is for information. The red is not as harsh as it used to be, but do you think orange would be a more appropriate color? I t

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Andres Betts
abetts added a comment. In D13346#274450 , @emateli wrote: > > In D13346#274446 , @abetts wrote: > > Could we have a button that enables/disables bluetooth instead? We can show the warning message on

D13390: Fonts KCM: Fix text readability regression

2018-06-08 Thread Andres Betts
abetts added a comment. Maybe this is for another ticket, but... can we make the field where the font is named the actual field where you select the fonts from? F5898561: InkedSpectacle.S22260_LI.jpg I mean, why have so many controls when the fi

D12278: WIP: [Colors KCM] Port to new design

2018-06-14 Thread Andres Betts
abetts added a comment. Ping? Is this KCM doing alright? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D13481: Recommend window border size "None"

2018-06-18 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: abetts, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

2018-06-18 Thread Andres Betts
abetts added a comment. In D13593#279642 , @nicolasfella wrote: > Sometimes it's better to be precise about well-known technical terms instead of hiding them. Would a person who does not know what anti-aliasing is want/need to change that setti

D13481: Recommend window border size "None"

2018-06-25 Thread Andres Betts
abetts added a comment. In D13481#282788 , @graesslin wrote: > In D13481#282653 , @mart wrote: > > > In D13481#280767 , @romangg wrote: > > > > > What

D11198: [libbreezecommon] Add box shadow helper

2018-06-30 Thread Andres Betts
abetts added a comment. I thought this was accepted and ready to go. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D13745: Implement support for virtual desktops on Wayland

2018-07-03 Thread Andres Betts
abetts added a comment. The dev team has been in talks with the VDG about this change. We are OK with the change. We understand that before we make any visual changes, we need to, at least, provide the same functionality that we have in X11 to what we want to have in Wayland. The VDG is curr

D10083: [Look and Feel] Reverse the button order

2018-07-11 Thread Andres Betts
abetts added a comment. Not sure it is redundant but it should follow what the mockups in pholio are saying. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: abetts, davidedmundson, plasma-devel, ragreen, Pit

D14145: Show a vertical menu for the panel widget options pop-up

2018-07-16 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14145 To: ngraham, #plasma Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14238: Polish Notifier Plasmoid's UI

2018-07-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14238 To: ngraham, apol, #discover_software_store, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Andres Betts
abetts added a comment. Can you share the svg file for this icon please? I would like to edit it a little bit REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmundson Cc: abetts, Zren, plasma-devel, ragreen,

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Andres Betts
abetts added a comment. In D14105#296525 , @ngraham wrote: > It's the `edit-clear-history` icon in the `breeze-icons` repo. Can you help me find that repo please? I have no clue how to get there. REPOSITORY R120 Plasma Workspace REVISI

D14325: Remove Advanced section from screen config

2018-07-24 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14326: Fix layout of resolution selection

2018-07-24 Thread Andres Betts
abetts added a comment. +1 on the visual changes! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: abetts, ngraham, broulik, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14326: Fix layout of resolution selection

2018-07-24 Thread Andres Betts
abetts added a comment. In D14326#296853 , @gladhorn wrote: > F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png F6134417: kcm_resolution_before.png

D14326: Fix layout of resolution selection

2018-07-24 Thread Andres Betts
abetts added a comment. In D14326#297020 , @gladhorn wrote: > In D14326#297016 , @abetts wrote: > > > In D14326#296853 , @gladhorn wrote: > > > > > F613

D14339: Remove confusing icons from rotation combobox

2018-07-24 Thread Andres Betts
abetts added a comment. In D14339#297211 , @ngraham wrote: > Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated. > > With no

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-26 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14347 To: ngraham, #plasma, davidedmundson, broulik Cc: abetts, broulik, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14339: Change rotation icons to be a rotated preview icon

2018-07-26 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham, romangg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14581: support for multilevel kcms

2018-08-08 Thread Andres Betts
abetts added a comment. Looking great! REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D14581 To: mart, #plasma, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14737: Move "update" button from the left side to the right side in NIC module

2018-08-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14737 To: schampailler, ngraham Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Andres Betts
abetts added a comment. In D14830#308870 , @davidedmundson wrote: > > about how having this option is stupid and doesn't fit in here and bla bla that always emerges when this entry is proposed or talked about. > > Being off by default does n

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Andres Betts
abetts added a comment. In D14830#309263 , @davidedmundson wrote: > > This could be good whenever we have situations where the desktop locks > > If the desktop locks then the one thing you can't do is right click on the desktop Odd

D14855: Add applet with screen layouts and presentation mode

2018-08-15 Thread Andres Betts
abetts added a comment. On the first string I would change the wording: "Configurations become enabled when another screen is connected" The second string could read: "It will prevent the screen from turning off" (automatically = optional) REPOSITORY R104 KScreen REVISION DET

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Andres Betts
abetts added a comment. I like the way this looks, I would like to push it further for clarity and ask for window title at 13 and bold. I feel people stand to benefit from seeing a window title that is readable, especially when we have a dark color background default. REPOSITORY R119 Plas

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Andres Betts
abetts added a comment. In D14869#309824 , @ngraham wrote: > In D14869#309821 , @abetts wrote: > > > I like the way this looks, I would like to push it further for clarity and ask for window title at

D14857: Label job notifications with destination file name

2018-08-16 Thread Andres Betts
abetts accepted this revision. abetts added a comment. +1 REVISION DETAIL https://phabricator.kde.org/D14857 To: karthikp, #vdg, ngraham, abetts Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Andres Betts
abetts added a comment. This makes good sense in that admin world, more business style. I think they would appreciate it. I would probably look for a string that is a little shorter. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14905 To: broulik, #plasm

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-20 Thread Andres Betts
abetts added a comment. In D14869#312156 , @ngraham wrote: > Apparently people are passionate about font sizes. :) > > after reading everyone's comments here, it seems like this will probably not work on its own, but has usefully exposed a nu

D14855: Add applet with screen layouts and presentation mode

2018-08-20 Thread Andres Betts
abetts added a comment. In D14855#312321 , @ngraham wrote: > Instead of: > > Presentation mode > This will prevent your screen and computer from turning off automatically >[] Enable Presentation Mode > > > I would prefer to g

D14855: Add applet with screen layouts and presentation mode

2018-08-22 Thread Andres Betts
abetts added a comment. Love! Love! <3 Thanks for working on it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, le

D15011: [Kickoff] Make the search field always look like a search field

2018-08-22 Thread Andres Betts
abetts added a comment. I like this idea REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson Cc: abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D15011: [Kickoff] Make the search field always look like a search field

2018-08-23 Thread Andres Betts
abetts accepted this revision. abetts added a comment. I like this idea, it is easier to discover. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, fil

D15024: Update icons kcm docbook to 5.13

2018-08-23 Thread Andres Betts
abetts added a comment. I am hoping there is also a way for people to be able to see more information about the theme in GHNS. Is there a visual way that we can do this? Maybe do the layout the same as it was before BUT where the preview image used to be, have the new gallery item look? REP

D15011: [Kickoff] Make the search field always look like a search field

2018-08-23 Thread Andres Betts
abetts added a comment. In D15011#314154 , @filipf wrote: > Yeah Nate, but if you look at your responses they're predominantly on a much higher level of abstraction (e.g "next step", "change is scary") than the issues raised. That's why for me t

D15011: [Kickoff] Make the search field always look like a search field

2018-08-23 Thread Andres Betts
abetts added a comment. In D15011#314181 , @davidedmundson wrote: > > @davidedmundson, does this look okay now? > > Code wise, yes. > > UI/Concept wide, I don't want to have an opinion either way Thanks Dave REPOSITORY R119 Pla

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Andres Betts
abetts added a comment. Maybe something I can explain, for us designers, is that we have a set of defined rules and guidelines for visual design on KDE and we should strive to first search for an option that is adapted or allowed by these guidelines. If that doesn't work, we could propose ot

D15011: [Kickoff] Make the search field always look like a search field

2018-08-26 Thread Andres Betts
abetts added a comment. I really like the last suggestion from Filip. It blends well with the theme. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: rooty, sharvey, romangg, broulik, safaalfulaij, oy

D15011: [Kickoff] Make the search field always look like a search field

2018-08-26 Thread Andres Betts
abetts added a comment. > However, regardless of what we choose, I would like to move towards unifying the interfaces in the above table, because inconsistency in something basic like this is not good. So if we decide to make search fields that have keyboard focus by default not visibly focu

D15011: [Kickoff] Make the search field always look like a search field

2018-08-26 Thread Andres Betts
abetts added a comment. In D15011#315863 , @ngraham wrote: > In D15011#315816 , @abetts wrote: > > > I agree that our HIG needs to explain focus better. It doesn't really have to be a long HIG about

D15011: [Kickoff] Make the search field always look like a search field

2018-08-27 Thread Andres Betts
abetts added a comment. Yay! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: fabianr, huftis, rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, michaeltunnell

D15101: [Widget Explorer] always show the search field

2018-08-27 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15101 To: ngraham, #plasma, sharvey, #vdg Cc: abetts, sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15101: [Widget Explorer] always show the search field

2018-08-27 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. Approved depending on the code review. REPOSITORY R119 Plasma Desktop BRANCH widget-explorer-always-shows-search-field (branched from master) REVISION DETAIL https://phabricator.kde.

D15121: Kirigami ages are required for kcms

2018-08-28 Thread Andres Betts
abetts added a comment. I prefer "allows you to configure" REPOSITORY R115 Plasma Audio Volume Applet BRANCH mart/newkcm REVISION DETAIL https://phabricator.kde.org/D15121 To: mart, #plasma, davidedmundson Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, le

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. Could you please put a video or gif that shows the effect? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: abetts, davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, les

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. In D14988#316633 , @phuongn wrote: > Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapp

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. In D14988#316672 , @ngraham wrote: > I think the terminology "wraps around" is fine. Seems pretty clear to me. Cool, let's go with that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

2018-08-29 Thread Andres Betts
abetts added a comment. Just a nitpick: Since we have a checkbox and then a label, can the label also have the word "Enable". We have transitioned into making actionable checkboxes to start their label with an active verb. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D13481: Recommend window border size "None"

2018-08-29 Thread Andres Betts
abetts added a comment. I think we were able to identify the issues, even the ones pointed out in the discussions earlier in this ticket. I feel that we have a path forward. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: pedrogome

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

2018-08-31 Thread Andres Betts
abetts added a comment. I like that string better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14989 To: phuongn, #plasma Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-04 Thread Andres Betts
abetts added a comment. What would this look like? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15233 To: underwit, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-09-04 Thread Andres Betts
abetts added a comment. In D15206#320116 , @mmustac wrote: > Personally I like it more without the separators but except of that the top-margin of the first element seems to be only 6px while the margin to the underneath elements is about 12px.

D15233: Add a tooltip for the appentry in the kicker

2018-09-05 Thread Andres Betts
abetts added a comment. In D15233#320616 , @underwit wrote: > Screenshot with tooltip > F6236529: Screenshot_20180905_105259.png > > For tooltip i use "comment", "genericname" or "name" from .desktop

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

<    1   2   3   4   >