D28461: In sidebar mode show if a module is in default state or not

GB_2 added a comment. In D28461#640439 , @The-Feren-OS-Dev wrote: > How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed,

D28842: Raise size of default fixed-width font from 9 to 10pt

GB_2 added a comment. Thanks for this :-) REPOSITORY R119 Plasma Desktop BRANCH even-bigger-hack (branched from master) REVISION DETAIL https://phabricator.kde.org/D28842 To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis Cc: GB_2, plasma-devel, Orage, LeGast00n, The-Fe

D28744: Rewrite of the global shortcuts kcm

GB_2 added a comment. Nitpick: put the "Add Application..." button on the left (T10384 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28744 To: davidre, #vdg, #plasma Cc: GB_2, broulik, davidedmundson, nicolasfella, ngr

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

GB_2 added a comment. Do we still want to ship the old Breeze Classic with Plasma or do we put it in `kde-vdg-extras`? I think there are quite a few people who like the mix of dark header and light content. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29439 To: nd

D29709: Give all OverlaySheets consistent headers

GB_2 added inline comments. INLINE COMMENTS > UpdatesPage.qml:39 > id: sheet > +header: Kirigami.Heading { text: i18n("Update issue") } > + "Update Issue" REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol, #discov

D17321: Change toolbox icon from from a hamburger icon to a configure icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Changes the desktop/panel toolbox icon from a hamburger icon to a configure icon (as suggested in th

D17321: Change toolbox icon from from a hamburger icon to a configure icon

GB_2 added a comment. In D17321#370322 , @ngraham wrote: > For the panel edit mode button, I think this is 100% appropriate since it opens a configuration UI. For the toolbox, I'm not as convinced yet, since clicking on it opens a menu with a nu

D17321: Change toolbox icon from from a hamburger icon to a configure icon

GB_2 updated this revision to Diff 46739. GB_2 edited the summary of this revision. GB_2 added a comment. Only change panel toolbox icon. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17321?vs=46736&id=46739 REVISION DETAIL https://phabricator.kd

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Modifies the screen edge button and panel size button in the panel edit mode to make them easier to

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. In D17323#370396 , @trickyricky26 wrote: > This is awesome, thank you! > > If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. In D17323#370402 , @ngraham wrote: > Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p Yeah :P REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. In D17323#370411 , @matheusm wrote: > +1, but why aren't the buttons content centered? They are, do you think that because of the screenshot? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kd

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46749. GB_2 edited the summary of this revision. GB_2 added a comment. Update panel size button icons. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46741&id=46749 REVISION DETAIL https://phabricator.kd

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Oh, you mean the button content... I will try to fix that! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Hmm... when a button has an icon the content gets aligned on the left and I can't find a way to change it... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. I managed to fix it, but it the Plasma QML Button code needs to be changed. Should I create a new Phabricator revision or add it here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, t

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Waiting for https://phabricator.kde.org/D17355 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozb

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Because https://phabricator.kde.org/D17355 is currently not working properly, we have two options: 1. Small "Height/Width" button F6458263: Panel Edit Mode Buttons (1).png 2. Align "Height/Width" button contents on th

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Ok, number two then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46971. GB_2 added a comment. Added the tooltip. F6459564: Panel Edit Mode Buttons (3).png It is ready now! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46749&id

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46972. GB_2 added a comment. Use QQC2 tooltip. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46971&id=46972 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES desktoppackage/contents/c

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Oops, forgot the import... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, n

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46973. GB_2 added a comment. Add import. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46972&id=46973 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES desktoppackage/contents/configu

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47010. GB_2 added a comment. Improve code and add tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46973&id=47010 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES deskt

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47011. GB_2 added a comment. Increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47010&id=47011 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES desktoppackage/co

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47033. GB_2 added a comment. Add tooltip for the resize button, change tooltip text and increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47011&id=47033 REVISION DETAIL https://ph

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47038. GB_2 added a comment. Improve wording. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47033&id=47038 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES desktoppackage/contents/co

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47041. GB_2 added a comment. Fix text color. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47038&id=47041 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES desktoppackage/contents/con

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47045. GB_2 added a comment. Fix tooltip text color (for real this time). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47041&id=47045 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY There is a configure button and an alternatives button in the context menu of an applet, but there i

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 updated this revision to Diff 47054. GB_2 added a comment. Update TODO text. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=47051&id=47054 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/conten

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 added a comment. In D17323#372752 , @Codezela wrote: > when resizing the panel can we show the width of it > 48px ,36px etc > because now when I resize the panel I guess what better visually > but if I know the size exactly It will m

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 added a comment. It's okay :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg, ngraham Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, cro

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47058. GB_2 added a comment. Hide the tooltip if you click on it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47045&id=47058 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES deskto

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#373036 , @ngraham wrote: > Neat, it seems to generally work well. I notice that when I click the new menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we could make it not do that, so it

D17440: Rotate busy indicator clockwise

GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. GB_2 added projects: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Most loading/refresh icons have a circular arrow pointing clockwise,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: davidedmundson, ngraham, nda

D17574: Remove period ( . ) character from the end

GB_2 added a comment. The two images need to be swapped. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17574 To: shubham, #plasma, #vdg, mart Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis, Z

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

GB_2 requested review of this revision. GB_2 added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:58 > This doesn't make sense.. > > We're re-evaulating because hasElement might have changed when switching > themes. So just remove the line? REPOSITORY R119 Plasma Deskto

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#374062 , @davidedmundson wrote: > > I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work... > > Use console.log to check your code is bein

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

GB_2 updated this revision to Diff 47615. GB_2 added a comment. Remove unneeded line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17321?vs=46739&id=47615 REVISION DETAIL https://phabricator.kde.org/D17321 AFFECTED FILES toolboxes/paneltoolbo

D17622: [Panel Edit Mode] Show screen edge button and panel size button tooltips immediately after click

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This sets the delay of the tooltips added in D17323 to 0, so th

D12278: WIP: [Colors KCM] Port to new design

GB_2 added a comment. > This removes the "Apply to non-Qt applications checkbox" which isn't something one should uncheck. I disagree. I even think it should be disabled by default, because it causes issues in GTK 2 apps such as this: https://i.stack.imgur.com/jpeYm.jpg I think it is n

D17935: [Clipboard] Use ellipsis in the search field label ('Search...' instead of 'Search')

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d066eb8cbd85: [Clipboard] Use ellipsis in the search field label ('Search...' instead of… (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R120 Plasma Workspace CHANGE

D17934: [Kickoff] Increase Kickoff information label readability

GB_2 added a comment. In D17934#386050 , @ngraham wrote: > The opacity change makes sense to me: since this text isn't visible by default, there's no reason to make it difficult to read with a low opacity. If you go hunting for it and want to se

D17934: [Kickoff] Increase Kickoff information label readability

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Looks better now! REPOSITORY R119 Plasma Desktop BRANCH centered-infolabel (branched from master) REVISION DETAIL https://phabricator.kde.org/D17934 To: rooty, ngraham, #vdg, #plasma, G

D17934: [Kickoff] Increase Kickoff information label readability

This revision was automatically updated to reflect the committed changes. Closed by commit R119:510c88f65b76: [Kickoff] Increase Kickoff information label readability (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This adds an icon to the "Edit Applications..." menu entry to make it look better. F6525011: Edit Ap

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f29c04572c06: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

GB_2 added a comment. In D17963#386701 , @ngraham wrote: > Hmm, this results in the menu having one colored icon and two monochrome icons. > > My gut feeling is that if we're going to use KMenuEdit's icon, perhaps we should mention it by nam

D18012: [SDDM theme] Update the theme preview

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. +1, updated and looks much better REPOSITORY R120 Plasma Workspace BRANCH new-sddm-preview (branched from master) REVISION DETAIL https://phabricator.kde.org/D18012 To: filipf, #plasma,

D18012: [SDDM theme] Update the theme preview

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a3bbdef02ad8: [SDDM theme] Update the theme preview (authored by filipf, committed by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18012?vs=48796&

D18016: Don't use hardcoded background color

GB_2 created this revision. GB_2 added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Fixes the hardcoded SDDM theme preview background color F6530004: SDDM KCM Breeze.png

D18005: Include only the largest size for each wallpaper

GB_2 added a comment. @cfeck had a good idea: In D18005#387519 , @cfeck wrote: > Maybe symlinking all to the largest version? REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL http

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

This revision was automatically updated to reflect the committed changes. Closed by commit R126:d8069f6fcbde: [kde-cli-tools] Add search ellipsis to label, make label more consistent with… (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R126 KDE CLI Utilities CH

D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c52d93976e60: [plasma-desktop] Add search ellipsis to Font Management and Date and Time (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SI

D18048: [Connections] Add search ellipsis to network connection search

This revision was automatically updated to reflect the committed changes. Closed by commit R116:9c7de905eab3: [Connections] Add search ellipsis to network connection search (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R116 Plasma Network Management Applet CHA

D18206: Improve the Look and Feel KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes that and make

D18206: Improve the Look and Feel KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:beca304a1f44: Improve the Look and Feel KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18206?vs=49321&id=49374 REVISION DETAIL htt

D18247: Improve Desktop/Plasma Theme KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Similar to D18206 . The Desktop/Plasma Theme KCM has some inconsi

D18247: Improve Desktop/Plasma Theme KCM

GB_2 added a comment. In D18247#393021 , @davidedmundson wrote: > > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and > > Where? > > > renames

D18247: Improve Desktop/Plasma Theme KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2015bad98e64: Improve Desktop/Plasma Theme KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18247?vs=49453&id=49461 REVISION DETAIL

D18267: Improve the Cursor Theme KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The Cursor Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it a

D18267: Improve the Cursor Theme KCM

GB_2 added a comment. In D18267#393604 , @davidedmundson wrote: > Try to stick to titles that aren't "improve" as that literally covers every patch (or at least, you'd hope so) Ok, there is one more patch that I will make with this name

D18267: Improve the Cursor Theme KCM

GB_2 added a comment. In D18267#393635 , @ngraham wrote: > In D18267#393620 , @davidedmundson wrote: > > > > In the tooltip and header on the page > > > > > > > > > In the description of the

D18267: Improve the Cursor Theme KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e0a4d3fa415d: Improve the Cursor Theme KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18267?vs=49536&id=49540 REVISION DETAIL http

D18269: Improve the Splash Screen KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Similar to D18206 . The Splash Screen KCM has some inconsistencie

D18269: Improve the Splash Screen KCM

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in kcm_splashscreen.desktop:2 > I know you're making this change because we don't actually have a > `preferences-system-splash` icon, but is this really semantically correct? It > seems like we should actually create that icon, or mayb

D18269: Improve the Splash Screen KCM

GB_2 added inline comments. INLINE COMMENTS > GB_2 wrote in kcm_splashscreen.desktop:2 > Yes, I just used it because I think it should be included in Plasma 5.15 and > it is the closest to a login splash icon I could find. BTW, the Plymouth Splash KCM just uses an empty screen icon. REPOSITORY

D18269: Improve the Splash Screen KCM

GB_2 updated this revision to Diff 49544. GB_2 added a comment. Use old icon `preferences-system-splash` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18269?vs=49541&id=49544 BRANCH improve-splashscreen-kcm (branched from master) REVISION DETAIL

D18269: Improve the Splash Screen KCM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd94db08a555: Improve the Splash Screen KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST U

D18269: Improve the Splash Screen KCM

GB_2 added a comment. In D18269#393711 , @ngraham wrote: > In general, you should wait until all reviewers with an open "Changes Requested" status have changed it to "Accepted" before landing a patch. Ok, sorry. REPOSITORY R119 Plasma

D18381: Add tooltip to configure panel button

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds a tooltip to the configure panel button. F6556503: Configure Panel Tooltip.png

D18381: Add tooltip to configure panel button

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a08f3d135c5: Add tooltip to configure panel button (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18381?vs=49870&id=49918 REVISION DETA

D12278: [Colors KCM] Port to new design

GB_2 added inline comments. INLINE COMMENTS > colors.cpp:58 > + > +KAboutData *about = new KAboutData(QStringLiteral("kcm_colors"), > i18n("Configure color schemes"), > + QStringLiteral("2.0"), QString(), > KAboutLicense::GPL); Better: "Choose the colo

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

GB_2 added a comment. Next time please upload images directly to Phabricator. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreute

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

GB_2 added a comment. Thanks! Looks good! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apo

D18528: [Desktop Toolbox] Use a clearer name when the label is shown

GB_2 added a comment. Looks good! INLINE COMMENTS > ToolBoxButton.qml:30 > > -property string text: main.Plasmoid.activityName > +property string text: main.Plasmoid.activityName == i18n("Default") ? > i18n("Desktop Toolbox") : i18n("Desktop Toolbox - %1 Activity", > main.Plasmoid

D18546: [Desktop Toolbox] Use "tools" icon

GB_2 added a comment. In D18546#400253 , @hein wrote: > How about we actually rename it "Desktop Menu". +1, good idea! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18546 To: ngraham, #vdg, #plasma Cc:

D18559: Use correct sidebar back button press color

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The system settings currently use a wrong sidebar back button press color, which can look very bad on

D18561: Use same intro page system settings icon as in the desktop file

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the same system settings icon in the intro page that is used in the desktop file for consistency a

D18561: Use same intro page system settings icon as in the desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R124:d5740e73d070: Use same intro page system settings icon as in the desktop file (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18561?vs=50

D18559: Use correct sidebar back button press color

This revision was automatically updated to reflect the committed changes. Closed by commit R124:cad722aa0fa0: Use correct sidebar back button press color (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18559?vs=50363&id=50651 REVISI

D18677: Change workspace theme category icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use a proper workspace theme icon for the workspace theme category. F6583141: Workspace Theme Categor

D18677: Change workspace theme category icon

This revision was automatically updated to reflect the committed changes. Closed by commit R124:4ef5a0b01421: Change workspace theme category icon (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18677?vs=50726&id=50728 REVISION DETA

D18681: Update Breeze Look and Feel theme previews

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Update and improve some old Breeze Look and Feel theme previews (the Breeze Dark previews will be upda

D18682: Update Breeze Dark Look and Feel theme previews

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Update and improve some old Breeze Dark Look and Feel theme previews (similar to D18681

D18681: Update Breeze Look and Feel theme previews

GB_2 added a comment. In D18681#404092 , @abetts wrote: > Maybe I am asking for a lot... but could these be animated and show what the splash screen does? Maybe a gif animation on hover? There's already the preview button that shows the s

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. I think we should really move the LnF KCM to the top level now since it affects everything. Doing that is safe IMO. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davide

D18681: Update Breeze Look and Feel theme previews

GB_2 updated this revision to Diff 50761. GB_2 added a comment. Improve Look and Feel theme previews REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18681?vs=50737&id=50761 BRANCH update-breeze-lookandfeel-theme-previews (branched from master) R

D18682: Update Breeze Dark Look and Feel theme previews

GB_2 updated this revision to Diff 50762. GB_2 added a comment. Improve Look and Feel theme previews REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18682?vs=50738&id=50762 BRANCH update-breezedark-lookandfeel-theme-previews (branched from master) REVISION

D18681: Update Breeze Look and Feel theme previews

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ba642873f40f: Update Breeze Look and Feel theme previews (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18681?vs=50761&id=50765 REVISI

D18682: Update Breeze Dark Look and Feel theme previews

This revision was automatically updated to reflect the committed changes. Closed by commit R31:2750e07e4e00: Update Breeze Dark Look and Feel theme previews (authored by GB_2). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18682?vs=50762&id=50766 REVISION DETA

D18785: Use different Font Management KCM "All Fonts" icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Needed for D18702 . F6591513: New Font Management All Fonts Icon.

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

GB_2 added a comment. In D18797#407129 , @ngraham wrote: > So if this isn't an acceptable solution, then what we need to do is remove all the 22px monochrome versions of icons that have colorful 32px-and-larger versions. What I proposed

D18785: Use different Font Management KCM "All Fonts" icon

GB_2 updated this revision to Diff 51115. GB_2 added a comment. Use new icon "font" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18785?vs=51032&id=51115 BRANCH use-different-font-management-all-fonts-icon (branched from master) REVISION DETAIL

D18785: Use different Font Management KCM "All Fonts" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e5ef9c97e75e: Use different Font Management KCM "All Fonts" icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18785?vs=51115&id=51162

D18861: Improve the Fonts KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, adding icons and tooltips to b

D18861: Improve the Fonts KCM UI

GB_2 updated this revision to Diff 51213. GB_2 added a comment. Change "Force fonts DPI" checkbox text to "Force font DPI" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18861?vs=51211&id=51213 BRANCH master REVISION DETAIL https://phabricator.

  1   2   3   4   5   6   7   >