It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Signed-off-by: Wolfgang Link
---
PVE/Storage.pm | 4 ++--
PVE/Storage/ISCSIDirectPlugin.pm | 2 +-
PVE/Storage/LVMPlugin.pm | 2 +-
PV
Hi all@list,
I'm think we should check if we make snapshots not at the Storage.
IMHO it should be done at the QemuServer.
Is there any matter to kept it?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listi
It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Signed-off-by: Wolfgang Link
---
PVE/QemuServer.pm | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b
> # Note about locking: we use flock on the config file protect
> @@ -3777,7 +3779,7 @@ sub qemu_volume_snapshot {
>
> my $running = check_running($vmid);
>
> -return if !PVE::Storage::volume_snapshot($storecfg, $volid, $snap,
> $running);
> +PVE::Storage::volume_snapshot($storec
---
www/manager5/Readme.md | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 www/manager5/Readme.md
diff --git a/www/manager5/Readme.md b/www/manager5/Readme.md
new file mode 100644
index 000..87e00c3
--- /dev/null
+++ b/www/manager5/Readme.md
@@ -0,0 +1,22 @@
Hi,
does it make sense to define
+my $snap_storage = {zfspool => 1, rbd => 1, zfs => 1, sheepdog => 1};
..
sub storage_support_snapshot()
in qemuserver ?
Couldn't we reuse volume_has_feature from storage plugins ?
- Mail original -
De: "Wolfgang Link"
À: "pve-devel"
Envoyé: Je
Also,
+ PVE::Storage::volume_snapshot($storecfg, $volid, $snap) if
storage_support_snapshop($volid, $storecfg);
This seem to be wrong.
we can't do a qcow2 snapshot with qemu-img if the vm is running, we need to use
qmp in this case.
- Mail original -
De: "Wolfgang Link"
À: "pve-de
> Couldn't we reuse volume_has_feature from storage plugins ?
We can, but this is misleading. It is not a storage feature, it
is a feature of qemu.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve
> + PVE::Storage::volume_snapshot($storecfg, $volid, $snap) if
> storage_support_snapshop($volid, $storecfg);
>
> This seem to be wrong.
>
> we can't do a qcow2 snapshot with qemu-img if the vm is running, we need to
> use qmp in this case.
Form what I see this case is already handled inside st
>>Form what I see this case is already handled inside
>>storage_support_snapshop()?
PVE::Storage::volume_snapshot($storecfg, $volid, $snap) if
storage_support_snapshop($volid, $storecfg);
return if !$running;
vm_mon_cmd($vmid, "snapshot-drive", device => $deviceid, name => $snap);
and
sto
> So, with this code, we always call qemu-img snasphot for qcow2, which is wrong
> if the vm is running.
> (for rbd,zfs,.. no problem).
>
> I think that's why we passed the running flag to pve-storage.
Ah, yes - the logic is wrong, but fixable.
___
pve
> > So, with this code, we always call qemu-img snasphot for qcow2, which is
> > wrong
> > if the vm is running.
> > (for rbd,zfs,.. no problem).
> >
> > I think that's why we passed the running flag to pve-storage.
>
> Ah, yes - the logic is wrong, but fixable.
Or is it the other way around? We
>>We need to use qemu "snapshot-drive" if the VM is running?
For qcow2 file yes.
found some reference here:
https://www.suse.com/documentation/sles11/book_kvm/data/cha_qemu_guest_inst_qemu-img.html
"
WARNING: Do not create or delete virtual machine snapshots with the qemu-img
snapshot command w
dpkg -i lxc-pve-dev_1.1.1-1_amd64.deb
Setting up lxc-pve (1.1.1-1) ...
usermod: invalid option -- 'v'
It's hanging in lxc-pve.postinst
# create subuid/subgui map for root
# (to run unprivileged containers as root)
usermod -v 10-165535 -w 10-165535 root
#usermo
Seem that passwd was not updated to jessie.
Works fine now
- Mail original -
De: "aderumier"
À: "pve-devel"
Envoyé: Jeudi 30 Avril 2015 15:01:28
Objet: [pve-devel] trying to install lxc-pve, usermod error in
lxc-pve.postinst
dpkg -i lxc-pve-dev_1.1.1-1_amd64.deb
Setting up lxc-pve
> #usermod -v 10-165535 -w 10-165535 root
> usermod: invalid option -- 'v'
Old system? This package is targeted for debian jessie.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>Old system? This package is targeted for debian jessie.
Yes, (it was the upgraded wheezy, seem that passwd was not upgraded correctly)
(about upgrade, we need also to install
apt-get install systemd-sysv
to get systemd working after reboot)
- Mail original -
De: "dietmar"
À: "ader
BTW,
do you plan to update jessie pvetest repo soon ?
I would like to test upgrade from wheezy with new packages version and lxc
- Mail original -
De: "aderumier"
À: "dietmar"
Cc: "pve-devel"
Envoyé: Jeudi 30 Avril 2015 17:17:26
Objet: Re: [pve-devel] trying to install lxc-pve, userm
> (about upgrade, we need also to install
>
> apt-get install systemd-sysv
>
> to get systemd working after reboot)
Ah, OK.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> do you plan to update jessie pvetest repo soon ?
>
> I would like to test upgrade from wheezy with new packages version and lxc
Yes, I can update if you want.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailma
> > do you plan to update jessie pvetest repo soon ?
> >
> > I would like to test upgrade from wheezy with new packages version and lxc
>
> Yes, I can update if you want.
OK, the repository is up to date now - please test.
___
pve-devel mailing list
p
hi,
I am currently testing with the latest release.
2 points:
- At the end of the update with pvetest, it propose to replace it with
pvetest pve - enterprise.
- A problem of installation dependencies ceph hammer :
The following packages have unmet dependencies:
ceph : Depends: libboost-system1.
> I am currently testing with the latest release.
you talk about pvetest for wheezy?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
pvetest for jessie
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> On April 30, 2015 at 8:09 PM Moula BADJI wrote:
>
>
> - A problem of installation dependencies ceph hammer :
There are still no ceph packages for jessie, sorry.
> One question: to make a new HA-PVE, a small howto ?
Sorry, there is currently no docu.
_
25 matches
Mail list logo
