[pve-devel] [PATCH manager 2/3] White and indentation fixes

2017-08-30 Thread Emmanuel Kasper
--- www/manager6/dc/Log.js | 4 ++-- www/manager6/dc/Tasks.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/dc/Log.js b/www/manager6/dc/Log.js index 4a47f18e..64178137 100644 --- a/www/manager6/dc/Log.js +++ b/www/manager6/dc/Log.js @@ -77,12 +77,12 @@ Ext

[pve-devel] [PATCH manager 1/3] Rewrite Log Panel and Task Panel with declarative synthax

2017-08-30 Thread Emmanuel Kasper
No functional changes --- www/manager6/dc/Log.js | 130 +++ www/manager6/dc/Tasks.js | 195 +++ 2 files changed, 161 insertions(+), 164 deletions(-) diff --git a/www/manager6/dc/Log.js b/www/manager6/dc/Log.js index 62370ec

Re: [pve-devel] [PATCH manager] pool: add member: use generic 'Virtual Guest' wording

2017-08-31 Thread Emmanuel Kasper
On 08/31/2017 09:47 AM, Thomas Lamprecht wrote: > --- > www/manager6/grid/PoolMembers.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/grid/PoolMembers.js > b/www/manager6/grid/PoolMembers.js > index 5d020f7b..8c7315f9 100644 > --- a/www/manager6/grid/

Re: [pve-devel] [PATCH manager] pending changes: switch to orange and anotate with '(pending)'

2017-08-31 Thread Emmanuel Kasper
On 08/31/2017 10:52 AM, Thomas Lamprecht wrote: > red is normally strongly associated with errors, put pending changes > are not errors. > Tus use proxmox orange, to not scare (new) users and annotate the > pending entry with '(pending)' to make it easier to see what > happens. > --- > www/manager

Re: [pve-devel] [PATCH manager v2 1/3] pool: add member: use generic wording for 'Guest'

2017-08-31 Thread Emmanuel Kasper
tested OK, and the serie looks good to me On 08/31/2017 02:25 PM, Thomas Lamprecht wrote: > --- > > changes v1 -> v2: > * use 'Guest' instead of 'Virtual Guest' > > www/manager6/grid/PoolMembers.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/grid/P

[pve-devel] Switching the scsi controller type in the Qemu Create VM Wizard

2017-09-05 Thread Emmanuel Kasper
Hi I would like to change the default scsi controller we use in the Wizard from virtio-scsi-pci, to virtio-scsi-single in a forthcoming path serie which touch the HD edition window. The difference between the two types is that with virtio-scsi-single each new disk is added on its own controller on

Re: [pve-devel] Switching the scsi controller type in the Qemu Create VM Wizard

2017-09-06 Thread Emmanuel Kasper
On 09/05/2017 05:48 PM, Dietmar Maurer wrote: >> This change would allow to select the iothread option on VM creation if >> the user wants that. > > I am quite unsure about that - this is usually just a waste of resources ... OK then I'll keep our current defaults.

[pve-devel] [PATCH manager 02/10] Move Wizard static properties to class body

2017-09-06 Thread Emmanuel Kasper
This allow those properties to be easily overriden in subclasses in a later step --- www/manager6/window/Wizard.js | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizard.js index 7ae58776..26c3ceaf 100644 ---

[pve-devel] [PATCH manager 08/10] Improve the display names of VirtIO-blk and VirtIO SCSI controllers

2017-09-06 Thread Emmanuel Kasper
SCSI is redundant in the VirtIO SCSI controller type. VirtIO-blk allows to better understand the different choices in the Combobox and is also the name used by Qemu upstream. --- www/manager6/Utils.js| 4 ++-- www/manager6/form/BusTypeSelector.js | 2 +- 2 files changed, 3 insertio

[pve-devel] [PATCH manager 05/10] Save the components we found via down() in a variable for later reuse.

2017-09-06 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 14ad574e..15023a7a 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/m

[pve-devel] [PATCH manager 06/10] Use the noVirtiIO ControllerSelector property to build the list of controllers

2017-09-06 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 15023a7a..5c6631b3 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/manager6

[pve-devel] [PATCH manager 00/10] Display the SCSI controller type when adding a new drive

2017-09-06 Thread Emmanuel Kasper
new combo box * 07 use the new combobox when adding a disk * 08-10 use the new combobox when adding a disk in the wizard Emmanuel Kasper (10): Do not change the SCSI controller type when iothread was selected Move Wizard static properties to class body Do not use 'autoselect' as

[pve-devel] [PATCH manager 07/10] Enhance BusStypeSelector with the SCSI controller description

2017-09-06 Thread Emmanuel Kasper
Since we started in PVE 4.3 to autoselect SCSI for new Linux VMs, it was not clear that this controller actually uses a pv virtio driver, which is confusing for users. See for example: https://forum.proxmox.com/threads/proxmox-hypervisor-scsi-or-virtio.36506/#post-179056 The vm configuration is o

[pve-devel] [PATCH manager 09/10] Make room in QemuWizard and Edit Window so that the larger combo boxes properly fit.

2017-09-06 Thread Emmanuel Kasper
This will benefit the BusTypeSelector, the DiskFormatSelector, the CD FileSelector, and possibily other long fields like vm name, pool name. --- www/manager6/form/ControllerSelector.js | 4 ++-- www/manager6/qemu/CDEdit.js | 3 +++ www/manager6/qemu/CreateWizard.js | 1 + www/ma

[pve-devel] [PATCH manager 04/10] Remove unused noScsi parameter

2017-09-06 Thread Emmanuel Kasper
SCSI is a valid bus for Disks and CD drives, so it should always be appear in the bus list. --- www/manager6/form/BusTypeSelector.js| 6 +- www/manager6/form/ControllerSelector.js | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/www/manager6/form/BusTypeSelector.

[pve-devel] [PATCH manager 01/10] Do not change the SCSI controller type when iothread was selected

2017-09-06 Thread Emmanuel Kasper
This was happening without giving the user feedback, and changes a value which should be set somewhere in the Options Panel. --- www/manager6/qemu/CreateWizard.js | 2 +- www/manager6/qemu/HDEdit.js | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/www/manager6/qemu/Cre

[pve-devel] [PATCH manager 10/10] Propagate the SCSI hw to the Hard Disk panel when selecting an OS

2017-09-06 Thread Emmanuel Kasper
--- www/manager6/qemu/OSTypeEdit.js | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js index 162a92ec..a779ab91 100644 --- a/www/manager6/qemu/OSTypeEdit.js +++ b/www/manager6/qemu/OSTypeEdit.js @@ -22,1

[pve-devel] [PATCH manager 03/10] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-06 Thread Emmanuel Kasper
The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect' to select a bus position when adding a CD Drive.

[pve-devel] [RFC PATCH common] Use double hyphens when prefixing command options in the documentation

2017-09-06 Thread Emmanuel Kasper
This makes our man pages follow the GNU long option recommandation where non-single character options are prefixed with a double hyphen. (https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html) The benefit for PVE is that our documentation looks more similar to what a user with pr

Re: [pve-devel] [RFC PATCH common] Use double hyphens when prefixing command options in the documentation

2017-09-06 Thread Emmanuel Kasper
please ignore, rebase error On 09/06/2017 02:24 PM, Emmanuel Kasper wrote: > This makes our man pages follow the GNU long option recommandation > where non-single character options are prefixed with a double hyphen. > (https://www.gnu.org/software/libc/manual/html_node/Argument-Sy

[pve-devel] [RFC PATCH v2 common] Use double hyphens when prefixing command options in the documentation

2017-09-06 Thread Emmanuel Kasper
This makes our man pages follow the GNU long option recommandations where non-single character options are prefixed with a double hyphen (https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html) The benefit for PVE is that our documentation looks more similar to what a user with pr

Re: [pve-devel] [PATCH qemu-server] Fix misleading error message when qmp fails to report a query-block-jobs

2017-09-07 Thread Emmanuel Kasper
any feedback on this ? cancelling an action because it has been cancelled it not such an helpful error message ;) On 08/02/2017 01:28 PM, Emmanuel Kasper wrote: > Currently when qmp fails to report a query-block-jobs, > we exit with the following log: > > drive-scsi0: transferred

Re: [pve-devel] [PATCH manager 3/3] Turn the offline/online checkbox of the Migrate Windows into a displayfield

2017-09-07 Thread Emmanuel Kasper
any feedback on this ? On 08/24/2017 11:45 AM, Emmanuel Kasper wrote: > This checkbox had not effect whatsoever: > * if the VM was online and offline was selected, the migration would fail > with the message that the --online flag is needed for running VMs > * if the the VM was

Re: [pve-devel] [PATCH manager 0/3] Turn the Online checkbox of the Migrate Window into a displayfield

2017-09-07 Thread Emmanuel Kasper
On 09/07/2017 11:39 AM, Dominik Csapak wrote: > On 08/24/2017 11:45 AM, Emmanuel Kasper wrote: >> This checkbox had no use, as checking/unchecking it would not be able >> to change the migration type. >> (see details in third patch). >> I also took the opportunity to r

Re: [pve-devel] [PATCH qemu-server] Fix misleading error message when qmp fails to report a query-block-jobs

2017-09-12 Thread Emmanuel Kasper
On 09/12/2017 02:30 PM, Wolfgang Bumiller wrote: > On Thu, Sep 07, 2017 at 10:00:07AM +0200, Emmanuel Kasper wrote: >> any feedback on this ? >> cancelling an action because it has been cancelled it not such an >> helpful error message ;) > > Wouldn't this resu

[pve-devel] [PATCH manager v2 00/10] Display the SCSI controller type when adding a new drive

2017-09-12 Thread Emmanuel Kasper
hen in the controller list NB: still open for better casing of VirtIO blk if anyone finds one ... I plan an update for the documentation after this serie is applied Emmanuel Kasper (10): Do not change the SCSI controller type when iothread was selected Move Wizard static properties to class body

[pve-devel] [PATCH manager v2 01/10] Do not change the SCSI controller type when iothread was selected

2017-09-12 Thread Emmanuel Kasper
This was happening without giving the user feedback, and changes a value which should be set somewhere in the Options Panel. --- www/manager6/qemu/CreateWizard.js | 2 +- www/manager6/qemu/HDEdit.js | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/www/manager6/qemu/Cre

[pve-devel] [PATCH manager v2 02/10] Move Wizard static properties to class body

2017-09-12 Thread Emmanuel Kasper
This allow those properties to be easily overriden in subclasses in a later step --- www/manager6/window/Wizard.js | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizard.js index 7ae58776..26c3ceaf 100644 ---

[pve-devel] [PATCH manager v2 03/10] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-12 Thread Emmanuel Kasper
The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect' to select a bus position when adding a CD Drive.

[pve-devel] [PATCH manager v2 08/10] Improve the display names of VirtIO blk and VirtIO SCSI controllers

2017-09-12 Thread Emmanuel Kasper
SCSI is redundant in the VirtIO SCSI controller type. VirtIO blk allows to better understand the different choices in the Combobox and is also the name used by Qemu upstream. --- www/manager6/Utils.js| 4 ++-- www/manager6/form/BusTypeSelector.js | 2 +- 2 files changed, 3 insertio

[pve-devel] [PATCH manager v2 06/10] Use the noVirtIO ControllerSelector property to build the list of controllers

2017-09-12 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 15023a7a..489b97de 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/manager6

[pve-devel] [PATCH manager v2 04/10] Remove unused noScsi parameter

2017-09-12 Thread Emmanuel Kasper
SCSI is a valid bus for Disks and CD drives, so it should always be appear in the bus list. --- www/manager6/form/BusTypeSelector.js| 6 +- www/manager6/form/ControllerSelector.js | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/www/manager6/form/BusTypeSelector.

[pve-devel] [PATCH manager v2 05/10] Save the components we found via down() in a variable for later reuse.

2017-09-12 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 14ad574e..15023a7a 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/m

[pve-devel] [PATCH manager v2 10/10] Propagate the SCSI hw to the Hard Disk panel when selecting an OS

2017-09-12 Thread Emmanuel Kasper
--- www/manager6/qemu/OSTypeEdit.js | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js index 162a92ec..a779ab91 100644 --- a/www/manager6/qemu/OSTypeEdit.js +++ b/www/manager6/qemu/OSTypeEdit.js @@ -22,1

[pve-devel] [PATCH manager v2 07/10] Enhance BusStypeSelector with the SCSI controller description

2017-09-12 Thread Emmanuel Kasper
Since we started in PVE 4.3 to autoselect SCSI for new Linux VMs, it was not clear that this controller actually uses a pv virtio driver, which is confusing for users. See for example: https://forum.proxmox.com/threads/proxmox-hypervisor-scsi-or-virtio.36506/#post-179056 The vm configuration is o

[pve-devel] [PATCH manager v2 09/10] Make room in QemuWizard and Edit Window so that the larger combo boxes properly fit

2017-09-12 Thread Emmanuel Kasper
This will benefit the BusTypeSelector, the DiskFormatSelector, the CD FileSelector, and possibily other long fields like vm name, pool name. --- www/manager6/form/ControllerSelector.js | 4 ++-- www/manager6/qemu/CDEdit.js | 3 +++ www/manager6/qemu/CreateWizard.js | 1 + www/ma

Re: [pve-devel] [PATCH manager v2 09/10] Make room in QemuWizard and Edit Window so that the larger combo boxes properly fit

2017-09-13 Thread Emmanuel Kasper
Q On 09/13/2017 07:09 AM, Thomas Lamprecht wrote: > On 09/12/2017 02:44 PM, Emmanuel Kasper wrote: >> This will benefit the BusTypeSelector, the DiskFormatSelector, the CD >> FileSelector, >> and possibily other long fields like vm name, pool name. >>

[pve-devel] [PATCH qemu-server v8 1/6] Force overwriting existing compressed man pages and symbolic links

2017-09-13 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index e9482f2..998d17a 100644 --- a/Makefile +++ b/Makefile @@ -69,12 +69,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [PATCH qemu-server v8 6/6] Add new qm command 'importovf', to create VMs from an OVF manifest

2017-09-13 Thread Emmanuel Kasper
Currently the following extracted parameters are used to create a VM: * VM name * Memory * Number of cores * Disks --- PVE/CLI/qm.pm | 99 +++ 1 file changed, 99 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 5dce10f..0a5571b

[pve-devel] [PATCH qemu-server v8 3/6] Initial support for importing OVF virtual machines

2017-09-13 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 236 2 files changed, 237 insertions(+) create mode 100644

[pve-devel] [PATCH qemu-server v8 0/6] Add qm importovf command

2017-09-13 Thread Emmanuel Kasper
bumping this after the topic has been brough in forum: https://forum.proxmox.com/threads/procedure-to-import-vmware-ova-to-proxmox-5-0-23-with-zfs-vm-store.36779/#post-180321 changes since V7: rebase on master Emmanuel Kasper (6): Force overwriting existing compressed man pages and symbolic

[pve-devel] [PATCH qemu-server v8 2/6] Add a build dependency to libxml-libxml-perl, needed for OVF parsing

2017-09-13 Thread Emmanuel Kasper
XML::LibXML is being actively developed, and has 91 reverse depencies in Debian Stretch, so it should not go away. --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index c2000e7..d5e4bb6 100644 --- a/debian/control +++ b/debian/control @@ -23,6

[pve-devel] [PATCH qemu-server v8 5/6] Refactor defaut bootdisk and smbios1 uuid generation in own subs

2017-09-13 Thread Emmanuel Kasper
This will allow code reuse for qm importovf --- PVE/API2/Qemu.pm | 20 PVE/QemuServer.pm | 20 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 1002c87..4173bdf 100644 --- a/PVE/API2/Qemu.pm +++ b/

[pve-devel] [PATCH qemu-server v8 4/6] Add tests for parse_ovf function

2017-09-13 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

Re: [pve-devel] [PATCH qemu-server v8 1/6] Force overwriting existing compressed man pages and symbolic links

2017-09-14 Thread Emmanuel Kasper
On 09/14/2017 08:09 AM, Thomas Lamprecht wrote: > On 09/13/2017 04:10 PM, Emmanuel Kasper wrote: >> This allows calling the 'make install' target twice in a row. > > Looks OK, we overwrite everything else so why not the man pages. > > This can be already a

[pve-devel] [PATCH qemu-server 1/1] do not overwrite global signal handlers

2017-09-14 Thread Emmanuel Kasper
perls 'local' must be either used in front of each $SIG{...} assignments or they must be put in a list, else it affects only the first variable and the rest are *not* in local context. In all cases the global signal handlers we overwrote were in cli programs or forked workers, not in daemons. ---

[pve-devel] [PATCH qemu-server 0/1] Do not overwrite global signal handlers, extra fix

2017-09-14 Thread Emmanuel Kasper
While poking around QemuServer.pm I noticed a couple of places where we were using 'local' in a wrong way like Thomas reported. After checking with grep in /usr/share/perl5/PVE, this should be now fixed everywhere. Emmanuel Kasper (1): do not overwrite global signal handlers PVE/AP

Re: [pve-devel] rfc : implementing a cloudinit metadata server

2017-09-20 Thread Emmanuel Kasper
On 08/30/2017 07:52 AM, Alexandre DERUMIER wrote: > Hi, > > the previous cloudinit patches used a cdrom for config drive. > > Wolfgang tell me that it could be great to get it work for lxc too. > > > So maybe we could try to implement a cloudinit metadataserver, with same api > than cloudstack

[pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

2017-09-21 Thread Emmanuel Kasper
Mainly to allow libguestfs and associated tools to work with our qemu binary. libguestfs tests at run timethe output of qemu -help and qemu -device ? to detect which features it can use, so it should not depend on which configure flags were used when compiling our qemu binary. --- debian/control

[pve-devel] [PATCH RFC qemu-kvm 0/1] Provides a qemu-system-x86 virtual package

2017-09-21 Thread Emmanuel Kasper
nd libvirt. Sending this as RFC as the debian qemu-system-x86 package provides two binaries qemu-system-i386 and qemu-system-x86_64, and I am not sure if we should provide a symlink to qemu-system-i386 as well (libguestfs does not need this it in any case) Emmanuel Kasper (1): Provides a virtu

Re: [pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

2017-09-21 Thread Emmanuel Kasper
On 09/21/2017 10:50 AM, Wolfgang Bumiller wrote: > On Thu, Sep 21, 2017 at 10:26:46AM +0200, Emmanuel Kasper wrote: >> Mainly to allow libguestfs and associated tools to work with our qemu binary. >> >> libguestfs tests at run timethe output of qemu -help and qemu -device

[pve-devel] [PATCH manager v3 8/8] Render full name of VirtIO Block controller

2017-09-26 Thread Emmanuel Kasper
This will hopefully reduce confusion with SCSI VirtIO controller --- www/manager6/form/BusTypeSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js index ae7c327e..8abdcf4b 100644 --- a/www/manag

[pve-devel] [PATCH manager v3 4/8] Use the noVirtIO ControllerSelector property to build the list of controllers

2017-09-26 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 15023a7a..489b97de 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/manager6

[pve-devel] [PATCH manager v3 0/8] Display the SCSI controller type when adding a new drive

2017-09-26 Thread Emmanuel Kasper
nside the wizard in a real component, so we can get rid of the setHiddenWizard() method which was a bit ugly. * write VirtIO as VirtIO Block when display a VirtIO Block controller Emmanuel Kasper (8): Do not use 'autoselect' as a boolean when preselecting a bus Remove unused noScsi p

[pve-devel] [PATCH manager v3 3/8] Save the components we found via down() in a variable for later reuse.

2017-09-26 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 14ad574e..15023a7a 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/m

[pve-devel] [PATCH manager v3 2/8] Remove unused noScsi parameter

2017-09-26 Thread Emmanuel Kasper
SCSI is a valid bus for Disks and CD drives, so it should always be appear in the bus list. --- www/manager6/form/BusTypeSelector.js| 6 +- www/manager6/form/ControllerSelector.js | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/www/manager6/form/BusTypeSelector.

[pve-devel] [PATCH manager v3 7/8] After OS type selection in Wizard, set the appropriate SCSI controller type in the Hard Disk panel

2017-09-26 Thread Emmanuel Kasper
This was done previously without any kind of user visible feedback, so users would not know that they had a Virtio SCSI controller as default controller for Linux VMs. --- www/manager6/qemu/CreateWizard.js | 5 - www/manager6/qemu/OSDefaults.js | 2 +- www/manager6/qemu/OSTypeEdit.js |

[pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-26 Thread Emmanuel Kasper
The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect' to select a bus position when adding a CD Drive.

[pve-devel] [PATCH manager v3 6/8] When inside the wizard, actualize the scsiType display field based on iothread selection

2017-09-26 Thread Emmanuel Kasper
We keep the same logic as before: once the iothread option is selected, the default SCSI controller is switched to virtio-scsi-single until iothread is unselected again. --- www/manager6/qemu/HDEdit.js | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git

[pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

2017-09-26 Thread Emmanuel Kasper
--- www/manager6/qemu/HDEdit.js | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 8a415d8b..075ad667 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -24,11 +24,12 @@ Ext

[pve-devel] [PATCH qemu-server] importovf: explicitly returns undef

2017-09-27 Thread Emmanuel Kasper
We set the returns value to { type => 'null' } but we returned an empty string, which was confusing the cli handler. --- PVE/CLI/qm.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 0e17cc9..90a44ef 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/C

[pve-devel] [PATCH docs 2/2] Update the Windows import example to use the qm importovf command

2017-09-27 Thread Emmanuel Kasper
Also create a new section, "Add an external disk image to a Virtual Machine" using the qm importdisk command. --- NB: qm.1-synopsis.adoc should be rebuilt, so the 'importovf' command is there too. qm.adoc | 74 - 1 file changed, 50 i

[pve-devel] [PATCH docs 1/2] Typo correction

2017-09-27 Thread Emmanuel Kasper
--- qm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 6cc8855..44d45f6 100644 --- a/qm.adoc +++ b/qm.adoc @@ -679,7 +679,7 @@ the VM. For Windows VMs, you need to install the Windows paravirtualized drivers by yourself. GNU/Linux and other fre

Re: [pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

2017-09-28 Thread Emmanuel Kasper
On 09/27/2017 11:27 AM, Thomas Lamprecht wrote: > On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >> --- >>   www/manager6/qemu/HDEdit.js | 15 --- >>   1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/www/manager6/qemu/HDEdit.js b/www

Re: [pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-28 Thread Emmanuel Kasper
On 09/27/2017 10:47 AM, Thomas Lamprecht wrote: > On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >> The bus selector is displayed when we add a Hard Disk or CD Drive. >> When it is displayed, we *always* preselect the next available >> slot on the controller of our choice. &

[pve-devel] [PATCH manager v4 0/8] Display the SCSI controller type when adding a new disk

2017-10-02 Thread Emmanuel Kasper
afety of changing the IDE bus position for CD ROM drives. * Patch 6: do not suspend change events, use temp variable to store SCSI type * Patch 7-8: fix long lines in commit log Emmanuel Kasper (8): Do not use 'autoselect' as a boolean when preselecting a bus Remove unused noScsi

[pve-devel] [PATCH manager v4 4/8] Do not use the noVirtIO property to build the controller list

2017-10-02 Thread Emmanuel Kasper
This property is only used for CDEdit, so we can deduce this from the fact that autoselect is set to 'cdrom' --- www/manager6/form/ControllerSelector.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 15

[pve-devel] [PATCH manager v4 3/8] Save the components we found via down() in a variable for later reuse.

2017-10-02 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 14ad574e..15023a7a 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/m

[pve-devel] [PATCH manager v4 5/8] Add a field to show which SCSI controller type we are currently using

2017-10-02 Thread Emmanuel Kasper
--- www/manager6/qemu/HDEdit.js | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 8a415d8b..075ad667 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -24,11 +24,12 @@ Ext

[pve-devel] [PATCH manager v4 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-10-02 Thread Emmanuel Kasper
The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect' to select a bus position when adding a CD Drive.

[pve-devel] [PATCH manager v4 6/8] Update VM SCSI type based on iothread value when inside the wizard

2017-10-02 Thread Emmanuel Kasper
We keep the same logic as before: once the iothread option is selected, the SCSI controller is switched to virtio-scsi-single, until iothread is unselected again. --- www/manager6/qemu/HDEdit.js | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/www/manager6/

[pve-devel] [PATCH manager v4 2/8] Remove unused noScsi parameter

2017-10-02 Thread Emmanuel Kasper
SCSI is a valid bus for Disks and CD drives, so it should always be appear in the bus list. --- www/manager6/form/BusTypeSelector.js| 6 +- www/manager6/form/ControllerSelector.js | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/www/manager6/form/BusTypeSelector.

[pve-devel] [PATCH manager v4 8/8] Render full name of VirtIO Block controller

2017-10-02 Thread Emmanuel Kasper
This will hopefully reduce confusion with SCSI VirtIO controller --- www/manager6/form/BusTypeSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js index ae7c327e..8abdcf4b 100644 --- a/www/manag

[pve-devel] [PATCH manager v4 7/8] Update VM SCSI controller type after OS selection in Wizard

2017-10-02 Thread Emmanuel Kasper
This was done previously without any kind of user visible feedback, so users would not know that they had a Virtio SCSI controller as default controller for Linux VMs. --- www/manager6/qemu/CreateWizard.js | 5 - www/manager6/qemu/OSDefaults.js | 2 +- www/manager6/qemu/OSTypeEdit.js | 1

Re: [pve-devel] [PATCH manager] fix #1510: do not scroll back to focus when view gets refreshed

2017-10-02 Thread Emmanuel Kasper
On 10/02/2017 02:53 PM, Thomas Lamprecht wrote: > Seems to works good, the small code change you made to the > original function looks also good to me: > Reviewed-by: Thomas Lamprecht Fine for me too, I tested this with IE11 and this works as expected.

[pve-devel] [PATCH docs] Add a paragraph to explain how network models match use cases

2017-10-02 Thread Emmanuel Kasper
Also : * explain more clearly when PVE switched to persistent device naming. (5.0) * use eno1 instead of eno0 everywhere when refering to the first onboard device * use IP addresses from the range IPv4 Address Blocks for Documentation (rfc5737) instead of private IPv4 addresses when giving exam

[pve-devel] [PATCH qemu 1/2] Provides a qemu-system-x86 virtual package

2017-10-04 Thread Emmanuel Kasper
This allows adding additional debian packages on pve hosts which depends on those. The following install paths were tested: * install of proxmox-ve on debian systems with standard package set: works as expected * install of proxmox-ve on debian having the debian qemu package installed: refu

[pve-devel] [PATCH qemu 2/2] Add a 'Conflicts' with qemu-system-common from Debian

2017-10-04 Thread Emmanuel Kasper
Both qemu-system-common and our pve-qemu-kvm package install the file /usr/bin/virtfs-proxy-helper. Since qemu-system-common does not have reverse dependencies in Debian for packages besides qemu-system-, and ovmf, which we don't want to install anyway, we do not need a 'Provides' for it. --- de

[pve-devel] [PATCH qemu 0/2] Provides a qemu-system-x86 virtual package

2017-10-04 Thread Emmanuel Kasper
nterprise Evaluation See http://libguestfs.org/guestfs-faq.1.html for the relation between libguestfs and libvirt. Emmanuel Kasper (2): Provides a qemu-system-x86 virtual package Add a 'Conflicts' with qemu-system-common from Debian debian/control | 6 +- debian/rules | 8

Re: [pve-devel] [PATCH qemu 1/2] Provides a qemu-system-x86 virtual package

2017-10-04 Thread Emmanuel Kasper
n 10/04/2017 04:10 PM, Thomas Lamprecht wrote: > On 10/04/2017 03:53 PM, Emmanuel Kasper wrote: >> This allows adding additional debian packages on pve hosts >> which depends on those. >> >> The following install paths were tested: >> >> * install of pro

Re: [pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

2017-10-05 Thread Emmanuel Kasper
On 10/05/2017 11:25 AM, Thomas Lamprecht wrote: > On 09/28/2017 03:10 PM, Emmanuel Kasper wrote: >> On 09/27/2017 11:27 AM, Thomas Lamprecht wrote: >>> On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >>>> --- >>>>   www/manager6/qemu/HDEdit.js | 15

[pve-devel] [PATCH manager v5 5/8] Add a field to show which SCSI controller type we are currently using

2017-10-05 Thread Emmanuel Kasper
We use the field label 'SCSI Controller'. 'Type' is redundant, otherwise we would have Network Card Type, Display Type, Network Card type, etc ... --- changes since v4: * rename the field label to SCSI Controller, and the associated component reference to scsiController. www/manager6/qemu/HDEd

[pve-devel] [PATCH manager v5 6/8] Update VM SCSI type based on iothread value when inside the wizard

2017-10-05 Thread Emmanuel Kasper
We keep the same logic as before: once the iothread option is selected, the SCSI controller is switched to virtio-scsi-single, until iothread is unselected again. --- rebase after 5/8 changed www/manager6/qemu/HDEdit.js | 21 + 1 file changed, 17 insertions(+), 4 deletions(-)

[pve-devel] [PATCH manager v5 7/8] Update VM SCSI controller type after OS selection in Wizard

2017-10-05 Thread Emmanuel Kasper
This was done previously without any kind of user visible feedback, so users would not know that they had a Virtio SCSI controller as default controller for Linux VMs. --- rebase after changes in 5/8 www/manager6/qemu/CreateWizard.js | 5 - www/manager6/qemu/OSDefaults.js | 2 +- www/manag

Re: [pve-devel] [PATCH manager] fix #1516: fix mouse-scrolling of overflowhandlers in firefox

2017-10-05 Thread Emmanuel Kasper
On 10/04/2017 10:04 AM, Dominik Csapak wrote: > this is a workaround for scrolling in toolbars, etc. in firefox with the > mouse > > while the result is not very "pretty", it maintains the old behaviour > for all other browsers and makes it work in firefox > > we can drop this when we update to a

[pve-devel] [PATCH storage] ISCSIPlugin: Use long options for readability

2017-10-09 Thread Emmanuel Kasper
We otherwise use the long options everywhere in the plugin. This will build the following command: iscsiadm --mode session --sid 1 --rescan Rescanning session [sid: 1, target: xxx, portal: yyy] --- PVE/Storage/ISCSIPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE

[pve-devel] [PATCH docs v2] Add a paragraph to explain how network models match use cases

2017-10-09 Thread Emmanuel Kasper
Also : * explain more clearly when PVE switched to persistent device naming. (5.0) * use eno1 instead of eno0 everywhere when refering to the first onboard device * use IP addresses from the range IPv4 Address Blocks for Documentation (rfc5737) instead of private IPv4 addresses when giving exam

[pve-devel] [PATCH qemu v2 1/5] Remove deprecated dh_clean -k

2017-10-11 Thread Emmanuel Kasper
--- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 98637c7..28723df 100755 --- a/debian/rules +++ b/debian/rules @@ -80,7 +80,7 @@ endif install: build dh_testdir dh_testroot - dh_clean -k + dh_prep

[pve-devel] [PATCH qemu v2 3/5] Bump dephelper compatibility level to 10

2017-10-11 Thread Emmanuel Kasper
The debian package content was found to be the same with diffoscope. No functional change. --- debian/compat | 2 +- debian/control | 2 +- debian/rules | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/debian/compat b/debian/compat index 7ed6ff8..f599e28 100644 --- a/debi

[pve-devel] [PATCH qemu v2 4/5] Provides a qemu-system-x86 virtual package

2017-10-11 Thread Emmanuel Kasper
This allows adding additional debian packages on pve hosts which depends on a qemu binary being installed. The following install paths were tested: * install of proxmox-ve on debian systems with standard package set: works as expected * install of proxmox-ve on debian having the debian qemu

[pve-devel] [PATCH qemu v2 5/5] Add a 'Conflicts' with qemu-system-common from Debian

2017-10-11 Thread Emmanuel Kasper
Both qemu-system-common and our pve-qemu-kvm package install the file /usr/bin/virtfs-proxy-helper. Since qemu-system-common does not have reverse dependencies in Debian for packages besides qemu-system-, and ovmf, which we don't want to install anyway, we do not need a 'Provides' for it. --- de

[pve-devel] [PATCH qemu v2 0/5] Provides a qemu-system-x86 virtual package

2017-10-11 Thread Emmanuel Kasper
package we 'Provides'. Emmanuel Kasper (5): Remove deprecated dh_clean -k Install userspace utilities and UEFI roms via dh_install Bump dephelper compatibility level to 10 Provides a qemu-system-x86 virtual package Add a 'Conflicts' with qemu-system-common from De

[pve-devel] [PATCH qemu v2 2/5] Install userspace utilities and UEFI roms via dh_install

2017-10-11 Thread Emmanuel Kasper
--- debian/pve-qemu-kvm.install | 9 + debian/rules| 12 +--- 2 files changed, 10 insertions(+), 11 deletions(-) create mode 100644 debian/pve-qemu-kvm.install diff --git a/debian/pve-qemu-kvm.install b/debian/pve-qemu-kvm.install new file mode 100644 index 0

Re: [pve-devel] [PATCH manager] fix updateStore destroy

2017-10-11 Thread Emmanuel Kasper
look goods to me maybe we should have mentioned that this is needed for having the 'autoDestroy' store property working properly. Otherwise it is not clear why we needed this in the pve context, as all updates store are unqueued manually with component.on('destroy', componentstore.stopUpdate); a

Re: [pve-devel] Include dpkg-reconfigure in Makefile

2017-10-16 Thread Emmanuel Kasper
On 10/13/2017 08:13 AM, Thomas wrote: > Hello! > > How can I include /dpkg-reconfigure tzdata/ (Europe/Berlin) and > /dpkg-reconfigure/ locales (de_DE.UTF-8) in the Makefile? Hi Thomas Not sure I understand your question because server specific setup is usually not done with Make. You should eit

Re: [pve-devel] [PATCH qemu v2 0/5] Provides a qemu-system-x86 virtual package

2017-10-16 Thread Emmanuel Kasper
> In general, looks good to me. > > Upstream package provides also the following man pages[1]: > /usr/share/man/man1/qemu-system-i386.1.gz > /usr/share/man/man1/qemu-system-x86_64.1.gz > Which we do not (we have only qemu), would it make sense > to make a link to these? yes makes sense, we shoul

[pve-devel] [PATCH qemu v3 4/5] Provides a qemu-system-x86 virtual package

2017-10-16 Thread Emmanuel Kasper
This allows adding additional debian packages on pve hosts which depends on a qemu binary being installed. The following install paths were tested: * install of proxmox-ve on debian systems with standard package set: works as expected * install of proxmox-ve on debian having the debian qemu

Re: [pve-devel] [PATCH manager 0/7] WebUI: make HA management easier

2017-10-16 Thread Emmanuel Kasper
On 10/16/2017 01:48 PM, Thomas Lamprecht wrote: > On 10/16/2017 01:39 PM, Wolfgang Bumiller wrote: >> On Wed, Oct 11, 2017 at 12:09:40PM +0200, Thomas Lamprecht wrote: >>> First two patches make adding a new services over DC->HA->Add more >>> confortable by switching out the simple VMID integer s

Re: [pve-devel] [PATCH manager 7/7] ui: lxc: add 'more' button with HA manage menu item to panel

2017-10-16 Thread Emmanuel Kasper
On 10/11/2017 12:09 PM, Thomas Lamprecht wrote: > Move the remove button into the more button and add a 'Manage HA' > button there, mirroring the changes from the qemu panel. > > Allows to add an unmanaged CT to HA or to edit the HA settings of a > managed one. > > Fixes: #1518 > Signed-off-by: T

Re: [pve-devel] [PATCH manager 1/2] ui: pveWindowEdit: allow sane onlineHelp specification for edit windows

2017-10-17 Thread Emmanuel Kasper
On 10/17/2017 02:29 PM, Thomas Lamprecht wrote: > instead of heuristically choosing the onlineHelp entry from our first > item prefer the one we have in our config, if noone the fallback to > the old heuristic. > > Signed-off-by: Thomas Lamprecht > --- > www/manager6/window/Edit.js | 5 +++-- >

<    1   2   3   4   5   6   7   8   9   10   >