[issue20451] os.exec* mangles argv on windows (splits on spaces, etc)

2014-01-30 Thread Florian Bruhin
New submission from Florian Bruhin: The os.exec* functions seem to mangle arguments on Windows. So far I noticed the supplied argv gets split on spaces, and double-quotes get stripped when not escaped. Example, on Windows 7: >>> platform.platform() 'Windows-7-6.1.7601-SP1' >>> os.execlp('pyth

[issue20406] Use application icon for IDLE

2014-01-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: I see. MS Paint just pulled out one of the 16-pixel images. Photoshop (like Tk) refused to open the file. However, I found the following: iconbitmap = wm_iconbitmap(self, bitmap=None, default=None) Set bitmap for the iconified widget to BITMAP. Return t

[issue18916] Various out-of-date Lock text in 3.2+

2014-01-30 Thread R. David Murray
R. David Murray added the comment: Yes, the latter: since someone thought it was important to mention, but only people working with the C code would benefit, it ought to be a comment in the C source. If there's no AC patch for threading yet, then there's no problem with that, and your patch w

[issue18916] Various out-of-date Lock text in 3.2+

2014-01-30 Thread Christopher Welborn
Changes by Christopher Welborn : Removed file: http://bugs.python.org/file33818/threading.lock.docs.patch ___ Python tracker ___ ___ Python-bu

[issue18916] Various out-of-date Lock text in 3.2+

2014-01-30 Thread Christopher Welborn
Christopher Welborn added the comment: Yep, I missed the PyThread_allocate_lock reference. As far as the Argument Clinic Derby, I've been following the python-dev list and reading about Argument Clinic, but I don't know enough about it to do the conversion. It's a really good tool from what I

[issue19658] inspect.getsource weird case

2014-01-30 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> committed/rejected superseder: -> inspect.findsource raises undocumented error for code objects with empty filename ___ Python tracker

[issue16991] Add OrderedDict written in C

2014-01-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: It's much too late for such a disruptive change in 3.4. -- nosy: +pitrou ___ Python tracker ___ ___

[issue16991] Add OrderedDict written in C

2014-01-30 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18916] Various out-of-date Lock text in 3.2+

2014-01-30 Thread R. David Murray
R. David Murray added the comment: Thanks for working on this. The patch looks pretty good. I would prefer to flow the two lines in the Lock docstring as a paragraph, rather than have once sentence per line. Also, the OP mentions that the docs for type(Lock) mention PyThread_allocate_lock..

[issue2292] Missing *-unpacking generalizations

2014-01-30 Thread Chris Angelico
Changes by Chris Angelico : -- nosy: +Rosuav ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue20398] stem crashes python

2014-01-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the feedback! Then I suggest you report the issue to the cygwin Python packagers. -- resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue20319] concurrent.futures.wait() can block forever even if Futures have completed

2014-01-30 Thread Glenn Langford
Glenn Langford added the comment: An idea for a different possible fix - rather than cleaning up waiters in wait() and as_completed(), could they be removed in Future.set_result() and Futures.set_exception() ? I'm not certain if any waiter should ever be notified twice; if not, perhaps set_r

[issue18916] Various out-of-date Lock text in 3.2+

2014-01-30 Thread Christopher Welborn
Christopher Welborn added the comment: Hello, my name is Chris Welborn (or Cj). I've been looking for opportunities to work on python. I figured a little Doc fix would be perfect for my first patch, as you originally planned. I ran the python unit-tests and `make test`, plus a 'patchcheck'. Ev

[issue19856] shutil.move() can't move a directory in non-empty directory on Windows

2014-01-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I suppose this patch should fix a bug on Windows. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file33817/shutil_move_dir_altsep.patch ___ Python tracker

[issue6478] time.tzset does not reset _strptime's locale time cache

2014-01-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: May be System Z Linux buildbot fails due to this bug (http://buildbot.python.org/all/builders/System%20Z%20Linux%203.x/builds/1154/steps/test/logs/stdio): == ERROR: test_strptime (test.dateti

[issue20449] _overlapped: read_buffer and write_buffer are misused

2014-01-30 Thread STINNER Victor
STINNER Victor added the comment: Patch commited as 73dbb884eb09 in Python 3.4. (No need to backport, it's a new module in Python 3.4). Thanks for the review Richard. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue20450] hg touch fails on System Z Linux buildbot

2014-01-30 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: "Touching generated files failed" step fails on System Z Linux buildbot (http://buildbot.python.org/all/builders/System%20Z%20Linux%203.x/builds/1157/steps/shell/logs/stdio): hg --config extensions.touch=Tools/hg/hgtouch.py touch -v ** unknown exception enc

[issue20444] Reduce logging.config.Converting duplication of code

2014-01-30 Thread Vinay Sajip
Vinay Sajip added the comment: I'll keep this issue open to remind me to patch 3.3 / 3.4 at the appropriate time. -- ___ Python tracker ___ _

[issue20444] Reduce logging.config.Converting duplication of code

2014-01-30 Thread Roundup Robot
New submission from Roundup Robot: New changeset 03b399c807d6 by Vinay Sajip in branch '2.7': Issue #20444: Reduced code duplication. Thanks to dongwm for the report and patch. http://hg.python.org/cpython/rev/03b399c807d6 -- nosy: +python-dev ___ Py

[issue20444] Reduce logging.config.Converting duplication of code

2014-01-30 Thread Vinay Sajip
Changes by Vinay Sajip : -- assignee: -> vinay.sajip versions: +Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list ma

[issue20406] Use application icon for IDLE

2014-01-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think that all icons used in Windows installer are in the repository. All four ico-files in the PC directory contains 7 images: 16, 32 and 48 pixels size and 4-, 8- and 32-bits per pixel. Three of them (except PC/launcher.ico) were added in issue1490384.

[issue20398] stem crashes python

2014-01-30 Thread lothar
lothar added the comment: you are right: windows native python 3.3.3 from your link runs the program properly - and without crashing. -- ___ Python tracker ___ _

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2014-01-30 Thread Ronald Oussoren
Ronald Oussoren added the comment: I just ran into this problem myself. On fresh installs of OSX 10.9 LC_CTYPE is set to "UTF-8" (at least for english language users), and now sphinx won't work :-( Is Dimitrys patch acceptable (either as is, or with my suggestion of checking for sys.platform

[issue20441] Test_tcl.TclTest.test_split(list) failures on Windows, 2.7.

2014-01-30 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue19320] Tkinter tests ran with wantobjects is false

2014-01-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Looks as dicts before 8.5.5 were converted to lists through string. Here are patches for 3.4 and 2.7. -- stage: committed/rejected -> patch review Added file: http://bugs.python.org/file33815/test_tcl_split_dict-3.4.patch

[issue19320] Tkinter tests ran with wantobjects is false

2014-01-30 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file33816/test_tcl_split_dict-2.7.patch ___ Python tracker ___ ___ Python-bug

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-01-30 Thread Yury Selivanov
Yury Selivanov added the comment: Attached is a second patch (sig_func_ducktype_02.patch), with a bit improved tests (and a small bug fixed). Larry, do you think it's OK if I merge this one in 3.4? Technically, it's a feature that we start to support Cython functions in inspect.signature, but

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-01-30 Thread Stefan Behnel
Stefan Behnel added the comment: LGTM, thanks! And works nicely with Cython: """ import inspect def test_isfunction(): """ >>> test_isfunction() True """ return inspect.isfunction(test_isfunction) def test_signature(): """ >>> test_signature() # doctest: +ELLIPSI

[issue20445] HAVE_BROKEN_NICE detected incorrectly due to configure.ac typo

2014-01-30 Thread Benjamin Peterson
Benjamin Peterson added the comment: Are you sure? The configure test sets ac_cv_broken_nice=1 if "val1 == nice(2)". That is if the call returns the same succesful value each time. -- nosy: +benjamin.peterson ___ Python tracker

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-01-30 Thread Yury Selivanov
Yury Selivanov added the comment: Stefan, I'm attaching a reviewed patch--was a bit easier to rebase it on the new code and fix the remaining issues. Please review. BTW, do cython functions have __name__ attribute? -- assignee: -> yselivanov Added file: http://bugs.python.org/file33

[issue20448] Adds missing backslash to devguide setup page

2014-01-30 Thread Zachary Ware
Zachary Ware added the comment: Actually, this was still an issue :) Thanks for the report and patch! If you intend to ever contribute more than the simplest of patches, please consider signing a contributor agreement: http://www.python.org/psf/contrib/ -- nosy: +zach.ware stage: ->

[issue20448] Adds missing backslash to devguide setup page

2014-01-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7d95a62513ce by Zachary Ware in branch 'default': Issue #20448: Escape backslashes. Caught by Saimadhav Heblikar. http://hg.python.org/devguide/rev/7d95a62513ce -- nosy: +python-dev ___ Python tracker <

[issue17162] Py_LIMITED_API needs a PyType_GenericDealloc

2014-01-30 Thread Larry Hastings
Larry Hastings added the comment: Also, isn't it reasonable to pass in non-heap type objects? I realize supporting this would complicate the implementation a great deal. -- ___ Python tracker

[issue17162] Py_LIMITED_API needs a PyType_GenericDealloc

2014-01-30 Thread Larry Hastings
Larry Hastings added the comment: I thought I replied to this... weird. Do I understand correctly that it's basically impossible to write a proper custom deallocator in the limited API right now, because you can't get access to your base class's tp_free? (If so, why didn't anybody notice?) -

[issue20449] _overlapped: read_buffer and write_buffer are misused

2014-01-30 Thread STINNER Victor
New submission from STINNER Victor: I found an issue in overlapped.c: read_buffer and write_buffer attributes are defined in an union, but they are sometimes use even if the type is not good. I found this issue while trying to get a BrokenPipeError on Windows when the stdin stream of a subproc

[issue20448] Adds missing backslash to devguide setup page

2014-01-30 Thread R. David Murray
Changes by R. David Murray : -- resolution: duplicate -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18673] Add O_TMPFILE to os module

2014-01-30 Thread Jakub Wilk
Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue12015] possible characters in temporary file name is too few

2014-01-30 Thread Jakub Wilk
Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue20448] Adds missing backslash to devguide setup page

2014-01-30 Thread Saimadhav Heblikar
Saimadhav Heblikar added the comment: http://hg.python.org/devguide/rev/99419f310cf1 -- resolution: -> duplicate status: open -> closed ___ Python tracker ___ __

[issue20444] Reduce logging.config.Converting duplication of code

2014-01-30 Thread R. David Murray
Changes by R. David Murray : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue17162] Py_LIMITED_API needs a PyType_GenericDealloc

2014-01-30 Thread Martin v . Löwis
Martin v. Löwis added the comment: If the set of slots gets extended, extensions would have to opt-in to use the newer slots, i.e. the availability of slot numbers should be conditional at compile-time. Returning 0 for slots not supported in a version seems fine to me as well (after reconside

[issue20448] Adds missing backslash to devguide setup page

2014-01-30 Thread Saimadhav Heblikar
New submission from Saimadhav Heblikar: This is a simple typofix. On line 224 and 225,there were unescaped backslashes,which resulted in the external.bat and external-amd64.bat appeared as Tools\buildbotexternal.bat and Tools\buildbotexternal-amd64.bat respectively. this patch escapes the two b

[issue20447] doctest.debug_script: insecure use of /tmp

2014-01-30 Thread Jakub Wilk
New submission from Jakub Wilk: The doctest.debug_script function creates temporary files in an insecure way: srcfilename = tempfile.mktemp(".py", "doctestdebug") f = open(srcfilename, 'w') This is already fixed for Python >= 3.2, although for reasons other than security: issue12451 -

[issue16202] sys.path[0] security issues

2014-01-30 Thread Jakub Wilk
Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue12187] subprocess.wait() with a timeout uses polling on POSIX

2014-01-30 Thread STINNER Victor
STINNER Victor added the comment: > But that is still a busy loop, no? No, it's not. asyncio uses a selector which waits for events on file descriptors. It uses signal.set_wakeup_fd() which writes asynchronously on a file descriptor. So asyncio is suspended until a file descriptor gets data. --

[issue20415] Could method "isinstance" take a list as parameter?

2014-01-30 Thread Jakub Wilk
Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue20445] HAVE_BROKEN_NICE detected incorrectly due to configure.ac typo

2014-01-30 Thread George Kouryachy
George Kouryachy added the comment: It seems to be permanent typo through all branches :( -- versions: +Python 3.1, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker

[issue20440] Use Py_REPLACE/Py_XREPLACE macros

2014-01-30 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- priority: normal -> high type: behavior -> crash ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20446] ipaddress: hash similarities for ipv4 and ipv6

2014-01-30 Thread flambda
New submission from flambda: Hi, I am a bit unsure if this is a problem but bear with me: Using ipaddress I noticed that: hash(ipaddress.ip_address("0.0.0.1")) == hash(ipaddress.ip_address("::1")) which makes sense as ipaddress uses this: (http://hg.python.org/cpython/file/default/Lib/ipaddre

[issue20440] Use Py_REPLACE/Py_XREPLACE macros

2014-01-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Unless some known bugs are being fixed, this should be 3.4 only. For example here is a bug very similar to a bug fixed in issue16447. class Nasty(str): def __del__(self): C.__qualname__ = "other" class C: pass C.__qualname__ = Nasty("abc")

[issue20445] HAVE_BROKEN_NICE detected incorrectly due to configure.ac typo

2014-01-30 Thread George Kouryachy
New submission from George Kouryachy: It's declared in pyconfig.h that HAVE_BROKEN_NICE is set if nice() returns success/failure instead of the new priority. But configure checks just opposite (as for http://hg.python.org/cpython/file/03fc7449f204/configure.ac#l4234): if (val1 != -1 && val1

[issue18321] Multivolume support in tarfile module

2014-01-30 Thread Lars Gustäbel
Lars Gustäbel added the comment: At first, I'd like to take back my comment on this patch being too complex for too little benefit. That is no real argument. Okay, I gave it a shot and I have a few more remarks: The patch does not support iterating over a multi-volume tar archive, e.g. for Ta

[issue12187] subprocess.wait() with a timeout uses polling on POSIX

2014-01-30 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > The new asyncio module doesn't have this performance issue > On Unix, the default implementation sets an handler for SIGCHLD signal which > calls waitpid(pid, WNOHANG) on all processes to detect process exit. But it > has > also a faster implementation wh

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

2014-01-30 Thread Stefan Behnel
Stefan Behnel added the comment: I stumble over this because I had already adapted our doctests in Cython to the changed Py3.4 behaviour, so they started failing now because the automatic signature extraction was essentially reverted in CPython. I had started to consider it a feature that CPyt