[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Éric Araujo added the comment: Now that site can be imported without side effects under -S, I think the tests could be updated: they don’t have to be all skipped under -S. See attached patch. -- Added file: http://bugs.python.org/file22293/test_site-11591.diff __

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Roundup Robot added the comment: New changeset 6ee5443773cb by Éric Araujo in branch 'default': Also add versionchanged directive to the function doc (#11591) http://hg.python.org/cpython/rev/6ee5443773cb -- ___ Python tracker

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Roundup Robot added the comment: New changeset 9a1ca0062950 by Éric Araujo in branch 'default': Add versionchanged for a364719e400a (#11591) http://hg.python.org/cpython/rev/9a1ca0062950 -- ___ Python tracker

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Éric Araujo added the comment: Committed with small wording changes and more docs. Thank you, and good luck for cpythonv! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Roundup Robot added the comment: New changeset a364719e400a by Éric Araujo in branch 'default': Do not touch sys.path when site is imported and python was started with -S. http://hg.python.org/cpython/rev/a364719e400a -- nosy: +python-dev ___ Python

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Changes by Terry J. Reedy : Removed file: http://bugs.python.org/file21350/ebe5760afa08.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Changes by Terry J. Reedy : Added file: http://bugs.python.org/file21350/ebe5760afa08.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Brett Cannon added the comment: Doc changes seem fine to me. -- assignee: brett.cannon -> eric.araujo ___ Python tracker ___ ___ Pyth

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Éric Araujo added the comment: > The "Remote hg repo" field was just empty when I made my latest comment Looks like this field is always empty: its goal is to add a repo, just like the File field is always empty unless you add a file. The existing files and repositories are however listed un

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Changes by Brett Cannon : -- assignee: eric.araujo -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Carl Meyer added the comment: > Did you have to manually click “Create Patch” to make roundup generate it? Yes - the first time too. > Did you try first to click on the button of the existing repo before adding a > new repo entry? That would probably have worked fine. The "Remote hg repo"

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Éric Araujo added the comment: Looks great, thank you. I think I’ll also add a docstring to main before committing, now that the function is publicly documented. Did you have to manually click “Create Patch” to make roundup generate it? Did you try first to click on the button of the existi

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Changes by Carl Meyer : Added file: http://bugs.python.org/file21327/ebe5760afa08.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Carl Meyer added the comment: Added documentation to Doc/library/site.rst and Misc/NEWS. -- hgrepos: +5 ___ Python tracker ___ ___ Py

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Éric Araujo added the comment: I think this requires a note in NEWS but also in Doc/library/site.rst. Carl, would you like to make a new changeset with that edition in your repo? (It will also provide a test for the Create Patch button after.) -- ___

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Brett Cannon added the comment: This is what I get for trying to clean up site.py years ago. =) I'm fine with the change as long as there is a very clear Misc/NEWS message that the semantics on import have changed (and obviously this is not backported). -- assignee: -> eric.araujo

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Éric Araujo added the comment: Fair argument. Brett is the author of recent changes in site, let him decide. Brett: Would you agree to 1)? -- nosy: +brett.cannon ___ Python tracker __

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Carl Meyer added the comment: Adding a test is easier said than done. The behavior change here depends on python being run with -S. Currently test_site skips itself if the test suite is run with -S, and if I remove that skip it crashes under -S. Options as I see it: 1. Declare this one-liner

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Éric Araujo added the comment: Thanks. Would you mind adding tests in test_site? -- nosy: +eric.araujo versions: +Python 3.3 ___ Python tracker ___

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

Changes by Carl Meyer : -- keywords: +patch Added file: http://bugs.python.org/file21274/87df1d37c88e.diff ___ Python tracker ___ ___

[issue11591] "python -S" should be robust against e.g. "from site import addsitedir"

New submission from Carl Meyer : If python is run with the -S flag, that declares the intent of the user to not have site-specific additions to sys.path. However, some code in that process may have a legitimate need for a function defined in site.py - for instance, addsitedir. But the act of i