[issue1960] test_gdbm.py converted to unittest

Brett Cannon <[EMAIL PROTECTED]> added the comment: Committed in revision 61374 (w/ changes so that the key stuff is not order-dependent). Thanks, Giampaolo! -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]>

[issue1960] test_gdbm.py converted to unittest

Changes by Brett Cannon: -- assignee: -> brett.cannon __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1960] test_gdbm.py converted to unittest

Changes by Christian Heimes: -- keywords: +patch priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsub

[issue1960] test_gdbm.py converted to unittest

Giampaolo Rodola' added the comment: The diff file in attachment was generated by using TortoiseSVN and it seems to be different than using "svn diff". The new diff file is in attachment. Added file: http://bugs.python.org/file9363/test_gdbm.diff __ Tracker <[EMA

[issue1960] test_gdbm.py converted to unittest

Changes by Giampaolo Rodola': Added file: http://bugs.python.org/file9323/test_gdbm.py __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing li

[issue1960] test_gdbm.py converted to unittest

Giampaolo Rodola' added the comment: Updated version in attachment. Changes: - Added "if self.g is not None: self.g.close()" clause in tearDown. - Used "test.test_support.unlink(filename)" instead of the try/except statement. - Added tests for the flag clause in the open() statement by trying a

[issue1960] test_gdbm.py converted to unittest

Brett Cannon added the comment: On Jan 28, 2008 6:20 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote: > > Giampaolo Rodola' added the comment: > > > Well, if you have an opinion, feel free to leave a comment in this > > issue about it. I will most likely be the one who does the checkin and > > I

[issue1960] test_gdbm.py converted to unittest

Giampaolo Rodola' added the comment: > Well, if you have an opinion, feel free to leave a comment in this > issue about it. I will most likely be the one who does the checkin and > I will read this issue before I commit. * One of the things I dislike is the fact that the student used "self.g =

[issue1960] test_gdbm.py converted to unittest

Brett Cannon added the comment: On Jan 28, 2008 5:03 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote: > > Giampaolo Rodola' added the comment: > > > Have a look at > http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 > > where a GHOP student did a conversion as wel

[issue1960] test_gdbm.py converted to unittest

Giampaolo Rodola' added the comment: > Have a look at http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 > where a GHOP student did a conversion as well. Interesting, didn't know about that. In future I'll check that site before start working on a new patch involv

[issue1960] test_gdbm.py converted to unittest

Brett Cannon added the comment: Have a look at http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 where a GHOP student did a conversion as well. Any chance to come up with a possible merged version that takes the best from your work, Giampaolo and the student's wo

[issue1960] test_gdbm.py converted to unittest

New submission from Giampaolo Rodola': In attachment. All existent tests are unchanged. -- components: Tests files: test_gdbm.diff messages: 61806 nosy: giampaolo.rodola severity: normal status: open title: test_gdbm.py converted to unittest type: rfe versions: Python 2.6 Added file: htt

[issue1960] test_gdbm.py converted to unittest

Changes by Giampaolo Rodola': Added file: http://bugs.python.org/file9316/test_gdbm.py __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing li