[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Roundup Robot added the comment: New changeset a9d34685ec47 by Brian Curtin in branch '2.7': Backport 4e9f1017355f from #3561. http://hg.python.org/cpython/rev/a9d34685ec47 -- ___ Python tracker

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: As Eric says: any further issues with this change should be reported separately. -- status: open -> closed ___ Python tracker ___ __

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Éric Araujo added the comment: Can this issue be closed? If there are still disagreements about the UI or UX, it could be a separate 3.4 report. -- ___ Python tracker ___ __

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jason Spiro added the comment: Adding Python to the end of the PATH would very much help Windows non-experts who don't even know what a PATH is. IMO, when Python 3.4 comes out, it'd make sense add Python to the end of the PATH by default. This'd help those non-experts a lot. On 7/4/12, Brian

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: We don't need to stay with some paradigm if it's not the best way. If I can get any of these ways to work, I may post some type of survey on python-dev. Adding to the end wouldn't make this much of a feature. Most users have already put another Python into thei

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jason Spiro added the comment: I'm glad you're willing to consider using a checkbox. It seems to fit better with the wizard paradigm, where there are always [ < Back ], [ Next > ], and [ Cancel ] buttons onscreen. OK, I acknowledge that a lot of third-party software still depends on Python 2.

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: > == Suggestion 1 == I don't think it's that unexpected. I certainly didn't come up with the idea myself - I've seen them before. Surely it might be new to some people, but is it confusing? For one, we think it's an option users should know about. It's also an

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jason Spiro added the comment: Just a few comments on your new UI design : == Suggestion 1 == It seems, from your screenshot, that you plan to hide the [ Next > ] and [ Cancel ] buttons, and show your [ Yes ] and [ No ] buttons instead. This is doing something co

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: These things are best studied with msiexec ... /l*v python.log, then inspecting python.log. Without looking at the trace, I'd expect that the actual installation run doesn't inherit ModifyPath from the UI run. The installer runs actually twice - once in the

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: So I have a patch that does most of what my previous message shows, but I can't seem to complete it. I don't know if I'm misunderstanding something or this just can't be done, but I could use the help of someone who understands MSI things much better than I can

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jim Jewett added the comment: On Thu, May 24, 2012 at 8:11 PM, Brian Curtin added the comment: > does anyone think something like this dialog http://i.imgur.com/18zPD.png be > helpful? yes. > After choosing the directory to install to and before choosing > the features, it's a simple dialog

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jim Jewett added the comment: Chris Lambacher On Wed, Apr 25, 2012 at 10:50 AM, Martin v. Löwis added the comment: > lambacck: I'm -1, but I'm willing to yield ... > regular users won't have to deal with negative > consequences that enabling this by default may have. > I'm quite opposed to y

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Changes by Sridhar Ratnakumar : -- nosy: -srid ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: I'm strongly opposed to enabling this by default at least for 3.3, but does anyone think something like this dialog http://i.imgur.com/18zPD.png be helpful? After choosing the directory to install to and before choosing the features, it's a simple dialog explai

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: > 2. Yes, only the installation directory, because that's the only > directory we create. Scripts is created by distutils/packaging, but > perhaps we could add it since it is widely used. Anyone have an > opinion? Fine with me. To create an empty directo

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Nick Coghlan added the comment: For 3, installing the PEP 397 launcher will be the long term "on-by-default" solution. For 2, adding the Scripts subdirectory seems reasonable. FWIW, Window used to have *very* severe restrictions on the maximum length of PATH, as well as gratuitously long nam

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Pekka Klärck added the comment: Being on by default would just be easier. If it's off, we still need to separately instruct users to turn it on. That's obviously a lot easier than instruction them to change environment variables, so I don't feel too strongly about it. Not adding Scripts into

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: 2. Yes, only the installation directory, because that's the only directory we create. Scripts is created by distutils/packaging, but perhaps we could add it since it is widely used. Anyone have an opinion? 3. Do you have a reason? Many tools that offer path man

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Pekka Klärck added the comment: I found about this enhancement via Python Insider blog post [1] that also asked adding comments to this issue. Here are mine: 1) Great to see that this is finally done! 2) Is only Python installation directory added into PATH? Why not also Scripts directory un

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Éric Araujo added the comment: [Jeff Dean] > If a goal is to make it easy for new users to run python, consider installing > a desktop shortcut. > This would make it very easy for new users (easier than starting up a shell). > This is independent of the Path changes discussed here. Hi Jeff; th

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Antoine Pitrou added the comment: > Unfortunately, from what I can tell, this is OFF by default. I think > that is a mistake. The default for something like this is really > important because without new users being explicitly told to set it, > new users will not. Most new Python users are just

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Chris Lambacher added the comment: The reason for the conditional approach was to attempt to account for the "negative consequences" of adding enabling this by default. i.e. if you are already a Python developer and install a new version, it will be status quo, but if you are a new Python dev

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: lambacck: I'm -1, but I'm willing to yield to anybody who wants to be "in charge" of this feature (i.e. Brian, or the release manager). I'm not willing yield to "mere" user requests, as regular users won't have to deal with negative consequences that enablin

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Chris Lambacher added the comment: I am really happy to see this as an option in the Windows installer. This has a potential to really reduce the support burden on training new Windows users to use Python and will really help normalize the experience for new users between Windows and POSIX pl

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: Now that the feature is in, I'm going to track the few places we need to document it in #14668. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Roundup Robot added the comment: New changeset 4e9f1017355f by Brian Curtin in branch 'default': Fix #3561. Add an option to place the Python installation into the Windows Path environment variable. http://hg.python.org/cpython/rev/4e9f1017355f -- nosy: +python-dev ___

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: Brian: The patch is fine, please apply. -- stage: patch review -> commit review ___ Python tracker ___

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: The attached patch changes the feature text to "Add python.exe to Path". I'm not sure the word "search" adds much there anyway. An additional change here that I think would be beneficial is a better description text, immediately covering the benefit of this fea

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Éric Araujo added the comment: A minor thing: The capitalization of the feature names is inconsistent. -- ___ Python tracker ___ ___ P

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: Here's a patch with better wording, and here's a screenshot of what the feature selection looks like with that text: http://i.imgur.com/k7e12.png -- Added file: http://bugs.python.org/file25255/issue3561_v2.diff ___ P

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: Agreed. I will work up a more friendly text to go along with the feature. -- ___ Python tracker ___ __

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: IANANSOE (I am not a native speaker of English), but it seems to me that "Prepend path" is a bit terse, in particular since "Path" is being prepended *to*. How about "Add python.exe to the search path"? That it is added to the beginning could be elaborated (

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: > UI-wise, I'm not sure why it looks like an installable component > rather than a separate checkbox. Is it a limitation of the > installation software? You are misinterpreting the UI. The list is not of "installable components", but of "features". Adjusti

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: > UI-wise, I'm not sure why it looks like an installable component rather than > a separate checkbox. Is it a limitation of the installation software? I originally did it as a separate check box UI-wise but couldn't hook that into be an actual "Feature" in MSI

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: I unlinked the old diff. issue3561.diff is the one that matters. As for what happens with multiple installations, it's no different than how you'd already be managing it or anything else like it. If you install 2.7 with the path option enabled and then you inst

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Antoine Pitrou added the comment: UI-wise, I'm not sure why it looks like an installable component rather than a separate checkbox. Is it a limitation of the installation software? -- nosy: +pitrou ___ Python tracker

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Changes by Brian Curtin : Removed file: http://bugs.python.org/file24574/prependpath_in-progress.diff ___ Python tracker ___ ___ Python-bugs-li

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jim Jewett added the comment: @Brian -- to clarify, (1) Does issue3561.diff completely supersede prependpath_in-progress.diff? (And should that be the one currently subject to review?) (2) What happens with multiple installations? Do users have to manually unset the path to avoid surpri

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: Attached is issue3561.diff which adds a path option, off by default, as a feature to be installed. I've tested installation and un-installation with the feature both installed and not installed and it seems to work fine for me. http://briancurtin.com/python-dev

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jeff Dean added the comment: I just saw Brian Curtin's Pycon 2012 presentation. If a goal is to make it easy for new users to run python, consider installing a desktop shortcut. This would make it very easy for new users (easier than starting up a shell). This is independent of the Path cha

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: Attached is an in-progress patch. I still need to figure out how to hook up the GUI to condition the path manipulation. A few locations have said to do conditional environment modification via the Component table, but I haven't been able to get some placeholde

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Helder Magalhães added the comment: @Brian: glad to know about it. It will surely help, as many Windows users aren't much comfortable with the console already, and even less comfortable for tweaking the system at this level (apart from permission issues, etc.). ;-) @Martin: you're right, sorr

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis added the comment: Helder: please don't change tracker settings unless you know what they are for. Python 2.6 and 3.1 can't possibly see any change here since they are in security fix mode, and can't see any fixes affecting this issue. Likewise, 2.7 and 3.2 will only see bug f

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Brian Curtin added the comment: FWIW I have an installer built which optionally adds to the path. It's not complete - still needs some GUI work to hook it all up, but I'll be proposing it shortly. -- ___ Python tracker

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Helder Magalhães added the comment: See tightly related ActivePython issue [1] regarding the way directories are added to the PATH environment variable. Also, here's qooxdoo (a well-known JavaScript framework) giving out instructions [2] on how to use the official python distribution due to t

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Changes by Aaron Robson : -- nosy: +AaronR ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Changes by Jonathan Hartley : -- nosy: +jonathan.hartley ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Sridhar Ratnakumar added the comment: > I believe ActiveState handle this by making the PATH modification > optional and having it off by default (I found docs for ActivePerl > stating this explicitly, but no equivalent for ActivePython). ActivePython 2.x has it on by default. -- __

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Nick Coghlan added the comment: Now, another factor to consider is that Windows 7 makes manipulating the system PATH even more difficult to do correctly (e.g. see http://www.symantec.com/connect/forums/wise-7-win-7-problems-updating-environment-variable-current-user). I believe ActiveState ha

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Nick Coghlan added the comment: Reopening this issue since #9228 was closed as a duplicate of this one. Given the significant level of user demand for this behaviour, it should NOT be closed again until a PEP has been written and either accepted or rejected. If such a PEP is not written and c

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Changes by Sridhar Ratnakumar : -- nosy: +srid ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > 1. [TARGETDIR] will stay on the path. I think that is fine, since the > python.exe will be gone, so will never be executed. Do you agree? Completely disagree. Adding something to PATH is nearly unacceptable clutter even during installa

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Jason Spiro <[EMAIL PROTECTED]> added the comment: Martin, at the time I read the python-list thread, I didn't pay any attention to the posts' authors. Only now did I realize you were one of the posters. Oops. I already know the basic ideas about creating MSIs with Wise from a past job. So

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: I still don't think such a change should be made, hence I reject this report as "won't fix". Discussion shouldn't start again on this matter until there is an actual patch to review. -- resolution: -> wont fix status: open -> closed

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

New submission from Jason Spiro <[EMAIL PROTECTED]>: The Python Windows installer[1] should automatically add the Python and Scripts directories to the PATH environment variable. (If you like, you can also provide a checkbox in the installer GUI that users can uncheck if they don't want this