On Fri, Feb 12, 2021 at 01:37:18PM -0800, Alistair Francis wrote:
> On Thu, Feb 11, 2021 at 12:36 AM Sai Pavan Boddu
> wrote:
> >
> > Configuring SDHCI-0 to act as eMMC controller.
> >
> > Signed-off-by: Sai Pavan Boddu
>
> Reviewed-by: Alistair Francis
>
> Alistair
Hi Sai,
It would be gre
From: Peter Krempa
Bitmap's source persistence is transported over the migration stream and
the destination mirrors it. In some cases the destination might want to
persist bitmaps which are not persistent on the source (e.g. the result
of merging bitmaps from a number of layers on the source when
From: Vladimir Sementsov-Ogievskiy
The recommended use of qemu error api assumes returning status together
with setting errp and avoid void functions with errp parameter. Let's
improve bdrv_append and some friends to reduce error-propagation
overhead in further patches.
Choose int return status,
From: Vladimir Sementsov-Ogievskiy
Now bdrv_append returns status and we can drop all the local_err things
around it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Message-Id: <20210202124956.63146-3-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block.c
From: Peter Krempa
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so pass a copy of the whole
BitmapMigrationBitmapAlias QAPI struct into the map.
Signed-off-by: Pete
From: Peter Krempa
Verify that the modification of the bitmap persistence over migration
which is controlled via BitmapMigrationBitmapAliasTransform works
properly.
Based on TestCrossAliasMigration
Signed-off-by: Peter Krempa
Message-Id:
Reviewed-by: Eric Blake
[eblake: Adjust test for expl
On 2/2/21 6:49 AM, Vladimir Sementsov-Ogievskiy wrote:
> This patch is generated by cocci script:
>
> @@
> symbol bdrv_open_child, errp, local_err;
> expression file;
> @@
>
> file = bdrv_open_child(...,
> -&local_err
> +errp
>
On 2/2/21 6:49 AM, Vladimir Sementsov-Ogievskiy wrote:
> Set errp always on failure. Generic bdrv_open_driver supports driver
> functions which can return negative value and forget to set errp.
> That's a strange thing.. Let's improve bdrv_qed_do_open to not behave
> this way. This allows to simpli
On Thu, Feb 11, 2021 at 12:15 AM Sai Pavan Boddu
wrote:
>
> From: Joel Stanley
>
> This assumes a specially constructued image:
>
> dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M
> dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc
> dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc c
On Thu, Feb 11, 2021 at 12:34 AM Sai Pavan Boddu
wrote:
>
> Embedded device slots should be allowed as support of eMMC is available.
>
> Signed-off-by: Sai Pavan Boddu
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/sd/sdhci.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/
On Thu, Feb 11, 2021 at 12:25 AM Sai Pavan Boddu
wrote:
>
> From: Joel Stanley
>
> The userdata size is derived from the file the user passes on the
> command line, but we must take into account the boot areas.
>
> Signed-off-by: Joel Stanley
> Signed-off-by: Cédric Le Goater
Acked-by: Alistai
On Thu, Feb 11, 2021 at 12:30 AM Sai Pavan Boddu
wrote:
>
> CID structure is little different for eMMC, w.r.t to product name and
> manufacturing date.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
> ---
> hw/sd/sd.c | 52 +++--
On Thu, Feb 11, 2021 at 12:19 AM Sai Pavan Boddu
wrote:
>
> Add CMD35 and CMD36 which sets the erase start and end.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
> ---
> hw/sd/sd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index
On Thu, Feb 11, 2021 at 12:18 AM Sai Pavan Boddu
wrote:
>
> eMMC is expected to be in idle-state post CMD1. Ready state is an
> intermediate stage which we don't come across in Device identification
> mode.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
Acked-by: Alistair
On Thu, Feb 11, 2021 at 12:17 AM Sai Pavan Boddu
wrote:
>
> Add support to Power up the card and send response r3 in case of eMMC.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
Acked-by: Alistair Francis
Alistair
> ---
> hw/sd/sd.c | 10 +-
> 1 file changed,
On Thu, Feb 11, 2021 at 12:36 AM Sai Pavan Boddu
wrote:
>
> Configuring SDHCI-0 to act as eMMC controller.
>
> Signed-off-by: Sai Pavan Boddu
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/arm/xlnx-versal-virt.c | 16 +++-
> hw/arm/xlnx-versal.c | 14 --
> 2 f
On Thu, Feb 11, 2021 at 12:22 AM Sai Pavan Boddu
wrote:
>
> OCR.CARD_CAPACITY field is only valid for sd cards, So skip it for eMMC.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/sd/sd.c | 3 ++-
> 1 file changed, 2 i
On Thu, Feb 11, 2021 at 12:15 AM Sai Pavan Boddu
wrote:
>
> From: Vincent Palatin
>
> Add new block device type.
>
> Signed-off-by: Vincent Palatin
> [SPB: Rebased over 5.1 version]
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Joel Stanley
> Signed-off-by: Cédric Le Goater
Reviewed-by:
From: Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-10-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block/backup.c | 10 ++
1 file cha
From: Vladimir Sementsov-Ogievskiy
Just stop waiting for connection in existing requests.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-3-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block/nbd.c | 15 +++
1 file
From: Vladimir Sementsov-Ogievskiy
We are going to add more test cases, so use the library supporting test
cases.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-7-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotest
From: Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-11-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/264 | 2
This gives us better feature parity with QMP nbd-server-start, where
max-connections defaults to 0 for unlimited.
Signed-off-by: Eric Blake
Message-Id: <20210209152759.209074-3-ebl...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
docs/tools/qemu-nbd.rst | 4 ++--
qemu-nbd.c | 6 +
From: Vladimir Sementsov-Ogievskiy
To be used in mirror in the following commit to cancel in-flight io on
target to not waste the time.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210205163720.887197-5-vsement...@virtuozzo.com>
Reviewed-by: Eric Blake
Signed-off-by: Eric Blake
From: Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-9-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/264 | 38
From: Vladimir Sementsov-Ogievskiy
To not interfere with other qemu_nbd_popen() calls in same test.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-8-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/iotests.py |
From: Vladimir Sementsov-Ogievskiy
We are going to cancel in-flight requests on mirror nbd target on job
cancel. Still nbd is often used not directly but as raw-format child.
So, add pass-through handler here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <202
From: Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-6-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block/mirror.c | 9 +
1 file change
Our default of a backlog of 1 connection is rather puny; it gets in
the way when we are explicitly allowing multiple clients (such as
qemu-nbd -e N [--shared], or nbd-server-start with its default
"max-connections":0 for unlimited), but is even a problem when we
stick to qemu-nbd's default of only
From: Vladimir Sementsov-Ogievskiy
It will be used to stop retrying NBD requests on mirror cancel.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-2-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
include/block/block.h | 3 +
From: Max Reitz
Commit 69b55e03f has changed an error message, adjust the reference
output to account for it.
Fixes: 69b55e03f7e65a36eb954d0b7d4698b258df2708
("block: refactor bdrv_check_request: add errp")
Signed-off-by: Max Reitz
Message-Id: <20210209181923.497688-1-mre...@redhat.com>
On 2/5/21 5:52 AM, Vladimir Sementsov-Ogievskiy wrote:
> 05.02.2021 14:43, Alberto Garcia wrote:
>> On Tue 02 Feb 2021 01:49:50 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>> -Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs,
>>> -
On 2/12/21 11:34 AM, Peter Krempa wrote:
> Verify that the modification of the bitmap persistence over migration
> which is controlled via BitmapMigrationBitmapAliasTransform works
> properly.
>
> Based on TestCrossAliasMigration
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemu-iotests/300
On 2/12/21 11:34 AM, Peter Krempa wrote:
> See 2/2 for explanation.
>
> Peter Krempa (3):
> migration: dirty-bitmap: Convert alias map inner members to
> BitmapMigrationBitmapAlias
> migration: dirty-bitmap: Allow control of bitmap persistence
> qemu-iotests: 300: Add test case for modif
On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote:
> We are going to switch the 'null-co' default 'read-zeroes' value
> from FALSE to TRUE in the next commit. First explicit the FALSE
> value when it is not set.
>
> Suggested-by: Eric Blake
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> +++ b/t
On 2/12/21 11:34 AM, Peter Krempa wrote:
> Bitmap's source persistence is transported over the migration stream and
> the destination mirrors it. In some cases the destination might want to
> persist bitmaps which are not persistent on the source (e.g. the result
> of merge of bitmaps from a number
On Fri, Feb 12, 2021 at 12:38:10 -0600, Eric Blake wrote:
> On 2/12/21 11:34 AM, Peter Krempa wrote:
>
> Long subject line; if it's okay with you, I'd prefer to use:
>
> migration: dirty-bitmap: Use struct for alias map inner members
>
> > Currently the alias mapping hash stores just strings of
On 2/12/21 11:34 AM, Peter Krempa wrote:
Long subject line; if it's okay with you, I'd prefer to use:
migration: dirty-bitmap: Use struct for alias map inner members
> Currently the alias mapping hash stores just strings of the target
> objects internally. In further patches we'll be adding anot
On 2/5/21 10:37 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> The problem
>
> Assume we have mirror job with nbd target node with enabled reconnect.
> Connection failed. So, all current requests to nbd node are waiting for
> nbd driver to reconnect. And they will wait for reconnect-delay
Patchew URL: https://patchew.org/QEMU/cover.1613150869.git.pkre...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1613150869.git.pkre...@redhat.com
Subject: [PATCH v3 0/3] migration: dirty-bitmap: Allo
Verify that the modification of the bitmap persistence over migration
which is controlled via BitmapMigrationBitmapAliasTransform works
properly.
Based on TestCrossAliasMigration
Signed-off-by: Peter Krempa
---
tests/qemu-iotests/300 | 91 ++
tests/qemu-i
See 2/2 for explanation.
Peter Krempa (3):
migration: dirty-bitmap: Convert alias map inner members to
BitmapMigrationBitmapAlias
migration: dirty-bitmap: Allow control of bitmap persistence
qemu-iotests: 300: Add test case for modifying persistence of bitmap
migration/block-dirty-bitm
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so pass a copy of the whole
BitmapMigrationBitmapAlias QAPI struct into the map.
Signed-off-by: Peter Krempa
---
migrat
Bitmap's source persistence is transported over the migration stream and
the destination mirrors it. In some cases the destination might want to
persist bitmaps which are not persistent on the source (e.g. the result
of merge of bitmaps from a number of layers on the source when migrating
into a sq
On 2/5/21 10:37 AM, Vladimir Sementsov-Ogievskiy wrote:
> To be used in mirror in the following commit to cancel in-flight io on
> target to not waste the time.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/qemu/job.h | 5 +
> job.c | 3 +++
> 2 files changed,
On 2/5/21 10:37 AM, Vladimir Sementsov-Ogievskiy wrote:
> Just stop waiting for connection in existing requests.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Eric Blake
> ---
> block/nbd.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/block/nbd.c b
On 2/10/21 10:53 AM, Peter Krempa wrote:
> Bitmap's source persistance is transported over the migration stream and
persistence
> the destination mirrors it. In some cases the destination might want to
> persist bitmaps which are not persistent on the source (e.g. the result
> of merge of bitmaps
On Wed, Feb 10, 2021 at 18:26:57 +0100, Kevin Wolf wrote:
> Am 08.02.2021 um 19:44 hat Alberto Garcia geschrieben:
> > Hi,
> >
> > this series allows changing bs->file using x-blockdev-reopen. Read
> > here for more details:
> >
> >https://lists.gnu.org/archive/html/qemu-block/2021-01/msg0043
On 2/11/21 4:42 PM, Alexander Bulekov wrote:
> On 210211 1526, Philippe Mathieu-Daudé wrote:
>> The null-co driver doesn't zeroize buffer in its default config,
>> because it is designed for testing and tests want to run fast.
>> However this confuses security researchers (access to uninit
>> buffe
On Thu, Feb 11, 2021 at 8:48 PM Philippe Mathieu-Daudé wrote:
>
> On 2/11/21 9:52 AM, Mauro Matteo Cascella wrote:
> > Hello,
> >
> > On Wed, Feb 10, 2021 at 11:27 PM Alistair Francis
> > wrote:
> >>
> >> On Tue, Feb 9, 2021 at 2:55 AM Bin Meng wrote:
> >>>
> >>> At the end of sdhci_send_comman
Am 03.02.2021 um 08:45 hat Vladimir Sementsov-Ogievskiy geschrieben:
> subject should start with [PATCH v5]
>
> 03.02.2021 05:40, 08005...@163.com wrote:
> > From: Michael Qiu
> >
> > v5: reformat the commit log with backtrace of main thread
> > Add a boolean variable to make main thread co
Am 10.02.2021 um 10:51 hat Max Reitz geschrieben:
> To disallow certain refcount_bits values, some _unsupported_imgopts
> invocations look like "refcount_bits=1[^0-9]", i.e. they match an
> integer boundary with [^0-9]. This expression does not match the end of
> the string, though, so it breaks d
On 12.02.21 11:25, Kevin Wolf wrote:
Am 12.02.2021 um 10:14 hat Max Reitz geschrieben:
On 11.02.21 21:38, Vladimir Sementsov-Ogievskiy wrote:
11.02.2021 20:22, Max Reitz wrote:
We have repeatedly received reports that SEEK_HOLE and SEEK_DATA are
slow on certain filesystems and/or under certain
12.02.2021 01:40, Eric Blake wrote:
On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote:
We are going to switch the 'null-co' default 'read-zeroes' value
from FALSE to TRUE in the next commit. First explicit the FALSE
value when it is not set.
Grammar suggestion, along with a suggestion for an ad
12.02.2021 12:23, Max Reitz wrote:
On 12.02.21 10:04, Vladimir Sementsov-Ogievskiy wrote:
11.02.2021 20:22, Max Reitz wrote:
mirror_top currently shares all permissions, and takes only the WRITE
permission (if some parent has taken that permission, too).
That is wrong, though; mirror_top is a
Am 12.02.2021 um 10:14 hat Max Reitz geschrieben:
> On 11.02.21 21:38, Vladimir Sementsov-Ogievskiy wrote:
> > 11.02.2021 20:22, Max Reitz wrote:
> > > We have repeatedly received reports that SEEK_HOLE and SEEK_DATA are
> > > slow on certain filesystems and/or under certain circumstances. That is
On 11.02.21 21:00, Eric Blake wrote:
On 2/11/21 11:22 AM, Max Reitz wrote:
We have repeatedly received reports that SEEK_HOLE and SEEK_DATA are
slow on certain filesystems and/or under certain circumstances. That is
why we generally try to avoid it (which is why bdrv_co_block_status()
has the @
On 12.02.21 10:04, Vladimir Sementsov-Ogievskiy wrote:
11.02.2021 20:22, Max Reitz wrote:
mirror_top currently shares all permissions, and takes only the WRITE
permission (if some parent has taken that permission, too).
That is wrong, though; mirror_top is a filter, so it should take
permission
11.02.2021 20:22, Max Reitz wrote:
mirror_top currently shares all permissions, and takes only the WRITE
permission (if some parent has taken that permission, too).
That is wrong, though; mirror_top is a filter, so it should take
permissions like any other filter does. For example, if the paren
On 11.02.21 21:38, Vladimir Sementsov-Ogievskiy wrote:
11.02.2021 20:22, Max Reitz wrote:
We have repeatedly received reports that SEEK_HOLE and SEEK_DATA are
slow on certain filesystems and/or under certain circumstances. That is
why we generally try to avoid it (which is why bdrv_co_block_sta
60 matches
Mail list logo
