[PULL 5/8] tests/qtest/intel-hda-test: Add reproducer for issue #542

2022-03-21 Thread Thomas Huth
: AddressSanitizer: stack-overflow softmmu/physmem.c:356 in address_space_translate_internal ==1580408==ABORTING Broken pipe Aborted (core dumped) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Thomas Huth Message-Id: <20211218160912.1591633-4-phi...@redhat.com> Signed-off-by: Thoma

[PULL 8/8] tests/qtest/fuzz-sdcard-test: Add reproducer for OSS-Fuzz (Issue 29225)

2022-03-21 Thread Thomas Huth
fd ==447470==ABORTING Broken pipe ERROR qtest-i386/fuzz-sdcard-test - too few tests run (expected 3, got 2) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Thomas Huth Message-Id: <20211215205656.488940-4-phi...@redhat.com> [thuth: Replaced "-m 4G" with "-m 512M"

[PULL 6/8] hw/sd/sdhci: Honor failed DMA transactions

2022-03-21 Thread Thomas Huth
hieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20211215205656.488940-2-phi...@redhat.com> Signed-off-by: Thomas Huth --- hw/sd/sdhci.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index e0bbc90344..fe2f21f

Re: [PATCH v3 0/4] Improve integration of iotests in the meson test harness

2022-03-21 Thread Thomas Huth
On 21/03/2022 17.14, Hanna Reitz wrote: On 23.02.22 10:38, Thomas Huth wrote: Though "make check-block" is currently already run via the meson test runner, it still looks like an oddball in the output of "make check". It would be nicer if the iotests would show up like th

Re: [PATCH v2 0/3] iotests: Check for zstd support

2022-03-22 Thread Thomas Huth
and 303 on my system! Series Tested-by: Thomas Huth

Re: [PATCH] iotests: update test owner contact information

2022-03-23 Thread Thomas Huth
whether these "owner" lines really still make that much sense if they are neglected that much, or whether the information should maybe rather be captured in MAINTAINERS instead? Anyway: Reviewed-by: Thomas Huth

[PATCH] tests/qtest: Run the fuzz-sdcard-test only on i386 and x86_64

2022-04-14 Thread Thomas Huth
3 spaces instead of 4 in some lines). Signed-off-by: Thomas Huth --- tests/qtest/fuzz-sdcard-test.c | 6 +++--- tests/qtest/meson.build| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qtest/fuzz-sdcard-test.c b/tests/qtest/fuzz-sdcard-test.c index 0f94965a66

Re: [PATCH] tests/qtest: Run the fuzz-sdcard-test only on i386 and x86_64

2022-04-14 Thread Thomas Huth
On 14/04/2022 14.28, Thomas Huth wrote: The fuzz-sdcard-test is currently scheduled for all targets, but the code limits itself to "i386". Move it to the right list in meson.build and allow it to be run on "x86_64", too. While we're at it, also clean up the wrong i

[PATCH] tests/qtest: Move the fuzz tests to x86 only

2022-04-14 Thread Thomas Huth
The fuzz tests are currently scheduled for all targets, but their setup code limits the run to "i386", so that these tests always show "SKIP" on other targets. Move it to the right x86 list in meson.build, then we can drop the architecture check during runtime, too. Signed

Re: [PATCH 28/41] Use QEMU_SANITIZE_ADDRESS

2022-04-20 Thread Thomas Huth
On 20/04/2022 15.26, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/qtest/fdc-test.c| 2 +- util/coroutine-ucontext.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/fdc-test.c b/tests/qtest/fdc-t

Re: [PATCH 04/10] tests: move libqtest.h back under qtest/

2022-04-25 Thread Thomas Huth
ith libqos/. Suggested-by: Thomas Huth Signed-off-by: Marc-André Lureau --- docs/devel/qtest.rst | 2 +- tests/qtest/acpi-utils.h | 2 +- tests/qtest/boot-sector.h| 2 +- tests/qtest/fuzz/fuzz.h | 2

Re: [PATCH v2 02/26] Use QEMU_SANITIZE_ADDRESS

2022-04-27 Thread Thomas Huth
30,7 +30,7 @@ #include #endif -#if defined(__SANITIZE_ADDRESS__) || __has_feature(address_sanitizer) +#ifdef QEMU_SANITIZE_ADDRESS #ifdef CONFIG_ASAN_IFACE_FIBER #define CONFIG_ASAN 1 #include Reviewed-by: Thomas Huth

Re: [PATCH 03/16] tests: make libqmp buildable for win32

2022-05-04 Thread Thomas Huth
On 04/05/2022 19.30, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/qtest/libqmp.h | 2 ++ tests/qtest/libqmp.c | 35 +-- 2 files changed, 31 insertions(+), 6 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 1/2] tests/qemu-iotests: print intent to run a test in TAP mode

2022-05-09 Thread Thomas Huth
if mp else '\r') +else: +testname = os.path.basename(test) +print(f'# running {self.env.imgfmt} {testname}') res = self.do_run_test(test, mp) Reviewed-by: Thomas Huth I wonder whether we should flush stdout, too?

Re: [PATCH 2/2] .gitlab-ci.d: export meson testlog.txt as an artifact

2022-05-09 Thread Thomas Huth
log.txt + .avocado_test_job_template: - extends: .native_test_job_template + extends: .common_test_job_template cache: key: "${CI_JOB_NAME}-cache" paths: Reviewed-by: Thomas Huth

Re: [PATCH v3] hw: m25p80: allow write_enable latch get/set

2022-05-13 Thread Thomas Huth
makes it a modifiable property. Signed-off-by: Iris Chen --- v3: Addressed comments by Peter and Cedric. v2: Ran ./scripts/checkpatch.pl on the patch and added a description. Fixed comments regarding DEFINE_PROP_BOOL. Acked-by: Thomas Huth

Re: [PATCH v2 2/2] hw: m25p80: add tests for write protect

2022-06-08 Thread Thomas Huth
==, SRWD); + +qtest_set_irq_in(global_qtest, + "/machine/soc/fmc/ssi.0/child[0]", "WP#", 0, 1); +flash_reset(); +} FWIW, I'd prefer if we could use qtest_writeb / qtest_readb for new code instead of writeb / readb, but well, the whole file is already written that way, so this is only "consistent" ... so: Acked-by: Thomas Huth

Re: [PATCH 4/5] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-13 Thread Thomas Huth
On 14/06/2022 03.50, John Snow wrote: The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow --- tests/vm/centos | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 3/5] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-06-13 Thread Thomas Huth
I wonder whether it would make sense to use "qemu-img create -b" instead to save some disk space? Anyway, your patch is certainly already an improvement, so: Reviewed-by: Thomas Huth

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-13 Thread Thomas Huth
On 14/06/2022 03.50, John Snow wrote: In certain container environments we may not have FUSE at all, so skip the test in this circumstance too. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/108 b/tests/qemu-io

Re: [PATCH] qemu-iotests: Discard stderr when probing devices

2022-06-13 Thread Thomas Huth
's/".*$//') for device do Reviewed-by: Thomas Huth

Re: [PATCH v2 03/10] qga: treat get-guest-fsinfo as "best effort"

2022-06-17 Thread Thomas Huth
On 16/06/2022 16.43, John Snow wrote: On Thu, Jun 16, 2022 at 10:36 AM Marc-André Lureau wrote: Hi On Thu, Jun 16, 2022 at 6:27 PM John Snow wrote: In some container environments, there may be references to block devices witnessable from a container through /proc/self/mountinfo that refere

Re: [PATCH v2 08/10] tests/vm: remove ubuntu.i386 VM test

2022-06-17 Thread Thomas Huth
ts/vm/ubuntu.i386 Reviewed-by: Thomas Huth

Re: [PATCH v2 02/10] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-17 Thread Thomas Huth
+_notrun 'No passwordless sudo nor usable /dev/fuse' +fi + # QSD --export fuse will either yield "Parameter 'id' is missing" # or "Invalid parameter 'fuse'", depending on whether there is # FUSE support or not. Reviewed-by: Thomas Huth

Re: [PATCH v2 09/10] tests/vm: remove duplicate 'centos' VM test

2022-06-17 Thread Thomas Huth
:= freebsd netbsd openbsd centos fedora haiku.x86_64 +X86_IMAGES := freebsd netbsd openbsd fedora haiku.x86_64 ifneq ($(GENISOIMAGE),) X86_IMAGES += centos ifneq ($(EFI_AARCH64),) Reviewed-by: Thomas Huth

Re: [PATCH v7 4/6] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-13 Thread Thomas Huth
On 13/03/2023 09.24, Alexander Bulekov wrote: This protects devices from bh->mmio reentrancy issues. Thanks: Thomas Huth for diagnosing OS X test failure. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Paul Durrant Signed-off

Re: [PATCH v2 05/32] gitlab: update centos-8-stream job

2023-03-17 Thread Thomas Huth
some comments to the top about setup Signed-off-by: Alex Bennée --- .../custom-runners/centos-stream-8-x86_64.yml | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 31/32] contrib/gitdm: add more individual contributors

2023-03-17 Thread Thomas Huth
m/group-map-individuals @@ -38,3 +38,4 @@ p...@nowt.org g...@xen0n.name si...@simonsafar.com research_tra...@irq.a4lg.com +shen...@gmail.com FWIW: Reviewed-by: Thomas Huth

Re: [PATCH v2 02/32] tests/docker: all add DOCKER_BUILDKIT to RUNC environment

2023-03-17 Thread Thomas Huth
-cache, \ $(if $(DOCKER_REGISTRY),--cache-from $(DOCKER_REGISTRY)/qemu/$*)) \ Reviewed-by: Thomas Huth

Re: [PATCH v2 07/32] tests/tcg: add some help output for running individual tests

2023-03-17 Thread Thomas Huth
: help +help: + @echo "TCG tests help $(TARGET_NAME)" + @echo "Built with $(CC)" + @echo "Available tests:" + @$(foreach t,$(RUN_TESTS),echo " $t";) Reviewed-by: Thomas Huth

Re: [PATCH v2 06/32] include/qemu: add documentation for memory callbacks

2023-03-17 Thread Thomas Huth
deletions(-) Reviewed-by: Thomas Huth

Re: test-blockjob: intermittent CI failures in msys2-64bit job

2023-03-17 Thread Thomas Huth
On 17/03/2023 11.17, Peter Maydell wrote: On Mon, 6 Mar 2023 at 11:16, Peter Maydell wrote: On Fri, 3 Mar 2023 at 18:36, Peter Maydell wrote: I've noticed that test-blockjob seems to fail intermittently on the msys2-64bit job: https://gitlab.com/qemu-project/qemu/-/jobs/3872508803 https://

Re: [PATCH v3] hw/block: replace TABs with space

2023-03-24 Thread Thomas Huth
+- hw/block/nand.c | 222 +++ hw/block/onenand.c | 128 +++--- hw/block/tc58128.c | 136 include/hw/block/flash.h | 20 ++-- 5 files changed, 255 insertions(+), 255 deletions(-) Reviewed-by: Thomas

Re: [PATCH v2] hw/ide: replace TABs with space

2023-03-24 Thread Thomas Huth
+-- hw/ide/core.c | 84 - hw/ide/microdrive.c | 360 +++--- include/hw/ide/internal.h | 248 +- 4 files changed, 360 insertions(+), 360 deletions(-) Reviewed-by: Thomas Huth PS: Please make sure to always CC: qemu

Re: s390x TCG migration failure

2023-03-28 Thread Thomas Huth
On 24/03/2023 19.41, Nina Schoetterl-Glausch wrote: Hi, We're seeing failures running s390x migration kvm-unit-tests tests with TCG. Some initial findings: What seems to be happening is that after migration a control block header accessed by the test code is all zeros which causes an unexpected

Re: s390x TCG migration failure

2023-03-28 Thread Thomas Huth
On 29/03/2023 00.21, Nina Schoetterl-Glausch wrote: On Tue, 2023-03-28 at 15:01 +0200, Thomas Huth wrote: On 24/03/2023 19.41, Nina Schoetterl-Glausch wrote: Hi, We're seeing failures running s390x migration kvm-unit-tests tests with TCG. Some initial findings: What seems to be happeni

Re: [PATCH v2 7/8] iotests: register each I/O test separately with meson

2023-03-29 Thread Thomas Huth
On 03/03/2023 17.07, Daniel P. Berrangé wrote: Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson. There are various downsides of doing this * You cannot ask 'meson test' to invoke a single I/O test * The meson test timeo

Re: [PATCH v2 7/8] iotests: register each I/O test separately with meson

2023-03-29 Thread Thomas Huth
On 29/03/2023 13.18, Daniel P. Berrangé wrote: On Wed, Mar 29, 2023 at 12:47:51PM +0200, Thomas Huth wrote: On 03/03/2023 17.07, Daniel P. Berrangé wrote: Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson. There are

Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Thomas Huth
ed-off-by: Alex Bennée Cc: Thomas Huth Cc: Daniel P. Berrangé Cc: Markus Armbruster Cc: Kashyap Chamarthy Cc: Paolo Bonzini Cc: Peter Maydell Cc: Philippe Mathieu-Daudé Cc: Bernhard Beschow --- v2 - s/your/you are/ - add some willing victims --- MAINTAINERS | 13 + 1 f

Re: [PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

2023-03-30 Thread Thomas Huth
+which is useful in the majority of cases. Older options like ``-hda`` +bake in a lot of assumptions from the days when QEMU was emulating a +legacy PC, they are not recommended for modern configurations. Reviewed-by: Thomas Huth

Re: [PATCH 05/11] metadata: add .git-blame-ignore-revs

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: Someone mentioned this on IRC so I thought I would try it out with a few commits that are pure code style fixes. Signed-off-by: Alex Bennée Message-Id: <20230318115657.1345921-1-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phili

Re: [PATCH 07/11] tests/qemu-iotests: explicitly invoke 'check' via 'python'

2023-03-30 Thread Thomas Huth
take as long as 45 seconds # Bump the timeout to 3 minutes for some headroom # on slow machines to minimize spurious failures test('io-' + format + '-' + item, - qemu_iotests_check_cmd, + python, args: args, depends: qemu_iotests_binaries, env: qemu_iotests_env, Reviewed-by: Thomas Huth

Re: [PATCH 08/11] tests/vm: use the default system python for NetBSD

2023-03-30 Thread Thomas Huth
ar -xf /dev/rld1a; cd ../build -../src/configure --python=python3.7 --disable-opengl {configure_opts}; +../src/configure --disable-opengl {configure_opts}; gmake --output-sync -j{jobs} {target} {verbose}; """ poweroff = "/sbin/poweroff" Reviewed-by: Thomas Huth

Re: [PATCH 10/11] gitlab: fix typo

2023-03-30 Thread Thomas Huth
/base.yml @@ -75,5 +75,5 @@ - if: '$QEMU_CI != "2" && $CI_PROJECT_NAMESPACE != "qemu-project"' when: manual -# Jobs can run if any jobs they depend on were successfull +# Jobs can run if any jobs they depend on were successful -

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the same as the one being passed to it by the avocado user (i.e. the avocado_qemu python module). In the ear

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Thomas Huth
On 30/03/2023 14.12, Alex Bennée wrote: Thomas Huth writes: On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the same as the one being passed to

Re: [PATCH 11/11] tests/gitlab: use kaniko to build images

2023-03-30 Thread Thomas Huth
er" "." -- docker push "$TAG" - after_script: -- docker logout +- /kaniko/executor + --reproducible + --context "${CI_PROJECT_DIR}" + --cache=true + --cache-repo "${COMMON_TAG}" + --dockerfile "${CI_PROJECT_DIR}/tests/docker/dockerfiles/$NAME.docker" + --destination "${TAG}" Acked-by: Thomas Huth

Re: [PATCH 01/11] scripts/coverage: initial coverage comparison script

2023-03-30 Thread Thomas Huth
ually providing additional coverage or just burning our precious CI time. Signed-off-by: Alex Bennée FWIW: Acked-by: Thomas Huth

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-31 Thread Thomas Huth
On 30/03/2023 14.21, Thomas Huth wrote: On 30/03/2023 14.12, Alex Bennée wrote: Thomas Huth writes: On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn&#

Re: [PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

2023-04-03 Thread Thomas Huth
On 03/04/2023 16.55, Markus Armbruster wrote: Alex Bennée writes: Markus Armbruster writes: Alex Bennée writes: ... I was under the impression things like -hda wouldn't work say on an Arm machine because you don't know what sort of interface you might be using and -hda implies IDE. Where

Re: s390x TCG migration failure

2023-04-04 Thread Thomas Huth
On 29/03/2023 08.36, Thomas Huth wrote: On 29/03/2023 00.21, Nina Schoetterl-Glausch wrote: On Tue, 2023-03-28 at 15:01 +0200, Thomas Huth wrote: On 24/03/2023 19.41, Nina Schoetterl-Glausch wrote: Hi, We're seeing failures running s390x migration kvm-unit-tests tests with TCG.

Re: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-23 Thread Thomas Huth
On 24/04/2023 07.58, Juan Quintela wrote: "Zhang, Chen" wrote: -Original Message- From: Daniel P. Berrangé Sent: Saturday, April 22, 2023 1:14 AM To: qemu-de...@nongnu.org Cc: qemu-block@nongnu.org; Paolo Bonzini ; Thomas Huth ; John Snow ; Li Zhijian ; Juan Quintela ; Stefa

Re: [PATCH v8 8/8] memory: abort on re-entrancy in debug builds

2023-04-25 Thread Thomas Huth
_io; if (bh->reentrancy_guard->engaged_in_io) { trace_reentrant_aio(bh->ctx, bh->name); +#ifdef DEBUG +abort(); +#endif } bh->reentrancy_guard->engaged_in_io = true; } Reviewed-by: Thomas Huth

Re: [PATCH v9 7/8] memory: abort on re-entrancy in debug builds

2023-04-27 Thread Thomas Huth
On 27/04/2023 16.44, Alexander Bulekov wrote: On 230426 1219, Alexander Bulekov wrote: This is useful for using unit-tests/fuzzing to detect bugs introduced by the re-entrancy guard mechanism into devices that are intentionally re-entrant. Signed-off-by: Alexander Bulekov Reviewed-by: Thomas

Re: [PATCH] async: avoid use-after-free on re-entrancy guard

2023-05-02 Thread Thomas Huth
{ +reentrancy_guard->engaged_in_io = last_engaged_in_io; } } Reviewed-by: Thomas Huth I'll assemble a pull request with this later today, to avoid that people run into this regression. Thomas

Re: [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

2023-05-04 Thread Thomas Huth
-test.c is updated to use and check for existence of only xorrisofs. CC: m...@redhat.com CC: berra...@redhat.com Signed-off-by: Ani Sinha --- Reviewed-by: Thomas Huth

Re: [PATCH 01/11] softmmu: Introduce qemu_target_page_mask/qemu_target_page_align helpers

2023-05-23 Thread Thomas Huth
Mathieu-Daudé --- include/exec/target_page.h | 2 ++ softmmu/physmem.c | 10 ++ 2 files changed, 12 insertions(+) Reviewed-by: Thomas Huth

Re: [PATCH 02/11] hw/scsi: Introduce VHOST_SCSI_COMMON symbol in Kconfig

2023-05-23 Thread Thomas Huth
eson.build | 6 -- 2 files changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 03/11] hw/scsi: Rearrange meson.build

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: We will modify this file shortly. Re-arrange it slightly first, declaring source sets first. No logical change. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/meson.build | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)

Re: [PATCH 05/11] hw/virtio: Introduce VHOST_VSOCK_COMMON symbol in Kconfig

2023-05-24 Thread Thomas Huth
hw/virtio/meson.build | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 07/11] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: Instead of having "virtio/virtio-bus.h" implicitly included, explicit it, to avoid when rearranging headers: s/explicit it/explicitly include it/ ? With that change: Reviewed-by: Thomas Huth

Re: [PATCH 08/11] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask()

2023-05-24 Thread Thomas Huth
vfio realize */ s->config.bypass = s->boot_bypass; -s->config.page_size_mask = TARGET_PAGE_MASK; +s->config.page_size_mask = qemu_target_page_mask(); s->config.input_range.end = UINT64_MAX; s->config.domain_range.end = UINT32_MAX; s->config.probe_size = VIOMMU_PROBE_SIZE; Reviewed-by: Thomas Huth

Re: [PATCH 09/11] hw/virtio: Remove unnecessary 'virtio-access.h' header

2023-05-24 Thread Thomas Huth
Very good catch! I checked that it compiles and links fine with this change, so: Tested-by: Thomas Huth

Re: [PATCH 10/11] hw/virtio: Build various target-agnostic objects just once

2023-05-24 Thread Thomas Huth
hw/block/dataplane/meson.build | 2 +- hw/scsi/meson.build| 10 +++--- hw/virtio/meson.build | 11 ++- 3 files changed, 14 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [RFC PATCH 11/11] hw/virtio: Make vhost-vdpa.c target-agnostic to build it once

2023-05-24 Thread Thomas Huth
ener add/del handlers (vhost_vdpa_listener_skipped_section is only called by vhost_vdpa_listener_region_add) which are not hot-path. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/vhost-vdpa.c | 16 hw/virtio/meson.build | 3 ++- 2 files changed, 10 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 03/10] hw/scsi: Rearrange meson.build

2023-05-24 Thread Thomas Huth
, 5 insertions(+), 5 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 04/10] hw/scsi: Rename target-specific source set as 'specific_virtio_scsi_ss'

2023-05-24 Thread Thomas Huth
ned-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/scsi/meson.build | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-05-25 Thread Thomas Huth
On 26/05/2023 07.05, Jeuk Kim wrote: Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI d

Re: io-qcow2 failures on zfs

2023-05-26 Thread Thomas Huth
On 25/05/2023 20.29, Richard Henderson wrote: Ping. On 5/19/23 15:44, Richard Henderson wrote: I'm doing some testing on one of the Linaro build machines and I reliably see Summary of Failures: 712/790 qemu:block / io-qcow2-150 ERROR 5

Re: [PATCH 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-05-29 Thread Thomas Huth
On 30/05/2023 03.36, Jeuk Kim wrote: On 26/05/2023 15:37, Thomas Huth wrote: On 26/05/2023 07.05, Jeuk Kim wrote: Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-21 Thread Thomas Huth
On 12/06/2023 21.33, Juan Quintela wrote: Only "defer" is recommended. After setting all migation parameters, start incoming migration with "migrate-incoming uri" command. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ softmmu/vl.c | 2 ++ 2 files chan

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-21 Thread Thomas Huth
On 12/06/2023 21.33, Juan Quintela wrote: Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json | 92 --- migration/options.c | 13 ++ 3 files changed, 79 insertions(+), 34 deletions(-) diff --git a/doc

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Thomas Huth
On 22/06/2023 10.52, Juan Quintela wrote: Paolo Bonzini wrote: On 6/12/23 22:51, Juan Quintela wrote: Shall we just leave it there? Or is deprecating it helps us in any form? See the patches two weeks ago when people complained that lisen(.., num) was too low. And there are other parameters

Re: [PATCH v2 2/5] migration: migrate 'inc' command option is deprecated.

2023-07-06 Thread Thomas Huth
3 files changed, 23 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 3/5] migration: migrate 'blk' command option is deprecated.

2023-07-06 Thread Thomas Huth
19 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH] hw/nvme: fix endianness issue for shadow doorbells

2023-07-18 Thread Thomas Huth
hosts. Fix this. Solves issue #1765. Fixes: 3f7fe8de3d49 ("hw/nvme: Implement shadow doorbell buffer support") Cc: qemu-sta...@nongnu.org Reported-by: Thomas Huth Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-)

Re: [PATCH] hw/nvme: use stl/ldl pci dma api

2023-07-20 Thread Thomas Huth
insertions(+), 29 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR)

2021-01-12 Thread Thomas Huth
used\n", + __func__, tag); return; } Reviewed-by: Thomas Huth

Re: [PATCH 2/9] configure: Add sys/timex.h to probe clk_adjtime

2021-01-12 Thread Thomas Huth
timex.h is indeed the right header here. Reviewed-by: Thomas Huth

Re: [PATCH 3/9] configure/meson: Only check sys/signal.h on non-Linux

2021-01-12 Thread Thomas Huth
nt of sys/signal.h on Linux + config_host_data.set('HAVE_SYS_SIGNAL_H', cc.has_header('sys/signal.h')) +endif Seems like it sys/signal.h was introduced for OpenBSD once (see commit 128ab2ff50a), so this new check should be fine. Reviewed-by: Thomas Huth

Re: [PATCH 4/9] libvhost-user: Include poll.h instead of sys/poll.h

2021-01-12 Thread Thomas Huth
clude -#include +#include #include #include #include "standard-headers/linux/virtio_ring.h" Reviewed-by: Thomas Huth

Re: [PATCH 5/9] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE

2021-01-12 Thread Thomas Huth
= 0xf780; KernBase -= PAGE_SIZE) { +for (; KernBase >= 0xf780; KernBase -= ELF2DMP_PAGE_SIZE) { nt_start_addr = va_space_resolve(&vs, KernBase); if (!nt_start_addr) { continue; Reviewed-by: Thomas Huth

Re: [PATCH 8/9] tests: Rename PAGE_SIZE definitions

2021-01-12 Thread Thomas Huth
t(rc < PAGE_SIZE); -g_assert(memcmp(test, buffer, PAGE_SIZE) == 0); +rc = xbzrle_decode_buffer(compressed, dlen, test, XBZRLE_PAGE_SIZE); +g_assert(rc < XBZRLE_PAGE_SIZE); +g_assert(memcmp(test, buffer, XBZRLE_PAGE_SIZE) == 0); g_free(buffer); g_free(compressed); Reviewed-by: Thomas Huth

Re: [PATCH 6/9] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE

2021-01-12 Thread Thomas Huth
_write = glue(nand_blk_write_, PAGE_SIZE); -s->blk_load = glue(nand_blk_load_, PAGE_SIZE); +s->blk_erase = glue(nand_blk_erase_, NAND_PAGE_SIZE); +s->blk_write = glue(nand_blk_write_, NAND_PAGE_SIZE); +s->blk_load = glue(nand_blk_load_, NAND_PAGE_SIZE); } -# undef PAGE_SIZE +# undef NAND_PAGE_SIZE # undef PAGE_SHIFT # undef PAGE_SECTORS # undef ADDR_SHIFT Reviewed-by: Thomas Huth

Re: [PATCH 7/9] accel/kvm: avoid using predefined PAGE_SIZE

2021-01-12 Thread Thomas Huth
On 21/12/2020 01.53, Jiaxun Yang wrote: As per POSIX specification of limits.h [1], OS libc may define PAGE_SIZE in limits.h. To prevent collosion of definition, we discard PAGE_SIZE from defined by libc and take QEMU's variable. [1]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.h

Re: [PATCH 2/4] tests/qtest: Make fuzz-test generic to all targets

2021-01-15 Thread Thomas Huth
On 15/01/2021 16.09, Philippe Mathieu-Daudé wrote: Tests in fuzz-test's main() already check for the supported architecture before adding tests, therefore this test is not specific to the X86 target. Move it to the generic set. As long as it does not run any test on non-x86, it does not make se

Re: [PATCH v2 0/9] Alpine Linux build fix and CI pipeline

2021-01-18 Thread Thomas Huth
er patches (Wainer) - Add shadow to dockerfile (Wainer) - Pickup proper signal.h fix (PMM) - Correct clock_adjtime title (Thomas Huth) - Collect review tags Jiaxun Yang (8): configure: Add sys/timex.h to probe clock_adjtime libvhost-user: Include poll.h instead of sys/poll.h hw/block/na

Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline

2021-01-18 Thread Thomas Huth
On 18/01/2021 11.11, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote: We only run build test and check-acceptance as their are too many failures in checks due to minor string mismatch. Can you give real examples of what's broken here, as that sounds rather

Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline

2021-01-18 Thread Thomas Huth
On 18/01/2021 14.37, Jiaxun Yang wrote: On Mon, Jan 18, 2021, at 6:11 PM, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote: We only run build test and check-acceptance as their are too many failures in checks due to minor string mismatch. Can you give re

Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline

2021-01-18 Thread Thomas Huth
On 18/01/2021 15.50, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 03:44:49PM +0100, Thomas Huth wrote: On 18/01/2021 14.37, Jiaxun Yang wrote: On Mon, Jan 18, 2021, at 6:11 PM, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote: We only run build

Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline

2021-01-19 Thread Thomas Huth
On 18/01/2021 16.12, Thomas Huth wrote: On 18/01/2021 15.50, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 03:44:49PM +0100, Thomas Huth wrote: On 18/01/2021 14.37, Jiaxun Yang wrote: On Mon, Jan 18, 2021, at 6:11 PM, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 02:38:08PM +0800

Re: [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux

2021-01-19 Thread Thomas Huth
On 18/01/2021 11.33, Daniel P. Berrangé wrote: On Mon, Jan 18, 2021 at 02:38:07PM +0800, Jiaxun Yang wrote: Alpine Linux[1] is a security-oriented, lightweight Linux distribution based on musl libc and busybox. It it popular among Docker guests and embedded applications. Adding it to test agai

[PATCH] tests/check-block.sh: Refuse to run the iotests with BusyBox' sed

2021-01-19 Thread Thomas Huth
usyBox' sed. Signed-off-by: Thomas Huth --- tests/check-block.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/check-block.sh b/tests/check-block.sh index fb4c1baae9..e4f37905be 100755 --- a/tests/check-block.sh +++ b/tests/check-block.sh @@ -60,6 +60,13 @@ if ! (sed

Re: [PATCH v2 1/2] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-26 Thread Thomas Huth
ry Fleytman diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 16d04625b8b..85682d0dfce 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -4,7 +4,9 @@ subdir_done() endif -qtests_generic = [ +qtests_generic = \ + (config_all_devices.has_key('CONFIG

Re: [PATCH v2 2/2] tests/qtest: Only run fuzz-virtio-scsi when virtio-scsi is available

2021-01-26 Thread Thomas Huth
-megasas-test'] : []) + \ + (config_all_devices.has_key('CONFIG_VIRTIO_SCSI') ? ['fuzz-virtio-scsi-test'] : []) + \ [ 'cdrom-test', 'device-introspect-test', Reviewed-by: Thomas Huth

Re: [PATCH v2 1/2] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-26 Thread Thomas Huth
On 26/01/2021 19.01, Alexander Bulekov wrote: On 210126 1851, Thomas Huth wrote: On 26/01/2021 12.16, Philippe Mathieu-Daudé wrote: This test fails when QEMU is built without the megasas device, restrict it to its availability. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/fuzz

Re: [PATCH] tests/Makefile.include: export PYTHON for check-block.sh

2021-01-29 Thread Thomas Huth
On 29/01/2021 06.13, Vladimir Sementsov-Ogievskiy wrote: check-block.sh called by make check-block rely on PYTHON variable being set. Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5 Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi! As Peter reported, build fails on platforms where python3 is

Re: [PATCH] iotests/testrunner: fix recognition of python tests

2021-01-29 Thread Thomas Huth
except UnicodeDecodeError: # binary test? for future. pass Together with your other patch, this fixes "make vm-build-netbsd" for me, thanks! Tested-by: Thomas Huth

Re: [PATCH] tests/Makefile.include: export PYTHON for check-block.sh

2021-01-29 Thread Thomas Huth
mu-iotests/socket_scm_helper$(EXESUF) check: check-block +export PYTHON check-block: $(SRC_PATH)/tests/check-block.sh qemu-img$(EXESUF) \ qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \ $(filter qemu-system-%, $(ninja-targets)) Tested-by: Thomas Huth

[PATCH 3/4] hw/virtio/virtio-balloon: Remove the "class" property

2021-02-03 Thread Thomas Huth
This property was only required for compatibility reasons in the pc-1.0 machine type and earlier. Now that these machine types have been removed, the property is not useful anymore. Signed-off-by: Thomas Huth --- hw/virtio/virtio-balloon-pci.c | 11 +-- 1 file changed, 1 insertion

<    6   7   8   9   10   11   12   13   14   >