[Qemu-devel] [Bug 979714] Re: The pit interrupt still exists even with tickless guest

2012-05-04 Thread Yongjie Ren
verified. this bug should have been fixed by the following commit. commit 80019541e9c13fab476bee35edcef3e11646222c Author: Jan Kiszka Date: Mon Apr 23 10:47:14 2012 +0200 qemu-kvm: Switch to upstream in-kernel KVM PIT The upstream version provides the same feature plus proper support

[Qemu-devel] [PATCH 1/2] block: make bdrv_create adopt coroutine

2012-05-04 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- block.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 43c794c..5de55fe 100644 --- a/block.c +++ b/block.c @@ -341,13 +341,59 @@ BlockDriver *bdrv_f

Re: [Qemu-devel] [PATCH v2] qcow2: Unlock during COW

2012-05-04 Thread Zhi Yong Wu
On Sat, May 5, 2012 at 8:21 AM, Marc-André Lureau wrote: > Hi > > On Mon, Nov 14, 2011 at 6:55 PM, Kevin Wolf wrote: >> Unlocking during COW allows for more parallelism. One change it requires is >> that buffers are dynamically allocated instead of just using a per-image >> buffer. > > This commi

[Qemu-devel] [PATCH 2/2] qcow2: lock on prealloc

2012-05-04 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- block/qcow2.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 8c60a6f..ee4678f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1192,7 +1192,10 @@ static int qcow2_create2(const cha

[Qemu-devel] [PATCH 1/2] block: make bdrv_create adopt coroutine

2012-05-04 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- block.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 43c794c..3ff78c5 100644 --- a/block.c +++ b/block.c @@ -341,13 +341,59 @@ BlockDriver *bdrv_f

Re: [Qemu-devel] [RFC 0/9] Virtio-mmio refactoring.

2012-05-04 Thread Evgeny Voevodin
On 04.05.2012 17:19, Anthony Liguori wrote: On 05/03/2012 07:14 AM, Peter Maydell wrote: On 25 April 2012 06:54, Evgeny Voevodin wrote: In this patchset refactoring of virtio-mmio layer is made. Instead of creating virtio-blk-mmio, virtio-net-mmio, etc on the system bus we create virtio-blk,

Re: [Qemu-devel] [PATCH v2] qcow2: Unlock during COW

2012-05-04 Thread Marc-André Lureau
Hi On Mon, Nov 14, 2011 at 6:55 PM, Kevin Wolf wrote: > Unlocking during COW allows for more parallelism. One change it requires is > that buffers are dynamically allocated instead of just using a per-image > buffer. This commit introduces failure with preallocation and some sizes: qemu-img cre

Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices

2012-05-04 Thread Kevin O'Connor
On Fri, May 04, 2012 at 05:35:10PM +0200, Gerd Hoffmann wrote: > On 05/04/12 15:15, Kevin O'Connor wrote: > > On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote: > >> seabios used to initialize root bus devices only, with this patch > >> devices behind pci bridges are initialized too. T

Re: [Qemu-devel] [RFC] [PATCH 2/2] Adding basic calls to libseccomp in vl.c

2012-05-04 Thread Andreas Färber
Am 04.05.2012 21:08, schrieb Eduardo Otubo: > I added a syscall struct using priority levels as described in the libseccomp > man page. The priority numbers are based to the frequency they appear in a > sample strace from a regular qemu guest run under libvirt. > > Libseccomp generates linear BPF

[Qemu-devel] [RFC] [PATCH 2/2] Adding basic calls to libseccomp in vl.c

2012-05-04 Thread Eduardo Otubo
I added a syscall struct using priority levels as described in the libseccomp man page. The priority numbers are based to the frequency they appear in a sample strace from a regular qemu guest run under libvirt. Libseccomp generates linear BPF code to filter system calls, those rules are read one

[Qemu-devel] [RFC] [PATCH 1/2] Adding support for libseccomp in configure

2012-05-04 Thread Eduardo Otubo
Adding basic options to the configure script to use libseccomp or not. The default is set to 'no'. If the flag --enable-libseccomp is used, the script will check for its existence using pkg-config. Signed-off-by: Eduardo Otubo --- configure | 23 +++ 1 file changed, 23 inse

[Qemu-devel] [RFC] [PATCH 0/2] Sandboxing Qemu guests with Libseccomp

2012-05-04 Thread Eduardo Otubo
Hello all, This is the first effort to sandboxing Qemu guests using Libseccomp[0]. The patches that follows are pretty simple and straightforward. I added the correct options and checks to the configure script and the basic calls to libseccomp in the main loop at vl.c. Details of each one are in t

[Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-05-04 Thread Jason Baron
Add a command line parameter to not dump guest memory in the core dump, the command line is: -dont-dump-guest. This brought the core dump down from 383MB to 13 MB on a 1GB guest. Signed-off-by: Jason Baron --- exec.c | 13 + osdep.h |7 +++ qemu-options.hx

[Qemu-devel] [PATCH 6/6] qemu-ga: guest-suspend-hybrid: don't emit a success response

2012-05-04 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-hybrid completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should ch

[Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response

2012-05-04 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-shutdown completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for

[Qemu-devel] [PATCH 5/6] qemu-ga: guest-suspend-ram: don't emit a success response

2012-05-04 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-ram completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check

[Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response

2012-05-04 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check

[Qemu-devel] [PATCH 2/6] qemu-ga: don't warn on no command return

2012-05-04 Thread Luiz Capitulino
This is a valid condition when a command chooses to not emit a success response. Signed-off-by: Luiz Capitulino --- qemu-ga.c |2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 216be39..3547119 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -488,8 +488,6 @@ static voi

[Qemu-devel] [PATCH 1/6] qapi: add support for command options

2012-05-04 Thread Luiz Capitulino
Options allow for changes in commands behavior. This commit introduces the QCO_NO_SUCCESS_RESP option, which causes a command to not emit a success response. This is needed by commands such as qemu-ga's guest-shutdown, which may not be able to complete before the VM vanishes. In this case, it's us

[Qemu-devel] [PATCH 0/6]: qemu-ga: no success response for certain commands

2012-05-04 Thread Luiz Capitulino
This series changes qemu-ga to not emit a success response for commands guest-shutdown and guest-suspend-{ram,disk,hybrid}. More details and the reason for this change can be found in the following patches. Also note that this series depends on this series sent by me previously: http://lists.

Re: [Qemu-devel] [PATCH] sdl: Avoid unnecessary resizing of the display surface

2012-05-04 Thread Stefan Weil
Am 01.05.2012 07:53, schrieb Stefan Weil: If neither width nor height changes, nothing has to be done. Cc: Anthony Liguori Signed-off-by: Stefan Weil --- This patch improves SDL for any host (for example with remote X displays), but the main reason why I wrote it was another problem: On w32 /

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Alexander Graf
On 04.05.2012, at 16:02, Christian Borntraeger wrote: > On 04/05/12 16:00, Christian Borntraeger wrote: An IPL (booting) on s390 of SCSI disks is done by a firmware component. Lets implement this scheme as an qemu device that also allows to configure the IPL like the HMC. We have a

Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state

2012-05-04 Thread Luiz Capitulino
On Fri, 04 May 2012 11:07:03 -0600 Eric Blake wrote: > On 05/04/2012 10:50 AM, Luiz Capitulino wrote: > > On Fri, 04 May 2012 18:39:06 +0200 > > Paolo Bonzini wrote: > > > >> Il 04/05/2012 17:02, Luiz Capitulino ha scritto: > >>> diff --git a/qapi-schema.json b/qapi-schema.json > >>> index 0166

Re: [Qemu-devel] [PATCH v2 13/14] target-arm: Move reset handling to arm_cpu_reset

2012-05-04 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: > Now that cpu_reset_model_id() has gone we can move the > reset code over to the class reset function and have cpu_state_reset > simply do a reset on the CPU QOM object. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.c| 94 +

Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state

2012-05-04 Thread Eric Blake
On 05/04/2012 10:50 AM, Luiz Capitulino wrote: > On Fri, 04 May 2012 18:39:06 +0200 > Paolo Bonzini wrote: > >> Il 04/05/2012 17:02, Luiz Capitulino ha scritto: >>> diff --git a/qapi-schema.json b/qapi-schema.json >>> index 0166ec2..4dbcb26 100644 >>> --- a/qapi-schema.json >>> +++ b/qapi-schema.

Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow

2012-05-04 Thread Stefan Weil
Am 04.05.2012 18:29, schrieb Paolo Bonzini: Il 04/05/2012 18:28, Stefan Weil ha scritto: - !(buf[0] == REQUEST_SENSE&& d->sense_is_ua))) { + if (cmd.xfer> INT32_MAX) { + req = scsi_req_alloc(&reqops_invalid_field, d, tag, lun, hba_private); WARNING: line over 80 characters #54: FILE: hw/scsi-b

[Qemu-devel] i82557 /i82558 network problems

2012-05-04 Thread Christoph Schneider
Hi all, I am running a 2.4.4 kernel linux on my Qemu 1.0.1 VM (i386) with Intel Pro/100 network driver version 2.3.38. As this driver does not support standard e1000 network adapter, I picked i82558a (driver documentation says it's network driver compatible). Anyway, the network device is listed w

Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state

2012-05-04 Thread Luiz Capitulino
On Fri, 04 May 2012 18:39:06 +0200 Paolo Bonzini wrote: > Il 04/05/2012 17:02, Luiz Capitulino ha scritto: > > diff --git a/qapi-schema.json b/qapi-schema.json > > index 0166ec2..4dbcb26 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -116,12 +116,14 @@ > > # > > # @shutdown

Re: [Qemu-devel] [PATCH 06/14] scsi: change "removable" field to host many features

2012-05-04 Thread Andreas Färber
Am 04.05.2012 18:36, schrieb Paolo Bonzini: > Il 04/05/2012 18:30, Stefan Weil ha scritto: >>> >>> +#define SCSI_DISK_F_REMOVABLE0 >>> + >> >> ERROR: code indent should never use tabs >> #23: FILE: hw/scsi-disk.c:64: >> +#define SCSI_DISK_F_REMOVABLE^I0$ >> >> total: 1 errors, 0 warnings, 74 li

[Qemu-devel] [Bug 994378] [NEW] Nested-virt)L1 (kvm on kvm)guest panic with parameter “-cpu host” in qemu command line.

2012-05-04 Thread Yongjie Ren
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):Linux kvm.git Commit:19853301ef3289bda2d5264c1093e74efddaeab9 qemu-kvm Commit:69abebf20280152da8fa7c418a819ae51e862231 Host Kernel Version:3.4.0-rc3 Hardwar

Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state

2012-05-04 Thread Paolo Bonzini
Il 04/05/2012 17:02, Luiz Capitulino ha scritto: > diff --git a/qapi-schema.json b/qapi-schema.json > index 0166ec2..4dbcb26 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -116,12 +116,14 @@ > # > # @shutdown: guest is shut down (and -no-shutdown is in use) > # > +# @suspended: gu

Re: [Qemu-devel] [PATCH 06/14] scsi: change "removable" field to host many features

2012-05-04 Thread Paolo Bonzini
Il 04/05/2012 18:30, Stefan Weil ha scritto: >> >> +#define SCSI_DISK_F_REMOVABLE0 >> + > > ERROR: code indent should never use tabs > #23: FILE: hw/scsi-disk.c:64: > +#define SCSI_DISK_F_REMOVABLE^I0$ > > total: 1 errors, 0 warnings, 74 lines checked Not code indent. $ git grep $'^#.*defin

[Qemu-devel] [Bug 994412] [NEW] reverse vnc to unix domain sockets does not work

2012-05-04 Thread bhuztez
Public bug reported: I tried to connect to a unix domain socket, but failed. $ qemu -vnc unix:/tmp/my.sock,reverse connect(unix:/tmp/my.sock,reverse): No such file or directory I guess it is because unix_connect does not remove characters after first comma. ** Affects: qemu Importance: Und

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Roman Drahtmueller
> > > FIPS 140-2 requires disabling certain ciphers, including DES, which is > > > used > > > by VNC to obscure passwords when they are sent over the network. The > > > solution for FIPS users is to disable the use of VNC password auth when > > > the > > > host system is operating in FIPS mode. >

Re: [Qemu-devel] [PATCH 07/14] scsi-disk: add dpofua property

2012-05-04 Thread Stefan Weil
Am 04.05.2012 10:45, schrieb Paolo Bonzini: Linux expects REQ_FUA to be advertised only if WRITE+FUA is faster than WRITE+SYNCHRONIZE CACHE, so we should not set the DPOFUA bit. However, it is useful to have it for testing purposes, so add a qdev property to set it. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 06/14] scsi: change "removable" field to host many features

2012-05-04 Thread Stefan Weil
Am 04.05.2012 10:45, schrieb Paolo Bonzini: It is pointless to add a uint32_t field for every new feature. Since we will need a new feature soon, convert accesses to "removable" to look at bit 0 only. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 23 +++ 1 file chang

Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow

2012-05-04 Thread Paolo Bonzini
Il 04/05/2012 18:28, Stefan Weil ha scritto: >> >> - !(buf[0] == REQUEST_SENSE&& d->sense_is_ua))) { >> +if (cmd.xfer> INT32_MAX) { >> +req = scsi_req_alloc(&reqops_invalid_field, d, tag, lun, >> hba_private); > > WARNING: line over 80 characters > #54: FILE: hw/s

Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow

2012-05-04 Thread Stefan Weil
Am 04.05.2012 10:45, schrieb Paolo Bonzini: Avoid sending more than 2GB of data, as that can cause overflows in int32_t variables. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/s

Re: [Qemu-devel] [PATCH 00/26] My block patches queue for 1.1

2012-05-04 Thread Paolo Bonzini
On Thu, Apr 12, 2012 at 2:00 PM, Paolo Bonzini wrote: > Here is my block patches queue for 1.1. > > Patches 1-6 are cleanups to tools and aio.c that let filesystems > use timers when running under qemu-io. > > Patches 7-12 are bugfixes from last week's series, patches 13-14 > are new. > > Patches

Re: [Qemu-devel] [PATCH 02/35] vmstate: make all architectures export a way to migrate cpu's

2012-05-04 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: > This makes several changes: > - exports VMStateDescription vmstate_cpu non-static. > - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined > - for the architecture that had nothing, it just register the cpu as > unmigratable. > - Depen

Re: [Qemu-devel] [PATCH 00/21] qbus QOM conversion, rebased on top of my patches

2012-05-04 Thread Paolo Bonzini
Il 02/05/2012 13:30, Paolo Bonzini ha scritto: > Here is Anthony's qbus conversion, with the qdev_add_properties changes > replaced by my bus property changes. > > I left out the removal of bus methods; I'm not sure I agree with all of > them (though I may just give up :)) and anyway they can be l

[Qemu-devel] [Bug 994662] Re: QEMU crashes on ioport access

2012-05-04 Thread Anthony Liguori
** Visibility changed to: Public ** This bug is no longer flagged as a security vulnerability -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/994662 Title: QEMU crashes on ioport access Status in Q

Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu

2012-05-04 Thread Peter Maydell
On 4 May 2012 16:28, Juan Quintela wrote: > The only other sane approach that I can think is changing: > > #define VMSTATE_INT32_V(_f, _s, _v)                                   \ > > into something like: > > VMSTATE_INT32_GENERAL(_f, _s, _v, _getter, _setter) > > and then _getter/_setter functions

Re: [Qemu-devel] [SeaBIOS] [seabios patch 0/5] dynamic pci i/o windows

2012-05-04 Thread Kevin O'Connor
On Fri, May 04, 2012 at 10:46:00AM -0400, Kevin O'Connor wrote: > On Fri, May 04, 2012 at 04:01:56PM +0200, Gerd Hoffmann wrote: > > On 05/04/12 15:18, Kevin O'Connor wrote: > > > On Fri, May 04, 2012 at 10:21:22AM +0200, Gerd Hoffmann wrote: > > >> Hi, > > >> > > >> This patch series makes the P

Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices

2012-05-04 Thread Gerd Hoffmann
On 05/04/12 15:15, Kevin O'Connor wrote: > On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote: >> seabios used to initialize root bus devices only, with this patch >> devices behind pci bridges are initialized too. This allows to boot >> from virtio devices behind pci bridges. >> >> Sig

Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu

2012-05-04 Thread Juan Quintela
Peter Maydell wrote: > On 4 May 2012 11:54, Juan Quintela wrote: >> Use one subsection for each feature.  This means that we don't need to >> bump the version field each time that a new feature gets introduced. >> >> Introduce cpsr_vmstate field, as I am not sure if I can "use" >> uncached_cpsr f

[Qemu-devel] [PATCH 2/4] qapi-schema.json: fix RunState enums alphabetical order

2012-05-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qapi-schema.json |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 9193fb9..0166ec2 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -92,6 +92,8 @@ # # @debug: QEMU is running on a debug

[Qemu-devel] [PATCH 3/4] runstate: introduce suspended state

2012-05-04 Thread Luiz Capitulino
QEMU enters in this state when the guest suspends to ram (S3). This is important so that HMP users and QMP clients can know that the guest is suspended. QMP also has an event for this, but events are not reliable and are limited (ie. a client can connect to QEMU after the event has been emitted).

[Qemu-devel] [PATCH 1/4] wakeup on migration

2012-05-04 Thread Luiz Capitulino
From: Gerd Hoffmann Wakeup the guest when the live part of the migation is finished. This avoids being in suspended state on migration, so we don't have to save the is_suspended bit. Signed-off-by: Gerd Hoffmann Reviewed-by: Luiz Capitulino --- migration.c |1 + 1 file changed, 1 insertio

[Qemu-devel] [PATCH 4/4] vl: prop is_suspended variable

2012-05-04 Thread Luiz Capitulino
Check for the RUN_STATE_SUSPENDED state instead. Signed-off-by: Luiz Capitulino --- vl.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index a7afc79..5e0080b 100644 --- a/vl.c +++ b/vl.c @@ -1293,7 +1293,6 @@ static pid_t shutdown_pid; static int powe

[Qemu-devel] [PATCH v2 0/4]: runstate: introduce 'suspended' state

2012-05-04 Thread Luiz Capitulino
This is for 1.1. The first patch is a fix from Gerd, it's included in this series for our convenience. The patch introducing the new RunState is actually patch 03/04. V2 - include a related fix from Gerd [Gerd] - check for RUN_STATE_SUSPENDED in the mouse driver [Gerd] - small changelog changes

Re: [Qemu-devel] [SeaBIOS] [seabios patch 0/5] dynamic pci i/o windows

2012-05-04 Thread Kevin O'Connor
On Fri, May 04, 2012 at 04:01:56PM +0200, Gerd Hoffmann wrote: > On 05/04/12 15:18, Kevin O'Connor wrote: > > On Fri, May 04, 2012 at 10:21:22AM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >> This patch series makes the PCI I/O windows runtime-configurable via > >> qemu firmware config interface.

Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state

2012-05-04 Thread Luiz Capitulino
On Fri, 04 May 2012 10:50:08 +0200 Gerd Hoffmann wrote: > Hi, > > > However, I've ran into a different issue today: migrating while suspended > > doesn't work. The target VM seems to be locked into S3, it just doesn't > > resume. > > > > Haven't investigated yet, but this is expected to work

Re: [Qemu-devel] [PATCH] fix build with pulseaudio versions older than 0.9.11

2012-05-04 Thread malc
On Thu, 3 May 2012, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > audio/paaudio.c | 30 +- > 1 files changed, 29 insertions(+), 1 deletions(-) > [..snip..] Thanks, applied. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX

2012-05-04 Thread Christian Borntraeger
>> Since load_image_targphys is declared as taking an int for max_sz, this will >> fail for ram sizes > INT_MAX. >> Lets change the max_sz parameter to a uint64_t. >> >> Signed-off-by: Christian Borntraeger > > A patch equivalent to this has already been submitted: > http://patchwork.ozlabs.org

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Christian Borntraeger
On 04/05/12 16:00, Christian Borntraeger wrote: >>> An IPL (booting) on s390 of SCSI disks is done by a firmware component. >>> Lets implement this scheme as an qemu device that also allows to >>> configure the IPL like the HMC. We have a parameter iplid that >>> refers to a disk device and a load

Re: [Qemu-devel] [SeaBIOS] [seabios patch 0/5] dynamic pci i/o windows

2012-05-04 Thread Gerd Hoffmann
On 05/04/12 15:18, Kevin O'Connor wrote: > On Fri, May 04, 2012 at 10:21:22AM +0200, Gerd Hoffmann wrote: >> Hi, >> >> This patch series makes the PCI I/O windows runtime-configurable via >> qemu firmware config interface. Main advantage is that we can size and >> shuffle around the PCI i/O wind

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Christian Borntraeger
On 04/05/12 15:53, Alexander Graf wrote: > > On 04.05.2012, at 15:44, Christian Borntraeger wrote: > >> An IPL (booting) on s390 of SCSI disks is done by a firmware component. >> Lets implement this scheme as an qemu device that also allows to >> configure the IPL like the HMC. We have a paramete

Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state

2012-05-04 Thread Luiz Capitulino
On Fri, 04 May 2012 15:54:26 +0200 Gerd Hoffmann wrote: > Hi, > > > There's a quite simple and stupid way to do it. When we migrate an stopped > > VM, it's automatically resumed on the target. We could do the same for a > > suspended VM: we could automatically resume it before migrating, as yo

Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state

2012-05-04 Thread Gerd Hoffmann
Hi, > There's a quite simple and stupid way to do it. When we migrate an stopped > VM, it's automatically resumed on the target. We could do the same for a > suspended VM: we could automatically resume it before migrating, as you said > above. > > That's not the behavior I'd expect, I mean I wo

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Alexander Graf
On 04.05.2012, at 15:44, Christian Borntraeger wrote: > An IPL (booting) on s390 of SCSI disks is done by a firmware component. > Lets implement this scheme as an qemu device that also allows to > configure the IPL like the HMC. We have a parameter iplid that > refers to a disk device and a load

[Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Christian Borntraeger
An IPL (booting) on s390 of SCSI disks is done by a firmware component. Lets implement this scheme as an qemu device that also allows to configure the IPL like the HMC. We have a parameter iplid that refers to a disk device and a load parm that specifies the entry on the disk to be ipled. We also p

[Qemu-devel] [PATCH 0/1] RFC: ipl device for s390

2012-05-04 Thread Christian Borntraeger
Alex, while Einar is reworking the block size/geometry patches, here is the current state of the external loader. While the real firmware loader only supports fcp, this patch also allows to ipl dasd disks (the differences in terms of on-disk format are pretty small). This has the advantage of bein

Re: [Qemu-devel] [PATCH 16/35] vmstate: make incompatible change for sparc

2012-05-04 Thread Andreas Färber
Am 04.05.2012 15:00, schrieb Peter Maydell: > On 4 May 2012 12:35, Andreas Färber wrote: >> Not even [cc'ing] Acked-by (or is git-send-email >> case-sensitive? it's spelled "Acked-By" in lm32 patch). > > FWIW, git-send-email is not case-sensitive when looking for > things indicating it should CC

Re: [Qemu-devel] [RFC 0/9] Virtio-mmio refactoring.

2012-05-04 Thread Anthony Liguori
On 05/03/2012 07:14 AM, Peter Maydell wrote: On 25 April 2012 06:54, Evgeny Voevodin wrote: In this patchset refactoring of virtio-mmio layer is made. Instead of creating virtio-blk-mmio, virtio-net-mmio, etc on the system bus we create virtio-blk, virtio-net, etc devices on the virtio-transpor

Re: [Qemu-devel] [SeaBIOS] [seabios patch 0/5] dynamic pci i/o windows

2012-05-04 Thread Kevin O'Connor
On Fri, May 04, 2012 at 10:21:22AM +0200, Gerd Hoffmann wrote: > Hi, > > This patch series makes the PCI I/O windows runtime-configurable via > qemu firmware config interface. Main advantage is that we can size and > shuffle around the PCI i/O windows according to the amount of memory the > vir

Re: [Qemu-devel] [SeaBIOS] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-05-04 Thread Kevin O'Connor
On Wed, May 02, 2012 at 03:42:51PM +0200, Gerd Hoffmann wrote: > Hi, > > > Is this just a matter of removing the "if (pci_bdf_to_bus(pci->bdf) != > > 0) break" from pci_bios_init_devices()? > > Seems to do the trick, at least the disks connected appear in the boot > menu now and the seabios log

Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices

2012-05-04 Thread Kevin O'Connor
On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote: > seabios used to initialize root bus devices only, with this patch > devices behind pci bridges are initialized too. This allows to boot > from virtio devices behind pci bridges. > > Signed-off-by: Gerd Hoffmann > --- > src/pciinit

[Qemu-devel] [PATCH 27/35] vmstate: rename machine.c to vmstate-cpu.c

2012-05-04 Thread Juan Quintela
They only contain vmstate cpu sections nowadays. Change name to reflect the case. Signed-off-by: Juan Quintela --- Makefile.target|3 ++- target-alpha/{machine.c => vmstate-cpu.c} |0 target-arm/{machine.c => vmstate-cpu.c}|0 target-cri

Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu

2012-05-04 Thread Peter Maydell
On 4 May 2012 11:54, Juan Quintela wrote: > Use one subsection for each feature.  This means that we don't need to > bump the version field each time that a new feature gets introduced. > > Introduce cpsr_vmstate field, as I am not sure if I can "use" > uncached_cpsr for saving state. > > Signed-o

Re: [Qemu-devel] [PATCH 09/35] vmstate: introduce float64 arrays

2012-05-04 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: > Signed-off-by: Juan Quintela > --- > savevm.c | 25 + > vmstate.h |4 > 2 files changed, 29 insertions(+), 0 deletions(-) > > diff --git a/savevm.c b/savevm.c > index a22278e..da8f234 100644 > --- a/savevm.c > +++

[Qemu-devel] [PATCH 02/35] vmstate: make all architectures export a way to migrate cpu's

2012-05-04 Thread Juan Quintela
This makes several changes: - exports VMStateDescription vmstate_cpu non-static. - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined - for the architecture that had nothing, it just register the cpu as unmigratable. - Depending on CPU_SAVE_VERSION we register old/new migration s

Re: [Qemu-devel] [PATCH 16/35] vmstate: make incompatible change for sparc

2012-05-04 Thread Peter Maydell
On 4 May 2012 12:35, Andreas Färber wrote: > It appears once again none of these patches are actually cc'ing the > proper maintainers. Not even Acked-by (or is git-send-email > case-sensitive? it's spelled "Acked-By" in lm32 patch). FWIW, git-send-email is not case-sensitive when looking for thin

[Qemu-devel] [PATCH 14/35] vmstate: define vmstate_info_uinttls

2012-05-04 Thread Juan Quintela
We are going to define arrays of this type, so we need the integer type. Signed-off-by: Juan Quintela --- hw/hw.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index e5cb9bf..9dbac88 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -52,11 +52,13 @@ int qemu_boo

[Qemu-devel] [PATCH 22/35] arm: save always 32 fpu registers

2012-05-04 Thread Juan Quintela
This way, we fix a bug (we were overwritten the 16 first registers on load), and we don't need to check for ARM_FEATURE_VPF3, we always send the 32 registers. Signed-off-by: Juan Quintela --- target-arm/cpu.h |2 +- target-arm/machine.c | 22 ++ 2 files changed, 3 i

Re: [Qemu-devel] [PATCH v5 00/35] VMState port of all cpus

2012-05-04 Thread Anthony Liguori
On 05/04/2012 06:35 AM, Juan Quintela wrote: Juan Quintela wrote: Andreas Färber wrote: Am 04.05.2012 12:54, schrieb Juan Quintela: This repository contains all the changes: git://repo.or.cz/qemu/quintela.git vmstate-cpus-v4 Oops, you meaned here. s/v4/v5/ :-( I have to put in one

[Qemu-devel] [PATCH 10/35] vmstate: introduce CPU_DoubleU arrays

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- savevm.c | 24 vmstate.h |4 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index da8f234..0a00dec 100644 --- a/savevm.c +++ b/savevm.c @@ -1132,6 +1132,30 @@ const VMStateInfo vmstate_info_

[Qemu-devel] [PATCH 28/35] vmstate: Add copyright info for alpha processor

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Richard Henderson --- target-alpha/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-alpha/vmstate-cpu.c b/target-alpha/vmstate-cpu.c index 22c70f3..b94b1e5 100644 --- a/target-alpha/vmstate-cpu.c +

[Qemu-devel] [PATCH 06/35] vmstate: make microblaze cpus not migrateable

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-microblaze/cpu.h |2 -- target-microblaze/machine.c | 26 ++ 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index 718d5bb..866623d 100644 --- a/target-micr

[Qemu-devel] [PATCH 26/35] vmstate: remove unneeded includes from target-*/machine.c

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-alpha/machine.c |1 - target-arm/machine.c |1 - target-cris/machine.c |1 - target-i386/machine.c |6 -- target-lm32/machine.c |1 - target-mips/machine.c |3 --- target-ppc/machine.c |2 -- target-sparc/machine.c |

[Qemu-devel] [PATCH 04/35] vmstate: use new cpu style for x86

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-i386/cpu.h |2 -- target-i386/machine.c | 12 +--- 2 files changed, 1 insertions(+), 13 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index b5b9a50..73b71ec 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -965,

[Qemu-devel] [PATCH 33/35] vmstate: Add copyright info for mips processor

2012-05-04 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c Signed-off-by: Juan Quintela --- target-mips/vmstate-cpu.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/target-mips/vmstate-cpu.c b/target-mips/vmstate-cpu.c index bbfa2a9..1e28b3f 100644 --- a/targe

Re: [Qemu-devel] [PATCH 22/35] arm: save always 32 fpu registers

2012-05-04 Thread Peter Maydell
On 4 May 2012 11:54, Juan Quintela wrote: > This way, we fix a bug (we were overwritten the 16 first registers on > load), and we don't need to check for ARM_FEATURE_VPF3, we always send > the 32 registers. As I pointed out last time around, this bug is already fixed in master and you need to cor

[Qemu-devel] [PATCH 19/35] mips: make tlb an embedded struct instead of a pointer

2012-05-04 Thread Juan Quintela
Adjust all callers. Signed-off-by: Juan Quintela --- hw/mips_timer.c |2 +- target-mips/cpu.h|2 +- target-mips/helper.c | 30 +- target-mips/machine.c| 56 +- target-mips/op_helper.c

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Daniel P. Berrange
On Fri, May 04, 2012 at 08:39:04AM -0400, Paul Moore wrote: > On Friday, May 04, 2012 04:01:09 AM Roman Drahtmueller wrote: > > Two problems: > > 1) openssl may not come with FIPS support. proc file is ignored. > > 2) openssl may run in FIPS mode for reasons other than fips=1 on the > >kernel

Re: [Qemu-devel] [PATCH v3] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Paul Moore
On Friday, May 04, 2012 09:54:17 AM Daniel P. Berrange wrote: > On Thu, May 03, 2012 at 05:00:45PM -0400, Paul Moore wrote: > > FIPS 140-2 requires disabling certain ciphers, including DES, which is > > used > > by VNC to obscure passwords when they are sent over the network. The > > solution for

[Qemu-devel] [PATCH 16/35] vmstate: make incompatible change for sparc

2012-05-04 Thread Juan Quintela
With this change, we sent arrays as arrays, making state description much simpler. The change is incompatible, but as far as I know, sparc don't care about migration compatibility beteween versions. Signed-off-by: Juan Quintela --- target-sparc/machine.c | 172 +++--

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Paul Moore
On Friday, May 04, 2012 04:01:09 AM Roman Drahtmueller wrote: > > > > FIPS 140-2 requires disabling certain ciphers, including DES, which is > > > > used > > > > by VNC to obscure passwords when they are sent over the network. The > > > > solution for FIPS users is to disable the use of VNC passwo

[Qemu-devel] [PATCH 08/35] vmstate: introduce float32 arrays

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- savevm.c | 25 + vmstate.h |5 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 2d18bab..a22278e 100644 --- a/savevm.c +++ b/savevm.c @@ -1082,6 +1082,31 @@ const VMStateInfo vmstate_inf

[Qemu-devel] [PATCH 11/35] vmstate: Introduce VMSTATE_STRUCT_VARRAY_INT32_TEST

2012-05-04 Thread Juan Quintela
We have an array of structs whose size is an int32 in the same struct that depends on a test value to know if it is there or not. Signed-off-by: Juan Quintela --- vmstate.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/vmstate.h b/vmstate.h index 5c56f25..b8a

[Qemu-devel] [PATCH 35/35] vmstate: Add copyright info for sparc processor

2012-05-04 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c v3: Change copyright dates v4: add QEMU contributors Signed-off-by: Juan Quintela --- target-sparc/vmstate-cpu.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/target-sparc/vmstate-cpu.c b/target-spar

[Qemu-devel] [PATCH 13/35] vmstate: introduce VMSTATE_VARRAY_MULTIPLY

2012-05-04 Thread Juan Quintela
This allows to sent a partial array where the size is another structure field multiplied by a constant. Signed-off-by: Juan Quintela --- savevm.c |6 ++ vmstate.h | 35 +++ 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/savevm.c b/save

[Qemu-devel] [PATCH 17/35] mips_fulong2e: cpu vmstate already registered in cpu_exec_init

2012-05-04 Thread Juan Quintela
This is the second place that register cpu migration code, it is done in general in cpu_exec_init(), just remove this call. Signed-off-by: Juan Quintela --- hw/mips_fulong2e.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c index 3

[Qemu-devel] [PATCH 09/35] vmstate: introduce float64 arrays

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- savevm.c | 25 + vmstate.h |4 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index a22278e..da8f234 100644 --- a/savevm.c +++ b/savevm.c @@ -1107,6 +1107,31 @@ const VMStateInfo vmstate_info

[Qemu-devel] [PATCH 21/35] vmstate: port mips cpu

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-mips/cpu.h |5 +- target-mips/machine.c | 465 +++-- 2 files changed, 182 insertions(+), 288 deletions(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index c77d270..8eb6173 100644 --- a/target-mip

[Qemu-devel] [PATCH 18/35] mips: make mvp an embedded struct instead of a pointer

2012-05-04 Thread Juan Quintela
Adjust all callers. Signed-off-by: Juan Quintela --- hw/mips_malta.c |4 ++-- target-mips/cpu.h|4 ++-- target-mips/machine.c| 12 ++-- target-mips/op_helper.c | 30 +- target-mips/translate.c |6 +++--

[Qemu-devel] [PATCH 24/35] vmstate: all cpus converted

2012-05-04 Thread Juan Quintela
We don't have any more CPU_SAVEVM_VERSION users, neither cpu_save/load() ones. Signed-off-by: Juan Quintela --- exec.c|5 - qemu-common.h |4 2 files changed, 0 insertions(+), 9 deletions(-) diff --git a/exec.c b/exec.c index 85f0d61..1deb943 100644 --- a/exec.c +++ b/e

[Qemu-devel] [PATCH 23/35] vmstate: port arm cpu

2012-05-04 Thread Juan Quintela
Use one subsection for each feature. This means that we don't need to bump the version field each time that a new feature gets introduced. Introduce cpsr_vmstate field, as I am not sure if I can "use" uncached_cpsr for saving state. Signed-off-by: Juan Quintela --- target-arm/cpu.h |5

[Qemu-devel] [PATCH 05/35] vmstate: use new style for lm32 cpus

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-lm32/cpu.h |2 -- target-lm32/machine.c | 14 ++ 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h index 422a55b..049936a 100644 --- a/target-lm32/cpu.h +++ b/target-lm32/cpu.h @@ -20

[Qemu-devel] [PATCH 07/35] vmstate: port cris cpu to vmstate

2012-05-04 Thread Juan Quintela
Have to define TLBSet struct. Multidimensional arrays in C are a mess, just unroll them. Signed-off-by: Juan Quintela --- target-cris/cpu.h | 13 ++--- target-cris/machine.c | 138 +++-- 2 files changed, 60 insertions(+), 91 deletions(-) diff -

  1   2   >