Il 24/09/2014 02:42, Gonglei (Arei) ha scritto:
> OK.
>
> This way I have to add a description string parametet to
> object_property_add_alias function. Will do in the next version. :)
No, just take it from the original property. So if you alias A.X to
B.Y, you copy the description of B.Y.
Pao
Add realization of rename all items in opts for qemu_opt_rename.
e.g:
When add bps twice in command line, need to rename all bps to
throttling.bps-total.
This patch solved following bug:
Bug 1145586 - qemu-kvm will give strange hint when add bps twice for a drive
ref:https://bugzilla.redhat.com/sh
Compiler warning (w32, w64):
include/hw/virtio/virtio_ring.h:142:26: warning:
cast from pointer to integer of different size [-Wpointer-to-int-cast]
When sizeof(long) < sizeof(void *), this is not only a warning but a
real program error.
Add also missing blanks in the same statement.
Signed-of
On Tue, 09/23 10:47, Eric Blake wrote:
> On 09/23/2014 07:13 AM, Jun Li wrote:
> > Add realization of rename all items in opts for qemu_opt_rename.
> > e.g:
> > When add bps twice in command line, need to rename all bps to
> > throttling.bps-total.
> >
> > Signed-off-by: Jun Li
> > ---
> > This p
When we expand a number range, we just print "$id - unknown test,
ignored", this is convenient if we want to run a range of tests.
When we designate a test case number explicitly, we shouldn't just
ignore it if the case script doesn't exist.
Print an error and fail the test.
Signed-off-by: Fam Z
ping...
On 09/17/2014 09:23 AM, Gu Zheng wrote:
> Previously we use cpu_added_notifiers to register cpu hotplug notifier
> callback
> which is not able to pass/handle errors, so we switch it to unified hotplug
> handler API which allows to pass errors and would allow to cancel device_add
> in ca
On Tue, Sep 23, 2014 at 11:14:50AM -0600, Alex Williamson wrote:
> From: Alexey Kardashevskiy
>
> This reverts commit c40708176a6b52b73bec14796b7c71b882ceb102.
>
> The resulting code wrongly assumed target and host endianness are
> the same which is not always the case for PPC64.
>
> [aw: or po
On Tue, Sep 23, 2014 at 11:14:57AM -0600, Alex Williamson wrote:
> From: Nikunj A Dadhania
>
> All memory regions used by VFIO are LITTLE_ENDIAN and they
> already take care of endiannes when accessing real device BARs
> except ROM - it was broken on BE hosts.
>
> This fixes endiannes for ROM BA
On Mon, Sep 22, 2014 at 10:38:34PM +0200, Laszlo Ersek wrote:
> The first patch introduces a generic comparator. This comparator should
> cover all machine types at once that don't belong to machine type
> "families". Hence, for example, the output it produces for
>
> qemu-system-aarch64 -M \?
>
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Wednesday, September 24, 2014 1:04 AM
> Subject: Re: [PATCH 0/7] add description field in ObjectProperty and
> PropertyInfo struct
>
> Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto:
> > From: Gong
> Subject: Re: [PATCH 5/7] qdev: set the object property's description to the
> qdev
> property's.
>
> Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto:
> > From: Gonglei
> >
> > When we call qdev_alias_all_properties() adding alias properties to
> > the source object all qdev properties
Hi,
Ping...
Thanks,
zhanghailiang
On 2014/9/19 14:43, zhanghailiang wrote:
Hi,
In original code, Function dump_error ignores its second parameter which
contains
error reason, it is better to return the error message to the caller.
Here we use error_setg to return the error info to caller.
Hi Peter,
This update contains the TCX framebuffer hardware acceleration patch for sun4m.
Please pull.
ATB,
Mark.
The following changes since commit 769188d3bbf95ce8d96a335624234dad083f4db6:
Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20140923-1' into
staging (
On 13/09/14 11:10, Mark Cave-Ayland wrote:
The S24/TCX framebuffer is a mildly accelerated video card with
blitter, stippler and hardware cursor.
* Solaris and NetBSD 6.x use all the hardware acceleration features
* The Xorg driver (used by Linux) can use the hardware cursor only
This patch im
On 28.08.14 14:23, Alexander Graf wrote:
>
>
> On 28.08.14 13:59, Alexander Graf wrote:
>>
>>
>> On 15.08.14 07:29, Peter Crosthwaite wrote:
>>> Hi All,
>>>
>>> So phase one was the QOMification of qemu_irq. This is the next step.
>>> We start to setup GPIOs as proper QOM objects. Inputs are ch
just come to do the same...need to revert and cant :-(
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1371915
Title:
Make Uninstall Rule Requested
Status in QEMU:
New
Bug description:
Environm
On 23.09.14 22:24, Benjamin Herrenschmidt wrote:
> On Tue, 2014-09-23 at 14:30 +0200, Gerd Hoffmann wrote:
>> Hi,
>
> (Adding Mike)
>
>> Series applies on top of the vga patches posted yesterday.
>> It adds a mmio register to the pci stdvga cards allowing
>> to switch framebuffer endiannness.
On Tue, 2014-09-23 at 14:30 +0200, Gerd Hoffmann wrote:
> Hi,
(Adding Mike)
> Series applies on top of the vga patches posted yesterday.
> It adds a mmio register to the pci stdvga cards allowing
> to switch framebuffer endiannness. Ben's patches 1+2 prepare
> for runtime-swicthable endianness
On 23 September 2014 11:52, John Snow wrote:
> On 08/22/2014 05:05 AM, Stefan Hajnoczi wrote:
>> Nice, and Paolo sent me an automated way of doing that:
>>
>> On Fri, Aug 22, 2014 at 12:14:28AM +0200, Paolo Bonzini wrote:
>>>
>>> You need to set PKG_CONFIG_LIBDIR to
>>>
>>> /usr/lib/$MULTILIBDIR/p
On 08/22/2014 05:05 AM, Stefan Hajnoczi wrote:
On Fri, Aug 22, 2014 at 9:20 AM, Daniel P. Berrange wrote:
On Thu, Aug 21, 2014 at 08:10:54PM -0400, John Snow wrote:
I was running a series of tests on 32 and 64 bit hosts to test for
endianness and variable width issues when I noticed that I c
On 09/23/2014 11:42 AM, Paolo Bonzini wrote:
> No, it just caught my eye because it'll conflict with the PPC patches
> that have NB_MMU_MODES == 12.
Ah, right, so it will.
Peter, please don't pull. I'll drop that patch for now.
r~
Il 23/09/2014 19:48, Peter Maydell ha scritto:
> On 22 September 2014 23:19, Paolo Bonzini wrote:
>> Il 22/09/2014 22:57, Richard Henderson ha scritto:
>>> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32);
>>> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8);
>>> +
>>> typedef struct TCGLabelQemuLdst {
>>> -b
Il 23/09/2014 20:17, Richard Henderson ha scritto:
> Ug. Failure to operate the mail program on my phone properly;
> the following went to Paolo only instead of the list too.
And my reply too, which was basically "np, just asking".
Paolo
>
> Forwarded Message
> Subject: Re: [
Ug. Failure to operate the mail program on my phone properly;
the following went to Paolo only instead of the list too.
r~
Forwarded Message
Subject: Re: [PULL 07/11] tcg: Compress TCGLabelQemuLdst
Date: Mon, 22 Sep 2014 16:10:40 -0700
From: Richard Henderson
To: Paolo Bonzi
On 22 September 2014 23:19, Paolo Bonzini wrote:
> Il 22/09/2014 22:57, Richard Henderson ha scritto:
>> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32);
>> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8);
>> +
>> typedef struct TCGLabelQemuLdst {
>> -bool is_ld:1; /* qemu_ld: true, qemu_st: false
From: Nikunj A Dadhania
All memory regions used by VFIO are LITTLE_ENDIAN and they
already take care of endiannes when accessing real device BARs
except ROM - it was broken on BE hosts.
This fixes endiannes for ROM BARs the same way as it is done
for other BARs.
This has been tested on PPC64 BE
From: Alexey Kardashevskiy
This reverts commit c40708176a6b52b73bec14796b7c71b882ceb102.
The resulting code wrongly assumed target and host endianness are
the same which is not always the case for PPC64.
[aw: or potentially any host supporting VFIO and TCG]
Signed-off-by: Alexey Kardashevskiy
The following changes since commit 07e2863d0271ac6c05206d8ce9e4f4c39b25d3ea:
exec.c: fix setting 1-byte-long watchpoints (2014-09-19 17:42:16 +0100)
are available in the git repository at:
git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20140923.0
for you to fetch changes up
On 09/23/2014 04:09 AM, Stefan Hajnoczi wrote:
> The blkdebug block driver is undocumented. Documenting it is worthwhile
> since it offers powerful error injection features that are used by
> qemu-iotests test cases.
>
> This document will make it easier for people to learn about and use
> blkdeb
On 09/23/2014 03:23 AM, Yang Hongyang wrote:
> add command line switch
>
> Signed-off-by: Yang Hongyang
> Cc: Anthony Liguori
> Cc: Stefan Hajnoczi
> ---
> qapi-schema.json | 8 +++-
> qemu-options.hx | 10 +-
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/
Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto:
> From: Gonglei
>
> PATCH 1 and PATCH 2 are bugfixes. PATCH 3~7 add a description
> field in both ObjectProperty and PropertyInfo struct.
> The descriptions can serve as documentation in the code,
> and they can be used to provide better he
Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto:
> From: Gonglei
>
> When we call qdev_alias_all_properties() adding alias properties to
> the source object all qdev properties on the target DeviceState,
> set the object property's description to the qdev property's.
>
> c: Paolo Bonzini
On 09/23/2014 04:15 AM, 吴志勇 wrote:
> HI,
[please configure your mailer to wrap long lines]
> As you've known, vhd-util and qemu-img both provide the capacity for
resizing the original disk, but why is virt-resize designed to involve
two disks, not only original disk? Is there any concern? Is it p
18.09.2014 10:35, Petr Matousek wrote:
> When guest sends udp packet with source port and source addr 0,
> uninitialized socket is picked up when looking for matching and already
> created udp sockets, and later passed to sosendto() where NULL pointer
> dereference is hit during so->slirp->vnetwork
This patch implements the backend for the Q35 board
for us to be able to pick up and use drives defined
by the -cdrom, -hda, or -drive if=ide shorthand options.
A workaround for these command line options not previously
working as intended in the bios-tables-test is also removed.
Signed-off-by: J
This patch adds the 'units_per_default_bus' property
which allows individual boards to declare their desired
index => (bus,unit) mapping for their default HBA, so
that boards such as Q35 can specify that its default
if_ide HBA, AHCI, only accepts one unit per bus.
This property only overrides the
Instead of duplicating the logic for the if_ide
(bus,unit) mappings, rely on the blockdev layer
for managing those mappings for us, and use the
drive_get_by_index call instead.
This allows ide_drive_get to work for AHCI HBAs
as well, and can be used in the Q35 initialization.
Signed-off-by: John
If the Q35 board types are to begin recognizing
and decoding syntactic sugar for drive/device
declarations, then workarounds found within
the qtests suite need to be adjusted to prevent
any test failures after the fix.
bios-tables-test improperly uses this cli:
-drive file=etc,id=hd -device ide-hd
When users use command line options like -hda, -cdrom,
or even -drive if=ide, it is up to the board initialization
routines to pick up these drives and create backing
devices for them.
Some boards, like Q35, have not been doing this.
However, there is no warning explaining why certain
drive specif
The Q35 board initialization does not currently bother to look
for any drives added by the various syntactical sugar shorthands
to be added to the AHCI HBA. These include -hda through -hdd,
-cdrom, and -drive if=ide shorthands.
An obstacle to having implemented this sooner is debate over
whether o
The if_max_devs table as in the past been an immutable
default that controls the mapping of index => (bus,unit)
for all boards and all HBAs for each interface type.
Since adding this mapping information to the HBA device
itself is currently unwieldly from the perspective of
retrieving this informa
On 09/23/2014 07:13 AM, Jun Li wrote:
> Add realization of rename all items in opts for qemu_opt_rename.
> e.g:
> When add bps twice in command line, need to rename all bps to
> throttling.bps-total.
>
> Signed-off-by: Jun Li
> ---
> This patch solved following bug:
> Bug 1145586 - qemu-kvm will
Am 18.09.2014 15:56, schrieb Stefan Hajnoczi:
There is the issue of request ordering (using write cache flushes). The
secondary probably needs to perform requests in the same order and
interleave cache flushes in the same way as the primary. Otherwise a
power failure on the secondary could leav
Kevin Wolf writes:
> Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
>> On BlockBackend destruction, unref its BlockDriverState. Replaces the
>> callers' unrefs.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> block/block-backend.c | 6 ++
>> blockdev.c| 8 ++-
On 09/23/2014 08:56 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> The previous commit demonstrated that the generator overlooked some
>> fairly basic broken expressions:
>> - missing metataype
>> - metatype key has a non-string value
>> - unknown key in relation to the metatype
>> - conf
On 09/23/2014 08:23 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> The previous commit demonstrated that the generator had several
>> flaws with less-than-perfect enums:
>> - an enum that listed the same string twice (or two variant
>> strings that map to the same C enum) ended up generat
On Mon, Sep 08, 2014 at 12:49:48PM +0300, Michael S. Tsirkin wrote:
> On Mon, Sep 08, 2014 at 11:17:50AM +0200, David Marchand wrote:
> > Send a protocol version as the first message from server, clients must close
> > communication if they don't support this protocol version.
>
> What's the motiv
; tracing bits for ohci.
>
> please pull,
> Gerd
>
> The following changes since commit 07e2863d0271ac6c05206d8ce9e4f4c39b25d3ea:
>
> exec.c: fix setting 1-byte-long watchpoints (2014-09-19 17:42:16 +0100)
>
> are available in the git repository at:
>
> git://git.k
On 23.09.14 16:50, Alex Bennée wrote:
>
> Alexander Graf writes:
>
>> On 15.09.14 18:48, Alex Bennée wrote:
>>> A significant portion of the build time is spent initialising all the
>>> sub-modules we use in the source tree. Often this is almost as long as
>>> the build itself. By pre-seeding t
Kevin Wolf writes:
> Am 23.09.2014 um 14:52 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 22.09.2014 um 18:34 hat Markus Armbruster geschrieben:
>> >> Kevin Wolf writes:
>> >>
>> >> > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
>> >> >> diff --git a/include
Install the ./trace-events file into the data directory. This file
contains the list of trace events that were built into QEMU at
compile-time.
The file is a handy reference for the set of trace events that the QEMU
binary was built with. It is also needed by the simpletrace.py tool
that parses
Quoting Petr Matousek (2014-09-18 01:35:37)
> When guest sends udp packet with source port and source addr 0,
> uninitialized socket is picked up when looking for matching and already
> created udp sockets, and later passed to sosendto() where NULL pointer
> dereference is hit during so->slirp->vne
Eric Blake writes:
> The previous commit demonstrated that the generator overlooked some
> fairly basic broken expressions:
> - missing metataype
> - metatype key has a non-string value
> - unknown key in relation to the metatype
> - conflicting metatype (this patch treats the second metatype as
Alexander Graf writes:
> On 15.09.14 18:48, Alex Bennée wrote:
>> A significant portion of the build time is spent initialising all the
>> sub-modules we use in the source tree. Often this is almost as long as
>> the build itself. By pre-seeding the .git/modules tree this will
>> hopefully improv
This structure is not documented in the official VHD specs, nor is the
'tdbatmap'
cookie used in differencing VHDs created by Windows Server 2012. Isn't
Hyper-V
compatibility desired?
Yepp, this structure of tdbatmap is a extra feature from vhd-util from Xen,
here we
could make sure the version of
Eric Blake writes:
> Demonstrate that the qapi generator doesn't deal well with
> expressions that aren't up to par. Later patches will improve
> the expected results as the generator is made stricter. Only
> one of the added tests actually behaves sanely at rejecting
> obvious problems.
>
> Not
Eric Blake writes:
> The previous commit demonstrated that the generator had several
> flaws with less-than-perfect enums:
> - an enum that listed the same string twice (or two variant
> strings that map to the same C enum) ended up generating an
> invalid C enum
> - because the generator adds a
From: Gonglei
meanwhile, qerror_report_err() is a transitional interface to
help with converting existing HMP commands to QMP. It should
not be used elsewhere.
Signed-off-by: Gonglei
Reviewed-by: Paolo Bonzini
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-network.c | 9 -
1 file change
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 73ced1f..c556367 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -3874,7 +3874,6 @@ static void xhci_class_init(ObjectClass *klass, void
*da
uhci hostadapters in companion setups can't be hotplugged. So leave
hotplug disabled for all ich9 variants (which are already tagged with
unplug = true in the info struct). For the other variants we'll enable
hotplug and remove the companion setup properties.
Signed-off-by: Gerd Hoffmann
---
h
gt;
> git://github.com/borntraeger/qemu.git tags/s390x-20140923
>
> for you to fetch changes up to e8601dd5d0ffa909068ddefe33bf6a53d8af063a:
>
> s390x/css: catch ccw sequence errors (2014-09-23 14:10:17 +0200)
>
> --
> Subject: [PATCH 4/7] qom: add description field in ObjectProperty struct
>
> From: Gonglei
>
> The descriptions can serve as documentation in the code,
> and they can be used to provide better help.
>
> Cc: Paolo Bonzini
> Cc: Michael S. Tsirkin
> Cc: Markus Armbruster
> Signed-off-by: Gon
Am 23.09.2014 um 14:52 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 22.09.2014 um 18:34 hat Markus Armbruster geschrieben:
> >> Kevin Wolf writes:
> >>
> >> > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> >> >> diff --git a/include/block/block_int.h b/include/b
Add prebuilt vgabios-virtio.bin binary.
Signed-off-by: Gerd Hoffmann
---
pc-bios/vgabios-virtio.bin | Bin 0 -> 37376 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 pc-bios/vgabios-virtio.bin
diff --git a/pc-bios/vgabios-virtio.bin b/pc-bios/vgabios-virtio.bin
new fil
This patch adds the core code for virtio gpu emulation,
covering 2d support.
Written by Dave Airlie and Gerd Hoffmann.
Signed-off-by: Dave Airlie
Signed-off-by: Gerd Hoffmann
---
default-configs/x86_64-softmmu.mak | 1 +
hw/display/Makefile.objs | 2 +
hw/display/virtio-gpu.c
This patch adds the header file with structs and defines for
the virtio based gpu device. Covers 2d operations only.
Written by Dave Airlie and Gerd Hoffmann.
Signed-off-by: Dave Airlie
Signed-off-by: Gerd Hoffmann
---
include/hw/virtio/virtgpu_hw.h | 207 +
This patch adds virtio-gpu-pci, which is the pci proxy for the virtio
gpu device. With this patch in place virtio-gpu is functional. You
need a linux guest with a virtio-gpu driver though, and output will
appear pretty late in boot, once the kernel initialized drm and fbcon.
Written by Dave Airl
Some convinience fluff: Add support for '-vga virtio', also add
virtio-vga to the list of vga cards so '-device virtio-vga' will
turn off the default vga.
Written by Dave Airlie and Gerd Hoffmann.
Signed-off-by: Dave Airlie
Signed-off-by: Gerd Hoffmann
---
hw/pci/pci.c| 2 ++
inc
Add seavgabios configuration for virtio-vga,
hook up the new vgabios in the makefiles.
Signed-off-by: Gerd Hoffmann
---
Makefile | 2 +-
roms/Makefile | 2 +-
roms/config.vga-virtio | 6 ++
3 files changed, 8 insertions(+), 2 deletions(-)
create mode 100644 roms/confi
Signed-off-by: Gerd Hoffmann
---
tests/Makefile | 3 +++
tests/display-vga-test.c | 18 ++
2 files changed, 21 insertions(+)
diff --git a/tests/Makefile b/tests/Makefile
index a5e3d0c..27edb2c 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -125,6 +125,9 @@ check-q
This patch adds a virtio-vga device. It is simliar to virtio-gpu-pci,
but it also adds in vga compatibility, so guests without native
virtio-gpu support can drive the device in vga mode.
Written by Dave Airlie and Gerd Hoffmann.
Signed-off-by: Dave Airlie
Signed-off-by: Gerd Hoffmann
---
defa
Hi,
Initial batch of virtio-gpu patches, covering 2D support.
Patch to the virtio spec has been sent to virtio-dev yesterday,
a formated version can be found here:
https://www.kraxel.org/virtio/
What is the virtio 1.0 state btw? Specs are final, do we have
qemu/kernel patches somewhere me
> Subject: Re: [Qemu-devel] [PATCH 1/2] qom: add error handler for
> object_property_print()
>
> Hi,
>
> Am 23.09.2014 um 05:25 schrieb arei.gong...@huawei.com:
> > From: Gonglei
> >
> > Avoid the caller of object_property_print() leaking string
> > argument's memory, such as qdev_print_props()
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Sent: Tuesday, September 23, 2014 9:23 PM
> Subject: Re: [PATCH 0/2] qom: add error handler for security
>
> Il 23/09/2014 15:21, Gonglei (Arei) ha scritto:
> > Thanks, Paolo. I merged those two patches in my next patch series
> > [PATCH 0/7] a
Il 23/09/2014 15:21, Gonglei (Arei) ha scritto:
> Thanks, Paolo. I merged those two patches in my next patch series
> [PATCH 0/7] add description field in ObjectProperty and PropertyInfo struct
> because of depending. Maybe I should spilt them again?
No, don't worry. Maintainers will handle it j
> >
> > The PATCH 2 is splited from another patch series, which has been
> > reviewed by Paolo. PATCH 1 can avoid possible leaking memory.
> >
> > Gonglei (2):
> > qom: add error handler for object_property_print()
> > qom: add error handler for object alias property
> >
> > qom/object.c | 21
Hi,
Am 23.09.2014 um 05:25 schrieb arei.gong...@huawei.com:
> From: Gonglei
>
> Avoid the caller of object_property_print() leaking string
> argument's memory, such as qdev_print_props() when
> encounter errors.
>
> Cc: Paolo Bonzini
> Signed-off-by: Gonglei
> ---
> qom/object.c | 12 +++
Il 23/09/2014 05:25, arei.gong...@huawei.com ha scritto:
> From: Gonglei
>
> The PATCH 2 is splited from another patch series, which has been
> reviewed by Paolo. PATCH 1 can avoid possible leaking memory.
>
> Gonglei (2):
> qom: add error handler for object_property_print()
> qom: add erro
From: Gonglei
The descriptions can serve as documentation in the code,
and they can be used to provide better help.
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Markus Armbruster
Signed-off-by: Gonglei
---
hw/core/qdev-properties-system.c | 4
hw/core/qdev-properties.c| 6 +
Add realization of rename all items in opts for qemu_opt_rename.
e.g:
When add bps twice in command line, need to rename all bps to
throttling.bps-total.
Signed-off-by: Jun Li
---
This patch solved following bug:
Bug 1145586 - qemu-kvm will give strange hint when add bps twice for a drive
ref:htt
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> On BlockBackend destruction, unref its BlockDriverState. Replaces the
> callers' unrefs.
>
> Signed-off-by: Markus Armbruster
> ---
> block/block-backend.c | 6 ++
> blockdev.c| 8 ++--
> hw/block/xen_disk.c |
From: Gonglei
The descriptions can serve as documentation in the code,
and they can be used to provide better help. For example:
Before this patch:
$./qemu-system-x86_64 -device virtio-blk-pci,?
virtio-blk-pci.iothread=link
virtio-blk-pci.x-data-plane=bool
virtio-blk-pci.scsi=bool
virtio-blk-pc
From: Gonglei
Avoid the caller of object_property_print() leaking string
argument's memory, such as qdev_print_props() when
encounter errors.
Cc: Paolo Bonzini
Signed-off-by: Gonglei
---
qom/object.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/qom/object.
From: Gonglei
The descriptions can serve as documentation in the code,
and they can be used to provide better help.
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Markus Armbruster
Signed-off-by: Gonglei
---
include/qom/object.h | 15 +++
qom/object.c | 12
2
From: Gonglei
The legacy_name is useless now, the better help
information provied by description field of property.
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Markus Armbruster
Signed-off-by: Gonglei
---
hw/core/qdev-properties-system.c | 4
hw/core/qdev-properties.c| 6 -
From: Gonglei
When we call qdev_alias_all_properties() adding alias properties to
the source object all qdev properties on the target DeviceState,
set the object property's description to the qdev property's.
c: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Markus Armbruster
Signed-off-by: Gonglei
From: Gonglei
PATCH 1 and PATCH 2 are bugfixes. PATCH 3~7 add a description
field in both ObjectProperty and PropertyInfo struct.
The descriptions can serve as documentation in the code,
and they can be used to provide better help. For example:
Before this patch series:
$./qemu-system-x86_64 -d
From: Gonglei
object_property_add_alias() is called at some
places at present. And its parameter errp may not NULL,
such as
object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread",
&error_abort);
This patch add error handler for security.
Cc: Stefa
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Paolo Bonzini
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-storage.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index d97f7fd..bd7cc53 100644
--- a/hw/usb/dev-sto
From: Gonglei
In this way, all the implementations now use
error_setg instead of error_report for reporting error.
Signed-off-by: Gonglei
Reviewed-by: Paolo Bonzini
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-storage.c | 21 -
1 file changed, 8 insertions(+), 13 deletions
Stefan Hajnoczi writes:
> On Mon, Sep 22, 2014 at 05:45:15PM +0200, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > Over time a few unused trace events have been left behind in
>> > ./trace-events.
>> > Either the code that called them was deleted or the event was
>> > never called
Event megasas_io_read was added in commit e8f943c, but never used.
Drop it.
Signed-off-by: Markus Armbruster
---
trace-events | 2 --
1 file changed, 2 deletions(-)
diff --git a/trace-events b/trace-events
index 467439b..cdabb4e 100644
--- a/trace-events
+++ b/trace-events
@@ -668,8 +668,6 @@ m
A few files have been renamed without updating their comment here. A
few events have been added in the wrong place. Clean that up.
Comments with no space after the '#' look ugly and confuse
cleanup-trace-events.pl. Insert a space.
scripts/cleanup-trace-events.pl is now happy again.
Signed-off
The script can get fooled too easily. For instance, it finds
trace_megasas_io_read_start when looking for trace_megasas_io_read,
and incorrectly concludes that event megasas_io_read is used.
Supply -w to git-grep to tighten the search.
Signed-off-by: Markus Armbruster
---
scripts/cleanup-trace
Event monitor_protocol_event is unused since commit 7517517. Drop it.
Signed-off-by: Markus Armbruster
---
trace-events | 1 -
1 file changed, 1 deletion(-)
diff --git a/trace-events b/trace-events
index cdabb4e..6eada18 100644
--- a/trace-events
+++ b/trace-events
@@ -927,7 +927,6 @@ esp_pci_
This series applies on top of Stefan's "trace: drop orphan events from
./trace-events".
Markus Armbruster (4):
cleanup-trace-events.pl: Tighten search for trace event call
trace-events: Drop unused megasas trace event
trace-events: Drop orphaned monitor trace event
trace-events: Fix commen
Kevin Wolf writes:
> Am 22.09.2014 um 18:34 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
>> >> diff --git a/include/block/block_int.h b/include/block/block_int.h
>> >> index 8d86a6c..14e0b7c 100644
>> >> --- a/include
On 2014/9/23 19:12, Igor Mammedov wrote:
On Tue, 23 Sep 2014 18:11:35 +0800
zhanghailiang wrote:
On 2014/9/23 16:58, Tang Chen wrote:
On 09/23/2014 04:40 PM, Igor Mammedov wrote:
..
It's fine to use SRAT for these purposes on baremetal NUMA systems since
due to used chipset constrains i
From: Gonglei
In this way, all the implementations now use
error_setg instead of error_report for reporting error.
Signed-off-by: Gonglei
Reviewed-by: Paolo Bonzini
Signed-off-by: Gerd Hoffmann
---
hw/usb/host-libusb.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
07e2863d0271ac6c05206d8ce9e4f4c39b25d3ea:
exec.c: fix setting 1-byte-long watchpoints (2014-09-19 17:42:16 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-usb-20140923-1
for you to fetch changes up to ec56214f6f23c1e2f78de6afa6835acc35fc03ed:
usb: tag
1 - 100 of 232 matches
Mail list logo
