On Thu, Aug 20, 2015 at 02:54:29PM -0700, Eduardo Habkost wrote:
> Machine class names should use the "-machine" suffix to allow
> class-name-based machine class lookup to work. Rename the vexpress
> machine classes using the MACHINE_TYPE_NAME macro.
>
> Cc: Peter Maydell
> Signed-off-by: Eduardo
On Thu, Aug 20, 2015 at 02:54:34PM -0700, Eduardo Habkost wrote:
> It will result in exactly the same class name, but it will make the code
> consistent with the other classes.
>
> Cc: Alexander Graf
> Cc: qemu-...@nongnu.org
> Signed-off-by: Eduardo Habkost
Reviewed-by: David Gibson
> ---
>
On Thu, Aug 20, 2015 at 02:54:28PM -0700, Eduardo Habkost wrote:
> The MachineClass::name field won't be ever be used on TYPE_VEXPRESS, as
> it is an abstract class and the machine class lookup code explicitly
> skips abstract classes. We can remove it to make the code simpler.
>
> Cc: Peter Mayde
On Thu, Aug 20, 2015 at 02:54:32PM -0700, Eduardo Habkost wrote:
> Machine class names should use the "-machine" suffix to allow
> class-name-based machine class lookup to work. Rename the s390-virtio
> machine class using the MACHINE_TYPE_NAME macro.
>
> Cc: Alexander Graf
> Cc: Richard Henderso
On Thu, Aug 20, 2015 at 02:54:30PM -0700, Eduardo Habkost wrote:
> Machine class names should use the "-machine" suffix to allow
> class-name-based machine class lookup to work. Rename the arm virt
> machine class using the MACHINE_TYPE_NAME macro.
>
> Cc: Peter Maydell
> Signed-off-by: Eduardo H
On Thu, Aug 20, 2015 at 02:54:33PM -0700, Eduardo Habkost wrote:
> Machine class names should use the "-machine" suffix to allow
> class-name-based machine class lookup to work. Rename the
> s390-ccw-virtio-2.4 machine class using the MACHINE_TYPE_NAME macro.
>
> Cc: Alexander Graf
> Cc: Cornelia
On Thu, Aug 20, 2015 at 02:54:31PM -0700, Eduardo Habkost wrote:
> Machine class names should use the "-machine" suffix to allow
> class-name-based machine class lookup to work. Rename the the pseries
> machine classes using the MACHINE_TYPE_NAME macro.
>
> Cc: Alexander Graf
> Cc: qemu-...@nongn
On 29/08/2015 19:36, Programmingkid wrote:
> > > Mac OS X is a second-class citizen in the QEMU world...
> >
> > Might have to do something with most (?) of it being non-free and Apple
> > not caring enough about KVM.
>
> Fact, Apple has made an hypervisor API available as of Mac OS 10.10, so w
On 29/08/2015 18:39, Max Reitz wrote:
>> Mac OS X is a second-class citizen in the QEMU world...
>
> Might have to do something with most (?) of it being non-free and
> Apple not caring enough about KVM.
>
> (And without KVM, people in turn don't care enough about OS X as a
> qemu host.)
>
> (
On Fri, Aug 28, 2015 at 01:53:39AM +, Ouyang, Changchun wrote:
> Hi Michael,
>
> Thanks for your response!
>
> > -Original Message-
> > From: snabb-de...@googlegroups.com [mailto:snabb-
> > de...@googlegroups.com] On Behalf Of Michael S. Tsirkin
> > Sent: Thursday, August 27, 2015 9:0
On Thu, Aug 20, 2015 at 02:54:27PM -0700, Eduardo Habkost wrote:
> The macro will be useful to ensure the machine class names follow the
> right format to make machine class lookup by class name work correctly.
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: David Gibson
--
David Gibson
After download and merge the all related patches to my local qemu, for
me:
- The refactor code is really very good to me! :-)
- It cause "hello world" test program "segment fault".
Do we need fix all related issues before merge the code?
- If I need fix them after finish merging the refacto
At present, I can send mail through git client directly with my qq mail
address, I reply this mail again to test whether our qemu mailing list
can accept qq mail address or not.
If it can accept qq mail address, I shall send mail through git client
directly.
> OK, thanks. I guess I should send ma
At present, I can send mail through git client directly with my qq mail
address, I reply this mail again to test whether our qemu mailing list
can accept qq mail address or not.
If it can accept qq mail address, I shall send mail through git client
directly.
> OK, thanks. I guess I should send ma
On Aug 29, 2015, at 7:04 PM, Eric Blake wrote:
> On 08/29/2015 11:36 AM, Programmingkid wrote:
>
>>>
Mac OS X is a second-class citizen in the QEMU world...
>>>
>>> Might have to do something with most (?) of it being non-free and Apple
>>> not caring enough about KVM.
>>
>> Fact, Apple
On Aug 29, 2015, at 7:10 PM, Eric Blake wrote:
> On 08/29/2015 01:34 PM, Max Reitz wrote:
>
Erm, well, I think I won't reply to that other than *cough* virt-manager
*cough*.
>>>
>>> Linux exclusive probably.
>>
>> Your point?
>>
>> You said applications on Linux are generally more d
On 8/29/15 22:50, Peter Maydell wrote:
> On 24 August 2015 at 17:17, Richard Henderson wrote:
>
>> + qemu_log_mask(CPU_LOG_TB_IN_ASM, " %" PRIx64 ": { ", dc->pc);
>> + if (get_Mode(bundle)) {
>> + notice_excp(dc, bundle, "y0", decode_y0(dc, bundle));
>> + qemu_log_mask(CPU_LOG_TB_IN_ASM, " ; ");
>
On Aug 29, 2015, at 7:12 PM, Eric Blake wrote:
> On 08/29/2015 02:18 PM, Programmingkid wrote:
>
>>>
>>> (1) 'change' always uses 'raw' as the format, but the selector
>>> apparently offers you the full range of image formats
>>> (supportedImageFileTypes).
>>
>> So far it has worked out just f
On 08/29/2015 02:18 PM, Programmingkid wrote:
>>
>> (1) 'change' always uses 'raw' as the format, but the selector
>> apparently offers you the full range of image formats
>> (supportedImageFileTypes).
>
> So far it has worked out just fine. Doesn't QEMU detect the format itself?
You DON'T want
On 08/29/2015 01:34 PM, Max Reitz wrote:
>>> Erm, well, I think I won't reply to that other than *cough* virt-manager
>>> *cough*.
>>
>> Linux exclusive probably.
>
> Your point?
>
> You said applications on Linux are generally more difficult to use than
> comparable applications on OS X, by des
On 08/29/2015 11:36 AM, Programmingkid wrote:
>>
>>> Mac OS X is a second-class citizen in the QEMU world...
>>
>> Might have to do something with most (?) of it being non-free and Apple
>> not caring enough about KVM.
>
> Fact, Apple has made an hypervisor API available as of Mac OS 10.10, so wh
On 29 August 2015 at 23:27, Peter Crosthwaite
wrote:
> "platform"
>
> On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois
> wrote:
>> Tested by booting a minimal Linux system on the emulated platform
>> Tested by booting the Xvisor hyprvisor on the emulated platform
>>
>
> "hypervisor"
Which
On Mon, Aug 10, 2015 at 3:03 PM, Jean-Christophe Dubois
wrote:
> This is using a ds1338 RTC chip on the I2C bus. This RTC chip is
> not present on the real 3DS PDK board.
>
> Signed-off-by: Jean-Christophe Dubois
Not an expert, but looks ok.
Acked-by: Peter Crosthwaite
> ---
>
> Changes since
"platform"
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois
wrote:
> Tested by booting a minimal Linux system on the emulated platform
> Tested by booting the Xvisor hyprvisor on the emulated platform
>
"hypervisor"
> Signed-off-by: Jean-Christophe Dubois
> ---
>
> Changes since v1:
>
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois
wrote:
> For now we support the following devices:
> * CPU: ARM926
> * Interrupt Controller: AVIC
> * CCM
> * UART x 5
> * EPIT x 2
> * GPT x 4
> * FEC
> * I2C x 3
>
> Signed-off-by: Jean-Ch
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois
wrote:
> This is based on mcf_fec.c FEC implementation for Coldfire
>
> * A generic PHY was added (borrowwed from LAN9118)
> * The buffer management is also modified as buffers are
> slightly different between Coldfire and i.MX
>
> Si
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois
wrote:
> The slave mode is not implemented.
>
> Signed-off-by: Jean-Christophe Dubois
> Reviewed-by: Peter Crosthwaite
Have you changed my email from the original RB? You should generally
keep this the same to preserve the affiliations whi
Commit subject should lead with out a verb after the subsystem label(s).
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois
wrote:
> Tested by booting a minimal Linux system on the emulated platform
Commit message should lead out with longer form of the main change.
Make a note in commit me
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Most of which are either nops or exceptions.
>
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 94
> ++-
> 1 file changed, 68 insertions(+), 26 deletions(-)
>
> diff --git a
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 39 +--
> 1 file changed, 33 insertions(+), 6 deletions(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 51
> +++
> 1 file changed, 38 insertions(+), 13 deletions(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> +if (dc->jmp.cond != TCG_COND_NEVER) {
> +if (dc->jmp.cond == TCG_COND_ALWAYS) {
> +tcg_gen_mov_i64(cpu_pc, dc->jmp.dest);
> +} else {
> +TCGv next = tcg_const_i64
On Aug 29, 2015, at 2:01 PM, Max Reitz wrote:
> On 29.08.2015 19:36, Programmingkid wrote:
>>
>> On Aug 29, 2015, at 12:39 PM, Max Reitz wrote:
>>
>>> On 29.08.2015 17:57, Programmingkid wrote:
On Aug 29, 2015, at 11:40 AM, Max Reitz wrote:
> On 27.08.2015 03:05, G 3 wrote:
On Aug 29, 2015, at 12:39 PM, Max Reitz wrote:
> On 29.08.2015 17:57, Programmingkid wrote:
>>
>> On Aug 29, 2015, at 11:40 AM, Max Reitz wrote:
>>
>>> On 27.08.2015 03:05, G 3 wrote:
I want to share files between my host and guest computer. A feature I
want to add would be a new menu
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 58
> +--
> 1 file changed, 41 insertions(+), 17 deletions(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 96
> ++-
> 1 file changed, 87 insertions(+), 9 deletions(-)
>
Reviewed-by: Peter Maydell
thanks
-- PMM
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 131
> --
> 1 file changed, 116 insertions(+), 15 deletions(-)
>
Reviewed-by: Peter Maydell
thanks
-- PMM
On Aug 29, 2015, at 3:52 PM, Max Reitz wrote:
> On 29.08.2015 20:34, MagicCat Software wrote:
>>
>> On Aug 29, 2015, at 2:01 PM, Max Reitz wrote:
>
> [snip]
>
>>> User-friendliness is always expensive,
>>> difficult to maintain, and a neverending source of complaints.
>>
>> Really? It has bee
On Aug 29, 2015, at 3:34 PM, Max Reitz wrote:
> On 29.08.2015 20:34, MagicCat Software wrote:
>>
>> On Aug 29, 2015, at 2:01 PM, Max Reitz wrote:
>>
>>> On 29.08.2015 19:36, Programmingkid wrote:
On Aug 29, 2015, at 12:39 PM, Max Reitz wrote:
>
> [snip]
>
If making QEMU more u
On 29.08.2015 20:34, MagicCat Software wrote:
>
> On Aug 29, 2015, at 2:01 PM, Max Reitz wrote:
[snip]
>> User-friendliness is always expensive,
>> difficult to maintain, and a neverending source of complaints.
>
> Really? It has been months since Peter Maydell implemented my GUI patches
> for
EM_MOXIE now has a proper assigned elf code. Use it. Register the old
interim value as EM_MOXIE_OLD and accept either in elf loading.
Cc: Anthony Green
Signed-off-by: Peter Crosthwaite
---
hw/moxie/moxiesim.c | 1 +
include/elf.h| 3 +++
include/hw/elf_ops.h | 8
target-moxie/
On Mon, Aug 17, 2015 at 8:48 PM, Richard Henderson wrote:
> On 08/17/2015 08:36 PM, Peter Crosthwaite wrote:
>>
>> On Mon, Aug 17, 2015 at 11:39 AM, Richard Henderson
>> wrote:
>>>
>>> On 08/15/2015 04:28 PM, Peter Crosthwaite wrote:
- ELF_MACHINE, 0);
+
Hi Richard,
This adds EM_MOXIE as suggested. Patch one does some surrounding code
style cleanup and P2 fixes Moxie.
Regards,
Peter
Peter Crosthwaite (2):
elf_ops: Fix coding style for EM alias case statement
elf: Update EM_MOXIE definition
hw/moxie/moxiesim.c | 1 +
include/elf.h
Fix the coding style for these cases as per CODING_STYLE. Reverse the
Yoda conditions and add missing if braces.
Signed-off-by: Peter Crosthwaite
---
include/hw/elf_ops.h | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops
On 29.08.2015 20:34, MagicCat Software wrote:
>
> On Aug 29, 2015, at 2:01 PM, Max Reitz wrote:
>
>> On 29.08.2015 19:36, Programmingkid wrote:
>>>
>>> On Aug 29, 2015, at 12:39 PM, Max Reitz wrote:
[snip]
>>> If making QEMU more user-friendly is a crime, I plead guilty!
>>
>> Yes, in some peop
On 29.08.2015 19:36, Programmingkid wrote:
>
> On Aug 29, 2015, at 12:39 PM, Max Reitz wrote:
>
>> On 29.08.2015 17:57, Programmingkid wrote:
>>>
>>> On Aug 29, 2015, at 11:40 AM, Max Reitz wrote:
>>>
On 27.08.2015 03:05, G 3 wrote:
> I want to share files between my host and guest compu
On 29.08.2015 17:57, Programmingkid wrote:
>
> On Aug 29, 2015, at 11:40 AM, Max Reitz wrote:
>
>> On 27.08.2015 03:05, G 3 wrote:
>>> I want to share files between my host and guest computer. A feature I
>>> want to add would be a new menu item in the Machine menu called "Mount
>>> Image File...
On 29 August 2015 at 17:04, Jonathan Neuschäfer wrote:
> On Thu, Aug 27, 2015 at 07:06:24PM +0100, Peter Maydell wrote:
>> This definitely looks like a bug, but I don't think this is
>> a sufficient fix, because if DEBUG_REMAP is defined then the
>> locked-memory which the target_cmsghdr* is in is
On Thu, Aug 27, 2015 at 07:06:24PM +0100, Peter Maydell wrote:
> This definitely looks like a bug, but I don't think this is
> a sufficient fix, because if DEBUG_REMAP is defined then the
> locked-memory which the target_cmsghdr* is in is not a
> simple g2h() away from the host pointer.
>
> What y
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Omitting crc instructions.
I'm not a fan of commit message bodies that rely on reading
the subject line to make sense (partly because my mail
client doesn't put the subject line very prominently
when reading the email...)
> Signed-off-by: Ri
On Aug 29, 2015, at 11:40 AM, Max Reitz wrote:
> On 27.08.2015 03:05, G 3 wrote:
>> I want to share files between my host and guest computer. A feature I
>> want to add would be a new menu item in the Machine menu called "Mount
>> Image File...". When the user selects it, a file open dialog box
>
On 27.08.2015 12:02, Wen Congyang wrote:
> We can start a nbd server in qemu, and the nbd client will connect
> to this server later. Each client has a export name, and the server
> will know the disk the client want to use according to the export
> name.
>
> If there are two clients that have the
On 27.08.2015 03:05, G 3 wrote:
> I want to share files between my host and guest computer. A feature I
> want to add would be a new menu item in the Machine menu called "Mount
> Image File...". When the user selects it, a file open dialog box
> displays. The user can then select the image file wit
On 27.08.2015 12:30, Peter Lieven wrote:
> If the file is readonly its not expected to grow so
> save the blocking call to nfs_fstat_async and use
> the value saved at connection time. Also important
> the monitor (and thus the main loop) will not hang
> if block device info is queried and the NFS
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 95
> ---
> 1 file changed, 89 insertions(+), 6 deletions(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 99
> +--
> 1 file changed, 96 insertions(+), 3 deletions(-)
>
> diff --git a/target-tilegx/translate.c b/target-tilegx/transla
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> linux-user/main.c | 3 +++
> target-tilegx/cpu.c | 5 -
> target-tilegx/cpu.h | 2 ++
> 3 files changed, 9 insertions(+), 1 deletion(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/translate.c | 1145
> +
> 1 file changed, 1145 insertions(+)
> create mode 100644 target-tilegx/translate.c
>
> diff --git a/target-tilegx/t
On 24 August 2015 at 17:17, Richard Henderson wrote:
> From: Chen Gang
>
> The related instructions are exception, cntlz, cnttz, shufflebytes.
>
> Signed-off-by: Chen Gang
> Message-Id:
> [rth: Remove incorrect implementation of add_saturate.]
> Signed-off-by: Richard Henderson
> ---
> +/*
>
On 24 August 2015 at 17:17, Richard Henderson wrote:
> An obvious typo in the mnemonic here.
>
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/opcode_tilegx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On 24 August 2015 at 17:17, Richard Henderson wrote:
> Both ADDX_SPECIAL_0_OPCODE_Y1 and ADD_SPECIAL_0_OPCODE_Y1
> do not appear to be "special" in any way, except that they
> don't follow the normal naming convention using _RRR_.
>
> Signed-off-by: Richard Henderson
> ---
> target-tilegx/opcode
Is tilegx patches OK to qemu mater tree?
Or shall I do anything for it? If I should do something for it, please
let me know, I shall try.
I almost finished analyzing one gcc bug (found root cause, got correct
result with my patch), it was waiting review. If I needn't do anything
for tilegx mergi
The uninstall keys include an optional key "DisplayVersion" which we set
now. By default the version value is read from file VERSION, but it is
also possible to pass VERSION=#.#.# to make.
Signed-off-by: Stefan Weil
---
Makefile | 1 +
qemu.nsi | 3 +++
2 files changed, 4 insertions(+)
diff --g
On 29 August 2015 at 11:33, Peter Crosthwaite
wrote:
> Every arch adds its disas configury to both its own config as well
> config_disas_all. Make a small function do to both at once.
>
> Signed-off-by: Peter Crosthwaite
> ---
> Changed since v1:
> Factor out everything except just the arch name.
Every arch adds its disas configury to both its own config as well
config_disas_all. Make a small function do to both at once.
Signed-off-by: Peter Crosthwaite
---
Changed since v1:
Factor out everything except just the arch name.
Prepares support for multi-arch where the disas configury for
mul
On Sat, Jul 18, 2015 at 2:09 AM, Peter Maydell wrote:
> On 18 July 2015 at 07:25, Peter Crosthwaite
> wrote:
>> Every arch adds its disas configury to both its own config as well
>> config_disas_all. Make a small function do to both at once.
>>
>> Signed-off-by: Peter Crosthwaite
>> ---
>> Prep
On Sat, Aug 29, 2015 at 3:08 AM, Peter Maydell wrote:
> On 29 August 2015 at 11:06, Peter Crosthwaite
> wrote:
>> Hi Peter,
>>
>> This removes the last of the hw_errors from target-arm.
>
> Hi; can you remind me what the reason was for wanting
> to remove them?
>
So hw_error is depracated in it'
On 29 August 2015 at 11:06, Peter Crosthwaite
wrote:
> Hi Peter,
>
> This removes the last of the hw_errors from target-arm.
Hi; can you remind me what the reason was for wanting
to remove them?
thanks
-- PMM
On 29 August 2015 at 08:29, Stefan Weil wrote:
> Warnings from the Sparse static analysis tool:
>
> linux-user/main.c:40:12: warning:
> symbol 'filename' was not declared. Should it be static?
> linux-user/main.c:41:12: warning:
> symbol 'argv0' was not declared. Should it be static?
> linux-use
All of these hw_errors are fatal and indicate something wrong with
QEMU implementation.
Convert to g_assert_not_reached.
Reviewed-by: Peter Maydell
Signed-off-by: Peter Crosthwaite
---
Dropped the error messages as they are not hugely useful outside of
a debug flow.
---
target-arm/cpu.c| 4
Hi Peter,
This removes the last of the hw_errors from target-arm.
Regards,
Peter
Changed since v1:
Handle everything as an assert()
Peter Crosthwaite (2):
arm: cpu: assert() on no-EL2 virt IRQ error condition.
arm: Remove hw_error() usages.
target-arm/cpu.c| 9 +++--
target-arm/he
Replace the hw_error() for no-EL2 VIRQ with an assert.
Signed-off-by: Peter Crosthwaite
---
Changed since v1:
Reimplement as assert
---
target-arm/cpu.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/target-arm/cpu.c b/target-arm/cpu.c
index cc6c6f3..4ba5929 100644
--- a
Signed-off-by: Stefan Weil
---
disas/microblaze.c | 150 -
1 file changed, 150 deletions(-)
diff --git a/disas/microblaze.c b/disas/microblaze.c
index c14ab89..3588235 100644
--- a/disas/microblaze.c
+++ b/disas/microblaze.c
@@ -604,25 +604,6 @
Warnings from the Sparse static analysis tool:
linux-user/main.c:40:12: warning:
symbol 'filename' was not declared. Should it be static?
linux-user/main.c:41:12: warning:
symbol 'argv0' was not declared. Should it be static?
linux-user/main.c:42:5: warning:
symbol 'gdbstub_port' was not declar
On 2015/8/29 14:49, Paolo Bonzini wrote:
>
>
> On 28/08/2015 14:53, Markus Armbruster wrote:
>> I believe this makes sense no matter what we do about device IDs (see
>> thread "Should we auto-generate IDs?").
>
> I haven't read that huge thread yet, but I think it gives the user too
> much power
On 28/08/2015 16:57, Peter Maydell wrote:
>> > More #ifdefs are not nice, but this clarifies why its usage is not
>> > protected by tb_lock.
> Does it? I thought the idea of this series was to add locking
> which we needed for adding multi-threading to softmmu, in
> which case presumably we need
Casting pointers to long won't work on 64 bit Windows.
It is not needed with the right format strings.
Signed-off-by: Stefan Weil
---
slirp/bootp.c | 12 +---
slirp/if.c | 4 ++--
slirp/ip_icmp.c| 4 ++--
slirp/ip_input.c | 10 +-
slirp/ip_output.c | 4 ++--
On 28/08/2015 16:56, Peter Maydell wrote:
> What's the rationale for this? Mostly we prefer not to
> add ifdefs in code if we can get away with compiling it for
> both cases, even if the resulting code isn't used.
True. The rationale is three-fold:
1) It makes sense to abort if TB_EXIT_ICOUNT_
78 matches
Mail list logo
