Re: [Qemu-devel] [kvm-unit-tests PATCHv6 2/3] arm: pmu: Check cycle count increases

2016-10-12 Thread Wei Huang
On 10/12/2016 01:10 PM, Christopher Covington wrote: > Hi Wei, > > On 10/12/2016 11:49 AM, Wei Huang wrote: >> On 10/11/2016 01:40 PM, Christopher Covington wrote: >>> Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, >>> even for the smallest delta of two subsequent reads. >>>

[Qemu-devel] [PATCH v3 2/4] target-arm: Code changes to implement overwrite of tag field on PC load

2016-10-12 Thread Thomas Hanson
For BR, BLR and RET instructions, if tagged addresses are enabled, the tag field in the address must be cleared out prior to loading the address into the PC. Depending on the current EL, it will be set to either all 0's or all 1's. Signed-off-by: Thomas Hanson --- target-arm/translate-a64.c | 9

Re: [Qemu-devel] [PATCH 2/3] target-arm: Code changes to implement overwrite of tag field on PC load

2016-10-12 Thread Tom Hanson
On 10/11/2016 10:12 AM, Peter Maydell wrote: > On 11 October 2016 at 16:51, Thomas Hanson wrote: >> On 5 October 2016 at 16:01, Peter Maydell wrote: >>> It matches the style of the rest of the code which generally >>> prefers to convert register numbers into TCGv earlier rather >>> than later (at

[Qemu-devel] [PATCH v3 3/4] target-arm: Comments to mark location of pending work for 56 bit addresses

2016-10-12 Thread Thomas Hanson
Certain instructions which can not directly load a tagged address value may trigger a corner case when the address size is 56 bits. This is because incrementing or offsetting from the current PC can cause an arithetic roll-over into the tag bits. Per the ARM ARM spec, these cases should also be a

[Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC

2016-10-12 Thread Thomas Hanson
If tagged addresses are enabled, then addresses being loaded into the PC must be cleaned up by overwriting the tag bits with either all 0's or all 1's as specified in the ARM ARM spec. The decision process is dependent on whether the code will be running in EL0/1 or in EL2/3 and is controlled

[Qemu-devel] [PATCH v3 1/4] target-arm: Infrastucture changes to enable handling of tagged address loading into PC

2016-10-12 Thread Thomas Hanson
When capturing the current CPU state for the TB, extract the TBI0 and TBI1 values from the correct TCR for the current EL and then add them to the TB flags field. Then, at the start of code generation for the block, copy the TBI fields into the DisasContext structure. Signed-off-by: Thomas Hanson

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

2016-10-12 Thread Max Reitz
On 12.10.2016 10:55, Hao QingFeng wrote: > Max, > > Just a common question for this case, if sshx block driver wasn't built > into qemu-img, this case would fail as below: Good point, and thanks for bringing it up, but it's not directly linked to this series other than by its subject, of course,

Re: [Qemu-devel] [PATCH v8 6/6] Add common functions for SET_IRQS and GET_REGION_INFO ioctls

2016-10-12 Thread Kirti Wankhede
On 10/12/2016 4:48 AM, Alex Williamson wrote: > On Tue, 11 Oct 2016 01:58:37 +0530 > Kirti Wankhede wrote: > >> Add common functions for SET_IRQS and to add capability buffer for >> GET_REGION_INFO ioctls > > Clearly should be two (or more) separate patches since SET_IRQS and > REGION_INFO are

[Qemu-devel] chardev's and fd's in monitors

2016-10-12 Thread Dr. David Alan Gilbert
Hi, I had a look at a couple of readline like libraries; editline and linenoise. A difficulty with using them is that they both want fd's or FILE*'s; editline takes either but from a brief look I think it's expecting to extract the fd. That makes them tricky to integrate into qemu, where the cha

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-12 Thread Kirti Wankhede
On 10/12/2016 9:29 PM, Alex Williamson wrote: > On Wed, 12 Oct 2016 20:43:48 +0530 > Kirti Wankhede wrote: > >> On 10/12/2016 7:22 AM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Wednesday, October 12, 2016 4:45 AM >> +* mdev_supported_types:

[Qemu-devel] [PATCH] script/clean-includes: added duplicate #include check

2016-10-12 Thread Anand J
Added script to check duplicate #include entries. This check will scan and print the files in which duplicate #include entries are present. Script might output false postive entries as well. Such entries should not be removed. So if it finds any duplicate entries script will terminate with an exit

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

2016-10-12 Thread David Hildenbrand
On Wed, Oct 12, 2016 at 03:55:18PM +0200, Claudio Imbrenda wrote: > On 12/10/16 15:15, David Hildenbrand wrote: > >>> +for (cx = 0; ccpus && ccpus[cx]; cx++) { > >>> +cpu_single_step(cpu, 0); > > > > This looks suspicious > > why? we set all cpus to single step, since

Re: [Qemu-devel] [PATCH 05/22] qcow2-bitmap: structs and consts

2016-10-12 Thread Max Reitz
On 11.10.2016 13:50, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 17:34, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Create block/qcow2-bitmap.c >>> Add data structures and constraints accordingly to docs/specs/qcow2.txt >>> >>> Signed-off-by: Vladimir Se

Re: [Qemu-devel] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-12 Thread Max Reitz
On 12.10.2016 14:30, Vladimir Sementsov-Ogievskiy wrote: > On 12.10.2016 14:38, Vladimir Sementsov-Ogievskiy wrote: >> On 07.10.2016 22:28, Max Reitz wrote: >>> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved

Re: [Qemu-devel] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-12 Thread Max Reitz
On 11.10.2016 15:11, Vladimir Sementsov-Ogievskiy wrote: > On 07.10.2016 20:54, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> New field BdrvDirtyBitmap.persistent means, that bitmap should be saved >>> on bdrv_close, using format driver. Format driver should maint

Re: [Qemu-devel] [PATCH 06/22] qcow2: add dirty bitmaps extension

2016-10-12 Thread Max Reitz
On 11.10.2016 14:09, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 17:46, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Add dirty bitmap extension as specified in docs/specs/qcow2.txt. >>> For now, just mirror extension header into Qcow2 state and check >>>

Re: [Qemu-devel] [PATCH] target-lm32: fix LOG_DIS operand order

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 18:15, Michael Walle wrote: > The order of most opcodes with immediates was wrong (according to the > reference manual) in the (debug) logging. Additionally, one operand for the > andhi instruction was completly wrong. Fix these. > > Signed-off-by: Michael Walle Reviewed-by

Re: [Qemu-devel] [Qemu-block] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.10.2016 um 17:50 hat Markus Armbruster geschrieben: >> "Daniel P. Berrange" writes: >> >> > The traditional CLI arg syntax allows two ways to specify >> > integer lists, either one value per key, or a range of >> > values per key. eg the following are identical: >> >

Re: [Qemu-devel] [PATCH] vfio: Fix vfio_rtl8168_quirk_data_read address offset

2016-10-12 Thread Thorsten Kohfeldt
Am 10.10.2016 um 17:18 schrieb Alex Williamson: On Sun, 9 Oct 2016 19:56:03 +0200 Thorsten Kohfeldt wrote: From: Thorsten Kohfeldt Date: Sat, 24 Sep 2016 20:43:20 +0200 Subject: [PATCH] vfio: Fix vfio_rtl8168_quirk_data_read address offset Introductory comment for rtl8168 VFIO MSI-X quirk s

Re: [Qemu-devel] [kvm-unit-tests PATCHv6 2/3] arm: pmu: Check cycle count increases

2016-10-12 Thread Christopher Covington
Hi Wei, On 10/12/2016 11:49 AM, Wei Huang wrote: > On 10/11/2016 01:40 PM, Christopher Covington wrote: >> Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, >> even for the smallest delta of two subsequent reads. >> >> Signed-off-by: Christopher Covington >> Reviewed-by: Andrew J

[Qemu-devel] [PATCH v2 1/4] target-arm: Implement dummy MDCCINT_EL1

2016-10-12 Thread Peter Maydell
MDCCINT_EL1 is part of the DCC debugger communication channel between the CPU and an attached external debugger. QEMU doesn't implement this, but since Linux may try to access this register we need to provide at least a dummy implementation. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Igle

[Qemu-devel] [PATCH v2 4/4] hw/char/pl011: Add trace events

2016-10-12 Thread Peter Maydell
Add some trace events for the pl011 UART model. Signed-off-by: Peter Maydell --- hw/char/pl011.c | 71 hw/char/trace-events | 9 +++ 2 files changed, 59 insertions(+), 21 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c i

[Qemu-devel] [PATCH v2 3/4] hw/intc/arm_gicv3: Fix ICC register tracepoints

2016-10-12 Thread Peter Maydell
Fix some problems with the tracepoints for ICC register reads and writes: * tracepoints for ICC_BPR, ICC_APR, ICC_IGRPEN, ICC_EIOR were not printing the that indicated whether the access was to the group 0 or 1 register * the ICC_IGREPEN1_EL3 read function was not actually calling the a

[Qemu-devel] [PATCH v2 2/4] target-arm: Add trace events for the generic timers

2016-10-12 Thread Peter Maydell
Add some useful trace events for the ARM generic timers (notably the various register writes and the resulting IRQ line state). Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- Makefile.objs | 1 + target-arm/helper.c | 20 target-arm/trace-eve

[Qemu-devel] [PATCH v2 0/4] preliminaries for GICv3 virt support

2016-10-12 Thread Peter Maydell
This set of straightforward patches is a preliminary for adding virtualization support to the GICv3 emulation: * add a (nop implementation of) MDCCINT_EL1, since KVM will read/write it on worldswitch * fix some bugs in the GICv3 trace events * add trace events for the generic timers (which

Re: [Qemu-devel] [PATCH v14 12/21] option: allow qemu_opts_to_qdict to merge repeated options

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > If given an option string such as > > size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind > > the qemu_opts_to_qdict() method will currently overwrite > the values for repeated option keys, so only the last > value is in the returned dict: > > size=QString("102

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-12 Thread Jianjun Duan
On 10/12/2016 05:07 AM, Paolo Bonzini wrote: > > > On 12/10/2016 13:59, Halil Pasic wrote: >> IMHO this would: >> * allow us to keep the good old MVStateInfo objects unmodified and >> the semantic of VMStateInfo unchanged >> * make clear that VMStateLinked does not care about the calculated s

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 18:11, Michael Walle wrote: > Am 2016-10-12 18:35, schrieb Peter Maydell: >> but I noticed while doing the review that our LOG_DIS >> is wrong for the compare-immediates: >> >> LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, >> sign_extend(dc->imm16, 1

[Qemu-devel] [PATCH] target-lm32: fix LOG_DIS operand order

2016-10-12 Thread Michael Walle
The order of most opcodes with immediates was wrong (according to the reference manual) in the (debug) logging. Additionally, one operand for the andhi instruction was completly wrong. Fix these. Signed-off-by: Michael Walle --- target-lm32/translate.c | 34 +- 1

Re: [Qemu-devel] [PATCH 1/2] compiler: add ignore_value() macro

2016-10-12 Thread Felipe Franciosi
> On 21 Sep 2016, at 19:15, Eric Blake wrote: > > On 09/21/2016 10:27 AM, Felipe Franciosi wrote: >> On GCC versions 3.4 and newer, simply using (void) in front of a >> function that has been declared with WUR will no longer suppress a >> compilation warning. This commit brings the ignore_value(

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 17:42, Michael Walle wrote: > Am 2016-10-12 18:35, schrieb Peter Maydell: >> >> but I noticed while doing the review that our LOG_DIS >> is wrong for the compare-immediates: >> >> LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, >> sign_extend(dc->imm16

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Michael Walle
Am 2016-10-12 18:35, schrieb Peter Maydell: On 12 October 2016 at 17:23, Michael Walle wrote: Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle --- target-lm32/translate.

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 10:10 PM, Kevin Wolf wrote: > Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: >> On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: >> > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> >> This series adds blockdev-add support for SSH block driver. >> >

Re: [Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 9:21 PM, Kevin Wolf wrote: > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> Add InetSocketAddress compatibility to SSH driver. >> >> Add a new option "server" to the SSH block driver which then accepts >> a InetSocketAddress. >> >> "host" and "port" are support

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

2016-10-12 Thread Paolo Bonzini
On 12/10/2016 15:55, Claudio Imbrenda wrote: >>> +for (cx = 0; ccpus && ccpus[cx]; cx++) { >>> +cpu_single_step(cpu, 0); >> > >> > This looks suspicious > why? we set all cpus to single step, since that is the default, and then > we clear the single-step pro

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Michael Walle
Am 2016-10-12 18:35, schrieb Peter Maydell: but I noticed while doing the review that our LOG_DIS is wrong for the compare-immediates: LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, sign_extend(dc->imm16, 16)); but the processor reference manual says cmpei's mnemonic sh

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > >> This series adds blockdev-add support for SSH block driver. > >> > >> Patch 1 prepares the code for the addition of a new

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 17:23, Michael Walle wrote: > Both branches of the ternary operator have the same expressions. Drop the > operator. > > This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 > > Signed-off-by: Michael Walle > --- > target-lm32/translate.c | 2 +- > 1 file changed, 1 inse

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Thomas Huth
On 12.10.2016 18:23, Michael Walle wrote: > Both branches of the ternary operator have the same expressions. Drop the > operator. > > This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 > > Signed-off-by: Michael Walle > --- > target-lm32/translate.c | 2 +- > 1 file changed, 1 insertion(+

[Qemu-devel] [Bug 1541643] Re: IA32_FEATURE_CONTROL MSR unset for nested virtualization

2016-10-12 Thread man
** Also affects: archlinux Importance: Undecided Status: New ** No longer affects: archlinux -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1541643 Title: IA32_FEATURE_CONTROL MSR unset f

[Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Michael Walle
Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle --- target-lm32/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-lm32/translate.c b/tar

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> This series adds blockdev-add support for SSH block driver. >> >> Patch 1 prepares the code for the addition of a new option prefix, >> which is "server.". This is accomplished by addin

Re: [Qemu-devel] [PATCH v6 15/35] tcg: Add CONFIG_ATOMIC64

2016-10-12 Thread Alex Bennée
Richard Henderson writes: > Allow qemu to build on 32-bit hosts without 64-bit atomic ops. > > Even if we only allow 32-bit hosts to multi-thread emulate 32-bit > guests, we still need some way to handle the 32-bit guest using a > 64-bit atomic operation. Do so by dropping back to single-step.

Re: [Qemu-devel] [PATCH v6 13/35] tcg: Add atomic helpers

2016-10-12 Thread Alex Bennée
Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > Makefile.objs | 2 +- > Ma

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-12 Thread John Snow
On 10/12/2016 06:22 AM, Kevin Wolf wrote: Am 11.10.2016 um 17:47 hat John Snow geschrieben: On 10/10/2016 03:23 PM, Mark Cave-Ayland wrote: On 10/10/16 17:34, Eric Blake wrote: On 10/09/2016 11:43 AM, Mark Cave-Ayland wrote: The hard-coded default alignment is BDRV_SECTOR_SIZE, however thi

Re: [Qemu-devel] [PATCH] hw/tpm/tpm_passthrough: Simplify if-statements a little bit

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 16:33, Thomas Huth wrote: > The condition '!A || (A && B)' is equivalent to '!A || B' > > Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 > Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 11/11] iotests: add transactional failure race test

2016-10-12 Thread John Snow
On 10/12/2016 07:26 AM, Vladimir Sementsov-Ogievskiy wrote: it is almost a duplication of test_transaction_failure, I think it would be better to make separate do_test_transaction_failure with parameter and two wrappers Yes, sorry -- I missed that for this iteration, but I'll act on it for

Re: [Qemu-devel] [Qemu-block] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 17:50 hat Markus Armbruster geschrieben: > "Daniel P. Berrange" writes: > > > The traditional CLI arg syntax allows two ways to specify > > integer lists, either one value per key, or a range of > > values per key. eg the following are identical: > > > > -arg foo=5,foo=6,foo=7

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a > ssh_has_filename_options_conflict() function which

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-12 Thread Alex Williamson
On Wed, 12 Oct 2016 20:43:48 +0530 Kirti Wankhede wrote: > On 10/12/2016 7:22 AM, Tian, Kevin wrote: > >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > >> Sent: Wednesday, October 12, 2016 4:45 AM > +* mdev_supported_types: > +List of current supported mediated device types

Re: [Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > Add InetSocketAddress compatibility to SSH driver. > > Add a new option "server" to the SSH block driver which then accepts > a InetSocketAddress. > > "host" and "port" are supported as legacy options and are mapped to > their InetSocketA

Re: [Qemu-devel] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The traditional CLI arg syntax allows two ways to specify > integer lists, either one value per key, or a range of > values per key. eg the following are identical: > > -arg foo=5,foo=6,foo=7 > -arg foo=5-7 > > This extends the QObjectInputVisitor so that it is

Re: [Qemu-devel] [kvm-unit-tests PATCHv6 2/3] arm: pmu: Check cycle count increases

2016-10-12 Thread Wei Huang
On 10/11/2016 01:40 PM, Christopher Covington wrote: > Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, > even for the smallest delta of two subsequent reads. > > Signed-off-by: Christopher Covington > Reviewed-by: Andrew Jones > --- > arm/pmu.c | 60

[Qemu-devel] error reporting in functions

2016-10-12 Thread Vladimir Sementsov-Ogievskiy
HI all! My questions is: what are general recommendations in Qemu for return code, if we have Error **errp? What should I prefer: errp, duplicated by int return code, or void functions with errp? void + errp seems good, just to not duplicate things. But it has a disadvantage of necessity of

[Qemu-devel] [PATCH] hw/tpm/tpm_passthrough: Simplify if-statements a little bit

2016-10-12 Thread Thomas Huth
The condition '!A || (A && B)' is equivalent to '!A || B' Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth --- hw/tpm/tpm_passthrough.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c i

Re: [Qemu-devel] [kvm-unit-tests PATCHv6 1/3] arm: Add PMU test

2016-10-12 Thread Wei Huang
On 10/11/2016 01:40 PM, Christopher Covington wrote: > Beginning with a simple sanity check of the control register, add > a unit test for the ARM Performance Monitors Unit (PMU). As of > October 2016, whether KVM mode has a PMU at all is a tricky > question of which QEMU / mach-virt version is u

Re: [Qemu-devel] Async savevm using userfaultfd(2)

2016-10-12 Thread Denis V. Lunev
On 10/12/2016 05:04 PM, Stefan Hajnoczi wrote: > John and I recently discussed asynchronous savevm and I wanted to post > the ideas so they aren't forgotten. (We're not actively working on this > feature.) > > Asynchronous savevm has the same effect as the 'savevm' monitor command: > it saves RAM,

Re: [Qemu-devel] MTTCG memory ordering

2016-10-12 Thread Pranith Kumar
Hi Stefan, Stefan Hajnoczi writes: > Hi Pranith, > I was curious about the status of your MTTCG GSoC work: > > I saw your fence series which implements the noop memory barrier/fence > instructions on various architectures, but I wasn't sure if that also > covers the case where a strong target is

Re: [Qemu-devel] [PATCH V2] docs: add PCIe devices placement guidelines

2016-10-12 Thread Laszlo Ersek
Marcel, On 10/11/16 15:45, Marcel Apfelbaum wrote: > Proposes best practices on how to use PCI Express/PCI device > in PCI Express based machines and explain the reasoning behind them. > > Signed-off-by: Marcel Apfelbaum > --- > > Hi, > > RFC->v2: > - Addressed a lot of comments from the revi

Re: [Qemu-devel] [PATCH] hw/block/nvme: Simplify if-statements a little bit

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 16:18, Thomas Huth wrote: > The condition '!A || (A && B)' is equivalent to '!A || B'. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 > Signed-off-by: Thomas Huth > --- > hw/block/nvme.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> Markus Armbruster writes: >> >>> "Daniel P. Berrange" writes: >>> Currently the QObjectInputVisitor assumes that all scalar values are directly represented as the final types declared by the thing being visited. ie it as

[Qemu-devel] [PATCH] hw/block/nvme: Simplify if-statements a little bit

2016-10-12 Thread Thomas Huth
The condition '!A || (A && B)' is equivalent to '!A || B'. Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth --- hw/block/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index cef3bb4..53d9d2e 100644

Re: [Qemu-devel] MTTCG memory ordering

2016-10-12 Thread Laszlo Ersek
On 10/12/16 10:58, Stefan Hajnoczi wrote: > Hi Pranith, > I was curious about the status of your MTTCG GSoC work: > > I saw your fence series which implements the noop memory barrier/fence > instructions on various architectures, but I wasn't sure if that also > covers the case where a strong targ

Re: [Qemu-devel] [PATCH] socket: add atomic QEMU_SOCK_NONBLOCK flag

2016-10-12 Thread Stefan Hajnoczi
On Fri, Oct 07, 2016 at 10:55:55AM -0500, Eric Blake wrote: > On 10/07/2016 08:54 AM, Stefan Hajnoczi wrote: > > The socket(2) and accept(2) syscalls have been extended to take flags > > that affect the socket atomically at creation time. This not only > > avoids the overhead of additional system

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-12 Thread Kirti Wankhede
On 10/12/2016 7:22 AM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, October 12, 2016 4:45 AM +* mdev_supported_types: +List of current supported mediated device types and its details are added +in this directory in following

Re: [Qemu-devel] PSA: wiki cleaned up

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 11:48, Paolo Bonzini wrote: > I don't have the power to delete pages on the wiki You do now :-) thanks -- PMM

Re: [Qemu-devel] [PATCH 4/4] qga: add vsock-listen method

2016-10-12 Thread Stefan Hajnoczi
On Fri, Oct 07, 2016 at 12:07:41PM -0500, Michael Roth wrote: > Quoting Stefan Hajnoczi (2016-10-06 11:40:18) > > Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-serial. > > > > $ qemu-system-x86_64 -device vhost-vsock-pci,guest-cid=3 ... > > (guest)# qemu-ga -m vsock-listen -p

Re: [Qemu-devel] [PATCH 3/4] sockets: add AF_VSOCK support

2016-10-12 Thread Stefan Hajnoczi
On Fri, Oct 07, 2016 at 11:42:35AM -0500, Michael Roth wrote: > Quoting Stefan Hajnoczi (2016-10-06 11:40:17) > > Add the AF_VSOCK address family so that qemu-ga will be able to use > > virtio-vsock. > > > > The AF_VSOCK address family uses address tuples. The cid is > > the unique identifier co

Re: [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> "Daniel P. Berrange" writes: >> >>> Currently the QObjectInputVisitor assumes that all scalar >>> values are directly represented as the final types declared >>> by the thing being visited. ie it assumes an 'int' is using >> >> i.e. >>

[Qemu-devel] [Bug 1630527] Re: qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

2016-10-12 Thread T. Huth
Thanks for reporting this bug! Looks like this has already been fixed by this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=1d5b128cbeeab638f772e ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-12 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 10/12/2016 02:07 PM, Paolo Bonzini wrote: > > > > On 12/10/2016 13:59, Halil Pasic wrote: > >> > IMHO this would: > >> > * allow us to keep the good old MVStateInfo objects unmodified and > >> > the semantic of VMStateInfo unchanged > >>

Re: [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Markus Armbruster writes: > "Daniel P. Berrange" writes: > >> Currently the QObjectInputVisitor assumes that all scalar >> values are directly represented as the final types declared >> by the thing being visited. ie it assumes an 'int' is using > > i.e. > >> QInt, and a 'bool' is using QBool, e

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Alberto Garcia
On Wed 12 Oct 2016 04:30:27 PM CEST, Kevin Wolf wrote: >> if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_STREAM, errp)) { >> goto out; >> } > > Added a bit more context. > > This check is redundant now... > >> if (has_base) { >> base_bs = bdrv_find_backing_image(bs, base

Re: [Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 16:33 hat Alberto Garcia geschrieben: > On Wed 12 Oct 2016 04:23:05 PM CEST, Kevin Wolf wrote: > >> +/* Block all intermediate nodes between bs and base, because they > >> + * will disappear from the chain after this operation */ > >> +for (iter = backing_bs(bs); iter

Re: [Qemu-devel] [PATCH v10 10/16] docs: Document how to stream to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia > --- > docs/live-block-ops.txt | 31 --- > 1 file changed, 20 insertions(+), 11 deletions(-) > > diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt > index a257087..014

Re: [Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer

2016-10-12 Thread Alberto Garcia
On Wed 12 Oct 2016 04:23:05 PM CEST, Kevin Wolf wrote: >> +/* Block all intermediate nodes between bs and base, because they >> + * will disappear from the chain after this operation */ >> +for (iter = backing_bs(bs); iter && iter != base; iter = >> backing_bs(iter)) { >> +blo

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > This patch makes the 'device' parameter of the 'block-stream' command > accept a node name that is not a root node. > > In addition to that, operation blockers will be checked in all > intermediate nodes between the top and the base node. >

Re: [Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > This makes sure that the image we are streaming into is open in > read-write mode during the operation. > > Operation blockers are also set in all intermediate nodes, since they > will be removed from the chain afterwards. > > Finally, this

Re: [Qemu-devel] Async savevm using userfaultfd(2)

2016-10-12 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > John and I recently discussed asynchronous savevm and I wanted to post > the ideas so they aren't forgotten. (We're not actively working on this > feature.) > > Asynchronous savevm has the same effect as the 'savevm' monitor command: > it saves RAM,

Re: [Qemu-devel] Async savevm using userfaultfd(2)

2016-10-12 Thread Eric Blake
On 10/12/2016 09:04 AM, Stefan Hajnoczi wrote: > John and I recently discussed asynchronous savevm and I wanted to post > the ideas so they aren't forgotten. (We're not actively working on this > feature.) > > Asynchronous savevm has the same effect as the 'savevm' monitor command: > it saves RAM

Re: [Qemu-devel] [PULL 00/11] usb patch queue

2016-10-12 Thread Peter Maydell
at: > > git://git.kraxel.org/qemu tags/pull-usb-20161012-1 > > for you to fetch changes up to d5c42857d6b0c35028897df8dfc3749eba6f6de3: > > usb-redir: allocate buffers before waking up the host adapter (2016-10-12 > 14:37:24 +0200) > > ---

Re: [Qemu-devel] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > Some of the historical command line opts that had their > keys in in a completely flat namespace are now represented > by QAPI schemas that use a nested structs. When converting > the QemuOpts to QObject, there is no information about > compound types available, so

Re: [Qemu-devel] [PATCH v2] 9pfs: fix memory leak in v9fs_write

2016-10-12 Thread Greg Kurz
On Wed, 12 Oct 2016 06:10:56 -0700 Li Qiang wrote: > From: Li Qiang > > If an error occurs when marshal the transfer length to the guest, the > v9fs_write doesn't free an IO vector, thus leading a memory leak. > This patch fix this. > > Signed-off-by: Li Qiang > --- Good catch again! Reviewe

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Oct 06, 2016 at 05:51:57PM +0200, Kevin Wolf wrote: >> Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: >> > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: >> > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: >> > > > On T

Re: [Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start()

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > When block-commit is launched without the top parameter, it uses > internally a mirror block job. In that case all intermediate nodes > between the active and base nodes must be blocked as well. > > Signed-off-by: Alberto Garcia Same as th

[Qemu-devel] Async savevm using userfaultfd(2)

2016-10-12 Thread Stefan Hajnoczi
John and I recently discussed asynchronous savevm and I wanted to post the ideas so they aren't forgotten. (We're not actively working on this feature.) Asynchronous savevm has the same effect as the 'savevm' monitor command: it saves RAM, device state, and a snapshot of all disks at the point in

Re: [Qemu-devel] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start()

2016-10-12 Thread Alberto Garcia
On Wed 12 Oct 2016 03:47:34 PM CEST, Kevin Wolf wrote: > Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: >> Use block_job_add_bdrv() instead of blocking all operations in >> backup_start() and unblocking them in backup_run(). >> >> Signed-off-by: Alberto Garcia > > This has the same probl

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

2016-10-12 Thread Claudio Imbrenda
On 12/10/16 15:15, David Hildenbrand wrote: >>> +for (cx = 0; ccpus && ccpus[cx]; cx++) { >>> +cpu_single_step(cpu, 0); > > This looks suspicious why? we set all cpus to single step, since that is the default, and then we clear the single-step property from all CPUs th

Re: [Qemu-devel] [PATCH v10 05/16] block: Check blockers in all nodes involved in a block-commit job

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > qmp_block_commit() checks for op blockers in the active and > destination (base) images. However all nodes between top_bs and base > are also involved, and they are removed from the chain afterwards. > > In addition to that, if top_bs is not

Re: [Qemu-devel] [PATCH v10 06/16] block: Block all nodes involved in the block-commit operation

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > After a successful block-commit operation all nodes between top and > base are removed from the backing chain, and top's overlay needs to > be updated to point to base. Because of that we should prevent other > block jobs from messing with th

Re: [Qemu-devel] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start()

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > Use block_job_add_bdrv() instead of blocking all operations in > backup_start() and unblocking them in backup_run(). > > Signed-off-by: Alberto Garcia This has the same problem as mirror (dataplane must be blocked). Kevin

Re: [Qemu-devel] [PATCH 12/15] xen: Rename xen_be_evtchn_event

2016-10-12 Thread Anthony PERARD
On Tue, Oct 04, 2016 at 09:43:41AM +0300, Emil Condrea wrote: > Prepare xen_be_evtchn_event to be shared with frontends: > * xen_be_evtchn_event -> xen_pv_evtchn_event > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCH 14/15] xen: Rename xen_be_del_xendev

2016-10-12 Thread Anthony PERARD
On Tue, Oct 04, 2016 at 09:43:43AM +0300, Emil Condrea wrote: > Prepare xen_be_del_xendev to be shared with frontends: > * xen_be_del_xendev -> xen_pv_del_xendev > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCHv2 6/7] spapr_pci: Add a 64-bit MMIO window

2016-10-12 Thread Laurent Vivier
On 12/10/2016 06:44, David Gibson wrote: > On real hardware, and under pHyp, the PCI host bridges on Power machines > typically advertise two outbound MMIO windows from the guest's physical > memory space to PCI memory space: > - A 32-bit window which maps onto 2GiB..4GiB in the PCI address spa

Re: [Qemu-devel] [PATCH 13/15] xen: Rename xen_be_find_xendev

2016-10-12 Thread Anthony PERARD
On Tue, Oct 04, 2016 at 09:43:42AM +0300, Emil Condrea wrote: > Prepare xen_be_find_xendev to be shared with frontends: > * xen_be_find_xendev -> xen_pv_find_xendev > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCH 10/15] xen: Rename xen_be_unbind_evtchn

2016-10-12 Thread Anthony PERARD
On Tue, Oct 04, 2016 at 09:43:39AM +0300, Emil Condrea wrote: > Prepare xen_be_unbind_evtchn to be shared with frontends: > * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCH v3 6/7] target-arm: Make page size a runtime setting

2016-10-12 Thread Andrew Jones
On Tue, Oct 11, 2016 at 06:08:18PM +0100, Peter Maydell wrote: > Rather than defining TARGET_PAGE_BITS to always be 10, > switch to using a value picked at runtime. This allows us > to use 4K pages for modern ARM CPUs (and in particular all > 64-bit CPUs) without having to drop support for the old

Re: [Qemu-devel] [PATCH v3 6/7] target-arm: Make page size a runtime setting

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 14:33, Andrew Jones wrote: > On Tue, Oct 11, 2016 at 06:08:18PM +0100, Peter Maydell wrote: >> Rather than defining TARGET_PAGE_BITS to always be 10, >> switch to using a value picked at runtime. This allows us >> to use 4K pages for modern ARM CPUs (and in particular all >>

Re: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link

2016-10-12 Thread Greg Kurz
On Wed, 12 Oct 2016 00:12:48 -0700 Li Qiang wrote: > From: Li Qiang > > In v9fs_link dispatch function, it doesn't put the 'oldfidp' > fid object, this will make the 'oldfidp->ref' never reach to 0, > thus leading a memory leak issue. This patch fix this. > > Signed-off-by: Li Qiang > --- Go

Re: [Qemu-devel] [PATCH 11/15] xen: Rename xen_be_send_notify

2016-10-12 Thread Anthony PERARD
On Tue, Oct 04, 2016 at 09:43:40AM +0300, Emil Condrea wrote: > Prepare xen_be_send_notify to be shared with frontends: > * xen_be_send_notify -> xen_pv_send_notify > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

<    1   2   3   4   >