Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

Hi Eric, Ping on this? http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg06169.html F. On 02/03/2017, 16:55, "Qemu-devel on behalf of no-re...@patchew.org" wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Su

Re: [Qemu-devel] [RFC 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue

On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: > Overview of the problem > === > On Exynos4210, by default Linux kernel uses cpuidle driver which tries > to enter low power mode, called AFTR (Arm Off, Top Running). On real > hardware this brings some power savings. This

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application Message-id: 1488472983-9108-1-git-send-email-fel...@nutanix.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing scri

Re: [Qemu-devel] [PATCH 1/5] hw/intc/exynos4210_gic: Fix GIC memory mappings for secondary CPU

On Thu, Mar 2, 2017 at 6:37 PM, Peter Maydell wrote: > On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: >> Recent Linux kernel (tested next-20170224) was complaining about missing >> GIC mask and was unable to bring up secondary CPU: >> >> [0.00] NR_IRQS:16 nr_irqs:16 16 >> [

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1488472983-9108-1-git-send-email-fel...@nutanix.com Type: series Subject: [Qemu-devel] [PATCH v4 0/3] Introduce vh

[Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

Based on various discussions on the 2016 KVM Forum, I'm sending over a vhost-user-scsi implementation for your consideration. This patchset introduces a new vhost-user SCSI device. While heavily based on vhost-scsi, it is implemented using vhost's userspace counterpart. The device has been coded a

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1488472983-9108-1-git-send-email-fel...@nutanix.com Type: series Subject: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application === TEST SCRIPT BEGIN === #!/bin/ba

Re: [Qemu-devel] [PATCH 4/5] hw/timer/exynos4210_mct: Fix checkpatch style errors

On Thu, Mar 2, 2017 at 6:44 PM, Peter Maydell wrote: > On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: >> Fix checkpatch errors: >> 1. ERROR: spaces required around that '+' (ctx:VxV) >> 2. ERROR: spaces required around that '&' (ctx:VxV) >> >> No functional changes. >> >> Signed-off-by: Krz

Re: [Qemu-devel] [PATCH 4/5] hw/timer/exynos4210_mct: Fix checkpatch style errors

On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: > Fix checkpatch errors: > 1. ERROR: spaces required around that '+' (ctx:VxV) > 2. ERROR: spaces required around that '&' (ctx:VxV) > > No functional changes. > > Signed-off-by: Krzysztof Kozlowski > --- > hw/timer/exynos4210_mct.c | 4 ++-- >

[Qemu-devel] [PATCH v4 1/3] vhost-scsi: create a vhost-scsi-common abstraction

In order to introduce a new vhost-user-scsi host device type, it makes sense to abstract part of vhost-scsi into a common parent class. This commit does exactly that. Signed-off-by: Felipe Franciosi --- hw/scsi/Makefile.objs | 2 +- hw/scsi/vhost-scsi-common.c | 143 +

[Qemu-devel] [PATCH v4 2/3] vus: Introduce vhost-user-scsi host device

This commit introduces a vhost-user device for SCSI. This is based on the existing vhost-scsi implementation, but done over vhost-user instead. It also uses a chardev to connect to the backend. Unlike vhost-scsi (today), VMs using vhost-user-scsi can be live migrated. To use it, start Qemu with a

[Qemu-devel] [PATCH v4 3/3] vus: Introduce a vhost-user-scsi sample application

This commit introduces a vhost-user-scsi backend sample application. It must be linked with libiscsi and libvhost-user. To use it, compile with: make vhost-user-scsi And run as follows: ./vhost-user-scsi -u /tmp/vus.sock -i iscsi://uri_to_target/ The application is currently limited at one LUN o

Re: [Qemu-devel] [PATCH 5/5] hw/timer/exynos4210_mct: Remove unused defines

On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: > Remove defines not used anywhere. > > Signed-off-by: Krzysztof Kozlowski > --- > hw/timer/exynos4210_mct.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c > index 4dd3e441e2e6.

Re: [Qemu-devel] [PATCH 4/5] hw/timer/exynos4210_mct: Fix checkpatch style errors

On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: > Fix checkpatch errors: > 1. ERROR: spaces required around that '+' (ctx:VxV) > 2. ERROR: spaces required around that '&' (ctx:VxV) > > No functional changes. > > Signed-off-by: Krzysztof Kozlowski > --- > hw/timer/exynos4210_mct.c | 4 ++-- >

Re: [Qemu-devel] [PATCH 3/5] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines

On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: > Statements under 'case' were in some places wrongly indented bringing > confusion and making the code less readable. Remove also few unneeded > blank lines. No functional changes. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: P

Re: [Qemu-devel] [PATCH 2/5] hw/intc/exynos4210_gic: Use more meaningful name for local variable

On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: > There are to SysBusDevice variables in exynos4210_gic_realize() > function: one for the device itself and second for arm_gic device. Add > a prefix "gic" to the second one so it will be easier to understand the > code. > > While at it, put lo

Re: [Qemu-devel] [PATCH 1/5] hw/intc/exynos4210_gic: Fix GIC memory mappings for secondary CPU

On 1 March 2017 at 18:26, Krzysztof Kozlowski wrote: > Recent Linux kernel (tested next-20170224) was complaining about missing > GIC mask and was unable to bring up secondary CPU: > > [0.00] NR_IRQS:16 nr_irqs:16 16 > [0.00] GIC CPU mask not found - kernel will fail to boo

Re: [Qemu-devel] [PULL 05/15] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

On 03/02/17 16:32, Michael S. Tsirkin wrote: > On Thu, Mar 02, 2017 at 06:50:45AM -0800, Ben Warren wrote: >> I >>> On Mar 2, 2017, at 5:15 AM, Laszlo Ersek wrote: >>> >>> On 03/02/17 09:42, Markus Armbruster wrote: Laszlo Ersek writes: > On 03/02/17 09:11, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCH 2/2] arm: kvm: set MPIDR when we can

On Thu, Mar 02, 2017 at 04:13:40PM +, Peter Maydell wrote: > On 27 February 2017 at 17:37, Andrew Jones wrote: > > If KVM supports user provided MPIDRs for the vcpus, then provide > > them. This simplifies management of vcpus as we can be sure of > > the identity of a vcpu even before it's bee

Re: [Qemu-devel] travis-ci 'make check' timeouts (was Re: [PULL 00/11] x86 queue, 2017-02-27)

On 2 March 2017 at 16:07, Eduardo Habkost wrote: > Earlier this week I saw the wait_for_fds assertion (mentioned at > the thread above) on a travis-ci job again, and I was suspecting > it was the same vhost_set_mem_table() + TCG error seen at the > thread above. > > Unfortunately travis-ci overwro

Re: [Qemu-devel] [PATCH v2 1/2] migration: allow clearing migration string parameters

On 03/02/2017 06:37 AM, Daniel P. Berrange wrote: > Some of the migration parameters are strings, which default to NULL, > eg tls-hostname and tls-creds. > > The mgmt app will set the tls-creds parameter on both source and target > QEMU instances, in order to trigger use of TLS for migration. > >

Re: [Qemu-devel] travis-ci 'make check' timeouts (was Re: [PULL 00/11] x86 queue, 2017-02-27)

On 02/03/2017 17:07, Eduardo Habkost wrote: > On Thu, Mar 02, 2017 at 04:54:26PM +0100, Paolo Bonzini wrote: >> On 02/03/2017 16:39, Eduardo Habkost wrote: >>> On Tue, Feb 28, 2017 at 07:17:39PM +, Peter Maydell wrote: On 28 February 2017 at 19:12, Eduardo Habkost wrote: > I saw a f

Re: [Qemu-devel] [PATCH 1/1] virtio-blk: fix race on guest notifiers

On 02/03/2017 16:55, Halil Pasic wrote: blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context()); > I'm wondering if synchronization is needed for batch_notify_vqs. I think > the set_bit can be from the iothread, but the notify_guest_bh below is main > event loop. Is it OK like th

[Qemu-devel] [PATCH v3 2/2] migration: always report tls-creds & tls-hostname migrate parameters

Currently the query-migrate-parameters command will omit reporting of the tls-creds & tls-hostname parameters if their value is NULL. This makes it impossible for an app to detect if these parameters are supported by QEMU, without trying to actually set them and catching the error. Since the code i

[Qemu-devel] [PATCH v3 1/2] migration: allow clearing migration string parameters

Some of the migration parameters are strings, which default to NULL, eg tls-hostname and tls-creds. The mgmt app will set the tls-creds parameter on both source and target QEMU instances, in order to trigger use of TLS for migration. After performing a TLS encrypted migration though, migration mi

[Qemu-devel] [PATCH v3 0/2] migration: fixes to handling tls-hostname/tls-creds

The need for these two patches was identified during implementation of TLS encrypted migration in libvirt. Changed in v3: - Add to qapi-schema.json docs Daniel P. Berrange (2): migration: allow clearing migration string parameters migration: always report tls-creds & tls-hostname migrate p

Re: [Qemu-devel] [PATCH 2/2] arm: kvm: set MPIDR when we can

On 27 February 2017 at 17:37, Andrew Jones wrote: > If KVM supports user provided MPIDRs for the vcpus, then provide > them. This simplifies management of vcpus as we can be sure of > the identity of a vcpu even before it's been instantiated. > > Cc: Igor Mammedov > Signed-off-by: Andrew Jones >

[Qemu-devel] [PULL v2 2/3] tests: fix leaks in test-io-channel-command

From: Marc-André Lureau No need for strdup, fix leaks when socat is missing. Spotted by ASAN. Signed-off-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange --- tests/test-io-channel-command.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/test-io-channel

[Qemu-devel] [PULL v2 3/3] io: fully parse & validate HTTP headers for websocket protocol handshake

The current websockets protocol handshake code is very relaxed, just doing crude string searching across the HTTP header data. This causes it to both reject valid connections and fail to reject invalid connections. For example, according to the RFC 6455 it: - MUST reject any method other than "GE

[Qemu-devel] [PULL v2 1/3] io: fix decoding when multiple websockets frames arrive at once

The qio_channel_websock_read_wire() method will read upto 4096 bytes off the socket and then decode the websockets header and payload. The code was only decoding a single websockets frame, even if the buffered data contained multiple frames. This meant that decoding of subsequent frames was delayed

[Qemu-devel] [PULL v2 0/3] Merge qio 2017/02/27

The following changes since commit 8f2d7c341184a95d05476ea3c45dbae2b9ddbe51: Merge remote-tracking branch 'remotes/berrange/tags/pull-qcrypto-2017-02-27-1' into staging (2017-02-27 15:33:21 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qio-2017-02-

Re: [Qemu-devel] [PATCH v2 2/2] migration: always report tls-creds & tls-hostname migrate parameters

On 03/02/2017 06:37 AM, Daniel P. Berrange wrote: > Currently the query-migrate-parameters command will omit reporting > of the tls-creds & tls-hostname parameters if their value is NULL. > This makes it impossible for an app to detect if these parameters > are supported by QEMU, without trying to

Re: [Qemu-devel] travis-ci 'make check' timeouts (was Re: [PULL 00/11] x86 queue, 2017-02-27)

On Thu, Mar 02, 2017 at 04:54:26PM +0100, Paolo Bonzini wrote: > On 02/03/2017 16:39, Eduardo Habkost wrote: > > On Tue, Feb 28, 2017 at 07:17:39PM +, Peter Maydell wrote: > >> On 28 February 2017 at 19:12, Eduardo Habkost wrote: > >>> I saw a failure on x86-pull-request that seemed to be beca

Re: [Qemu-devel] [PATCH 0/2] misc aarch64 fixes for Windows

On 28 February 2017 at 22:22, Andrew Baumann wrote: >> From: no-re...@patchew.org [mailto:no-re...@patchew.org] >> Sent: Tuesday, 28 February 2017 14:13 >> >> Hi, >> >> This series failed build test on s390x host. Please find the details below. > [..] >> /var/tmp/patchew-tester-tmp-64adnjjr/src/ta

Re: [Qemu-devel] [PATCH] qmp: allow setting properties to empty string in qmp-shell

On 03/02/2017 06:24 AM, Daniel P. Berrange wrote: > The qmp-shell property parser currently rejects attempts to > set string properties to the empty string eg > > (QEMU) migrate-set-parameters tls-hostname= > Error while parsing command line: Expected a key=value pair, got > 'tls-hostname='

Re: [Qemu-devel] travis-ci 'make check' timeouts (was Re: [PULL 00/11] x86 queue, 2017-02-27)

On 02/03/2017 16:39, Eduardo Habkost wrote: > On Tue, Feb 28, 2017 at 07:17:39PM +, Peter Maydell wrote: >> On 28 February 2017 at 19:12, Eduardo Habkost wrote: >>> I saw a failure on x86-pull-request that seemed to be because of >>> vhost-user-test[1]. However, after restarting the job, it

Re: [Qemu-devel] [PATCH 1/2] target/arm: implement armv8 PMUSERENR (user-mode enable bits)

On 28 February 2017 at 21:58, Andrew Baumann wrote: > In armv8, this register implements more than a single bit, with > fine-grained enables for read access to event counters, cycles > counters, and write access to the software increment. This change > implements those checks using custom access f

Re: [Qemu-devel] [PATCH 1/1] virtio-blk: fix race on guest notifiers

On 03/02/2017 04:32 PM, Paolo Bonzini wrote: > > > On 02/03/2017 15:49, Cornelia Huck wrote: >> On Thu, 2 Mar 2017 14:04:22 +0100 >> Halil Pasic wrote: >> >>> diff --git a/hw/block/dataplane/virtio-blk.c >>> b/hw/block/dataplane/virtio-blk.c >>> index 5556f0e..13dd14d 100644 >>> --- a/hw/blo

Re: [Qemu-devel] travis-ci 'make check' timeouts (was Re: [PULL 00/11] x86 queue, 2017-02-27)

On Tue, Feb 28, 2017 at 07:17:39PM +, Peter Maydell wrote: > On 28 February 2017 at 19:12, Eduardo Habkost wrote: > > I saw a failure on x86-pull-request that seemed to be because of > > vhost-user-test[1]. However, after restarting the job, it > > passed[2]. > > I'm currently processing a pa

Re: [Qemu-devel] [PULL 05/15] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

On Thu, Mar 02, 2017 at 06:50:45AM -0800, Ben Warren wrote: > I > > On Mar 2, 2017, at 5:15 AM, Laszlo Ersek wrote: > > > > On 03/02/17 09:42, Markus Armbruster wrote: > >> Laszlo Ersek writes: > >> > >>> On 03/02/17 09:11, Markus Armbruster wrote: > Crash bug, I'm afraid... > >

Re: [Qemu-devel] [PATCH 1/1] virtio-blk: fix race on guest notifiers

On 02/03/2017 15:49, Cornelia Huck wrote: > On Thu, 2 Mar 2017 14:04:22 +0100 > Halil Pasic wrote: > >> diff --git a/hw/block/dataplane/virtio-blk.c >> b/hw/block/dataplane/virtio-blk.c >> index 5556f0e..13dd14d 100644 >> --- a/hw/block/dataplane/virtio-blk.c >> +++ b/hw/block/dataplane/virti

Re: [Qemu-devel] [PULL 00/24] block: Command line option -blockdev

On 28 February 2017 at 22:25, Markus Armbruster wrote: > Actually, the command line option is the least part of this series. > Its bulk is about building infrastructure and getting errors out of > the JSON parser[*]. The latter part could be spun out in its own > series, if that helps. We'll see

Re: [Qemu-devel] [PULL 00/15] virtio, pc: fixes, features

On Thu, Mar 02, 2017 at 08:34:42AM +, Peter Maydell wrote: > On 2 March 2017 at 06:20, Michael S. Tsirkin wrote: > > The following changes since commit 1e0addb682c3c552fd97480037d4f8ff18e2b87e: > > > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170228-tag' > > into staging

Re: [Qemu-devel] [PULL 00/50] ppc-for-2.9 queue 20170301

On 1 March 2017 at 04:43, David Gibson wrote: > The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba: > > vhost-user: delay vhost_user_stop (2017-02-28 19:11:15 +) > > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.9-2017

Re: [Qemu-devel] [PULL 05/15] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

I > On Mar 2, 2017, at 5:15 AM, Laszlo Ersek wrote: > > On 03/02/17 09:42, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 03/02/17 09:11, Markus Armbruster wrote: Crash bug, I'm afraid... "Michael S. Tsirkin" writes: > From: Igor Mammedov > > Add

Re: [Qemu-devel] [PATCH 1/1] virtio-blk: fix race on guest notifiers

On Thu, 2 Mar 2017 14:04:22 +0100 Halil Pasic wrote: > diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c > index 5556f0e..13dd14d 100644 > --- a/hw/block/dataplane/virtio-blk.c > +++ b/hw/block/dataplane/virtio-blk.c > @@ -258,9 +258,16 @@ void virtio_blk_data_plane_

Re: [Qemu-devel] [PATCH] qmp-shell: add persistent command history

On Wed, Mar 01, 2017 at 02:44:33PM -0500, John Snow wrote: > Use the existing readline history function we are utilizing > to provide persistent command history across instances of qmp-shell. Thanks for adding it to 'qmp-shell' this is useful. I normally use the READLINE functionality using 'qmp_

Re: [Qemu-devel] [PATCH RFC] block: Tolerate existing writers on read only BdrvChild

Am 02.03.2017 um 12:21 hat Fam Zheng geschrieben: > On Wed, 03/01 17:22, Kevin Wolf wrote: > > Am 01.03.2017 um 17:10 hat Fam Zheng geschrieben: > > > On Wed, 03/01 16:16, Kevin Wolf wrote: > > > > > I'm not sure about this because: 1) this is intrusive from a user > > > > > PoV, many > > > > > sc

[Qemu-devel] [PATCH v2] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

Use the softfloat api for fused multiply-add. Introduce routine to set the FPSCR flags VXNAN, VXIMZ nad VMISI. Signed-off-by: Nikunj A Dadhania --- v1: * Removed float64_madd_set_vxisi() * Introduced float64_maddsub_update_excp() will updated required flags * Changed layout of error handling v

Re: [Qemu-devel] [PULL for-2.9] Update OpenBIOS images

On 28 February 2017 at 22:16, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the OpenBIOS updates for QEMU 2.9. Please pull. > > > ATB, > > Mark. > > > The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba: > > vhost-user: delay vhost_user_stop (2017-02-28 19:11:15 +)

Re: [Qemu-devel] [PATCH v2 2/2] migration: always report tls-creds & tls-hostname migrate parameters

On Thu, Mar 02, 2017 at 08:19:29AM -0500, John Ferlan wrote: > > > On 03/02/2017 07:37 AM, Daniel P. Berrange wrote: > > Currently the query-migrate-parameters command will omit reporting > > of the tls-creds & tls-hostname parameters if their value is NULL. > > This makes it impossible for an ap

Re: [Qemu-devel] [PATCH v2 2/2] migration: always report tls-creds & tls-hostname migrate parameters

On 03/02/2017 07:37 AM, Daniel P. Berrange wrote: > Currently the query-migrate-parameters command will omit reporting > of the tls-creds & tls-hostname parameters if their value is NULL. > This makes it impossible for an app to detect if these parameters > are supported by QEMU, without trying t

Re: [Qemu-devel] [PULL 05/15] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

On 03/02/17 09:42, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 03/02/17 09:11, Markus Armbruster wrote: >>> Crash bug, I'm afraid... >>> >>> "Michael S. Tsirkin" writes: >>> From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP

Re: [Qemu-devel] [PATCH 1/1] virtio: fallback from irqfd to non-irqfd notify

On 03/01/2017 08:53 PM, Paolo Bonzini wrote: > > > On 01/03/2017 17:08, Halil Pasic wrote: >> applied I do not see the problem any more. I will most likely >> turn this into a patch tomorrow. I would like to give it some more testing >> and >> thinking (see questions below) until tomorrow. >>

Re: [Qemu-devel] [PATCH v4] target-s390x: Implement stfl and stfle

>> As it happens, this reminds me that I wrote a version of this several >> years ago but never submitted it upstream. I'll dig it out. > > So, does it make sense for me to post a v5 again not using > s390_cpu_virt_mem_write(), or are you going to refresh your stfle > implementation? > > Thanks,

Re: [Qemu-devel] [PATCH v4] target-s390x: Implement stfl and stfle

>>> Of course, in practice we could reduce this to just one cpu_stl_data for >>> STFL and one or two cpu_stq_data for STFLE. >> >> I think STFLE can store more than two 64-bit words, can't it? > > Technically, yes. But there are less than 128 bits defined. Certainly much > less than the 4k bits

[Qemu-devel] [PATCH 1/1] virtio-blk: fix race on guest notifiers

The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" changed how notifications are done for virtio-blk substantially. Due to a race condition, interrupts are lost when irqfd behind the guest notifier is torn

Re: [Qemu-devel] mips failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

Yongbok Kim writes: > On 01/03/2017 18:41, Thomas Huth wrote: >> On 01.03.2017 12:36, Alex Bennée wrote: >>> >>> Peter Maydell writes: >>> I got a make check failure on aarch64 host running a sparc64 test: TEST: tests/prom-env-test... (pid=13573) /sparc64/prom-env/sun

[Qemu-devel] [PATCH v2 1/2] migration: allow clearing migration string parameters

Some of the migration parameters are strings, which default to NULL, eg tls-hostname and tls-creds. The mgmt app will set the tls-creds parameter on both source and target QEMU instances, in order to trigger use of TLS for migration. After performing a TLS encrypted migration though, migration mi

[Qemu-devel] [PATCH v2 2/2] migration: always report tls-creds & tls-hostname migrate parameters

Currently the query-migrate-parameters command will omit reporting of the tls-creds & tls-hostname parameters if their value is NULL. This makes it impossible for an app to detect if these parameters are supported by QEMU, without trying to actually set them and catching the error. Since the code i

[Qemu-devel] [PATCH v2 0/2] migration: fixes to handling tls-hostname/tls-creds

The need for these two patches was identified during implementation of TLS encrypted migration in libvirt. Daniel P. Berrange (2): migration: allow clearing migration string parameters migration: always report tls-creds & tls-hostname migrate parameters migration/migration.c | 22 ++

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: > On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: > > } > > if (params->has_tls_creds) { > > g_free(s->parameters.tls_creds); > > -s->parameters.tls_creds = g_strdup(params->tls_creds); > > +if (*params

Re: [Qemu-devel] [PULL 00/11] x86 queue, 2017-02-27

On 27 February 2017 at 19:16, Peter Maydell wrote: > On 27 February 2017 at 16:24, Eduardo Habkost wrote: >> The following changes since commit 3b1d8169844fafee184366b0e0d7080534758b4d: >> >> tests-aio-multithread: use atomic_read properly (2017-02-27 12:54:08 +) >> >> are available in the

[Qemu-devel] [PATCH] qmp: allow setting properties to empty string in qmp-shell

The qmp-shell property parser currently rejects attempts to set string properties to the empty string eg (QEMU) migrate-set-parameters tls-hostname= Error while parsing command line: Expected a key=value pair, got 'tls-hostname=' command format: [arg-name1=arg1] ... [arg-nameN=argN] This

Re: [Qemu-devel] [PATCH v2 5/5] xen: use libxendevicemodel when available

On Thu, Mar 02, 2017 at 11:09:46AM +, Paul Durrant wrote: > This patch modifies the wrapper functions in xen_common.h to use the > new xendevicemodel interface if it is available along with compatibility > code to use the old libxenctrl interface if it is not. > > Signed-off-by: Paul Durrant

Re: [Qemu-devel] mips failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

On 01/03/2017 18:41, Thomas Huth wrote: > On 01.03.2017 12:36, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> I got a make check failure on aarch64 host running a sparc64 test: >>> >>> >>> TEST: tests/prom-env-test... (pid=13573) >>> /sparc64/prom-env/sun4u:

[Qemu-devel] [Bug 1653384] Re: Assertion failed with USB pass through with XHCI controller

** Changed in: qemu (Debian) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1653384 Title: Assertion failed with USB pass through with XHCI controller S

Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

On 02/03/17 12:06, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 02 March 2017 11:01 >> To: Anthony Perard ; Paul Durrant >> >> Cc: xen-de...@lists.xenproject.org; Stefano Stabellini >> ; qemu-devel@nongnu.org >> Subject: Re: [Xen-devel]

Re: [Qemu-devel] [PATCH RFC] block: Tolerate existing writers on read only BdrvChild

On Wed, 03/01 17:22, Kevin Wolf wrote: > Am 01.03.2017 um 17:10 hat Fam Zheng geschrieben: > > On Wed, 03/01 16:16, Kevin Wolf wrote: > > > > I'm not sure about this because: 1) this is intrusive from a user PoV, > > > > many > > > > scripts and upper layer tools will stop working; > > > > > > Ar

Re: [Qemu-devel] [PULL 0/1] seabios: update to 1.10.2 release

On 28 February 2017 at 09:06, Gerd Hoffmann wrote: > Hi, > > Here comes the seabios update for qemu 2.9, > the just tagged 1.10.2 release. > > Our seabios.git mirror @ qemu.org seems to not sync properly. The > commit isn't there even though it was pushed a few days ago already > (only the tag

[Qemu-devel] [PATCH v2 5/5] xen: use libxendevicemodel when available

This patch modifies the wrapper functions in xen_common.h to use the new xendevicemodel interface if it is available along with compatibility code to use the old libxenctrl interface if it is not. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard v2: - Add a compat defi

[Qemu-devel] [PATCH v2 2/5] xen: rename xen_modified_memory() to xen_hvm_modified_memory()

This patch is a purely cosmetic change that avoids a name collision in a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Paolo Bonzini Cc: Stefano Stabellini --- include/exec/ram_addr.h | 4 ++-- include/hw/xen/xen.h| 2 +- xen-hvm-stub.c | 2 +-

[Qemu-devel] [PATCH v2 0/5] xen: use new xendevicemodel library

My recent patches to Xen [1] introduced a new library to support running device models for HVM guests. This series ports QEMU onto the new library if it is available in the build environment. [1] Patches starting with http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=b108240265deea37601f1a60591

[Qemu-devel] [PATCH v2 1/5] xen: make use of xen_xc implicit in xen_common.h inlines

Doing this will make the transition to using the new libxendevicemodel interface less intrusive on the callers of these functions, since using the new library will require a change of handle. NOTE: The patch also moves the 'externs' for xen_xc and xen_fmem from xen_backend.h to xen_common.h,

[Qemu-devel] [PATCH v2 3/5] xen: create wrappers for all other uses of xc_hvm_XXX() functions

This patch creates inline wrapper functions in xen_common.h for all open coded calls to xc_hvm_XXX() functions outside of xen_common.h so that use of xen_xc can be made implicit. This again is in preparation for the move to using libxendevicemodel. Signed-off-by: Paul Durrant Reviewed-by: Anthony

[Qemu-devel] [PATCH v2 4/5] configure: detect presence of libxendevicemodel

This patch adds code in configure to set CONFIG_XEN_CTRL_INTERFACE_VERSION to a new value of 490 if libxendevicemodel is present in the build environment. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini --- configure | 19 +++ 1 file changed,

Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 02 March 2017 11:01 > To: Anthony Perard ; Paul Durrant > > Cc: xen-de...@lists.xenproject.org; Stefano Stabellini > ; qemu-devel@nongnu.org > Subject: Re: [Xen-devel] [PATCH 4/5] configure: detect presence of > li

Re: [Qemu-devel] [PATCH] qmp-shell: add persistent command history

On Thu, Mar 2, 2017 at 12:19 AM, John Snow wrote: > > > On 03/01/2017 05:01 PM, Nir Soffer wrote: >> On Wed, Mar 1, 2017 at 9:44 PM, John Snow wrote: >>> >>> Use the existing readline history function we are utilizing >>> to provide persistent command history across instances of qmp-shell. >>> >>

Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

On 02/03/17 11:54, Anthony PERARD wrote: > On Thu, Mar 02, 2017 at 09:06:43AM +, Paul Durrant wrote: >>> -Original Message- >>> From: Anthony PERARD [mailto:anthony.per...@citrix.com] >>> Sent: 01 March 2017 17:18 >>> To: Paul Durrant >>> Cc: xen-de...@lists.xenproject.org; qemu-devel@

Re: [Qemu-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 02 March 2017 10:55 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > Stabellini > Subject: Re: [PATCH 4/5] configure: detect presence of libxendevicemodel > > O

Re: [Qemu-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

On Thu, Mar 02, 2017 at 09:06:43AM +, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > Sent: 01 March 2017 17:18 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > > Stabellini > > Sub

Re: [Qemu-devel] [PATCH v4] target-s390x: Implement stfl and stfle

Dne 28.2.2017 v 23:11 Richard Henderson napsal(a): > On 02/27/2017 09:18 PM, Michal Marek wrote: >> +static int do_stfle(CPUS390XState *env, uint64_t addr, uint32_t ar, >> int len) >> +{ >> +S390CPU *cpu = s390_env_get_cpu(env); >> +/* 256 doublewords as per STFLE documentation */ >> +u

Re: [Qemu-devel] [PATCH 3/5] xen: create wrappers for all other uses of xc_hvm_XXX() functions

On Wed, Mar 01, 2017 at 04:16:32PM +, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > Sent: 01 March 2017 16:14 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > > Stabellini ; Paolo

Re: [Qemu-devel] [PATCH] virtio: unbreak virtio-pci with IOMMU after caching ring translations

On 02/03/2017 08:47, Jason Wang wrote: >>> >>> Fixes: c611c76417f5 ("virtio: add MemoryListener to cache ring >>> translations") >>> Cc: Paolo Bonzini >>> Signed-off-by: Jason Wang >> This is very ugly. I guess it's better than broken IOMMU ... >> Paolo? > > Maybe we can delay the registering

Re: [Qemu-devel] [PATCH v2] spice-char: fix segfault in char_spice_finalize

On 02/03/2017 11:20, Li Qiang wrote: > Hello Paolo, > > Have you queued this patch? No, I thought Gerd would. Queued now. Paolo > 2017-02-21 16:32 GMT+08:00 Marc-André Lureau >: > > Hi > > - Original Message - > > In 'qemu_chr_open_spice_vmc'

Re: [Qemu-devel] [PATCH v2] spice-char: fix segfault in char_spice_finalize

Hello Paolo, Have you queued this patch? 2017-02-21 16:32 GMT+08:00 Marc-André Lureau : > Hi > > - Original Message - > > In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will > > call 'char_spice_finalize'. But as the SpiceChardev is not inserted > > in the 'spice_chars' list,

Re: [Qemu-devel] [PULL] TCG queued patch

On 28 February 2017 at 21:33, Richard Henderson wrote: > Only one this week. Pranith didn't mention which compiler version, > but I can imagine gcc7 or clang warning of such a thing. > > > r~ > > > The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba: > > vhost-user: dela

[Qemu-devel] [PATCH 1/3] ide: qdev: register ide bus unrealize function

we have an idebus unrealize function, but it was being registered as the unrealize function for the IDE Device, so it was not getting invoked on device teardown because nothing is "unrealizing" the IDE devices themselves. Suggested-by: John Snow Signed-off-by: Li Qiang --- hw/ide/qdev.c | 12 ++

[Qemu-devel] [PATCH 3/3] ide: ahci: call cleanup function in ahci unit

This can avoid memory leak when hotunplug the ahci device. Signed-off-by: Li Qiang --- hw/ide/ahci.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 6a17acf..f60826d 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1485,6 +1485,18 @@ void a

[Qemu-devel] [PATCH 2/3] ide: core: add cleanup function

As the pci ahci can be hotplug and unplug, in the ahci unrealize function it should free all the resource once allocated in the realized function. This patch add ide_exit to free the resource. Signed-off-by: Li Qiang --- hw/ide/core.c | 8 include/hw/ide/internal.h | 1 + 2

[Qemu-devel] [PATCH 0/3] ide: ahci: fix memory leak in device unit

As the pci ahci can be hotplug and unplug, in the ahci unrealize function it should free all the resource once allocated in the realized function. This patchset first add cleanup function in core layer and then call it in the ahci unit. Li Qiang (3): ide: qdev: register ide bus unrealize functio

[Qemu-devel] [PATCH V3 1/3] COLO-compare: Rename compare function and remove duplicate codes

Rename colo_packet_compare() to colo_packet_compare_common() that make tcp_compare udp_compare icmp_compare reuse this function. Remove minimum packet size check in icmp_compare, because we have check this in parse_packet_early(). Signed-off-by: Zhang Chen --- net/colo-compare.c | 18 +++

[Qemu-devel] [PATCH V3 2/3] COLO-compare: Optimize compare_common and compare_tcp

Add offset args for colo_packet_compare_common, optimize colo_packet_compare_icmp() and colo_packet_compare_udp() just compare the IP payload. Before compare all tcp packet, we compare tcp checksum firstly, this function can get better performance. Signed-off-by: Zhang Chen --- net/colo-compare.

[Qemu-devel] [PATCH V3 0/3] COLO-compare: Optimize the code and fix some bug

This series we will Optimize the code and fix some bug. Patch1: Rename colo_packet_compare() and remove duplicate check in compare icmp. Patch2: Optimize compare_common and increase compare performance. Patch3: Fix debug info always print bug. Zhang Chen (3): COLO-compare: Rename compare functio

[Qemu-devel] [PATCH V3 3/3] COLO-compare: Fix icmp and udp compare different packet always dump bug

Signed-off-by: Zhang Chen --- net/colo-compare.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 9f5968d..282727b 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -279,9 +279,13 @@ static int colo_pac

Re: [Qemu-devel] [PULL 0/1] seabios: update to 1.10.2 release

On 01/03/2017 18:40, Peter Maydell wrote: > On 1 March 2017 at 13:27, Stefan Hajnoczi wrote: >> On Tue, Feb 28, 2017 at 9:06 AM, Gerd Hoffmann wrote: >>> Our seabios.git mirror @ qemu.org seems to not sync properly. The >>> commit isn't there even though it was pushed a few days ago already >>

Re: [Qemu-devel] [PULL 05/15] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

Laszlo Ersek writes: > On 03/02/17 09:25, Laszlo Ersek wrote: > > Regarding your other email ("New QMP command without a test -> automatic > NAK"), Ben did write a small test suite for this feature: > > [Qemu-devel] [PATCH v8 7/8] tests: Add unit tests for the VM Generation >

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

On Wed, Mar 01, 2017 at 11:38:56PM +0100, Eduardo Otubo wrote: > On Thu, Feb 16, 2017 at 09=33=16AM +, Daniel P. Berrange wrote: > > On Thu, Feb 16, 2017 at 12:36:51AM +0100, Eduardo Otubo wrote: > > > On Wed, Feb 15, 2017 at 06=27=32PM +, Daniel P. Berrange wrote: > > [...] > > > > > >

Re: [Qemu-devel] [PATCH V2 2/3] COLO-compare: Optimize compare_common and compare_tcp

On 2017年03月02日 16:15, Zhang Chen wrote: On 03/02/2017 03:51 PM, Jason Wang wrote: On 2017年02月28日 14:11, Zhang Chen wrote: OK, How about this? +/* + * Because of ppkt and spkt are both in the same connection, + * The ppkt's src ip, dst ip, src port, dst port, ip_proto all a

Re: [Qemu-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 01 March 2017 17:18 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > Stabellini > Subject: Re: [PATCH 4/5] configure: detect presence of libxendevicemodel > > O

<    1   2   3   4   >