Re: [Qemu-devel] EL2\EL3 support for Aarch64

2017-05-19 Thread Alex Bennée
Sergey Smolov writes: > Hello, List! > > Could you tell me, what is the current state for EL2\EL3 (Aarch64)? > Whether they are fully supported, or not? > Am I need to use any command line options to enable them for Aarch64 > assembler programs simulation? Sure you can use both. To enable EL2 s

Re: [Qemu-devel] [RFC PATCH v2 1/4] migration: Introduce unregister_savevm_live()

2017-05-19 Thread Laurent Vivier
On 19/05/2017 09:33, David Gibson wrote: > On Fri, May 19, 2017 at 11:10:36AM +0530, Bharata B Rao wrote: >> Introduce a new function unregister_savevm_live() to unregister the vmstate >> handlers registered via register_savevm_live(). >> >> register_savevm() allocates SaveVMHandlers while register

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Daniel P. Berrange
On Fri, May 19, 2017 at 02:02:00PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, May 19, 2017 at 01:51:43PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, May 19, 2017 at 02:43:27PM

Re: [Qemu-devel] [PULL 0/3] audio patch queue.

2017-05-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170519112415.19191-1-kra...@redhat.com Type: series Subject: [Qemu-devel] [PULL 0/3] audio patch queue. === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $B

Re: [Qemu-devel] [Qemu-ppc] [PATCH v11 2/2] migration: spapr: migrate pending_events of spapr state

2017-05-19 Thread Daniel Henrique Barboza
On 05/18/2017 11:32 PM, David Gibson wrote: On Thu, May 18, 2017 at 05:24:02PM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, May 19, 2017 at 01:51:43PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > > > We don't really have a return path for the other

[Qemu-devel] [Bug 1511887] Re: USB device 1.1 not correctly passedthru from Linux host to Windows guest

2017-05-19 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1511887 Title: USB device 1.1 not correctly passedthru from Linux host to Windows guest Sta

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Daniel P. Berrange
On Fri, May 19, 2017 at 01:51:43PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > > We don't really have a return path for the other types yet. Let's check > > > this when .get_return_path()

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > > We don't really have a return path for the other types yet. Let's check > > > this when .get_return_path() is c

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > We don't really have a return path for the other types yet. Let's check > > this when .get_return_path() is called. > > > > For this, we introduce a new feature bit, and set it up only

[Qemu-devel] [PATCH v2 7/9] serial: move TIOCM update to a separate function

2017-05-19 Thread Anton Nefedov
will be used by the following patch Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Michael S. Tsirkin CC: Paolo Bonzini --- hw/char/serial.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/char/serial.c b/hw/

[Qemu-devel] [PATCH v2 9/9] char: avoid chardevice direct access

2017-05-19 Thread Anton Nefedov
frontends should avoid accessing CharDriver struct where possible Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy --- chardev/char.c | 5 + gdbstub.c | 2 +- hw/arm/strongarm.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char

[Qemu-devel] [PATCH v2 4/9] hmp: add hmp analogue for qmp-chardev-change

2017-05-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Dr. David Alan Gilbert --- chardev/char.c| 4 ++-- hmp-commands.hx | 16 hmp.c | 34 ++ hmp.h | 1 + include/sysemu/char.h

[Qemu-devel] [PATCH v2 6/9] virtio-console: chardev hotswap support

2017-05-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Amit Shah --- hw/char/virtio-console.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c index cf7331d..bd74669 1

[Qemu-devel] [PATCH v2 2/9] char: add backend hotswap handler

2017-05-19 Thread Anton Nefedov
Frontends should have an interface to setup the handler of a backend change. The interface will be used in the next commits Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy --- backends/rng-egd.c | 2 +- chardev/char-mux.c | 1 + chardev/char.c

[Qemu-devel] [PATCH v2 3/9] char: chardevice hotswap

2017-05-19 Thread Anton Nefedov
This patch adds a possibility to change a char device without a frontend removal. 1. Ideally, it would have to happen transparently to a frontend, i.e. frontend would continue its regular operation. However, backends are not stateless and are set up by the frontends via qemu_chr_fe_<> functions, a

[Qemu-devel] [PATCH v2 1/9] char: move QemuOpts->ChardevBackend translation to a separate func

2017-05-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy --- chardev/char.c | 72 +- 1 file changed, 46 insertions(+), 26 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index 4e24dc3..684cccd 100644 --- a/chardev/c

[Qemu-devel] [PATCH v2 8/9] serial: chardev hotswap support

2017-05-19 Thread Anton Nefedov
for a backend change, a number of ioctls has to be replayed to sync the current setup of a frontend to a backend tty. This is hopefully enough so we don't have to track, store and replay the whole original control byte sequence. Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievsk

[Qemu-devel] [PATCH v2 0/9] chardevice hotswap

2017-05-19 Thread Anton Nefedov
This serie is a v2 of the February submit http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg01989.html The interface is changed as requested and the changes are slightly reworked and split into separate patches. The patchset adds support of the character device change without a

[Qemu-devel] [PATCH v2 5/9] char: forbid direct chardevice access for hotswap devices

2017-05-19 Thread Anton Nefedov
qemu_chr_fe_get_driver() is unsafe, frontends with hotswap support should not access CharDriver ptr directly as CharDriver might change. Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy --- chardev/char.c| 7 +++ include/sysemu/char.h | 10 ++ 2 files

Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19

2017-05-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1495192872-27667-1-git-send-email-pbonz...@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tota

Re: [Qemu-devel] [PATCH 1/1] s390x/css: catch section mismatch on load

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/18/2017 07:47 PM, Dr. David Alan Gilbert wrote: > >> Hi! > >> > >> I also wonder what is the best way to do this with vmstate. I know there > >> are VMSTATE_*_EQUAL macros for integers, and I have partially modelled my > >> patch after

[Qemu-devel] [PATCH] ehci: fix frame timer invocation.

2017-05-19 Thread Gerd Hoffmann
ehci registers ehci_frame_timer as both timer and bottom half, which turned out to be a bad idea as it can be called as bottom half then while it is running as timer, and it isn't prepared to handle recursive calls. Change the timer func to just schedule the bottom half to avoid this. Fixes: http

Re: [Qemu-devel] [Xen-devel] [RFC PATCH V2 1/2] xen-pt: bind/unbind interrupt remapping format MSI

2017-05-19 Thread Jan Beulich
>>> On 19.05.17 at 13:16, wrote: > On Thu, May 18, 2017 at 01:32:59AM -0400, Lan Tianyu wrote: >> --- a/include/hw/i386/apic-msidef.h >> +++ b/include/hw/i386/apic-msidef.h >> @@ -26,6 +26,7 @@ >> >> #define MSI_ADDR_DEST_ID_SHIFT 12 >> #define MSI_ADDR_DEST_IDX_SHIFT 4 >> -#d

Re: [Qemu-devel] [RFC PATCH V2 2/2] msi: Handle remappable format interrupt request

2017-05-19 Thread Anthony PERARD
On Thu, May 18, 2017 at 01:33:00AM -0400, Lan Tianyu wrote: > From: Chao Gao > > According to VT-d spec Interrupt Remapping and Interrupt Posting -> > Interrupt Remapping -> Interrupt Request Formats On Intel 64 > Platforms, fields of MSI data register have changed. This patch > avoids wrongly re

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-05-19 Thread Frediano Ziglio
wddm dod 0.17 version released which fixes the issue guest side. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1635339 Title: qxl_pre_save assertion failure on vm "save" Status in QEMU: Confirme

[Qemu-devel] [Bug 1511887] Re: USB device 1.1 not correctly passedthru from Linux host to Windows guest

2017-05-19 Thread Jiri Cejka
Currently I can reproduce this bug with 2.8+dfsg-3~bpo8+1 version because I'm using stable Debian GNU/Linux. I'll try install latest qemu test it and report back here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [PULL 1/3] audio: Move arch_init audio code to hw/audio/soundhw.c

2017-05-19 Thread Gerd Hoffmann
From: Eduardo Habkost There's no reason to keep the soundhw table in arch_init.c. Move that code to a new hw/audio/soundhw.c file. While moving the code, trivial coding style issues were fixed. Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson Reviewed-by: Thomas Huth Reviewed-by: Phi

[Qemu-devel] [PULL 3/3] audio: Rename hw/audio/audio.h to hw/audio/soundhw.h

2017-05-19 Thread Gerd Hoffmann
From: Eduardo Habkost All the functions in hw/audio/audio.h are called "soundhw_*()" and live in hw/audio/audiohw.c. Rename the header file for consistency. Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson Reviewed-by: Hervé Poussineau Message-id: 20170508205735.23444-4-ehabk...@redha

Re: [Qemu-devel] [PATCH 1/1] s390x/css: catch section mismatch on load

2017-05-19 Thread Halil Pasic
On 05/18/2017 07:47 PM, Dr. David Alan Gilbert wrote: >> Hi! >> >> I also wonder what is the best way to do this with vmstate. I know there >> are VMSTATE_*_EQUAL macros for integers, and I have partially modelled my >> patch after that, but there we only get a != b as error message, which is >>

[Qemu-devel] [PULL 0/3] audio patch queue.

2017-05-19 Thread Gerd Hoffmann
ble in the git repository at: git://git.kraxel.org/qemu tags/pull-audio-20170519-1 for you to fetch changes up to 8a824e4d74213a2da39323304f949c5b4243e1fb: audio: Rename hw/audio/audio.h to hw/audio/soundhw.h (2017-05-19 10:48

Re: [Qemu-devel] [Bug 1034423] Re: Guests running OpenIndiana (and relatives) fail to boot on AMD hardware

2017-05-19 Thread Owen Tuz
This is an old ticket! I had completely forgotten about it, but will test when I get a chance and let you know. Cheers, Owen On Fri, May 19, 2017 at 11:25 AM, Thomas Huth <1034...@bugs.launchpad.net> wrote: > Triaging old bug tickets ... can you still reproduce this issue with the > latest vers

[Qemu-devel] [PULL 2/3] audio: Rename audio_init() to soundhw_init()

2017-05-19 Thread Gerd Hoffmann
From: Eduardo Habkost To make it consistent with the remaining soundhw.c functions and avoid confusion with the audio_init() function in audio/audio.c, rename audio_init() to soundhw_init(). Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson Message-id: 20170508205735.23444-3-ehabk...@re

[Qemu-devel] [PULL 20/20] target/i386: use multiple CPU AddressSpaces

2017-05-19 Thread Paolo Bonzini
This speeds up SMM switches. Later on it may remove the need to take the BQL, and it may also allow to reuse code between TCG and KVM. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c| 15 +- target/i386/cpu.h| 11 +- target/i386/helper.c | 54 +

[Qemu-devel] [PULL 17/20] vhost-user-scsi: Introduce vhost-user-scsi host device

2017-05-19 Thread Paolo Bonzini
From: Felipe Franciosi This commit introduces a vhost-user device for SCSI. This is based on the existing vhost-scsi implementation, but done over vhost-user instead. It also uses a chardev to connect to the backend. Unlike vhost-scsi (today), VMs using vhost-user-scsi can be live migrated. To u

[Qemu-devel] [PULL 18/20] vhost-user-scsi: Introduce a vhost-user-scsi sample application

2017-05-19 Thread Paolo Bonzini
From: Felipe Franciosi This commit introduces a vhost-user-scsi backend sample application. It must be linked with libiscsi and libvhost-user. To use it, compile with: $ make vhost-user-scsi And run as follows: $ ./vhost-user-scsi -u vus.sock -i iscsi://uri_to_target/ $ qemu-system-x86_64

[Qemu-devel] [PULL 14/20] nbd/client.c: use errp instead of LOG

2017-05-19 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy Move to modern errp scheme from just LOGging errors. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20170516094533.6160-6-vsement...@virtuozzo.com> Signed-off-by: Paolo Bonzini --- block/nbd-client.c | 7 ++- include/block/nbd.h | 5 +++-- n

[Qemu-devel] [PULL 09/20] Check the return value of fcntl in qemu_set_cloexec

2017-05-19 Thread Paolo Bonzini
From: Stefano Stabellini Assert that the return value is not an error. This issue was found by Coverity. CID: 1374831 Signed-off-by: Stefano Stabellini CC: gr...@kaod.org CC: pbonz...@redhat.com CC: Eric Blake Message-Id: <1494356693-13190-2-git-send-email-sstabell...@kernel.org> Signed-off-b

[Qemu-devel] [PULL 16/20] virtio-scsi: Unset hotplug handler when unrealize

2017-05-19 Thread Paolo Bonzini
From: Fam Zheng This matches the qbus_set_hotplug_handler in realize, and it releases the final reference to the embedded VirtIODevice so that it is properly finalized. A use-after-free is fixed with this patch, indirectly: virtio_device_instance_finalize wasn't called at hot-unplug, and the vde

[Qemu-devel] [PULL 19/20] target/i386: enable A20 automatically in system management mode

2017-05-19 Thread Paolo Bonzini
Ignore env->a20_mask when running in system management mode. Reported-by: Anthony Xu Signed-off-by: Paolo Bonzini Message-Id: <1494502528-12670-1-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- target/i386/arch_memory_mapping.c | 18 + target/i386/cpu.h

[Qemu-devel] [PULL 10/20] nbd: strict nbd_wr_syncv

2017-05-19 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy nbd_wr_syncv is called either from coroutine or from client negotiation code, when socket is in blocking mode. So, -EAGAIN is impossible. Furthermore, EAGAIN is confusing, as, what to read/write again? With EAGAIN as a return code we don't know how much data is

[Qemu-devel] [PULL 06/20] kvm: irqchip: trace changes on msi add/remove

2017-05-19 Thread Paolo Bonzini
From: Peter Xu It'll be nice to know which virq belongs to which device/vector when adding msi routes, so adding two more parameters for the add trace. Meanwhile, releasing virq has no tracing before. Add one for it. Signed-off-by: Peter Xu Message-Id: <1494309644-18743-2-git-send-email-pet...

[Qemu-devel] [PULL 15/20] exec: simplify phys_page_find() params

2017-05-19 Thread Paolo Bonzini
From: Peter Xu It really only plays with the dispatchers, so the parameter list does not need that complexity. This helps for readability at least. Signed-off-by: Peter Xu Message-Id: <1494838260-30439-2-git-send-email-pet...@redhat.com> Reviewed-by: David Gibson Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 05/20] mc146818rtc: embrace all x86 specific code

2017-05-19 Thread Paolo Bonzini
From: Xiao Guangrong Introduce a function, rtc_policy_slew_deliver_irq(), which delivers irq if LOST_TICK_POLICY_SLEW is used, as which is only supported on x86, other platforms call it will trigger a assert After that, we can move the x86 specific code to the common place Signed-off-by: Xiao G

[Qemu-devel] [PULL 13/20] nbd: add errp to read_sync, write_sync and drop_sync

2017-05-19 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy There a lot of calls of these functions, which already have errp, which they are filling themselves. On the other hand, nbd_wr_syncv has errp parameter too, so it would be great to connect them. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20170516

[Qemu-devel] [PULL 08/20] kvm: irqchip: skip update msi when disabled

2017-05-19 Thread Paolo Bonzini
From: Peter Xu It's possible that one device kept its irqfd/virq there even when MSI/MSIX was disabled globally for that device. One example is virtio-net-pci (see commit f1d0f15a6 and virtio_pci_vq_vector_mask()). It is used as a fast path to avoid allocate/release irqfd/virq frequently when gue

[Qemu-devel] [PULL 11/20] nbd: read_sync and friends: return 0 on success

2017-05-19 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy functions read_sync, drop_sync, write_sync, and also nbd_negotiate_write, nbd_negotiate_read, nbd_negotiate_drop_sync returns number of processed bytes. But what this number can be, except requested number of bytes? Actually, underlying nbd_wr_syncv function re

[Qemu-devel] [PULL 04/20] mc146818rtc: drop unnecessary '#ifdef TARGET_I386'

2017-05-19 Thread Paolo Bonzini
From: Xiao Guangrong If the code purely depends on LOST_TICK_POLICY_SLEW, we can simply drop '#ifdef TARGET_I386' as only x86 can enable this tick policy Signed-off-by: Xiao Guangrong Message-Id: <20170510083259.3900-5-xiaoguangr...@tencent.com> Signed-off-by: Paolo Bonzini --- hw/timer/mc146

[Qemu-devel] [PULL 07/20] msix: trace control bit write op

2017-05-19 Thread Paolo Bonzini
From: Peter Xu Meanwhile, abstract a function to detect msix masked bit. Signed-off-by: Peter Xu Message-Id: <1494309644-18743-3-git-send-email-pet...@redhat.com> Acked-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --

[Qemu-devel] [PULL 12/20] nbd: add errp parameter to nbd_wr_syncv()

2017-05-19 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy Will be used in following patch to provide actual error message in some cases. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20170516094533.6160-4-vsement...@virtuozzo.com> Signed-off-by: Paolo Bonzini --- block/nbd-client.c | 4 ++-- include/bl

[Qemu-devel] [PULL 01/20] mc146818rtc: update periodic timer only if it is needed

2017-05-19 Thread Paolo Bonzini
From: Xiao Guangrong Currently, the timer is updated whenever RegA or RegB is written even if the periodic timer related configuration is not changed This patch optimizes it slightly to make the update happen only if its period or enable-status is changed, also later patches are depend on this o

[Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19

2017-05-19 Thread Paolo Bonzini
The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 02/20] mc146818rtc: precisely count the clock for periodic timer

2017-05-19 Thread Paolo Bonzini
From: Tai Yunfang There are two issues in current code: 1) If the period is changed by re-configuring RegA, the coalesced irq will be scaled to reflect the new period, however, it calculates the new interrupt number like this: s->irq_coalesced = (s->irq_coalesced * s->period) / period;

[Qemu-devel] [PULL 03/20] mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386

2017-05-19 Thread Paolo Bonzini
From: Xiao Guangrong Any tick policy specified on other platforms rather on TARGET_I386 will fall back to LOST_TICK_POLICY_DISCARD silently, this patch makes sure only TARGET_I386 can enable LOST_TICK_POLICY_SLEW After that, we can enable LOST_TICK_POLICY_SLEW in the common code which need not u

[Qemu-devel] old_vm_running boolean variable

2017-05-19 Thread ali saeedi
Hello What is the role of "old_vm_running" variable in migration_thread? thanks a lot

Re: [Qemu-devel] [Qemu-ppc] [RESEND PATCH v10 1/5] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

2017-05-19 Thread Daniel Henrique Barboza
On 05/19/2017 01:26 AM, David Gibson wrote: On Thu, May 18, 2017 at 06:54:12PM -0300, Daniel Henrique Barboza wrote: The LMB DRC release callback, spapr_lmb_release(), uses an opaque parameter, a sPAPRDIMMState struct that stores the current LMBs that are allocated to a DIMM (nr_lmbs). After e

Re: [Qemu-devel] [RFC PATCH V2 1/2] xen-pt: bind/unbind interrupt remapping format MSI

2017-05-19 Thread Anthony PERARD
On Thu, May 18, 2017 at 01:32:59AM -0400, Lan Tianyu wrote: > From: Chao Gao > > If a vIOMMU is exposed to guest, guest will configure the msi to remapping > format. The original code isn't suitable to the new format. A new pair > bind/unbind interfaces are added for this usage. This patch recogn

[Qemu-devel] [PATCH 17/21] s390x/css: introduce and realize ccw-request callback

2017-05-19 Thread Cornelia Huck
From: Xiao Feng Ren Introduce a new callback on subchannel to handle ccw-request. Realize the callback in vfio-ccw device. Besides, resort to the event notifier handler to handling the ccw-request results. 1. Pread the I/O results via MMIO region. 2. Update the scsw info to guest. 3. Inject an I/

[Qemu-devel] [PATCH 21/21] s390/kvm: do not reset riccb on initial cpu reset

2017-05-19 Thread Cornelia Huck
From: Christian Borntraeger The riccb is kept unchanged during initial cpu reset. Move the data structure to the other registers that are unchanged. Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- target/s390x/cpu.c | 7 --- target/s390x/cpu.h | 6 -- 2 files cha

[Qemu-devel] [PATCH 10/21] s390x/css: add s390-squash-mcss machine option

2017-05-19 Thread Cornelia Huck
From: Xiao Feng Ren We want to support real (i.e. not virtual) channel devices even for guests that do not support MCSS-E (where guests may see devices from any channel subsystem image at once). As all virtio-ccw devices are in css 0xfe (and show up in the default css 0 for guests not activating

[Qemu-devel] [PATCH 19/21] vfio/ccw: update sense data if a unit check is pending

2017-05-19 Thread Cornelia Huck
From: Dong Jia Shi Concurrent-sense data is currently not delivered. This patch stores the concurrent-sense data to the subchannel if a unit check is pending and the concurrent-sense bit is enabled. Then a TSCH can retreive the right IRB data back to the guest. Acked-by: Alex Williamson Signed-

[Qemu-devel] [PATCH 16/21] vfio/ccw: get irqs info and set the eventfd fd

2017-05-19 Thread Cornelia Huck
From: Dong Jia Shi vfio-ccw resorts to the eventfd mechanism to communicate with userspace. We fetch the irqs info via the ioctl VFIO_DEVICE_GET_IRQ_INFO, register a event notifier to get the eventfd fd which is sent to kernel via the ioctl VFIO_DEVICE_SET_IRQS, then we can implement read operati

[Qemu-devel] [PATCH 09/21] linux-headers: update

2017-05-19 Thread Cornelia Huck
Update against Linux v4.12-rc1. Also include the new vfio_ccw.h header. Signed-off-by: Cornelia Huck --- include/standard-headers/asm-x86/hyperv.h | 7 +- include/standard-headers/linux/input-event-codes.h | 1 + include/standard-headers/linux/input.h | 11 +--- i

[Qemu-devel] [PATCH 20/21] MAINTAINERS: Add vfio-ccw maintainer

2017-05-19 Thread Cornelia Huck
From: Dong Jia Shi Add Cornelia Huck as the vfio-ccw maintainer. Acked-by: Alex Williamson Signed-off-by: Dong Jia Shi Message-Id: <20170517004813.58227-14-bjsdj...@linux.vnet.ibm.com> [CH: add tree] Signed-off-by: Cornelia Huck --- MAINTAINERS | 8 1 file changed, 8 insertions(+)

[Qemu-devel] [PATCH 08/21] pc-bios/s390-ccw.img: rebuild image

2017-05-19 Thread Cornelia Huck
From: Eric Farman Contains the following commits: - pc-bios/s390-ccw: Remove duplicate blk_factor adjustment - pc-bios/s390-ccw: Move SCSI block factor to outer read - pc-bios/s390-ccw: Break up virtio-scsi read into multiples - pc-bios/s390-ccw: Refactor scsi_inquiry function - pc-bios/s390-ccw:

[Qemu-devel] [PATCH 11/21] s390x/css: realize css_sch_build_schib

2017-05-19 Thread Cornelia Huck
From: Xiao Feng Ren The S390 virtual css support already has a mechanism to build a virtual subchannel information block (schib) and provide virtual subchannels to the guest. However, to pass-through subchannels to a guest, we need to introduce a new mechanism to build its schib according to the

[Qemu-devel] [PATCH 18/21] s390x/css: ccw translation infrastructure

2017-05-19 Thread Cornelia Huck
From: Xiao Feng Ren Implement a basic infrastructure of handling channel I/O instruction interception for passed through subchannels: 1. Branch the code path of instruction interception handling by SubChannel type. 2. For a passed-through subchannel, issue the ORB to kernel to do ccw transl

[Qemu-devel] [PATCH 13/21] s390x/css: device support for s390-ccw passthrough

2017-05-19 Thread Cornelia Huck
From: Dong Jia Shi In order to support subchannels pass-through, we introduce a s390 subchannel device called "s390-ccw" to hold the real subchannel info. The s390-ccw devices inherit from the abstract CcwDevice which connect to the existing virtual-css-bus. Reviewed-by: Eric Auger Signed-off-b

[Qemu-devel] [PATCH 14/21] vfio/ccw: vfio based subchannel passthrough driver

2017-05-19 Thread Cornelia Huck
From: Xiao Feng Ren We use the IOMMU_TYPE1 of VFIO to realize the subchannels passthrough, implement a vfio based subchannels passthrough driver called "vfio-ccw". Support qemu parameters in the style of: "-device vfio-ccw,sysfsdev=$mdev_file_path,devno=xx.x.' Reviewed-by: Eric Auger Acked

[Qemu-devel] [PATCH 05/21] pc-bios/s390-ccw: Get list of supported VPD pages

2017-05-19 Thread Cornelia Huck
From: Eric Farman The "Supported Pages" Inquiry EVPD page is mandatory for all SCSI devices, and is used as a gateway for what VPD pages the device actually supports. Let's issue this Inquiry, and dump that list with the debug facility. Signed-off-by: Eric Farman Message-Id: <20170510155359.327

[Qemu-devel] [PATCH 04/21] pc-bios/s390-ccw: Refactor scsi_inquiry function

2017-05-19 Thread Cornelia Huck
From: Eric Farman If we want to issue any of the SCSI Inquiry EVPD pages, which we do, we could use this function to issue both types of commands with a little bit of refactoring. Signed-off-by: Eric Farman Message-Id: <20170510155359.32727-5-far...@linux.vnet.ibm.com> Signed-off-by: Cornelia H

[Qemu-devel] [PATCH 15/21] vfio/ccw: get io region info

2017-05-19 Thread Cornelia Huck
From: Dong Jia Shi vfio-ccw provides an MMIO region for I/O operations. We fetch its information via ioctls here, then we can use it performing I/O instructions and retrieving I/O results later on. Reviewed-by: Eric Auger Acked-by: Alex Williamson Signed-off-by: Dong Jia Shi Message-Id: <2017

[Qemu-devel] [PATCH 06/21] pc-bios/s390-ccw: Get Block Limits VPD device data

2017-05-19 Thread Cornelia Huck
From: Eric Farman The "Block Limits" Inquiry VPD page is optional for any SCSI device, but if it's supported it provides a hint of the maximum I/O transfer length for this particular device. If this page is supported by the disk, let's issue that Inquiry and use the minimum of it and the SCSI con

[Qemu-devel] [PATCH 12/21] s390x/css: realize css_create_sch

2017-05-19 Thread Cornelia Huck
From: Dong Jia Shi The S390 virtual css support already has a mechanism to create a virtual subchannel and provide it to the guest. However, to pass-through subchannels to a guest, we need to introduce a new mechanism to create the subchannel according to the real device information. Thus we reco

[Qemu-devel] [PATCH 01/21] pc-bios/s390-ccw: Remove duplicate blk_factor adjustment

2017-05-19 Thread Cornelia Huck
From: Eric Farman When using virtio-scsi, we multiply the READ(10) data_size by a block factor twice when building the I/O. This is fine, since it's only 1 for SCSI disks, but let's clean it up. Signed-off-by: Eric Farman Reviewed-by: Christian Borntraeger Message-Id: <20170510155359.32727-2-

[Qemu-devel] [PATCH 07/21] pc-bios/s390-ccw: Build a reasonable max_sectors limit

2017-05-19 Thread Cornelia Huck
From: Eric Farman Now that we've read all the possible limits that have been defined for a virtio-scsi controller and the disk we're booting from, it's possible that we are STILL going to exceed the limits of the host device. For example, a "-device scsi-generic" device does not support the Block

[Qemu-devel] [PATCH 03/21] pc-bios/s390-ccw: Break up virtio-scsi read into multiples

2017-05-19 Thread Cornelia Huck
From: Eric Farman A virtio-scsi request that goes through the host sd driver and exceeds the maximum transfer size is automatically broken up for us. But the equivalent request going to the sg driver presumes that any length requirements have already been honored. Let's use the max_sectors fiel

[Qemu-devel] [PATCH 00/21] s390x changes

2017-05-19 Thread Cornelia Huck
Hi, here's a fairly large s390x update for which I plan to send a pull request next week. The biggest part is the introduction of the new vfio-ccw support to passthrough ccw devices (kernel part has been merged as of 4.12-rc1). There's also some changes to allow the ccw bios to boot from scsi gen

[Qemu-devel] [PATCH 02/21] pc-bios/s390-ccw: Move SCSI block factor to outer read

2017-05-19 Thread Cornelia Huck
From: Eric Farman Simple refactoring so that the blk_factor adjustment is moved into virtio_scsi_read_many routine, in preparation for another change. Signed-off-by: Eric Farman Message-Id: <20170510155359.32727-3-far...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/vi

Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-19 Thread Markus Armbruster
Juan Quintela writes: > We have change in the previous patch to use migration capabilities for > it. Notice that we continue using the old command line flags from > migrate command from the time being. Remove the set_params method as > now it is empty. > > For savevm, one can't do a: > > savevm

[Qemu-devel] [Bug 1255303] Re: ALSA underruns occurr when using QEMU

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (currently v2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2017-05-19 Thread Thomas Huth
If I get the previous comments right, this is just about using the right configuration, and not a real bug? If so, I assume we can close this ticket nowadays? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-

[Qemu-devel] [Bug 1511887] Re: USB device 1.1 not correctly passedthru from Linux host to Windows guest

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (currently v2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [Bug 1198350] Re: USB pass-through fails with USBDEVFS_DISCONNECT: Invalid argument

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (currently v2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

Re: [Qemu-devel] [PATCH] i386: fix read/write cr with icount option

2017-05-19 Thread Mihail Abakumov
Paolo Bonzini писал 2017-05-19 12:59: On 19/05/2017 11:36, Mihail Abakumov wrote: Running Windows with icount causes a crash in instruction of write cr. This patch fixes it. Reading and writing cr cause an icount read because there are called cpu_get_apic_tpr and cpu_set_apic_tpr functions. So,

Re: [Qemu-devel] [RFC v5 4/4] hw/intc/arm_gicv3_its: Allow save/restore

2017-05-19 Thread Shannon Zhao
On 2017/4/14 20:46, Eric Auger wrote: > We change the restoration priority of both the GICv3 and ITS. The > GICv3 must be restored before the ITS and the ITS needs to be restored > before PCIe devices since it translates their MSI transactions. > > Signed-off-by: Eric Auger > Reviewed-by: Juan

[Qemu-devel] [PATCH v2 2/4] block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()

2017-05-19 Thread Stefan Hajnoczi
Calling aio_poll() directly may have been fine previously, but this is the future, man! The difference between an aio_poll() loop and BDRV_POLL_WHILE() is that BDRV_POLL_WHILE() releases the AioContext around aio_poll(). This allows the IOThread to run fd handlers or BHs to complete the request.

[Qemu-devel] [Bug 1162227] Re: Mouse works badly when connecting to host via vnc

2017-05-19 Thread Thomas Huth
As you mentioned already, the solution is to use an USB tablet instead of a mouse device, and as far as I can see, it is also mentioned in the documentation of the "-vnc" parameter, so I'm closing this ticket now... ** Changed in: qemu Status: New => Invalid -- You received this bug notif

[Qemu-devel] [Bug 1034423] Re: Guests running OpenIndiana (and relatives) fail to boot on AMD hardware

2017-05-19 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (currently v2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [PATCH v2 4/4] migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()

2017-05-19 Thread Stefan Hajnoczi
blk/bdrv_drain_all() only takes effect for a single instant and then resumes block jobs, guest devices, and other external clients like the NBD server. This can be handy when performing a synchronous drain before terminating the program, for example. Monitor commands usually need to quiesce I/O a

[Qemu-devel] [PATCH v2 1/4] spapr_cpu_core: drop reference on ICP object during CPU realization

2017-05-19 Thread Greg Kurz
When a piece of code allocates an object, it implicitely gets a reference on it. If it then makes that object a child property of another object, it should drop its own reference at some point otherwise the child object can never be finalized. The current code hence leaks one ICP object per CPU whe

[Qemu-devel] [PATCH v2 0/4] block: fix 'savevm' hang with -object iothread

2017-05-19 Thread Stefan Hajnoczi
v2: * New patch to use bdrv_drain_all_begin/end() in savevm/loadvm [Kevin] (All other patches unchanged) The 'savevm' command hangs when -object iothread is used. See patches for details, but basically the vmstate read/write code didn't conform to the latest block layer locking rules. Stefan

[Qemu-devel] [PATCH v2 3/4] migration: avoid recursive AioContext locking in save_vmstate()

2017-05-19 Thread Stefan Hajnoczi
AioContext was designed to allow nested acquire/release calls. It uses a recursive mutex so callers don't need to worry about nesting...or so we thought. BDRV_POLL_WHILE() is used to wait for block I/O requests. It releases the AioContext temporarily around aio_poll(). This gives IOThreads a ch

[Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-19 Thread Greg Kurz
Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This is an improvement since we no longer allocate ICP objects that will never be used. But it has the side-effect of breaking migration of older machine types from o

[Qemu-devel] [PATCH v2 1/4] block: count bdrv_co_rw_vmstate() requests

2017-05-19 Thread Stefan Hajnoczi
Call bdrv_inc/dec_in_flight() for vmstate reads/writes. This seems unnecessary at first glance because vmstate reads/writes are done synchronously while the guest is stopped. But we need the bdrv_wakeup() in bdrv_dec_in_flight() so the main loop sees request completion. Besides, it's cleaner to c

[Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

2017-05-19 Thread Greg Kurz
For historical reasons, we compute CPU device-tree ids with a non-trivial logic. This patch consolidate the logic in a single helper to be used in various places where it is currently open-coded. It is okay to get rid of DIV_ROUND_UP() because we're sure that the number of threads per core in the

[Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-19 Thread Greg Kurz
If the user explicitely asked for kernel-irqchip support and "xics-kvm" initialization fails, we shouldn't fallback to emulated "xics" as we do now. It is also awkward to print an error message when we have an errp pointer argument. Let's use the errp argument to report the error and let the calle

[Qemu-devel] [PATCH v2 0/4] spapr/xics: fix migration of older machine types

2017-05-19 Thread Greg Kurz
v2: - some patches from v1 are already merged in ppc-for-2.10 - added a new fix to a potential memory leak (patch 1) - consolidate dt_id computation (patch 3) - see individual changelogs for patch 2 and 4 This series is based on: https://github.com/dgibson/qemu.git ppc-for-2.10 I cou

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Daniel P. Berrange
On Fri, May 19, 2017 at 05:51:43PM +0800, Peter Xu wrote: > On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > > We don't really have a return path for the other types yet. Let's check > > > this when .get_return_pat

Re: [Qemu-devel] [PATCH] i386: fix read/write cr with icount option

2017-05-19 Thread Paolo Bonzini
On 19/05/2017 11:36, Mihail Abakumov wrote: > Running Windows with icount causes a crash in instruction of write cr. > This patch fixes it. > > Reading and writing cr cause an icount read because there are called > cpu_get_apic_tpr and cpu_set_apic_tpr functions. So, there is need > gen_io_start

<    1   2   3   >