Re: [Qemu-devel] [PATCH] ppc/pnv: Set default ram size to 2GB

2019-07-17 Thread David Gibson
On Thu, Jul 18, 2019 at 03:02:36PM +0930, Joel Stanley wrote: > This makes the powernv machine easier for end users as the default > initrd address is now within RAM. > > Signed-off-by: Joel Stanley Applied to ppc-for-4.2, thanks. -- David Gibson| I'll have my music baroque

[Qemu-devel] [PATCH] migration: equation is more proper than and to check LOADVM_QUIT

2019-07-17 Thread Wei Yang
LOADVM_QUIT allows a command to quit all layers of nested loadvm loops, while current return value check is not that proper even it works now. Current return value check "ret & LOADVM_QUIT" would return true if bit[0] is 1. This would be true when ret is -1 which is used to indicate an error of ha

[Qemu-devel] No archives to download from www.qemu.org/download/

2019-07-17 Thread Philippe Mathieu-Daudé
When building from the GitHub generated archive (https://github.com/qemu/qemu/archive/v4.1.0-rc0.tar.gz) we get: --- $ ./configure ERROR: missing file /tmp/qemu-4.1.0-rc0/ui/keycodemapdb/README This is not a GIT checkout but module content appears to be missing. Do not use 'git archive' or GitHu

Re: [Qemu-devel] [QUESTION] SDL 1.2 support

2019-07-17 Thread Philippe Mathieu-Daudé
On 7/16/19 8:20 PM, Philippe Mathieu-Daudé wrote: > Hi Aleksandar, > > On 7/16/19 7:09 PM, Aleksandar Markovic wrote: >> On Tue, Jul 16, 2019 at 1:54 PM Thomas Huth wrote: >>> >>> On 16/07/2019 13.17, Aleksandar Markovic wrote: Hello, Gerd, Daniel, and others involved. I have multi

Re: [Qemu-devel] [PATCH v2] target/i386: Introduce Denverton CPU model

2019-07-17 Thread Xiaoyao Li
On 7/18/2019 9:56 AM, Tao Xu wrote: On 7/18/2019 2:38 AM, Eduardo Habkost wrote: On Wed, Jul 17, 2019 at 01:39:01PM +0800, Tao Xu wrote: Hi Eduardo, Could I ask a question about introducing a old CPU model? Maybe not so old because it was launched in 2017. It is the former generation (Atom S

Re: [Qemu-devel] [PATCH] ppc/pnv: Set default ram size to 2GB

2019-07-17 Thread Cédric Le Goater
On 18/07/2019 07:32, Joel Stanley wrote: > This makes the powernv machine easier for end users as the default > initrd address is now within RAM. > > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Thanks, C. > -- > This replaces https://patchwork.ozlabs.org/patch/1132438/ > > h

[Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-17 Thread tony.nguyen
This patch moves the define of target access alignment earlier from target/foo/cpu.h to configure. Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now accelerator independent MemOp" Signed-off-by: Tony Nguyen --- configure | 12 ++-- include/exec/pois

Re: [Qemu-devel] [PATCH v2 2/4] ppc: fix memory leak in spapr_dt_drc()

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 03:20:01AM -0500, Shivaprasad G Bhat wrote: > Leaking the drc_name while preparing the DT properties. > Fixing that. > > Also, remove the const qualifier from spapr_drc_name(). > > Signed-off-by: Shivaprasad G Bhat Applied to ppc-for-4.2, thanks. > --- > hw/ppc/spapr_d

Re: [Qemu-devel] [PATCH v6 0/4] spapr: implement dispatch and suspend calls

2019-07-17 Thread David Gibson
On Thu, Jul 18, 2019 at 01:42:10PM +1000, Nicholas Piggin wrote: > Lot of good reviews (thanks), several more bug fixes and some good > cleanups. Applied to ppc-for-4.2, thanks. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimal

Re: [Qemu-devel] [PATCH-for-4.1 v2 1/3] virtio-balloon: fix QEMU crashes on pagesize > BALLOON_PAGE_SIZE

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 12:35:48PM +0200, David Hildenbrand wrote: > We are using the wrong functions to set/clear bits, effectively touching > multiple bits, writing out of range of the bitmap, resulting in memory > corruptions. We have to use set_bit()/clear_bit() instead. > > Can easily be repr

Re: [Qemu-devel] [PATCH for-4.2 v2 0/2] spapr: Implement H_TPM_COMM for accessing host TPM device

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 03:58:40PM -0500, Michael Roth wrote: > These patches are based on ppc-for-4.2 and are also available at: > > https://github.com/mdroth/qemu/commits/spapr-tpm-hcall-v2 > > This patchset implements the H_TPM_COMM hypercall, which provides a way > for an Ultravisor to pass

Re: [Qemu-devel] [PATCH v2 3/4] ppc: fix leak in h_client_architecture_support

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 03:20:31AM -0500, Shivaprasad G Bhat wrote: > Free all SpaprOptionVector local pointers after use. > > Signed-off-by: Shivaprasad G Bhat Applied to ppc-for-4.2, thanks. > --- > hw/ppc/spapr_hcall.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ppc/sp

Re: [Qemu-devel] [PATCH-for-4.1 v2 3/3] virtio-balloon: reset pbp on device resets

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 12:35:50PM +0200, David Hildenbrand wrote: > When a guest reboots (ordinary reboots, but also via kexec), it will > happily reuse any system memory, including previously inflated memory. > > We could have tracking data for a pbp (PartiallyBalloonedPage). It could > happen t

Re: [Qemu-devel] [PATCH-for-4.1 v2 2/3] virtio-balloon: fix memory leak on unrealize()

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 12:35:49PM +0200, David Hildenbrand wrote: > We could have tracking data for a pbp (PartiallyBalloonedPage) > allocated. Let's free it. > > Fixes: ed48c59875b6 ("virtio-balloon: Safely handle BALLOON_PAGE_SIZE < > host page size") > Cc: qemu-sta...@nong

Re: [Qemu-devel] [PATCH v2 1/4] ppc: fix memory leak in spapr_caps_add_properties

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 03:19:43AM -0500, Shivaprasad G Bhat wrote: > Free the capability name string after setting > the capability. > > Signed-off-by: Shivaprasad G Bhat Applied to ppc-for-4.2, thanks. > --- > hw/ppc/spapr_caps.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH] ppc/pnv: Set default ram size to 2GB

2019-07-17 Thread Joel Stanley
This makes the powernv machine easier for end users as the default initrd address is now within RAM. Signed-off-by: Joel Stanley -- This replaces https://patchwork.ozlabs.org/patch/1132438/ hw/ppc/pnv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pn

Re: [Qemu-devel] [PATCH v26 0/7] QEMU AVR 8 bit cores

2019-07-17 Thread Philippe Mathieu-Daudé
Hi Michael, On 7/17/19 5:46 PM, Michael Rolnik wrote: > ping. QEMU is currently preparing for the next release (4.1) and we entered the "freezed" period where no new features are accepted. This does not mean people are not allowed to post new features to the list, but most volunteering reviewers

Re: [Qemu-devel] [PATCH] ppc/pnv: Warn when using -initrd and low ram

2019-07-17 Thread Joel Stanley
On Tue, 16 Jul 2019 at 08:53, David Gibson wrote: > > On Tue, Jul 16, 2019 at 09:39:36AM +0200, Cédric Le Goater wrote: > > > Provide a helpful message for users so they don't go reporting bugs to > > > kernel developers. > > > > > > Signed-off-by: Joel Stanley > > > --- > > > We could solve this

Re: [Qemu-devel] [PATCH] virtio-scsi: remove unused argument to virtio_scsi_common_realize

2019-07-17 Thread Philippe Mathieu-Daudé
On 7/17/19 11:47 AM, Paolo Bonzini wrote: > The argument is not used and passing it clutters error propagation in the > callers. So, get rid of it. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi/vhost-scsi.c| 2 +- > hw/scsi/vhost-user-scsi.c | 2 +- > hw/scsi/virtio-scsi.c

Re: [Qemu-devel] [PATCH] virtio-scsi: remove unused argument to virtio_scsi_common_realize

2019-07-17 Thread Philippe Mathieu-Daudé
Cc'ing qemu-block@ On 7/18/19 5:25 AM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190717094728.31006-1-pbonz...@redhat.com/ [...]> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 [...] > PASS 18 test-bdrv-drain /bdrv-drain/iothread/drain_a

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-17 Thread Jing Liu
On 7/11/2019 1:38 PM, Jing Liu wrote: Intel CooperLake cpu adds AVX512_BF16 instruction, defining as CPUID.(EAX=7,ECX=1):EAX[bit 05]. The release spec link as follows, https://software.intel.com/sites/default/files/managed/c5/15/\ architecture-instruction-set-extensions-programming-reference.

Re: [Qemu-devel] [PATCH 2/2] spapr: initial implementation for H_TPM_COMM hcall

2019-07-17 Thread David Gibson
On Wed, Jul 17, 2019 at 03:53:47PM -0500, Michael Roth wrote: > Quoting David Gibson (2019-07-16 20:29:12) > > On Tue, Jul 16, 2019 at 11:30:01AM -0500, Michael Roth wrote: > > > Quoting David Gibson (2019-07-14 21:25:24) > > > > On Fri, Jul 12, 2019 at 09:34:46AM -0500, Michael Roth wrote: > > > >

[Qemu-devel] [PATCH v6 4/4] spapr: Implement H_JOIN

2019-07-17 Thread Nicholas Piggin
This has been useful to modify and test the Linux pseries suspend code but it requires modification to the guest to call it (due to being gated by other unimplemented features). It is not otherwise used by Linux yet, but work is slowly progressing there. Signed-off-by: Nicholas Piggin --- Changes

[Qemu-devel] [PATCH v6 3/4] spapr: Implement H_CONFER

2019-07-17 Thread Nicholas Piggin
This does not do directed yielding and is not quite as strict as PAPR specifies in terms of precise dispatch behaviour. This generally will mean suboptimal performance, rather than guest misbehaviour. Linux does not rely on exact dispatch behaviour. Signed-off-by: Nicholas Piggin --- Changes sinc

[Qemu-devel] [PATCH v6 2/4] spapr: Implement H_PROD

2019-07-17 Thread Nicholas Piggin
H_PROD is added, and H_CEDE is modified to test the prod bit according to PAPR. Signed-off-by: Nicholas Piggin --- Changes since v5: - Add the prod bit here - Fix target CPU hw/ppc/spapr.c | 1 + hw/ppc/spapr_hcall.c| 32 include/hw

[Qemu-devel] [PATCH v6 1/4] spapr: Implement dispatch tracking for tcg

2019-07-17 Thread Nicholas Piggin
Implement cpu_exec_enter/exit on ppc which calls into new methods of the same name in PPCVirtualHypervisorClass. These are used by spapr to implement the splpar VPA dispatch counter initially. Signed-off-by: Nicholas Piggin --- Changes since v5: - Move 'prod' into next patch. - Use uint32_t type

[Qemu-devel] [PATCH v6 0/4] spapr: implement dispatch and suspend calls

2019-07-17 Thread Nicholas Piggin
Lot of good reviews (thanks), several more bug fixes and some good cleanups. Thanks, Nick Nicholas Piggin (4): spapr: Implement dispatch tracking for tcg spapr: Implement H_PROD spapr: Implement H_CONFER spapr: Implement H_JOIN hw/ppc/spapr.c | 54 hw/ppc/

Re: [Qemu-devel] [PATCH] virtio-scsi: remove unused argument to virtio_scsi_common_realize

2019-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190717094728.31006-1-pbonz...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash mak

Re: [Qemu-devel] [PATCH v5 4/4] spapr: Implement H_JOIN

2019-07-17 Thread Nicholas Piggin
Greg Kurz's on July 18, 2019 3:30 am: > On Wed, 17 Jul 2019 15:39:52 +1000 > Nicholas Piggin wrote: > >> This has been useful to modify and test the Linux pseries suspend >> code but it requires modification to the guest to call it (due to >> being gated by other unimplemented features). It is no

Re: [Qemu-devel] [PATCH v5 2/4] spapr: Implement H_PROD

2019-07-17 Thread Nicholas Piggin
Cédric Le Goater's on July 17, 2019 11:33 pm: > On 17/07/2019 07:39, Nicholas Piggin wrote: >> H_PROD is added, and H_CEDE is modified to test the prod bit >> according to PAPR. >> >> Signed-off-by: Nicholas Piggin >> --- >> hw/ppc/spapr_hcall.c | 29 + >> 1 file chan

Re: [Qemu-devel] [PATCH v5 3/4] spapr: Implement H_CONFER

2019-07-17 Thread Nicholas Piggin
Greg Kurz's on July 18, 2019 3:00 am: > On Wed, 17 Jul 2019 15:39:51 +1000 > Nicholas Piggin wrote: > >> This does not do directed yielding and is not quite as strict as PAPR >> specifies in terms of precise dispatch behaviour. This generally will >> mean suboptimal performance, rather than guest

Re: [Qemu-devel] [PATCH v5 1/4] spapr: Implement VPA dispatch counter and prod bit on tcg

2019-07-17 Thread Nicholas Piggin
Greg Kurz's on July 18, 2019 1:29 am: > On Wed, 17 Jul 2019 15:39:49 +1000 > Nicholas Piggin wrote: > >> -cpu->machine_data = g_new0(SpaprCpuState, 1); >> +spapr_cpu = g_new0(SpaprCpuState, 1); >> +cpu->machine_data = spapr_cpu; > > What's the purpose of this change since there's no

Re: [Qemu-devel] [PATCH v5 1/4] spapr: Implement VPA dispatch counter and prod bit on tcg

2019-07-17 Thread Nicholas Piggin
Cédric Le Goater's on July 17, 2019 10:50 pm: > On 17/07/2019 07:39, Nicholas Piggin wrote: >> Implement cpu_exec_enter/exit on ppc which calls into new methods of >> the same name in PPCVirtualHypervisorClass. These are used by spapr >> to implement these splpar elements, used in subsequent change

Re: [Qemu-devel] [PATCH v2] target/i386: Introduce Denverton CPU model

2019-07-17 Thread Tao Xu
On 7/18/2019 2:38 AM, Eduardo Habkost wrote: On Wed, Jul 17, 2019 at 01:39:01PM +0800, Tao Xu wrote: Hi Eduardo, Could I ask a question about introducing a old CPU model? Maybe not so old because it was launched in 2017. It is the former generation (Atom Server) of Snowridge and if this cpu mod

Re: [Qemu-devel] [PATCH v3 0/2] bitmap: refine bitmap_set

2019-07-17 Thread Peter Xu
On Thu, Jul 18, 2019 at 09:04:54AM +0800, Wei Yang wrote: > Patch 1 refine bitmap_set a little. > Patch 2 add related test case to bitmap_set. > > v3: > * free bmap > * all 1's set correctly > * expand range to 2 long > * check each possible of offset > * add a skeleton to test both bitm

Re: [Qemu-devel] [PATCH] migration: just pass RAMBlock is enough

2019-07-17 Thread Peter Xu
On Thu, Jul 18, 2019 at 09:25:47AM +0800, Wei Yang wrote: > RAMBlock->used_length is always passed to migration_bitmap_sync_range(), > which could be retrieved from RAMBlock. > > Suggested-by: Paolo Bonzini > Signed-off-by: Wei Yang Reviewed-by: Peter Xu -- Peter Xu

[Qemu-devel] [PATCH] migration: just pass RAMBlock is enough

2019-07-17 Thread Wei Yang
RAMBlock->used_length is always passed to migration_bitmap_sync_range(), which could be retrieved from RAMBlock. Suggested-by: Paolo Bonzini Signed-off-by: Wei Yang --- migration/ram.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c

Re: [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to a word

2019-07-17 Thread Wei Yang
On Wed, Jul 17, 2019 at 11:17:50AM +0200, Paolo Bonzini wrote: >On 30/04/19 05:44, Wei Yang wrote: >> RAMBlock->offset is calculated by find_ram_offset, which makes sure the >> offset is aligned to a word. >> >> This patch removes the alignment check on offset and unnecessary >> variable *word*. >

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v2] spapr_pci: Advertise BAR reallocation capability

2019-07-17 Thread Alexey Kardashevskiy
On 17/07/2019 20:21, Greg Kurz wrote: On Wed, 17 Jul 2019 17:06:36 +1000 Alexey Kardashevskiy wrote: The pseries guests do not normally allocate PCI resources and rely on the system firmware doing so. Furthermore at least at some point in the past the pseries guests won't even allowed to ch

Re: [Qemu-devel] [PATCH 2/3] migration/ram.c: start of cpu_physical_memory_sync_dirty_bitmap is always 0

2019-07-17 Thread Wei Yang
On Wed, Jul 17, 2019 at 11:16:19AM +0200, Paolo Bonzini wrote: >On 17/07/19 03:13, Wei Yang wrote: >> On Tue, May 14, 2019 at 03:21:08PM +0100, Dr. David Alan Gilbert wrote: >>> * Wei Yang (richardw.y...@linux.intel.com) wrote: Since start of cpu_physical_memory_sync_dirty_bitmap is always 0,

[Qemu-devel] [PATCH v3 0/2] bitmap: refine bitmap_set

2019-07-17 Thread Wei Yang
Patch 1 refine bitmap_set a little. Patch 2 add related test case to bitmap_set. v3: * free bmap * all 1's set correctly * expand range to 2 long * check each possible of offset * add a skeleton to test both bitmap_set and bitmap_set_atomic v2: * refine bitmap_set_atomic * add a test

[Qemu-devel] [PATCH v3 1/2] bitmap: get last word mask from nr directly

2019-07-17 Thread Wei Yang
The value left in nr is the number of bits for the last word, which could be calculate the last word mask directly. Remove the unnecessary size. Signed-off-by: Wei Yang --- v2: refine bitmap_set_atomic too, suggested from Peter --- util/bitmap.c | 9 +++-- 1 file changed, 3 insertions(+),

[Qemu-devel] [PATCH v3 2/2] test-bitmap: add test for bitmap_set

2019-07-17 Thread Wei Yang
Add a test for bitmap_set. There are three cases: * Both start and end is BITS_PER_LONG aligned * Only start is BITS_PER_LONG aligned * Only end is BITS_PER_LONG aligned Signed-off-by: Wei Yang --- v3: * free bmap * all 1's set correctly * expand range to 2 long * check each possi

Re: [Qemu-devel] [PATCH v2 0/2] bitmap: refine bitmap_set

2019-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190717071114.14772-1-richardw.y...@linux.intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH v2] tests/boot_linux_console: add a test for riscv64 + virt

2019-07-17 Thread Alistair Francis
On Tue, Jul 16, 2019 at 10:21 PM Chih-Min Chao wrote: > > > > On Wed, Jul 17, 2019 at 6:59 AM Alistair Francis wrote: >> >> On Tue, Jul 16, 2019 at 2:50 PM Philippe Mathieu-Daudé >> wrote: >> > >> > On 7/16/19 10:43 PM, Alistair Francis wrote: >> > > On Tue, Jul 16, 2019 at 6:56 AM Chih-Min Chao

Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support

2019-07-17 Thread Debarshi Ray
On Wed, Jul 10, 2019 at 10:40 AM Marc-André Lureau wrote: > I am not very familiar with podman or docker, so I am not able to tell > you why docker does work by default. @Debarshi Ray might know, as he > helped me finding a workaround. You need to mention the UID mapping via --uidmap arguments (

Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support

2019-07-17 Thread Debarshi Ray
Hey, Sorry for the late response. I was on vacation and away from my keyboard. On Tue, Jul 9, 2019 at 9:44 PM Marc-André Lureau wrote: > With current podman, we have to use a uidmap trick in order to be able > to rw-share the ccache directory with the container user. > > With a user 1000, the de

[Qemu-devel] [PATCH v2 3/5] block/ide/scsi: Set BLK_PERM_SUPPORT_ZONED

2019-07-17 Thread Dmitry Fomichev
Added a new boolean argument to blkconf_apply_backend_options() to let the common block code know whether the chosen block backend can handle zoned block devices or not. blkconf_apply_backend_options() then sets BLK_PERM_SUPPORT_ZONED permission accordingly. The raw code can then use this permissi

[Qemu-devel] [PATCH v2 4/5] raw: Don't open ZBDs if backend can't handle them

2019-07-17 Thread Dmitry Fomichev
Abort opening a zoned device as a raw file in case the chosen block backend driver lacks proper support for this type of storage. Signed-off-by: Dmitry Fomichev --- block/file-posix.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c inde

[Qemu-devel] [PATCH v2 0/5] virtio/block: handle zoned backing devices

2019-07-17 Thread Dmitry Fomichev
Currently, attaching zoned block devices (i.e. storage devices compliant to ZAC/ZBC standards) using several virtio methods doesn't work properly as zoned devices appear as regular block devices at the guest. This may cause unexpected i/o errors and, potentially, some data corruption. To be more p

[Qemu-devel] [PATCH v2 5/5] hw/scsi: Check sense key before READ CAPACITY output snoop

2019-07-17 Thread Dmitry Fomichev
From: Shin'ichiro Kawasaki When READ CAPACITY command completes, scsi_read_complete() function snoops the command result and updates SCSIDevice members blocksize and max_lba . However, this update is executed even when READ CAPACITY command indicates an error in sense data. This causes unexpected

[Qemu-devel] [PATCH v2 2/5] raw: Recognize zoned backing devices

2019-07-17 Thread Dmitry Fomichev
The purpose of this patch is to recognize a zoned block device (ZBD) when it is opened as a raw file. The new code initializes the zoned model propery introduced by the previous commit. This commit is Linux-specific as it gets the Zoned Block Device Model value (none/host-managed/host-aware) from

[Qemu-devel] [PATCH v2 1/5] block: Add zoned device model property

2019-07-17 Thread Dmitry Fomichev
This commit adds Zoned Device Model (as defined in T10 ZBC and T13 ZAC standards) as a block driver property, along with some useful access functions. A new backend driver permission, BLK_PERM_SUPPORT_ZONED, is also introduced. Only the drivers having this permission will be allowed to open zoned

Re: [Qemu-devel] [PATCH v3] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread John Snow
On 7/17/19 1:39 PM, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Let's add a possibility to query dirty-bitmaps not only on root nodes. > It is useful when dealing both with snapshots and incremental backups. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > [Added deprecation i

[Qemu-devel] [PATCH for-4.2 v2 0/2] spapr: Implement H_TPM_COMM for accessing host TPM device

2019-07-17 Thread Michael Roth
These patches are based on ppc-for-4.2 and are also available at: https://github.com/mdroth/qemu/commits/spapr-tpm-hcall-v2 This patchset implements the H_TPM_COMM hypercall, which provides a way for an Ultravisor to pass raw TPM commands on to a host's TPM device, either directly or through a

[Qemu-devel] [PATCH for-4.2 v2 1/2] docs/specs: initial spec summary for Ultravisor-related hcalls

2019-07-17 Thread Michael Roth
For now this only covers hcalls relating to TPM communication since it's the only one particularly important from a QEMU perspective atm, but others can be added here where it makes sense. The full specification for all hcalls/ucalls will eventually be made available in the public/OpenPower versio

[Qemu-devel] [PATCH for-4.2 v2 2/2] spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy

2019-07-17 Thread Michael Roth
This implements the H_TPM_COMM hypercall, which is used by an Ultravisor to pass TPM commands directly to the host's TPM device, or a TPM Resource Manager associated with the device. This also introduces a new virtual device, spapr-tpm-proxy, which is used to configure the host TPM path to be used

Re: [Qemu-devel] [RFC PATCH 10/10] hw/pci-host/gt64120: Clean the decoded address space

2019-07-17 Thread Paul Burton
Hi Philippe, Sorry for the delay; I was away for a few weeks visiting family. On Mon, Jul 01, 2019 at 08:06:21PM +0200, Philippe Mathieu-Daudé wrote: > The difference with the previous content is now we have > two new holes: > > - 0x0200-0x1000 > - 0x14001000-0x1c00 > > Ralf/Paul/Ja

Re: [Qemu-devel] [PATCH for-4.2 2/2] spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy

2019-07-17 Thread Michael Roth
Quoting David Gibson (2019-07-16 21:01:15) > On Tue, Jul 16, 2019 at 06:53:13PM -0500, Michael Roth wrote: > > This implements the H_TPM_COMM hypercall, which is used by an > > Ultravisor to pass TPM commands directly to the host's TPM device, or > > a TPM Resource Manager associated with the devic

Re: [Qemu-devel] [PATCH 2/2] spapr: initial implementation for H_TPM_COMM hcall

2019-07-17 Thread Michael Roth
Quoting David Gibson (2019-07-16 20:29:12) > On Tue, Jul 16, 2019 at 11:30:01AM -0500, Michael Roth wrote: > > Quoting David Gibson (2019-07-14 21:25:24) > > > On Fri, Jul 12, 2019 at 09:34:46AM -0500, Michael Roth wrote: > > > > Quoting David Gibson (2019-07-12 01:46:19) > > > > > On Thu, Jul 11,

Re: [Qemu-devel] [PATCH v3] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread John Snow
On 7/17/19 4:05 PM, Eric Blake wrote: > On 7/17/19 2:21 PM, John Snow wrote: >>> >>> Is this worth squeezing into 4.1, to start the deprecation clock one >>> cycle earlier (on the grounds that the missing information for anonymous >>> nodes is a bug)? Or am I pushing the boundaries too far, whe

Re: [Qemu-devel] [PATCH v3] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread Eric Blake
On 7/17/19 2:21 PM, John Snow wrote: >> >> Is this worth squeezing into 4.1, to start the deprecation clock one >> cycle earlier (on the grounds that the missing information for anonymous >> nodes is a bug)? Or am I pushing the boundaries too far, where keeping >> this as 4.2 material remains the

Re: [Qemu-devel] [QUESTION] SDL 1.2 support

2019-07-17 Thread Eric Blake
On 7/17/19 2:20 PM, Aleksandar Markovic wrote: > But, does "configure" list somewhere unmet soft dependencies? (the > question is general, not looking at SDL only) Is there any other way for > an end user to have info on unmet dependencies (whether soft or hard), > other than see QEMU is not build

Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface

2019-07-17 Thread Kevin Wolf
Am 17.07.2019 um 21:03 hat Sam Eiderman geschrieben: > Gentle ping. Through which tree is this supposed to go? I feel this is more firmware interface related than block layer stuff. Kevin > > On 8 Jul 2019, at 20:30, Sam Eiderman wrote: > > > > Thanks Gerd, > > > > Gentle ping on this. > > >

Re: [Qemu-devel] [PATCH v2 00/11] bitmaps: allow bitmaps to be used with full and top

2019-07-17 Thread John Snow
On 7/15/19 8:01 PM, John Snow wrote: > Based-on: https://github.com/jnsnow/qemu/tree/bitmaps > > This follows the previous series which adds the 'bitmap' sync mode > and uses it to add interactions with bitmaps to the 'full' and 'top' > modes to blockdev-backup and drive-backup. > > Why? > on

Re: [Qemu-devel] [PATCH v3] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread John Snow
On 7/17/19 3:13 PM, Eric Blake wrote: > On 7/17/19 12:39 PM, John Snow wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Let's add a possibility to query dirty-bitmaps not only on root nodes. >> It is useful when dealing both with snapshots and incremental backups. >> >> Signed-off-by: Vladimi

Re: [Qemu-devel] [QUESTION] SDL 1.2 support

2019-07-17 Thread Aleksandar Markovic
On Wed, Jul 17, 2019 at 8:57 PM Eric Blake wrote: > > On 7/17/19 1:34 PM, Aleksandar Markovic wrote: > > > > > Daniel, that is fine, I don't question that, I basically wanted to start a > > talk > > between us to clarify some things. Related to our situation in the field, > > I have a sub-questio

Re: [Qemu-devel] [PATCH v3] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread Eric Blake
On 7/17/19 12:39 PM, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Let's add a possibility to query dirty-bitmaps not only on root nodes. > It is useful when dealing both with snapshots and incremental backups. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > [Added deprecation inf

[Qemu-devel] [PATCH] make check-unit: use after free in test-opts-visitor

2019-07-17 Thread Andrey Shinkevich
In struct OptsVisitor, repeated_opts member points to a list in the unprocessed_opts hash table after the list has been destroyed. A subsequent call to visit_type_int() references the deleted list. It results in use-after-free issue. Also, the Visitor object call back functions are supposed to set

Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface

2019-07-17 Thread Sam Eiderman
Gentle ping. Sam > On 8 Jul 2019, at 20:30, Sam Eiderman wrote: > > Thanks Gerd, > > Gentle ping on this. > > Sam > >> On 1 Jul 2019, at 10:41, Gerd Hoffmann wrote: >> >> On Wed, Jun 26, 2019 at 03:39:40PM +0300, Sam Eiderman wrote: >>> v1: >>> >>> Non-standard logical geometries break un

Re: [Qemu-devel] [QUESTION] SDL 1.2 support

2019-07-17 Thread Eric Blake
On 7/17/19 1:34 PM, Aleksandar Markovic wrote: > > Daniel, that is fine, I don't question that, I basically wanted to start a > talk > between us to clarify some things. Related to our situation in the field, > I have a sub-question to you: > > Let's say there is a build system with SDL 1.2, an

Re: [Qemu-devel] [PATCH v2] target/i386: Introduce Denverton CPU model

2019-07-17 Thread Eduardo Habkost
On Wed, Jul 17, 2019 at 01:39:01PM +0800, Tao Xu wrote: > Hi Eduardo, > > Could I ask a question about introducing a old CPU model? Maybe not so old > because it was launched in 2017. It is the former generation (Atom Server) > of Snowridge and if this cpu model be added, qemu may can migrate gues

Re: [Qemu-devel] [QUESTION] SDL 1.2 support

2019-07-17 Thread Aleksandar Markovic
On Tue, Jul 16, 2019 at 7:44 PM Daniel P. Berrangé wrote: > > On Tue, Jul 16, 2019 at 07:09:37PM +0200, Aleksandar Markovic wrote: > > On Tue, Jul 16, 2019 at 1:54 PM Thomas Huth wrote: > > > > > > On 16/07/2019 13.17, Aleksandar Markovic wrote: > > > > Hello, Gerd, Daniel, and others involved. >

Re: [Qemu-devel] [PATCH v2 16/23] NSIS: Add missing firmware blobs

2019-07-17 Thread Stefan Weil
Am 17.07.2019 um 15:43 schrieb Alex Bennée: > From: Philippe Mathieu-Daudé > > Various firmwares has been added in the pc-bios/ directory: > > - CCW (since commit 0c1fecdd523) > - Skiboot (since commit bcad45de6a0) > - EDK2(since commit f7fa38b74c3) > > Since we install qemu-system able to

Re: [Qemu-devel] [PATCH v2 09/11] block/backup: teach TOP to never copy unallocated regions

2019-07-17 Thread John Snow
On 7/16/19 12:11 PM, Max Reitz wrote: > On 16.07.19 18:02, John Snow wrote: >> >> >> On 7/16/19 7:43 AM, Max Reitz wrote: >>> On 16.07.19 02:01, John Snow wrote: Presently, If sync=TOP is selected, we mark the entire bitmap as dirty. In the write notifier handler, we dutifully copy out

Re: [Qemu-devel] [PATCH v2 11/11] iotests/257: test traditional sync modes

2019-07-17 Thread John Snow
On 7/17/19 5:50 AM, Max Reitz wrote: > On 16.07.19 18:58, John Snow wrote: >> >> >> On 7/16/19 8:04 AM, Max Reitz wrote: >>> On 16.07.19 02:01, John Snow wrote: Signed-off-by: John Snow --- tests/qemu-iotests/257 | 41 +- tests/qemu-iotests/257.out | 3089 +

Re: [Qemu-devel] [PATCH v3] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread John Snow
On 7/17/19 1:39 PM, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Let's add a possibility to query dirty-bitmaps not only on root nodes. > It is useful when dealing both with snapshots and incremental backups. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > [Added deprecation i

[Qemu-devel] [PATCH v3] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Let's add a possibility to query dirty-bitmaps not only on root nodes. It is useful when dealing both with snapshots and incremental backups. Signed-off-by: Vladimir Sementsov-Ogievskiy [Added deprecation information. --js] Signed-off-by: John Snow --- block

Re: [Qemu-devel] [PATCH v5 4/4] spapr: Implement H_JOIN

2019-07-17 Thread Greg Kurz
On Wed, 17 Jul 2019 15:39:52 +1000 Nicholas Piggin wrote: > This has been useful to modify and test the Linux pseries suspend > code but it requires modification to the guest to call it (due to > being gated by other unimplemented features). It is not otherwise > used by Linux yet, but work is sl

Re: [Qemu-devel] [PATCH v5 3/4] spapr: Implement H_CONFER

2019-07-17 Thread Greg Kurz
On Wed, 17 Jul 2019 15:39:51 +1000 Nicholas Piggin wrote: > This does not do directed yielding and is not quite as strict as PAPR > specifies in terms of precise dispatch behaviour. This generally will > mean suboptimal performance, rather than guest misbehaviour. Linux > does not rely on exact d

Re: [Qemu-devel] [RISU PATCH v3 09/18] risugen: add --xfeatures option for x86

2019-07-17 Thread Richard Henderson
On 7/11/19 3:32 PM, Jan Bobek wrote: > The --xfeatures option is modelled after identically-named option to > RISU itself; it allows the user to specify which vector registers > should be initialized, so that the test image doesn't try to access > registers which may not be present at runtime. Note

Re: [Qemu-devel] [RISU PATCH v3 08/18] risugen: add command-line flag --x86_64

2019-07-17 Thread Richard Henderson
On 7/11/19 3:32 PM, Jan Bobek wrote: > This flag instructs the x86 backend to emit 64-bit (rather than > 32-bit) code. > > Signed-off-by: Jan Bobek > --- > risugen | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v5] LUKS: support preallocation

2019-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190716161901.1430-1-mlevi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make

[Qemu-devel] [Bug 1835693] Re: s390x binaries segfault

2019-07-17 Thread Thomas Huth
Which QEMU version are you using here? Can you reproduce this issue with the latest upstream QEMU ? ... otherwise, please report this issue to the Debian bug tracker instead. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bug

Re: [Qemu-devel] [PATCH v2 17/23] hw/i386: also turn off VMMOUSE is VMPORT is disabled

2019-07-17 Thread Thomas Huth
On 17/07/2019 15.43, Alex Bennée wrote: > Commit 97fd1ea8c1 broke the build for --without-default-devices as > VMMOUSE depends on VMPORT. > > Fixes: 97fd1ea8c1 > Signed-off-by: Alex Bennée > --- > hw/i386/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i3

Re: [Qemu-devel] [PATCH] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-07-17 Thread John Snow
On 7/16/19 11:26 AM, John Snow wrote: > > > On 7/16/19 2:32 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 6/5/19 8:46 AM, Markus Armbruster wrote: John Snow writes: > On 5/31/19 10:55 AM, Eric Blake wrote: >> On 5/30/19 11:26 AM, John Snow wrote: >>> >

Re: [Qemu-devel] [PATCH v26 0/7] QEMU AVR 8 bit cores

2019-07-17 Thread Michael Rolnik
ping. On Fri, Jul 12, 2019 at 8:37 AM Michael Rolnik wrote: > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully > tested yet. > However I was able to execute simple code with functions. e.g fibonacci > calculation. > This

Re: [Qemu-devel] [PATCH v2 06/14] target/arm: Allow SVE to be disabled via a CPU property

2019-07-17 Thread Andrew Jones
On Wed, Jun 26, 2019 at 03:52:44PM +0200, Andrew Jones wrote: > On Wed, Jun 26, 2019 at 12:20:29PM +0200, Richard Henderson wrote: > > On 6/21/19 6:34 PM, Andrew Jones wrote: > > > Since 97a28b0eeac14 ("target/arm: Allow VFP and Neon to be disabled via > > > a CPU property") we can disable the 'max

Re: [Qemu-devel] [PATCH v5 1/4] spapr: Implement VPA dispatch counter and prod bit on tcg

2019-07-17 Thread Greg Kurz
On Wed, 17 Jul 2019 15:39:49 +1000 Nicholas Piggin wrote: > Implement cpu_exec_enter/exit on ppc which calls into new methods of > the same name in PPCVirtualHypervisorClass. These are used by spapr > to implement these splpar elements, used in subsequent changes. > > Signed-off-by: Nicholas Pig

[Qemu-devel] [Bug 1828723] Re: [RFE] option to suppress gemu_log() output

2019-07-17 Thread Alex Bennée
Although arguably the line: gemu_log("Unsupported setsockopt level=%d optname=%d\n", level, optname); Could be qemu_log_mask(LOG_UNIMP,) Not sure where gemu_log is used, it seems to be strace related. -- You received this bug notification because you are a member of qemu- devel-ml, wh

[Qemu-devel] [Bug 1828723] Re: [RFE] option to suppress gemu_log() output

2019-07-17 Thread Alex Bennée
The -d/-D options should work in linux-user as well. You can also set QEMU_LOG_FILENAME and QEMU_LOG environment variables. Do these not work for you? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/182

[Qemu-devel] [Bug 1829576] Re: QEMU-SYSTEM-PPC64 Regression QEMU-4.0.0

2019-07-17 Thread Alex Bennée
Is this fixed now? Can we mark as fix committed? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1829576 Title: QEMU-SYSTEM-PPC64 Regression QEMU-4.0.0 Status in QEMU: New Bug description: I ha

[Qemu-devel] [Bug 1835693] Re: s390x binaries segfault

2019-07-17 Thread Alex Bennée
Does "make check-tcg" work in this case? It works for me here. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1835693 Title: s390x binaries segf

[Qemu-devel] [Bug 1830415] Re: linux-user elf loader issue

2019-07-17 Thread Alex Bennée
Have you got a test case? The check-tcg tests all pass and they are statically linked elfs. ** Tags added: linux-user ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support

2019-07-17 Thread Laszlo Ersek
On 07/17/19 15:46, Peter Maydell wrote: > On Wed, 17 Jul 2019 at 14:36, Philippe Mathieu-Daudé > wrote: >> I still wonder why this didn't assert on Peter's setup. > > My setup does not assert because my host kernel correctly > provides the ID register values to QEMU. Laszlo's appears > to be pro

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-17 Thread Paolo Bonzini
On 17/07/19 16:54, Collin Walling wrote: > PCI host plugging will check for the MSI-X capability on the > PCI device. If the MSI-X cap is missing, we fail device plugging. > We do not check for MSI. Only MSI-X. > > Specifically, the capability is represented by PCI_CAP_ID_MSIX > in pci_regs.h The

[Qemu-devel] [Bug 1835693] Re: s390x binaries segfault

2019-07-17 Thread Alex Bennée
** Tags added: linux-user s390x tcg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1835693 Title: s390x binaries segfault Status in QEMU: Incomplete Bug description: Hello World appears to seg

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 4/4] ppc: dont overwrite initialized idle_timer

2019-07-17 Thread Greg Kurz
On Wed, 17 Jul 2019 03:20:55 -0500 Shivaprasad G Bhat wrote: > The check to see if the idle_timer is already initialized is > missing. Every vcpu thread would call kvm_arch_init_vcpu() > and overwrite the idle_timer resulting in a memory leak. > Patch fixes that. > > Signed-off-by: Shivaprasad G

[Qemu-devel] [PULL 1/3] linux-user: Fix structure target_ucontext for MIPS

2019-07-17 Thread Laurent Vivier
From: Aleksandar Markovic Structure ucontext for MIPS is defined in the following way in Linux kernel: (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) struct ucontext { /* Historic fields matching asm-generic */ unsigned long uc_flags; struct ucontext *uc_link; st

[Qemu-devel] [PULL 2/3] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-17 Thread Laurent Vivier
From: Daniel P. Berrangé The SIOCGSTAMP symbol was previously defined in the asm-generic/sockios.h header file. QEMU sees that header indirectly via sys/socket.h In linux kernel commit 0768e17073dc527ccd18ed5f96ce85f9985e9115 the asm-generic/sockios.h header no longer defines SIOCGSTAMP. Instead

  1   2   3   >