Re: [PATCH 1/2] target/s390x: Fix EXECUTE of relative long instructions

2023-03-14 Thread Richard Henderson
On 3/13/23 16:38, Ilya Leoshkevich wrote: The code uses the wrong base for relative addressing: it should use the target instruction address and not the EXECUTE's address. Fix by storing the target instruction address in the new CPUS390XState member and loading it from the code generated by

[PULL 2/3] ps2: Don't send key release event for Lang1, Lang2 keys

2023-03-14 Thread Daniel P . Berrangé
From: Ross Lagerwall The scancodes for the Lang1 and Lang2 keys (i.e. Hangeul, Hanja) are special since they already have the 0x80 bit set which is commonly used to indicate a key release in AT set 1. Reportedly, real hardware does not send a key release scancode. So, skip sending a release for

[PULL 1/3] Add qemu qcode support for keys F13 to F24

2023-03-14 Thread Daniel P . Berrangé
From: Willem van de Velde To be able to use the function keys F13 to F24 these should be defined in de keycodemapdb and added to the qapi. The keycodemapdb is updated in its own repository, this patch enables the use of those keys within qemu. Signed-off-by: Willem van de Velde

[PULL 0/3] Misc next patches

2023-03-14 Thread Daniel P . Berrangé
The following changes since commit 5cfda4ce79dd455f1726874a555260a70f84b2ec: Merge tag 'pull-request-2023-03-13' of https://gitlab.com/thuth/qemu into staging (2023-03-13 17:09:33 +) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/misc-next-pull-request

[PULL 3/3] io/channel-tls: plug memory leakage on GSource

2023-03-14 Thread Daniel P . Berrangé
From: Matheus Tavares Bernardino This leakage can be seen through test-io-channel-tls: $ ../configure --target-list=aarch64-softmmu --enable-sanitizers $ make ./tests/unit/test-io-channel-tls $ ./tests/unit/test-io-channel-tls Indirect leak of 104 byte(s) in 1 object(s) allocated from: #0

Re: [PATCH v17 06/12] s390x/cpu topology: interception of PTF instruction

2023-03-14 Thread Pierre Morel
I am currently developing tests under avocado to help debugging. And... it helps. There is a bug here in s390_topology_set_cpus_entitlement for dedicated CPUs. On 3/9/23 13:15, Pierre Morel wrote: [...] --- a/hw/s390x/cpu-topology.c +++ b/hw/s390x/cpu-topology.c @@ -87,6 +87,84 @@ static

Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-14 Thread Christian Schoenebeck
On Monday, February 20, 2023 11:08:03 AM CET Bin Meng wrote: > From: Guohuai Shi > > This commit implements Windows specific xxxdir() APIs for safety > directory access. That comment is seriously too short for this patch. 1. You should describe the behaviour implementation that you have chosen

Re: [PATCH v4 4/6] hw/cxl: QMP based poison injection support

2023-03-14 Thread Fan Ni
The 03/03/2023 15:09, Jonathan Cameron wrote: > Inject poison using qmp command cxl-inject-poison to add an entry to the > poison list. > > For now, the poison is not returned CXL.mem reads, but only via the > mailbox command Get Poison List. > > See CXL rev 3.0, sec 8.2.9.8.4.1 Get Poison list

Re: [PATCH v4 5/6] hw/cxl: Add poison injection via the mailbox.

2023-03-14 Thread Fan Ni
The 03/03/2023 15:09, Jonathan Cameron wrote: > Very simple implementation to allow testing of corresponding > kernel code. Note that for now we track each 64 byte section > independently. Whilst a valid implementation choice, it may > make sense to fuse entries so as to prove out more complex >

Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-14 Thread Fan Ni
The 03/03/2023 15:09, Jonathan Cameron wrote: > Current implementation is very simple so many of the corner > cases do not exist (e.g. fragmenting larger poison list entries) > > Signed-off-by: Jonathan Cameron > --- Reviewed-by: Fan Ni One minor thing as mentioned below. > v4: > - Fix off by

Re: [PATCH] MAINTAINERS: Mark the Nios II CPU as orphan

2023-03-14 Thread Sandra Loosemore
On 3/13/23 14:46, Philippe Mathieu-Daudé wrote: +CodeSourcery folks On 13/3/23 19:33, Thomas Huth wrote: Marek and Chris haven't been active for Nios II since years (the last time seems to have been in 2017), and we've got unhandled severe Nios II bug tickets in the bug tracker since a long

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Mark Cave-Ayland
On 14/03/2023 14:21, Chuck Zmudzinski wrote: On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: On 14/03/2023 13:26, Chuck Zmudzinski wrote: On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: On 14/03/2023 06:33, Michael S. Tsirkin

Re: [PULL v3 00/91] tcg patch queue

2023-03-14 Thread Peter Maydell
On Mon, 13 Mar 2023 at 18:59, Richard Henderson wrote: > > Version 3 fixes a rebase error from v2 affecting ARM BFC insn. > > > r~ > > > The following changes since commit 29c8a9e31a982874ce4e2c15f2bf82d5f8dc3517: > > Merge tag 'linux-user-for-8.0-pull-request' of >

Re: [PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests

2023-03-14 Thread Thomas Huth
On 14/03/2023 15.08, Peter Maydell wrote: On Tue, 14 Mar 2023 at 14:01, Thomas Huth wrote: On 14/03/2023 14.33, Peter Maydell wrote: The postcopy/preempt tests seem to have a race which makes them hang on the s390x CI runner. Disable them for the moment, while we investigate. As with the

Re: [PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests

2023-03-14 Thread Peter Maydell
On Tue, 14 Mar 2023 at 14:14, Thomas Huth wrote: > > On 14/03/2023 15.08, Peter Maydell wrote: > > On Tue, 14 Mar 2023 at 14:01, Thomas Huth wrote: > >> > >> On 14/03/2023 14.33, Peter Maydell wrote: > >>> The postcopy/preempt tests seem to have a race which makes them hang > >>> on the s390x CI

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > On 14/03/2023 13:26, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > >> On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > >>> On 14/03/2023 06:33, Michael S. Tsirkin wrote: > >>> > On Tue, Mar

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > On 14/03/2023 13:26, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > >> On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > >>> On 14/03/2023 06:33, Michael S. Tsirkin wrote: > >>> > On Tue, Mar

Re: [PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests

2023-03-14 Thread Peter Maydell
On Tue, 14 Mar 2023 at 14:01, Thomas Huth wrote: > > On 14/03/2023 14.33, Peter Maydell wrote: > > The postcopy/preempt tests seem to have a race which makes them hang > > on the s390x CI runner. Disable them for the moment, while we > > investigate. As with the other disabled subtest, you can

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > > On 14/03/2023 06:33, Michael S. Tsirkin wrote: > > > > > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot

Re: [PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests

2023-03-14 Thread Thomas Huth
On 14/03/2023 14.33, Peter Maydell wrote: The postcopy/preempt tests seem to have a race which makes them hang on the s390x CI runner. Disable them for the moment, while we investigate. As with the other disabled subtest, you can opt back in by setting QEMU_TEST_FLAKY_TESTS=1 in your

[PULL 3/3] MAINTAINERS: Remove CXL maintainer Ben Widawsky

2023-03-14 Thread Laurent Vivier
From: Markus Armbruster Ben is no longer with intel. He told me he expected to get back to CXL, but it's not happening as quickly as he'd like, and that it's best to remove him as maintainer. So let's do that. Thank you for serving as maintainer, Ben! Signed-off-by: Markus Armbruster

Re: [PATCH v2 0/8] iotests: make meson aware of individual I/O tests

2023-03-14 Thread Alex Bennée
Daniel P. Berrangé writes: > To just repeat the patch 5 description... > Queued to for-8.0/tweaks-and-fixes, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL 2/3] MAINTAINERS: update my email address for the clock framework

2023-03-14 Thread Laurent Vivier
From: Damien Hedde Also update mailmap Signed-off-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel Message-Id: <20230213105227.2357-1-damien.he...@dahe.fr> Signed-off-by: Laurent Vivier --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+),

[PULL 0/3] Trivial branch for 8.0 patches

2023-03-14 Thread Laurent Vivier
/trivial-branch-for-8.0-pull-request for you to fetch changes up to fcc8f37ca3eca968932e5da716ec5e7fc05fdcf4: MAINTAINERS: Remove CXL maintainer Ben Widawsky (2023-03-14 14:46:38 +0100) trivial branch pull request 20230314 Update

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Mark Cave-Ayland
On 14/03/2023 13:26, Chuck Zmudzinski wrote: On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: On 14/03/2023 06:33, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: Commit

[PULL 1/3] qemu-options.hx: remove stray quote

2023-03-14 Thread Laurent Vivier
From: John Snow Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230202223121.252073-1-js...@redhat.com> Signed-off-by: Laurent Vivier --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index

Re: [PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests

2023-03-14 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > The postcopy/preempt tests seem to have a race which makes them hang > on the s390x CI runner. Disable them for the moment, while we > investigate. As with the other disabled subtest, you can opt back in > by setting QEMU_TEST_FLAKY_TESTS=1 in

[PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests

2023-03-14 Thread Peter Maydell
The postcopy/preempt tests seem to have a race which makes them hang on the s390x CI runner. Disable them for the moment, while we investigate. As with the other disabled subtest, you can opt back in by setting QEMU_TEST_FLAKY_TESTS=1 in your environment. Suggested-by: Dr. David Alan Gilbert

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Michael S. Tsirkin
On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > On 14/03/2023 06:33, Michael S. Tsirkin wrote: > > > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > > > uses slot_reserved_mask

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Michael S. Tsirkin
On Tue, Mar 14, 2023 at 08:33:02AM -0400, Chuck Zmudzinski wrote: > On 3/14/2023 2:33 AM, Michael S. Tsirkin wrote: > > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > > > uses slot_reserved_mask to

Re: [PATCH] tests/qtest/migration-test: Disable migration/multifd/tcp/plain/cancel

2023-03-14 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 14 Mar 2023 at 10:12, Dr. David Alan Gilbert > wrote: > > > > Copying Peter Xu on this one since it's poscopy, especially the newer > > postcopy preempt. > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On Sun, 12 Mar 2023

Re: [PATCH] tests/qtest/migration-test: Disable migration/multifd/tcp/plain/cancel

2023-03-14 Thread Daniel P . Berrangé
On Tue, Mar 14, 2023 at 12:46:18PM +, Peter Maydell wrote: > On Tue, 14 Mar 2023 at 10:12, Dr. David Alan Gilbert > wrote: > > > > Copying Peter Xu on this one since it's poscopy, especially the newer > > postcopy preempt. > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On

Re: [PATCH] tests/qtest/migration-test: Disable migration/multifd/tcp/plain/cancel

2023-03-14 Thread Peter Maydell
On Tue, 14 Mar 2023 at 10:12, Dr. David Alan Gilbert wrote: > > Copying Peter Xu on this one since it's poscopy, especially the newer > postcopy preempt. > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Sun, 12 Mar 2023 at 14:06, Peter Maydell > > wrote: > > > Here's another one, on

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Mark Cave-Ayland
On 14/03/2023 06:33, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the xenfv machine when the guest is

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 2:33 AM, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > > uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the > > xenfv machine when the guest

Re: [PATCH nbd 2/4] nbd: Split out block device state from underlying NBD connections

2023-03-14 Thread Eric Blake
On Thu, Mar 09, 2023 at 11:39:44AM +, Richard W.M. Jones wrote: > To implement multi-conn, we will put multiple underlying NBD > connections (ie. NBDClientConnection) inside the NBD block device > handle (BDRVNBDState). This requires first breaking the one-to-one > relationship between

Re: [RESEND PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-14 Thread Jonathan Cameron via
> > diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h > > index 7e5ad65c1d..d589f78202 100644 > > --- a/include/hw/cxl/cxl_device.h > > +++ b/include/hw/cxl/cxl_device.h > > @@ -232,6 +232,14 @@ REG64(CXL_MEM_DEV_STS, 0) > > FIELD(CXL_MEM_DEV_STS, MBOX_READY, 4, 1) > >

Re: [PATCH] DO-NOT-MERGE: pipewire sample code

2023-03-14 Thread Dorinda Bassey
Hi Volker, Thank you for the clarification. I see the problem now. So is it safe to say that: @@ -104,8 +104,9 @@ playback_on_process(void *data) /* calculate the total no of bytes to read data from buffer */ req = b->requested * v->frame_size; if (req == 0) { -req = 4096

[PATCH] docs/sphinx/kerneldoc.py: Honour --enable-werror

2023-03-14 Thread Peter Maydell
Currently, the kerneldoc Sphinx plugin doesn't honour the --enable-werror configure option, so its warnings are never fatal. This is because although we do pass sphinx-build the -W switch, the warnings from kerneldoc are produced by the scripts/kernel-doc script directly and don't go through

Re: [PATCH v7 1/6] memory: Reference as->current_map directly in memory commit

2023-03-14 Thread David Edmondson
Chuang Xu writes: > From: Peter Xu > > Calling RCU variance of address_space_get|to_flatview() during memory "variants" rather than "variance", perhaps? > commit (flatview updates, triggering memory listeners, or updating > ioeventfds, etc.) is not 100% accurate, because commit() requires BQL

[PATCH 2/4] hw/pci/msi: Ensure msi_init() is called before device is realized

2023-03-14 Thread Philippe Mathieu-Daudé
A PCI device can't magically become MSI-capable at runtime. Guests aren't expecting that. Assert MSI is initialized _before_ a device instance is realized. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci/msi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/msi.c b/hw/pci/msi.c

[PATCH 3/4] hw/pci: Add sanity check in pci_find_space()

2023-03-14 Thread Philippe Mathieu-Daudé
This 'used' array is allocated via: pci_qdev_realize() -> do_pci_register_device() -> pci_config_alloc() In a perfect world where all device models are correctly QOM'ified this can't happen. Still it occured to me while refactoring QDev and it was not obvious to figure out. This assert helped,

[PATCH 4/4] hw/pci: Ensure pci_add_capability() is called before device is realized

2023-03-14 Thread Philippe Mathieu-Daudé
PCI capabilities can't appear magically at runtime. Guests aren't expecting that. Assert all capabilities are added _before_ a device instance is realized. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c

[PATCH 1/4] hw/pci/msi: Fix debug format string

2023-03-14 Thread Philippe Mathieu-Daudé
Fix this format string warning when defining MSI_DEBUG: hw/pci/msi.c:209:28: warning: format specifies type 'char' but the argument has type 'unsigned int' [-Wformat] offset, nr_vectors, msi64bit, msi_per_vector_mask);

[PATCH 0/4] hw/pci: Ensure capabilities are added before calling pci_qdev_realize()

2023-03-14 Thread Philippe Mathieu-Daudé
Per MST in [*]: "Calling pci_add_capability when VM is running is likely to confuse guests". Ensure this can't happen by asserting pci_add_capability() is never called after a PCI device is realized. [*] https://lore.kernel.org/qemu-devel/20230308071628-mutt-send-email-...@kernel.org/ Based-on:

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-14 Thread Christian Schoenebeck
On Monday, March 13, 2023 8:06:15 PM CET Dorinda Bassey wrote: > > > > Are you sure about sizeof(n_bytes) here? That's 4. ;-) > > > my bad! > > > > > Volker's point was that "silence" is the center of the wave range. With > > signed > > range that's zero, yes, but with unsigned range that's

[PATCH 0/2] target/s390x: Implement Early Exception Recognition

2023-03-14 Thread Ilya Leoshkevich
Hi, Currently loading bad PSW flags does not lead to an exception, which is not correct. This series fixes this by implementing what PoP calls "Early Exception Recognition". Since it applies to both loading PSW with LPSW/LPSWE and to interrupt handling, s390_cpu_set_psw() looks like the right

[PATCH 1/2] target/s390x: Implement Early Exception Recognition

2023-03-14 Thread Ilya Leoshkevich
Generate specification exception if a reserved bit is set in the PSW mask or if the PSW address is out of bounds dictated by the addresing mode. Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/cpu.c | 26 ++

[PATCH 2/2] tests/tcg/s390x: Add early-exception-recognition.S

2023-03-14 Thread Ilya Leoshkevich
Add a small test that checks whether early exceptions are recognized and whether the correct ILC and old PSW are stored when they happen. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.softmmu-target | 1 + tests/tcg/s390x/early-exception-recognition.S | 38

Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode

2023-03-14 Thread Jason Andryuk
On Tue, Mar 14, 2023 at 4:35 AM David Woodhouse wrote: > > From: David Woodhouse > > When dm_restrict is set, QEMU isn't permitted to update the XenStore node > to indicate its running status. Previously, the xs_write() call would fail > but the failure was ignored. > > However, in refactoring

Re: [PATCH] hw/net/can: Add mcp25625 model

2023-03-14 Thread Ben Dooks
On Tue, Jan 17, 2023 at 07:16:35PM +0100, Pavel Pisa wrote: > Dear Ben, > > sorry for longer response times... I think we've both dropped the ball on this one, just got reminded about this set and found it got deleted from work email. We've done review upates and will try and get some branches

Re: [PATCH v2 1/3] qapi/machine-target: refactor machine-target

2023-03-14 Thread Philippe Mathieu-Daudé
On 14/3/23 11:00, Dinah Baum wrote: Moved architecture agnostic data types to their own file to avoid "attempt to use poisoned TARGET_*" error that results when including qapi header with commands that aren't defined for all architectures. Required to implement enabling

Re: [PATCH v4 1/2] tests/qtest/cxl-test: whitespace, line ending cleanup

2023-03-14 Thread Philippe Mathieu-Daudé
On 27/2/23 17:31, Jonathan Cameron wrote: From: Gregory Price Defines are starting to exceed line length limits, align them for cleanliness before making modifications. Signed-off-by: Gregory Price Signed-off-by: Jonathan Cameron --- tests/qtest/cxl-test.c | 84

[PATCH v2] s390x/gdb: Split s390-virt.xml

2023-03-14 Thread Ilya Leoshkevich
Both TCG and KVM emulate ckc, cputm, last_break and prefix, and it's quite useful to have them during debugging. Right now they are grouped together with KVM-only pp, pfault_token, pfault_select and pfault_compare in s390-virt.xml, and are not available when debugging TCG-emulated code. Move

Re: [PATCH] tests/qtest/migration-test: Disable migration/multifd/tcp/plain/cancel

2023-03-14 Thread Dr. David Alan Gilbert
Copying Peter Xu on this one since it's poscopy, especially the newer postcopy preempt. * Peter Maydell (peter.mayd...@linaro.org) wrote: > On Sun, 12 Mar 2023 at 14:06, Peter Maydell wrote: > > > > On Tue, 7 Mar 2023 at 09:53, Peter Maydell wrote: > > > > > > On Sat, 4 Mar 2023 at 15:39, Peter

Re: [PULL 0/5] s390x and test fixes for 8.0-rc0

2023-03-14 Thread Peter Maydell
On Mon, 13 Mar 2023 at 14:11, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit 29c8a9e31a982874ce4e2c15f2bf82d5f8dc3517: > > Merge tag 'linux-user-for-8.0-pull-request' of > https://gitlab.com/laurent_vivier/qemu into staging (2023-03-12 10:57:00 > +) > > are

[PATCH v2 2/3] cpu, qapi, target/arm, i386, s390x: Generalize query-cpu-model-expansion

2023-03-14 Thread Dinah Baum
This patch enables 'query-cpu-model-expansion' on all architectures. Only architectures that implement the command will return results, others will return an error message as before. This patch lays the groundwork for parsing a -cpu cpu,help option as specified in

[PATCH v2 3/3] cpu, qdict, vl: Enable printing options for CPU type

2023-03-14 Thread Dinah Baum
Change parsing of -cpu argument to allow -cpu cpu,help to print options for the CPU type similar to how the '-device' option works. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1480 Signed-off-by: Dinah Baum --- cpu.c | 41 +++

[PATCH v2 1/3] qapi/machine-target: refactor machine-target

2023-03-14 Thread Dinah Baum
Moved architecture agnostic data types to their own file to avoid "attempt to use poisoned TARGET_*" error that results when including qapi header with commands that aren't defined for all architectures. Required to implement enabling `query-cpu-model-expansion` on all architectures

[PATCH v2 0/3] Enable -cpu ,help

2023-03-14 Thread Dinah Baum
Part 1 is a refactor/code motion patch for qapi/machine target required for setup of Part 2 which enables query-cpu-model-expansion on all architectures Part 3 implements the ',help' feature Limitations: Currently only 'FULL' expansion queries are implemented since that's the only type enabled

Re: [PATCH] s390x/gdb: Split s390-virt.xml

2023-03-14 Thread Ilya Leoshkevich
On Tue, 2023-03-14 at 08:06 +0100, Christian Borntraeger wrote: > > > Am 13.03.23 um 22:16 schrieb Ilya Leoshkevich: > > TCG emulates ckc, cputm, last_break and prefix, and it's quite > > useful > > to have them during debugging. > > KVM provides those as well so I dont get what you are trying

Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH

2023-03-14 Thread Paolo Bonzini
On Mon, Mar 13, 2023 at 5:32 PM Kevin Wolf wrote: > > So I still think that this bug is a symptom of a problem in the design > > of request queuing. > > > > In fact, shouldn't request queuing was enabled at the _end_ of > > bdrv_drained_begin (once the BlockBackend has reached a quiescent > >

Re: [PATCH 1/2] target/s390x: Fix EXECUTE of relative long instructions

2023-03-14 Thread David Hildenbrand
On 14.03.23 00:38, Ilya Leoshkevich wrote: The code uses the wrong base for relative addressing: it should use the target instruction address and not the EXECUTE's address. Fix by storing the target instruction address in the new CPUS390XState member and loading it from the code generated by

Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode

2023-03-14 Thread Paul Durrant
On 14/03/2023 08:35, David Woodhouse wrote: From: David Woodhouse When dm_restrict is set, QEMU isn't permitted to update the XenStore node to indicate its running status. Previously, the xs_write() call would fail but the failure was ignored. However, in refactoring to allow for emulated

[PATCH] accel/xen: Fix DM state change notification in dm_restrict mode

2023-03-14 Thread David Woodhouse
From: David Woodhouse When dm_restrict is set, QEMU isn't permitted to update the XenStore node to indicate its running status. Previously, the xs_write() call would fail but the failure was ignored. However, in refactoring to allow for emulated XenStore operations, a new call to xs_open() was

Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-14 Thread David Woodhouse
On Mon, 2023-03-13 at 19:17 -0400, Jason Andryuk wrote: > This looks good, better than what I posted, and seems to work for both > dm_restrict set and unset. Thanks. > For dm_restricted, xs_write() does fail.  I verified that with a print > statement.  I think "shouldn't even try" makes sense. 

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-14 Thread Luis Machado
On 3/13/23 19:21, Richard Henderson wrote: On 3/13/23 04:44, Luis Machado wrote: Luis: I think that rather than doing (2) with a QEMU namespace, we should define a gdb namespace for this. That makes it clear that this is still a gdb-upstream-sanctioned way of exposing the pauth registers.

Re: [PATCH] s390x/gdb: Split s390-virt.xml

2023-03-14 Thread Christian Borntraeger
Am 13.03.23 um 22:16 schrieb Ilya Leoshkevich: TCG emulates ckc, cputm, last_break and prefix, and it's quite useful to have them during debugging. KVM provides those as well so I dont get what you are trying to do here. (I would understand moving out the pfault things into a KVM section)

Re: [RFC PATCH v2 1/2] util: Add thread-safe qemu_strerror() function

2023-03-14 Thread Yohei Kojima
I'm sorry for sending ill-formed thread twice. This problem was because the SMTP server overwrites Message-ID, and git-sendemail does not reflect it to In-Reply-To: and Reply-To: in the header. I will test well before sending the next patch. The original cover letter was

[RFC PATCH v2 0/2] util: Add thread-safe qemu_strerror() function

2023-03-14 Thread Yohei Kojima
This patch series adds qemu_strerror() function, which is thread-safe version of the libc strerror(). The first patch introduces the qemu_strerror() function, and the second patch replaces strerror() function in linux-user/* with qemu_strerror() function. Because it involves thread safety,

[RFC PATCH v2 2/2] linux-user: replace strerror() function to the thread safe qemu_strerror()

2023-03-14 Thread Yohei Kojima
strerror() is not guaranteed to be thread-safe as described in (https://gitlab.com/qemu-project/qemu/-/issues/416). This commit changes files under /linux-user that call strerror() to call the safer qemu_strerror(). Signed-off-by: Yohei Kojima --- linux-user/elfload.c | 4 ++--

[RFC PATCH v2 1/2] util: Add thread-safe qemu_strerror() function

2023-03-14 Thread Yohei Kojima
Add qemu_strerror() which follows the POSIX specification for strerror(). While strerror() is not guaranteed to be thread-safe, this function is thread-safe. This function is added to solve the following issue: https://gitlab.com/qemu-project/qemu/-/issues/416 Signed-off-by: Yohei Kojima ---

[PULL 1/2] disas/riscv: Fix slli_uw decoding

2023-03-14 Thread Alistair Francis
From: Ivan Klokov The decoding of the slli_uw currently contains decoding error: shamt part of opcode has six bits, not five. Fixes 3de1fb71("target/riscv: update disas.c for xnor/orn/andn and slli.uw") Signed-off-by: Ivan Klokov Reviewed-by: Philipp Tomsich Acked-by: Alistair Francis

[PULL 2/2] Fix incorrect register name in disassembler for fmv, fabs, fneg instructions

2023-03-14 Thread Alistair Francis via
From: Mikhail Tyutin Fix incorrect register name in RISC-V disassembler for fmv,fabs,fneg instructions Signed-off-by: Mikhail Tyutin Reviewed-by: Alistair Francis Message-Id: <3454991f-7f64-24c3-9a36-f5fa2cc38...@yadro.com> Signed-off-by: Alistair Francis --- disas/riscv.c | 19

[PULL 0/2] riscv-to-apply queue

2023-03-14 Thread Alistair Francis
/alistair23/qemu.git tags/pull-riscv-to-apply-20230314 for you to fetch changes up to 0d581506de803204c5a321100afa270573382932: Fix incorrect register name in disassembler for fmv,fabs,fneg instructions (2023-03-14 16:36:43 +1000

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Michael S. Tsirkin
On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the > xenfv machine when the guest is configured for igd-passthru. > > A desired

Re: [PATCH v4 0/6] hw/cxl: Poison get, inject, clear

2023-03-14 Thread Philippe Mathieu-Daudé
Hi Jonathan, On 3/3/23 16:09, Jonathan Cameron wrote: Note there are several series ahead of this one and in particular the RAS error injection series needs some QAPI review. The QAPI stuff in this patch is similar but in essence very similar to what we have in that series. Whilst I'm an

Re: [PATCH v4 5/6] hw/cxl: Add poison injection via the mailbox.

2023-03-14 Thread Philippe Mathieu-Daudé
On 3/3/23 16:09, Jonathan Cameron wrote: Very simple implementation to allow testing of corresponding kernel code. Note that for now we track each 64 byte section independently. Whilst a valid implementation choice, it may make sense to fuse entries so as to prove out more complex corners of

Re: [PATCH v3 1/3] numa: Validate cluster and NUMA node boundary if required

2023-03-14 Thread Gavin Shan
On 3/13/23 7:40 PM, Philippe Mathieu-Daudé wrote: On 25/2/23 07:35, Gavin Shan wrote: For some architectures like ARM64, multiple CPUs in one cluster can be associated with different NUMA nodes, which is irregular configuration because we shouldn't have this in baremetal environment. The

Re: [PATCH v4 4/6] hw/cxl: QMP based poison injection support

2023-03-14 Thread Philippe Mathieu-Daudé
On 3/3/23 16:09, Jonathan Cameron wrote: Inject poison using qmp command cxl-inject-poison to add an entry to the poison list. For now, the poison is not returned CXL.mem reads, What do you mean? but only via the mailbox command Get Poison List. See CXL rev 3.0, sec 8.2.9.8.4.1 Get Poison

Re: [PATCH v5 2/2] target/riscv: redirect XVentanaCondOps to use the Zicond functions

2023-03-14 Thread Alistair Francis
On Wed, Mar 8, 2023 at 4:10 AM Philipp Tomsich wrote: > > The Zicond standard extension implements the same instruction > semantics as XVentanaCondOps, although using different mnemonics and > opcodes. > > Point XVentanaCondOps to the (newly implemented) Zicond implementation > to reduce the

Re: [PATCH v5 1/2] target/riscv: refactor Zicond support

2023-03-14 Thread Alistair Francis
On Wed, Mar 8, 2023 at 4:10 AM Philipp Tomsich wrote: > > After the original Zicond support was stuck/fell through the cracks on > the mailing list at v3 (and a different implementation was merged in > the meanwhile), we need to refactor Zicond to prepare it to be reused > by XVentanaCondOps. > >

Re: [PATCH v4 3/6] bswap: Add the ability to store to an unaligned 24 bit field

2023-03-14 Thread Philippe Mathieu-Daudé
On 3/3/23 16:09, Jonathan Cameron wrote: From: Ira Weiny CXL has 24 bit unaligned fields which need to be stored to. CXL is specified as little endian. Define st24_le_p() and the supporting functions to store such a field from a 32 bit host native value. The use of b, w, l, q as the size

<    1   2