Re: [PULL 01/24] configure: move -mcx16 flag out of CPU_CFLAGS

h == 'x86_64' > + qemu_common_flags = ['-mcx16'] + qemu_common_flags > +endif > + > if get_option('prefer_static') >qemu_ldflags += get_option('b_pie') ? '-static-pie' : '-static' > endif This breaks atomic detection resulting in: #undef CONFIG_ATOMIC128 #undef CONFIG_ATOMIC128_OPT #undef CONFIG_CMPXCHG128 which makes the TCG atomic handling code fallback to cpu_step_atomic, killing performance. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH trivial] gitlab-ci/build-oss-fuzz: print FAILED marker in case the test failed and run all tests

> Print easily recognizable error message about test failure, so > it becomes obvious what exactly has failed. > > While at it, continue running other tests even in case of > failure, and exit non-zero if at least one test failed. Queued to testing/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[RFC PATCH] accel/tcg: add tracepoints for cpu_loop_exit_atomic

-name=rom,driver=file,filename=(pwd)/pc-bios/edk2-aarch64-code.fd,read-only=true \ -blockdev node-name=efivars,driver=file,filename=$HOME/images/qemu-arm64-efivars \ -m 8192 \ -object memory-backend-memfd,id=mem,size=8G,share=on \ -kernel /home/alex/lsrc

Re: [PATCH v3 00/14] macOS PV Graphics and new vmapple machine type

ing of the extra instructions that Apple added (although in theory that should only be run in Apples own ML libraries). -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: Rust BoF and maintainer minutes and planning the roadmap to Rust

Warner Losh writes: > On Thu, Oct 3, 2024 at 2:53 AM Warner Losh wrote: > > On Thu, Sep 26, 2024 at 8:24 AM Alex Bennée wrote: > > One output from this discussion should be a clear statement that we are > going forward with this work and the road map. A rough roadmap

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

Peter Maydell writes: > On Wed, 2 Oct 2024 at 16:35, Alex Bennée wrote: >> >> Helge Deller writes: >> >> > When the emulated CPU reads or writes to a memory location >> > a) for which no read/write permissions exists, *and* >> > b) the

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

hing > +mmu_check_alignment(cpu, addr, ra, type, l); > } > > l->page[0].addr = addr; > @@ -1760,6 +1777,10 @@ static bool mmu_lookup(CPUState *cpu, vaddr addr, > MemOpIdx oi, > tcg_debug_assert((flags & TLB_BSWAP) == 0); > } > > +if

Re: [PATCH] tests/tcg/plugins: Remove remainder of the cris target

yscallInfo arch_syscall_info[] = { > { "arm", 4 }, > { "armeb", 4 }, > { "avr", -1 }, > -{ "cris", -1 }, > { "hexagon", 64 }, > { "hppa", -1 }, > { "i386", 4 }, Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 06/13] tests/tcg/plugins: Use the ld/st_endian_p() API

Philippe Mathieu-Daudé writes: > Refactor to use the recently introduced ld/st_endian_p() API > No logical change intended. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v4] testing: bump mips64el cross to bookworm and allow to fail

Thomas Huth writes: Sorry to mention it but now the subject needs tweaking... -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: what is the right way for an avocado test to do "wait for text that doesn't end in newline" ?

word:' prompt lines don't > have a newline after them. > > What is the right way to do this common thing? Well the easiest way (which I do on some of my test images) is to enable autologin so you get a shell prompt at the start. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] testing: bump mips64el cross to bookworm and allow to fail

Thomas Huth writes: > From: Alex Bennée > > The mips64el cross setup is very broken for bullseye which has now > entered LTS support so is unlikely to be fixed. While we still can't > build the container for bookworm due to a single missing dependency > that will hop

Re: [PATCH v2 14/18] util/timer: avoid deadlock when shutting down

Michael Tokarev writes: > On 16.09.2024 11:53, Alex Bennée wrote: >> When we shut down a guest we disable the timers. However this can >> cause deadlock if the guest has queued some async work that is trying >> to advance system time and spins forever trying to wind

Re: [PATCH v3 10/22] hw/sdhci: fix -Werror=maybe-uninitialized false-positive

length : 64 * KiB; means we always have something. Although get_adma_description() is deserving of a g_assert_not_reached() lest we end up re-using a previous descr. I guess wider re-factoring is out of scope for this series though: Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: Rust BoF and maintainer minutes and planning the roadmap to Rust

Stefan Hajnoczi writes: > On Thu, 26 Sept 2024 at 10:24, Alex Bennée wrote: >> Another potential area for conversion was the VirtIO device and >> vhost-user code which could expect to re-use a lot of the crates from >> the rust-vmm project. However this did bring up th

Re: [PATCH] testing: bump mips64el cross to bookworm and allow to fail

Thomas Huth writes: > On 23/09/2024 10.15, Alex Bennée wrote: >> The mips64el cross setup is very broken for bullseye which has now >> entered LTS support so is unlikely to be fixed. While we still can't >> build the container for bookworm due to a single missi

Rust BoF and maintainer minutes and planning the roadmap to Rust

ch would be hard to get well reviewed before switching for such a crucial sub-system. Maybe this is an ordering problem and it would make more sense to start with individual block drivers first and work up from there. Alex mentioned softfloat could make a good candidate for conversion as while the rew

[PATCH 07/10] docs/devel: update tsan build documentation

From: Pierrick Bouvier Mention it's now possible to build with gcc, instead of clang, and explain how to build a sanitized glib version. Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Message-Id: <20240910174013.141-4-pierrick.bouv...@linaro.org> Signed-off-by:

[PATCH 01/10] testing: bump mips64el cross to bookworm and allow to fail

rk it as allow_fail for the time being. Signed-off-by: Alex Bennée Cc: Michael Tokarev --- .gitlab-ci.d/container-cross.yml | 3 +++ tests/docker/dockerfiles/debian-mips64el-cross.docker | 10 -- tests/lcitool/refresh | 2 +- 3

[PATCH 10/10] tests/tcg: enable basic testing for aarch64_be-linux-user

Signed-off-by: Alex Bennée --- configure| 5 tests/tcg/aarch64_be/hello.c | 35 tests/tcg/Makefile.target| 7 +- tests/tcg/aarch64_be/Makefile.target | 17 ++ 4 files changed, 63 insertions(+),

[PATCH 04/10] MAINTAINERS: mention my testing/next tree

I put it under my name as there may be other maintainer testing trees as well. Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ffacd60f40..7ac2252303 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4114,6 +4114,7

[PATCH 05/10] meson: hide tsan related warnings

ouv...@linaro.org> Signed-off-by: Alex Bennée --- meson.build | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 10464466ff..ceee6b22c8 100644 --- a/meson.build +++ b/meson.build @@ -518,7 +518,15 @@ if get_option

[PATCH 09/10] config/targets: update aarch64_be-linux-user gdb XML list

Attempting to run the binary asserts when it can't find the XML entry. We can fix it so we don't although I suspect other stuff is broken. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2580 Signed-off-by: Alex Bennée --- configs/targets/aarch64_be-linux-user.mak | 2 +- 1 file

[PATCH 03/10] tests/docker: add NOFETCH env variable for testing

n the tests. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 681feae744..fead7d3abe 100644 --- a/tests/docker/Makefile.include +++ b/tests/d

[PATCH 02/10] tests/docker: Fix microblaze atomics

com> Signed-off-by: Alex Bennée --- .../debian-microblaze-cross.d/build-toolchain.sh | 8 tests/docker/dockerfiles/debian-toolchain.docker | 7 +++ 2 files changed, 15 insertions(+) diff --git a/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh b

[PATCH 00/10] maintainer updates (testing, gdbstub)

4_be-linux-user to assert - finally I've made the mips64el cross compiler bookworm and allow_fail Alex Bennée (6): testing: bump mips64el cross to bookworm and allow to fail tests/docker: add NOFETCH env variable for testing MAINTAINERS: mention my testing/next tree MAINTAINERS: men

[PATCH 06/10] target/i386: fix build warning (gcc-12 -fsanitize=thread)

org> Signed-off-by: Alex Bennée --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index ada581c5d6..c8056ef83d 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5771,7 +5771,7 @@ stat

[PATCH 08/10] MAINTAINERS: mention my gdbstub/next tree

Make it easy for people to see what is already queued. Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ac2252303..f34b8843e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3028,6 +3028,7 @@ F: gdb-xml/ F: tests/tcg

Re: [PATCH v3 0/3] build qemu with gcc and tsan

id > false positives related to glib synchronisation primitives. Queued to testing/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] tests/docker: Fix microblaze atomics

Ilya Leoshkevich writes: > On Tue, 2024-09-24 at 12:54 +0100, Alex Bennée wrote: >> Ilya Leoshkevich writes: >> >> (add Mahesh to CC) >> >> > GCC produces invalid code for microblaze atomics. >> > >> > The fix is unfortunately not up

Re: [PATCH v2] Add -build-info and -build-info-json CLI arguments

. Perhaps we can expose it in a > different way so that people don't end up confused? I think the problem is however much we might say it's not a capabilities discovery API it's very existence encourages users to use it as one. What about a script: qemu-get-build-info which would launch the binary and query it over QMP? Would that work? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] tests/docker: Fix microblaze atomics

\ > +DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ > +DEBIAN_FRONTEND=noninteractive eatmydata \ > +apt install -y --no-install-recommends \ > +libmpc3 > COPY --from=0 /usr/local /usr/local > # As a final step configure the user (if env is defined) > ARG USER -- Alex Bennée Virtualisation Tech Lead @ Linaro

Canceled event: QEMU/KVM developers conference call @ Tue 1 Oct 2024 14:00 - 15:00 (BST) (qemu-devel@nongnu.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDA

[PATCH] testing: bump mips64el cross to bookworm and allow to fail

rk it as allow_fail for the time being. Signed-off-by: Alex Bennée Cc: Michael Tokarev --- .gitlab-ci.d/container-cross.yml | 3 +++ tests/docker/dockerfiles/debian-mips64el-cross.docker | 10 -- tests/lcitool/refresh | 2 +- 3

Re: [PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

Brad Smith writes: > On 2024-09-21 8:55 a.m., Alex Bennée wrote: >> Brad Smith writes: >> >>> contrib/plugins: ensure build does not pick up a system copy of plugin >>> header >> I'm confused because this changes the ordering of the GLIB inclusion.

Re: [PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

gt; +PLUGIN_CFLAGS += -fPIC -Wall > > # Helper that honours V=1 so we get some output when compiling > quiet-@ = $(if $(V),,@$(if $1,printf " %-7s %s\n" "$(strip $1)" "$(strip > $2)" && )) -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL v2 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

ite memory - validate ips plugin arguments meet minimum slice value Akihiko Odaki (1): contrib/plugins: Add a plugin to generate basic block vectors Alex Bennée (9): deprecation: don't enable TCG plugins by default

Re: [PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

Peter Maydell writes: > On Thu, 19 Sept 2024 at 14:11, Alex Bennée wrote: >> >> Peter Maydell writes: >> > While I'm looking at the code, this caught my eye: >> > >> > case QEMU_PLUGIN_MEM_VALUE_U64: >> > {

Re: [PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

Peter Maydell writes: > On Wed, 18 Sept 2024 at 22:08, Alex Bennée wrote: >> >> The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: >> >> Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into >> st

[PULL 07/18] tests/tcg: allow to check output of plugins

off-by: Alex Bennée Message-Id: <20240916085400.1046925-8-alex.ben...@linaro.org> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index c5b1c7a786..2da70b2fcf 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -90,6 +90,7 @@ CFLAGS= LDFLAGS=

[PULL 14/18] util/timer: avoid deadlock when shutting down

ed-by: Elisha Hollander Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier Message-Id: <20240916085400.1046925-15-alex.ben...@linaro.org> diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 213114be68..6b1533bc2a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -685

[PULL 08/18] tests/tcg/plugins/mem: add option to print memory accesses

: Pierrick Bouvier Message-Id: <20240724194708.1843704-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-9-alex.ben...@linaro.org> diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plugins/mem.c index b650dddcce..086e6f5bdf 100644 --- a/t

[PULL 10/18] tests/tcg: clean up output of memory system test

: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-11-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index 6eb2eb16f7..8f2371975d 100644 --- a/tests/tcg/multiarch/system/memory.c +++ b/tests/tcg/mul

[PULL 06/18] tests/tcg: add mechanism to run specific tests with plugins

ed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-7-alex.ben...@linaro.org> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 452a2cde65..c5b1c7a786 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -152,10 +152,11 @@ PLUGINS=$(patsubst

[PULL 09/18] tests/tcg/multiarch: add test for plugin memory access

ing stdout, we can compare to plugins output and have a multiarch test. Can be run with: make -C build/tests/tcg/$ARCH-linux-user run-plugin-test-plugin-mem-access-with-libmem.so Tested-by: Xingtao Yao Signed-off-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240910172

[PULL 15/18] contrib/plugins: Add a plugin to generate basic block vectors

Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240816-bb-v3-1-b9aa4a5c7...@daynix.com> Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-16-alex.ben...@linaro.org> diff --git a/docs/about/emulation.rst b/docs/about/emulation.rst index 05f54d3f27..ee59c2fa9b 100644

[PULL 13/18] tests/tcg: add a system test to check memory instrumentation

d a regions worth of writes to the expected total. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier Message-Id: <20240916085400.1046925-14-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index 28080767b2..65a6038a24 100644

[PULL 11/18] tests/tcg: only read/write 64 bit words on 64 bit systems

While the compilers will generally happily synthesise a 64 bit value for you on 32 bit systems it doesn't exercise anything on QEMU. It also makes it hard to accurately compare the accesses to test_data when instrumenting. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Messa

[PULL 12/18] tests/tcg: ensure s390x-softmmu output redirected

The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Acked-by: Ilya Leoshkevich Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée

[PULL 17/18] plugins: add option to dump write argument to syscall plugin

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier Message-Id: <20240827215329.248434-3-rowanbh...@gmail.com> [AJB: tweak fmt string for vaddr] Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-18-alex.ben...@linaro.o

[PULL 01/18] deprecation: don't enable TCG plugins by default on 32 bit hosts

-by: Alex Bennée Message-Id: <20240916085400.1046925-2-alex.ben...@linaro.org> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ed31d4b0b2..809b2b9b81 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -184,6 +184,17 @@ be an effective use

[PULL 02/18] deprecation: don't enable TCG plugins by default with TCI

The softmmu memory instrumentation test sees so many more accesses than a normal translated host and its really not worth fixing up. Lets deprecate this odd configuration and save on the CI cycles. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240916085400.104692

[PULL 18/18] contrib/plugins: avoid hanging program

Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Reported-by: Elisha Hollander Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier Message-Id

[PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

- validate ips plugin arguments meet minimum slice value Akihiko Odaki (1): contrib/plugins: Add a plugin to generate basic block vectors Alex Bennée (9): deprecation: don't enable TCG plugins by default

[PULL 05/18] plugins: extend API to get latest memory value accessed

://gitlab.com/qemu-project/qemu/-/issues/2152 Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-6

[PULL 03/18] contrib/plugins: control flow plugin

This is a simple control flow tracking plugin that uses the latest inline and conditional operations to detect and track control flow changes. It is currently an exercise at seeing how useful the changes are. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id

[PULL 04/18] plugins: save value during memory accesses

iewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-5-alex.ben...@linaro.org> diff --git a/accel/tcg/atomic_te

[PULL 16/18] plugins: add plugin API to read guest memory

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-17-alex.ben...@linaro.org> diff --git a/inclu

Canceled event with note: QEMU/KVM developers conference call @ Tue 17 Sept 2024 14:00 - 15:00 (BST) (qemu-devel@nongnu.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDA

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

Brian Cain writes: > On 9/16/2024 8:12 AM, Alex Bennée wrote: >> Brian Cain writes: >> >>> On 9/6/2024 9:39 PM, Brian Cain wrote: >>>> With newer clang builds (19.x), there's a warning for implicit function >>>> declarations and it r

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

t;> +++ b/tests/tcg/multiarch/linux/linux-test.c >> @@ -17,6 +17,7 @@ >>* along with this program; if not, see <http://www.gnu.org/licenses/>. >>*/ >> #define _GNU_SOURCE >> +#define _LARGEFILE64_SOURCE >> #include >> #include >

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

t;> +++ b/tests/tcg/multiarch/linux/linux-test.c >> @@ -17,6 +17,7 @@ >>* along with this program; if not, see <http://www.gnu.org/licenses/>. >>*/ >> #define _GNU_SOURCE >> +#define _LARGEFILE64_SOURCE >> #include >> #include >>

[PATCH v2 16/18] plugins: add plugin API to read guest memory

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée --- vAJB: - explicit bool for cpu_memory_rw_debug v2 - fix alignment --- includ

[PATCH v2 17/18] plugins: add option to dump write argument to syscall plugin

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier Message-Id: <20240827215329.248434-3-rowanbh...@gmail.com> [AJB: tweak fmt string for vaddr] Signed-off-by: Alex Bennée --- vAJB - tweak fmt string for PRIu64 v2 - add sta

[PATCH v2 15/18] contrib/plugins: Add a plugin to generate basic block vectors

Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240816-bb-v3-1-b9aa4a5c7...@daynix.com> Signed-off-by: Alex Bennée --- docs/about/emulation.rst | 30 contrib/plugins/bbv.c| 158 +++ contrib/plugins/Makefile | 1 + 3 files changed, 189

[PATCH v2 18/18] contrib/plugins: avoid hanging program

Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Signed-off-by: Alex Bennée Reported-by: Elisha Hollander Reviewed-by: Richard Henderson --- contrib/plugins/ips.c | 5 + 1 file

[PATCH v2 09/18] tests/tcg/multiarch: add test for plugin memory access

From: Pierrick Bouvier Add an explicit test to check expected memory values are read/written. 8,16,32 load/store are tested for all arch. 64,128 load/store are tested for aarch64/x64. atomic operations (8,16,32,64) are tested for x64 only. By default, atomic accesses are non atomic if a single c

[PATCH v2 14/18] util/timer: avoid deadlock when shutting down

d-off-by: Alex Bennée Reported-by: Elisha Hollander --- util/qemu-timer.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 213114be68..6b1533bc2a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -685,10 +6

[PATCH v2 10/18] tests/tcg: clean up output of memory system test

: <20240910140733.4007719-20-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 47 ++--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tes

[PATCH v2 12/18] tests/tcg: ensure s390x-softmmu output redirected

The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée --- v2 - don't remove EXTFLAGS, add comment ---

[PATCH v2 13/18] tests/tcg: add a system test to check memory instrumentation

d a regions worth of writes to the expected total. Signed-off-by: Alex Bennée --- v2 - aggressively align test_data on "region size" - sort the regions in the final report - ensure alpha-softmmu uses byte access when it can v3 - fix thinko while iterating through the regions - fix

[PATCH v2 11/18] tests/tcg: only read/write 64 bit words on 64 bit systems

Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- v2 - >= test of __SIZEOF_POINTER__ --- tests/tcg/multiarch/system/memory.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/mu

[PATCH v2 04/18] plugins: save value during memory accesses

iewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 66 ++- include/hw/core/cpu.h | 4 +++

[PATCH v2 06/18] tests/tcg: add mechanism to run specific tests with plugins

ed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 452a2cde65..c5b1c7a786 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -152,10 +

[PATCH v2 02/18] deprecation: don't enable TCG plugins by default with TCI

ouvier Signed-off-by: Alex Bennée --- docs/about/deprecated.rst | 8 configure | 11 +-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index f7c7c33d39..5aa2e35314 100644 --- a/docs/about/deprecat

[PATCH v2 05/18] plugins: extend API to get latest memory value accessed

://gitlab.com/qemu-project/qemu/-/issues/2152 Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h

[PATCH v2 07/18] tests/tcg: allow to check output of plugins

off-by: Alex Bennée --- tests/tcg/Makefile.target | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index c5b1c7a786..2da70b2fcf 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -90,6 +90,7 @@ CFLAGS= L

[PATCH v2 03/18] contrib/plugins: control flow plugin

ben...@linaro.org> Based-on: <20240312075428.244210-1-pierrick.bouv...@linaro.org> Cc: Gustavo Romero Signed-off-by: Alex Bennée --- v2 - only need a single call back - drop need for INSN_WIDTH - still don't understand the early exits v3 - move initial STORE ops to first ins

[PATCH v2 00/18] tcg plugins pre-PR (deprecations, mem apis, contrib plugins)

/multiarch: add test for plugin memory access (0 acks, 1 sobs, 1 tbs) v2 - fix some nits - included fix to ips posted as an RFC before Alex. Akihiko Odaki (1): contrib/plugins: Add a plugin to generate basic block vectors Alex Bennée (9): deprecation: don't enable TCG plugins by default

[PATCH v2 01/18] deprecation: don't enable TCG plugins by default on 32 bit hosts

-12-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- v2 - don't manually set based on CPU type, use __SIZEOF_POINTER__ --- docs/about/deprecated.rst | 11 +++ configure | 21 - 2 files changed, 31 inser

[PATCH v2 08/18] tests/tcg/plugins/mem: add option to print memory accesses

: Pierrick Bouvier Message-Id: <20240724194708.1843704-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/mem.c | 69 - 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plu

Re: [PATCH 11/17] tests/tcg: only read/write 64 bit words on 64 bit systems

Philippe Mathieu-Daudé writes: > On 13/9/24 19:26, Alex Bennée wrote: >> While the compilers will generally happily synthesise a 64 bit value >> for you on 32 bit systems it doesn't exercise anything on QEMU. It >> also makes it hard to accurately compare the acc

Re: [PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected

Thomas Huth writes: > On 13/09/2024 19.26, Alex Bennée wrote: >> The multiarch system tests output serial data which should be >> redirected to the "output" chardev rather than echoed to the console. >> Remove the unused EXTFLAGS variable while we are at it

[RFC PATCH] contrib/plugins: avoid hanging program

Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Signed-off-by: Alex Bennée Reported-by: Elisha Hollander --- contrib/plugins/ips.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 15/17] contrib/plugins: Add a plugin to generate basic block vectors

Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240816-bb-v3-1-b9aa4a5c7...@daynix.com> Signed-off-by: Alex Bennée --- docs/about/emulation.rst | 30 contrib/plugins/bbv.c| 158 +++ contrib/plugins/Makefile | 1 + 3 files changed, 189

[PATCH 17/17] plugins: add option to dump write argument to syscall plugin

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier Message-Id: <20240827215329.248434-3-rowanbh...@gmail.com> [AJB: tweak fmt string for vaddr] Signed-off-by: Alex Bennée --- vAJB - tweak fmt string for PRIu64 --- docs/about/emulati

[PATCH 16/17] plugins: add plugin API to read guest memory

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée --- vAJB: - explicit bool for cpu_memory_rw_debug --- include/qemu/qemu-plugin.h

[PATCH 02/17] deprecation: don't enable TCG plugins by default with TCI

ouvier Signed-off-by: Alex Bennée --- docs/about/deprecated.rst | 8 configure | 11 +-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index f7c7c33d39..5aa2e35314 100644 --- a/docs/about/deprecat

[PATCH 13/17] tests/tcg: add a system test to check memory instrumentation

d a regions worth of writes to the expected total. Signed-off-by: Alex Bennée --- v2 - aggressively align test_data on "region size" - sort the regions in the final report - ensure alpha-softmmu uses byte access when it can v3 - fix thinko while iterating through the regions - fix

[PATCH 10/17] tests/tcg: clean up output of memory system test

: <20240910140733.4007719-20-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 47 ++--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tes

[PATCH 01/17] deprecation: don't enable TCG plugins by default on 32 bit hosts

-12-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- v2 - don't manually set based on CPU type, use __SIZEOF_POINTER__ --- docs/about/deprecated.rst | 11 +++ configure | 21 - 2 files changed, 31 inser

[PATCH 14/17] util/timer: avoid deadlock when shutting down

d-off-by: Alex Bennée Reported-by: Elisha Hollander --- util/qemu-timer.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 213114be68..6b1533bc2a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -685,10 +6

[PATCH 03/17] contrib/plugins: control flow plugin

ben...@linaro.org> Based-on: <20240312075428.244210-1-pierrick.bouv...@linaro.org> Cc: Gustavo Romero Signed-off-by: Alex Bennée --- v2 - only need a single call back - drop need for INSN_WIDTH - still don't understand the early exits v3 - move initial STORE ops to first ins

[PATCH 07/17] tests/tcg: allow to check output of plugins

off-by: Alex Bennée --- tests/tcg/Makefile.target | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index c5b1c7a786..2da70b2fcf 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -90,6 +90,7 @@ CFLAGS= L

[PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected

The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Remove the unused EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée --- tests/tcg/s390x/Makefile.softmmu-target | 2 +- 1 file changed, 1

[PATCH 11/17] tests/tcg: only read/write 64 bit words on 64 bit systems

Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index 8f2371975d..680dd4

[PATCH 09/17] tests/tcg/multiarch: add test for plugin memory access

From: Pierrick Bouvier Add an explicit test to check expected memory values are read/written. 8,16,32 load/store are tested for all arch. 64,128 load/store are tested for aarch64/x64. atomic operations (8,16,32,64) are tested for x64 only. By default, atomic accesses are non atomic if a single c

[PATCH 04/17] plugins: save value during memory accesses

iewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 66 ++- include/hw/core/cpu.h | 4 +++

[PATCH 05/17] plugins: extend API to get latest memory value accessed

://gitlab.com/qemu-project/qemu/-/issues/2152 Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h

[PATCH 08/17] tests/tcg/plugins/mem: add option to print memory accesses

: Pierrick Bouvier Message-Id: <20240724194708.1843704-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/mem.c | 69 - 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plu

  1   2   3   4   5   6   7   8   9   10   >