On Mittwoch, 9. März 2022 15:49:04 CET Christian Schoenebeck wrote:
> Extend previously added fs_walk_none() test by comparing the QID
> of the root fid with the QID of the cloned fid. They should be
> equal.
>
> Signed-off-by: Christian Schoenebeck
> ---
> tests/qtest/
On Mittwoch, 9. März 2022 14:24:24 CET Christian Schoenebeck wrote:
> Send Twalk request with nwname=0. In this case no QIDs should
> be returned by 9p server; this is equivalent to walking to dot.
>
> Signed-off-by: Christian Schoenebeck
> ---
> tests/qtest/vir
read.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index a6d6b3f835..6cdc566866 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -1764,7 +1764,7 @@ static bool same_stat_id(const s
already existing variable 'err' only reflects
the last error.
Despite QIDs being delivered to client in a more relaxed way now, it is
important to note though that fid still must remain uneffacted if any error
occurred.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 29 ++
Extend previously added fs_walk_none() test by comparing the QID
of the root fid with the QID of the cloned fid. They should be
equal.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 70
1 file changed, 70 insertions(+)
diff --git a
Send Twalk request with nwname=0. In this case no QIDs should
be returned by 9p server; this is equivalent to walking to dot.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/tests/qtest/virtio-9p
he 1st path component
is valid, whereas the 2nd path component transmitted to server does not
exist. The expected behaviour is that 9p server would respond by sending
a 'Rwalk' response with exactly 1 QID (instead of 'Rlerror' response).
Signed-off-by: Christian S
Expect ENOENT Rlerror response when trying to walk to a
non-existent directory.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
ke patch 5 better
readable.
All the other patches are just additional test cases for guarding 'Twalk'
behaviour.
Christian Schoenebeck (6):
tests/9pfs: walk to non-existent dir
tests/9pfs: Twalk with nwname=0
tests/9pfs: compare QIDs in fs_walk_none() test
9pfs: refactor '
out having a co-maintained section, including
> technical expertise from Akihiko / Joelle / Christian? (Cc'ed)
>
> Regards,
Also CCing Cameron on this, just in case someone at Apple could spend some
slices on QEMU macOS patches in general as well.
As for my part: I try to help out more on the macOS front. As there's now
macOS host support for 9p I have to start QEMU testing on macOS locally
anyway. Too bad that macOS CI tests on Github are no longer available BTW.
Best regards,
Christian Schoenebeck
wco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Peter Maydell
Message-Id:
---
hw/9pfs/9p-util.h| 30 ++
include/qemu/osdep.h | 13 -
util/osdep.c | 21 -
3 files changed, 30 insertions(+), 34 del
]
Signed-off-by: Will Cohen
Reviewed-by: Greg Kurz
Message-Id: <20220227223522.91937-11-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/vir
API doc comments in QEMU are supposed to be in kerneldoc format, so drop
occurrences of "@c" which is Doxygen format for fixed-width text.
Link:
https://lore.kernel.org/qemu-devel/cafeaca89+enom6x19oef53kd2dwkhn5sn21va0d7yepjsa3...@mail.gmail.com/
Based-on:
Signed-off-by: Christian S
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Based-on:
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<2b8f91de7bac3d3bc85d60eb08830a35a394be75.1646314856.git.qe
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
hw/9pfs/9p-util.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions
937-12-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Acked-by: Christian Schoenebeck
---
fsdev/meson.build | 1 +
meson.build | 12 +++-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/fsdev/meson.build b/fsdev/meson.build
index adf57cc43e..b632b66348
API doc comments in QEMU are supposed to be in kerneldoc format, so
drop Doxygen format used on v9fs_co_run_in_worker() macro.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
hw/9pfs/coth.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw
apply cleanly on top of the 2022-02-10
changes to 9pfs
- Fix line over 90 characters formatting error]
Signed-off-by: Will Cohen
Message-Id: <20220227223522.91937-10-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
h
Message-Id: <20220227223522.91937-9-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Acked-by: Christian Schoenebeck
---
hw/9pfs/9p-local.c | 12
hw/9pfs/9p-util.h | 17 +
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/hw/9pfs/9p-local.
rt for Darwin (a.k.a. macOS) hosts.
* Code cleanup (move qemu_dirent_dup() from osdep -> 9p-util).
* API doc cleanup (convert Doxygen -> kerneldoc format).
v1 -> v2:
- Fix compiler warning "unused label &#x
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<4ece6ffa4465c271c6a7c42a3040f42780fcce87.1646314856.git.qemu_...@crudebyte.com>
-
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
hw/9pfs/codir.c | 30 +++---
1 file changed, 15 insertions
ot;. ]
Link: https://lore.kernel.org/qemu-devel/11201492.CjeqJxXfGd@silver/
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
hw/9pfs/9p-util.h | 4
hw/9pfs/9p.c | 13 -
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/hw/9pfs/9p-ut
: <20220227223522.91937-4-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
hw/9pfs/9p-proxy.c | 22 --
hw/9pfs/9p-synth.c | 2 ++
hw/9pfs/9p.c | 16 ++--
3 files changed, 36 insertions(+), 4 deletions(-)
diff --gi
this patch series]
Signed-off-by: Will Cohen
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Greg Kurz
Message-Id: <20220227223522.91937-2-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
---
fsdev/file-op-9p.h | 9 -
hw/9pfs/9p-local.c | 2 ++
hw/9pfs/9p.c | 4 ++
]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
Reviewed-by: Greg Kurz
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20220227223522.91937-3-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/{9p-util.c => 9p-util-linux.c} | 2 +-
hw/9pfs/me
Message-Id: <20220227223522.91937-8-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Acked-by: Christian Schoenebeck
---
hw/9pfs/9p-util-darwin.c | 64
hw/9pfs/meson.build | 1 +
2 files changed, 65 insertions(+)
create mode 100644 hw/9
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<2e2d46a402560f155de322d95789ba107d728885.1646314856.git.qemu_...@crudebyte.
: <20220227223522.91937-5-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
hw/9pfs/9p-local.c | 9 +
hw/9pfs/9p-proxy.c | 16 +++-
hw/9pfs/9p-synth.c | 4
hw/9pfs/9p-util.h | 16
hw/9pfs/9p.c | 7 +--
h
error
out for undefined hosts]
Signed-off-by: Will Cohen
Message-Id: <20220227223522.91937-7-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 2 +-
hw/9pfs/9p.h | 18 ++
2 files changed, 19 inse
On Sonntag, 6. März 2022 21:59:55 CET Will Cohen wrote:
> On Fri, Mar 4, 2022 at 4:31 PM Will Cohen wrote:
> > On Fri, Mar 4, 2022 at 3:16 PM Christian Schoenebeck <
> >
> > qemu_...@crudebyte.com> wrote:
> >> On Freitag, 4. März 2022 19:42:18 CET Peter Mayd
On Sonntag, 6. März 2022 11:54:00 CET Akihiko Odaki wrote:
> On 2022/03/06 19:49, Christian Schoenebeck wrote:
> > On Sonntag, 6. März 2022 07:39:49 CET Akihiko Odaki wrote:
> >> MacOSX.sdk/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHar
> >> dwa re.h
), or is this a user
visible improvement, i.e. does it fix a misbehaviour? In case of the latter,
which misbehaviour did you encounter?
Best regards,
Christian Schoenebeck
>
> Signed-off-by: Akihiko Odaki
> ---
> audio/coreaudio.c | 6 ++
> 1 file changed, 2 insertions(+
On Freitag, 4. März 2022 19:42:18 CET Peter Maydell wrote:
> On Fri, 4 Mar 2022 at 12:32, Christian Schoenebeck
>
> wrote:
> > The following changes since commit
5959ef7d431ffd02db112209cf55e47b677256fd:
> > Merge remote-tracking branch
> > 'remotes/a
error
out for undefined hosts]
Signed-off-by: Will Cohen
Message-Id: <20220227223522.91937-7-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 2 +-
hw/9pfs/9p.h | 18 ++
2 files changed, 19 inse
: <20220227223522.91937-4-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
hw/9pfs/9p-proxy.c | 22 --
hw/9pfs/9p-synth.c | 2 ++
hw/9pfs/9p.c | 16 ++--
3 files changed, 36 insertions(+), 4 deletions(-)
diff --gi
wco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Peter Maydell
Message-Id:
---
hw/9pfs/9p-util.h| 30 ++
include/qemu/osdep.h | 13 -
util/osdep.c | 21 -
3 files changed, 30 insertions(+), 34 del
]
Signed-off-by: Will Cohen
Reviewed-by: Greg Kurz
Message-Id: <20220227223522.91937-11-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/vir
er.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen
Message-Id: <20220227223522.91937-6-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoene
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Based-on:
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<2b8f91de7bac3d3bc85d60eb08830a35a394be75.1646314856.git.qe
]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
Reviewed-by: Greg Kurz
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20220227223522.91937-3-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/{9p-util.c => 9p-util-linux.c} | 2 +-
hw/9pfs/me
* Add support for Darwin (a.k.a. macOS) hosts.
* Code cleanup (move qemu_dirent_dup() from osdep -> 9p-util).
* API doc cleanup (convert Doxygen -> kerneldoc format).
----
Christian Schoenebeck (8):
9pfs: move qemu_dirent_dup
apply cleanly on top of the 2022-02-10
changes to 9pfs
- Fix line over 90 characters formatting error]
Signed-off-by: Will Cohen
Message-Id: <20220227223522.91937-10-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
h
: <20220227223522.91937-5-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
---
hw/9pfs/9p-local.c | 9 +
hw/9pfs/9p-proxy.c | 16 +++-
hw/9pfs/9p-synth.c | 4
hw/9pfs/9p-util.h | 16
hw/9pfs/9p.c | 7 +--
h
API doc comments in QEMU are supposed to be in kerneldoc format, so
drop Doxygen format used on v9fs_co_run_in_worker() macro.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
hw/9pfs/coth.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw
Message-Id: <20220227223522.91937-9-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Acked-by: Christian Schoenebeck
---
hw/9pfs/9p-local.c | 12
hw/9pfs/9p-util.h | 17 +
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/hw/9pfs/9p-local.
937-12-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Acked-by: Christian Schoenebeck
---
fsdev/meson.build | 1 +
meson.build | 12 +++-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/fsdev/meson.build b/fsdev/meson.build
index adf57cc43e..b632b66348
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<4ece6ffa4465c271c6a7c42a3040f42780fcce87.1646314856.git.qemu_...@crudebyte.com>
-
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<2e2d46a402560f155de322d95789ba107d728885.1646314856.git.qemu_...@crudebyte.
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
hw/9pfs/9p-util.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions
this patch series]
Signed-off-by: Will Cohen
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Greg Kurz
Message-Id: <20220227223522.91937-2-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
---
fsdev/file-op-9p.h | 9 -
hw/9pfs/9p-local.c | 2 ++
hw/9pfs/9p.c | 4 ++
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
hw/9pfs/codir.c | 30 +++---
1 file changed, 15 insertions
Message-Id: <20220227223522.91937-8-wwco...@gmail.com>
Signed-off-by: Christian Schoenebeck
Acked-by: Christian Schoenebeck
---
hw/9pfs/9p-util-darwin.c | 64
hw/9pfs/meson.build | 1 +
2 files changed, 65 insertions(+)
create mode 100644 hw/9
API doc comments in QEMU are supposed to be in kerneldoc format, so drop
occurrences of "@c" which is Doxygen format for fixed-width text.
Link:
https://lore.kernel.org/qemu-devel/cafeaca89+enom6x19oef53kd2dwkhn5sn21va0d7yepjsa3...@mail.gmail.com/
Based-on:
Signed-off-by: Christian S
On Freitag, 4. März 2022 08:39:36 CET Greg Kurz wrote:
> On Thu, 3 Mar 2022 14:40:56 +0100
>
> Christian Schoenebeck wrote:
> > This patch set converts occurrences of API doc comments from Doxygen
> > format
> > into kerneldoc format. No behaviour change wha
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
---
fsdev/p9array.h | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff
This patch set converts occurrences of API doc comments from Doxygen format
into kerneldoc format. No behaviour change whatsoever.
Christian Schoenebeck (6):
9pfs/9p.h: convert Doxygen -> kerneldoc format
9pfs/codir.c: convert Doxygen -> kerneldoc format
9pfs/9p.c: convert D
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 62 +---
1 file changed, 35 insertions(+), 27 deletions
API doc comments in QEMU are supposed to be in kerneldoc format, so
drop Doxygen format used on v9fs_co_run_in_worker() macro.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/coth.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/9pfs/coth.h b/hw/9pfs/coth.h
index
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Based-on:
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/9pfs/9p.h b
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/codir.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/hw
API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p-util.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/9pfs/9p-util.h b/hw
On Mittwoch, 2. März 2022 19:30:39 CET Christian Schoenebeck wrote:
> API doc comments in QEMU are supposed to be in kerneldoc format, so drop
> occurrences of "@c" which is Doxygen format for fixed-width text.
>
> Link:
> https://lore.kernel
On Dienstag, 1. März 2022 21:33:49 CET Christian Schoenebeck wrote:
> Function qemu_dirent_dup() is currently only used by 9pfs server, so move
> it from project global header osdep.h to 9pfs specific header 9p-util.h.
>
> Link:
> https://lore.kernel.org/qemu
On Donnerstag, 3. März 2022 10:53:32 CET Greg Kurz wrote:
> On Wed, 2 Mar 2022 19:30:39 +0100
>
> Christian Schoenebeck wrote:
> > API doc comments in QEMU are supposed to be in kerneldoc format, so drop
> > occurrences of "@c" which is Doxygen format for
API doc comments in QEMU are supposed to be in kerneldoc format, so drop
occurrences of "@c" which is Doxygen format for fixed-width text.
Link:
https://lore.kernel.org/qemu-devel/cafeaca89+enom6x19oef53kd2dwkhn5sn21va0d7yepjsa3...@mail.gmail.com/
Based-on:
Signed-off-by: Christian S
On Dienstag, 1. März 2022 21:09:27 CET Will Cohen wrote:
> On Tue, Mar 1, 2022 at 2:25 PM Christian Schoenebeck
>
> wrote:
> > On Sonntag, 27. Februar 2022 23:35:11 CET Will Cohen wrote:
> > > This is a followup to
> > > https://lists.gnu.org/archive/html
data for a longer period of time as with a smaller buffer
> and more audio data in the mixing engine buffer that they can't
> access.
>
> Signed-off-by: Volker Rümelin
> ---
I actually reviewed this patch already, but OK, then a 2nd time:
Reviewed-by: Christian Schoenebeck
Be
On Dienstag, 1. März 2022 22:59:43 CET Peter Maydell wrote:
> On Tue, 1 Mar 2022 at 20:47, Christian Schoenebeck
>
> wrote:
> > Function qemu_dirent_dup() is currently only used by 9pfs server, so move
> > it from project global header osdep.h to 9pfs specific header 9p-
wco...@gmail.com>
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p-util.h| 30 ++
include/qemu/osdep.h | 13 -
util/osdep.c | 21 -
3 files changed, 30 insertions(+), 34 deletions(-)
diff --git a/hw/9pfs/9p-util.h b/hw/9
d, 292 insertions(+), 26 deletions(-)
> create mode 100644 hw/9pfs/9p-util-darwin.c
> rename hw/9pfs/{9p-util.c => 9p-util-linux.c} (90%)
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck
On Montag, 28. Februar 2022 15:06:07 CET Peter Maydell wrote:
> On Mon, 28 Feb 2022 at 13:58, Christian Schoenebeck
>
> wrote:
> > On Montag, 28. Februar 2022 14:36:30 CET Thomas Huth wrote:
> > > For lines less than 90 characters, it's just a warning, and I thin
On Montag, 28. Februar 2022 14:36:30 CET Thomas Huth wrote:
> On 28/02/2022 14.20, Christian Schoenebeck wrote:
> > On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote:
> >> From: Keno Fischer
> >>
> >> Darwin does not support mknodat. However, to a
version
> of macOS");
You took the code style error message a bit too literal; this line is still
too long:
WARNING: line over 80 characters
#199: FILE: hw/9pfs/9p-util-darwin.c:81:
+error_report_once("pthread_fchdir_np() not available on this version
of macOS");
t
to master]
> Signed-off-by: Will Cohen
> Reviewed-by: Paolo Bonzini
Paolo, could you have a look at this patch, please? It has changed quite a bit
since your review.
Best regards,
Christian Schoenebeck
> [Will Cohen: - Add check for pthread_fchdir_np to virtfs
> - Add
On Samstag, 26. Februar 2022 11:18:44 CET Akihiko Odaki wrote:
> On 2022/02/26 19:16, Christian Schoenebeck wrote:
> > On Samstag, 26. Februar 2022 11:02:48 CET Akihiko Odaki wrote:
> >> Signed-off-by: Akihiko Odaki
> >> ---
> >>
> >> audi
t; +return -1;
> }
>
> return 0;
Is this a pure theoretical fix, or does it actually fix an actually
encountered misbehaviour? I don't see any explanation in the commit log. I
mean the branch here is about removing a listener only.
Best regards,
Christian Schoenebeck
On Freitag, 25. Februar 2022 17:38:51 CET Will Cohen wrote:
> On Fri, Feb 25, 2022 at 11:31 AM Christian Schoenebeck <
>
> qemu_...@crudebyte.com> wrote:
> > On Freitag, 25. Februar 2022 15:00:40 CET Will Cohen wrote:
> > > On Tue, Feb 22, 2022 at 9:27 AM Christian S
On Freitag, 25. Februar 2022 15:00:40 CET Will Cohen wrote:
> On Tue, Feb 22, 2022 at 9:27 AM Christian Schoenebeck <
>
> qemu_...@crudebyte.com> wrote:
> > On Sonntag, 20. Februar 2022 17:50:54 CET Will Cohen wrote:
> > > From: Keno Fischer
> > >
> &g
On Sonntag, 20. Februar 2022 17:50:54 CET Will Cohen wrote:
> From: Keno Fischer
>
> Darwin does not support mknodat. However, to avoid race conditions
> with later setting the permissions, we must avoid using mknod on
> the full path instead. We could try to fchdir, but that would cause
> proble
On Dienstag, 22. Februar 2022 14:21:52 CET Peter Maydell wrote:
> On Thu, 17 Feb 2022 at 16:43, Christian Schoenebeck
>
> wrote:
> > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> > index d1660d67fa..ce12f64853 100644
> > --- a/include/qemu/osdep.h
>
d with Apple for implementing mknodat:
> + * rdar://FB9862426 (https://openradar.appspot.com/FB9862426)
> + */
> +#if defined CONFIG_DARWIN && defined CONFIG_PTHREAD_FCHDIR_NP
> +
> +int qemu_mknodat(int dirfd, const char *filename, mode_t mode, dev_t dev)
> +{
> +
low(int dirfd, const char
> *filename, const char *name);
>
> #endif
... ^- this is the end of file #endif, so qemu_dirent_off() should be above
that #endif, and ...
> +
> +
> +/**
> + * Darwin has d_seekoff, which appears to function similarly to d_off.
> + * However, it d
e it completely to app developers how their app menus looks like exactly,
instead of Apple injecting something there without being asked.
There are much bigger oddities in macOS's menu design than that IMO.
Best regards,
Christian Schoenebeck
something.
Will, one more thing though: I just sent a PR with one particular patch that I
would ask you to test in conjunction with this series:
https://github.com/cschoenebeck/qemu/commit/e64e27d5cb103b7764f1a05b6eda7e7fedd517c5
You might simply wait for the PR being merged (maybe monday?) and then rebase
this series to master and test if this patch is not breaking anything for
macOS. Theoretically the new qemu_dirent_dup() function should fallback on
macOS to its portable branch, but it should be tested before merging this
series, just to be sure.
Best regards,
Christian Schoenebeck
x27; tests.
* Tests: Third patch fixes a memory leak.
* Tests: The remaining two patches are code cleanup.
----
Christian Schoenebeck (2):
tests/9pfs: use g_autofree where possible
tests/9pfs: fix mkdir() being called
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
tests/qtest/virtio-9p-test.c | 90 +++-
1 file changed, 27 insertions(+), 63 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 41fed41de1
:
Signed-off-by: Greg Kurz
Message-Id: <20220201151508.190035-2-gr...@kaod.org>
Reviewed-by: Christian Schoenebeck
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/virtio-9p.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/
From: Greg Kurz
It is recommended to use g_autofree or g_autoptr as it reduces
the odds of introducing memory leaks in future changes.
Signed-off-by: Greg Kurz
Message-Id: <20220201151508.190035-3-gr...@kaod.org>
Reviewed-by: Christian Schoenebeck
Signed-off-by: Christian Schoe
me systems.
Signed-off-by: Christian Schoenebeck
Fixes: 136b7af2 (tests/9pfs: fix test dir for parallel tests)
Reported-by: Daniel P. Berrangé
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/832
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Greg Kurz
Message-Id:
---
tests/qtest/libqos/virtio
t' cloning.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
Cc: qemu-sta...@nongnu.org
Co-authored-by: Christian Schoenebeck
Reviewed-by: Dmitry V. Levin
Signed-off-by: Vitaly Chikunov
Tested-by: Christian Schoenebeck
Reviewed-by: Christian Schoenebeck
Acked-by: Greg Kurz
Te
/a +
> 0x0)
>
> While fixing this, provide a helper for any future `struct dirent' cloning.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
> Cc: qemu-sta...@nongnu.org
> Co-authored-by: Christian Schoenebeck
> Reviewed-by: Dmitry V. Levin
&g
/a +
> 0x0)
>
> While fixing this, provide a helper for any future `struct dirent' cloning.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
> Cc: qemu-sta...@nongnu.org
> Co-authored-by: Christian Schoenebeck
> Reviewed-by: Dmitry V. Levin
> Signed-
On Mittwoch, 16. Februar 2022 17:09:56 CET Vitaly Chikunov wrote:
> Christian,
>
> On Wed, Feb 16, 2022 at 11:30:12AM +0100, Christian Schoenebeck wrote:
> > On Dienstag, 15. Februar 2022 08:01:37 CET Greg Kurz wrote:
> > > On Mon, 14 Feb 2022 17:43:51 +0300
> > &
l send one this
evening to bring this issue forward, because it is blocking my queue.
Best regards,
Christian Schoenebeck
that should be prepared for this patch set to hopefully be able
> to target 7.0?
>
> Will
That's in three weeks. I'm optimistic that we get this merged before the QEMU
7.0 soft freeze deadline.
Best regards,
Christian Schoenebeck
On Dienstag, 15. Februar 2022 14:45:00 CET Peter Maydell wrote:
> On Tue, 15 Feb 2022 at 13:18, Christian Schoenebeck
>
> wrote:
> > On Dienstag, 15. Februar 2022 13:06:25 CET Philippe Mathieu-Daudé via
wrote:
> > > We globally ignore the 'initializer overrides&#x
eC/WorkingwithBlocks/WorkingwithBlocks.html
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
We already had a similar discussion before [1] whether to use .c and add
required compiler flags or using .m. I find this solution more appropriate.
Reviewed-by: Christian Schoenebeck
[1]
See also:
https://stackoverflow.com/questions/40920714/is-full-followed-by-partial-initialization-of-a-subobject-undefined-behavior
So I have my doubts whether this warning suppression should be used in QEMU at
all.
Best regards,
Christian Schoenebeck
On Montag, 14. Februar 2022 15:43:51 CET Vitaly Chikunov wrote:
> Christian,
>
> On Mon, Feb 14, 2022 at 12:44:48PM +0100, Christian Schoenebeck wrote:
> > On Montag, 14. Februar 2022 11:36:53 CET Greg Kurz wrote:
> > > The synth backend should be fixed to honor d_recl
401 - 500 of 1006 matches
Mail list logo
