Arguments `ram_block` are reassigned to local declarations `block`
without further use. Remove re-assignment to reduce noise.
Signed-off-by: Manos Pitsidianakis
---
system/physmem.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/system/physmem.c b/system/physmem.c
utput_format() and use it in the code
>(this one has been sent in a separate patch, here it is just for
> completness)
> qemu-img: refresh options/--help for "check" command
> qemu-img: simplify --repair error message
> qemu-img: refresh options/--help for "commi
s->host_features);
virtio_init(vdev, VIRTIO_ID_BLOCK, s->config_size);
--
2.43.0
virtio_block_ops and methods are moved around without changes in the
diff, is that on purpose? If no the patch and history would be less
noisy.
Regardless:
Reviewed-by: Manos Pitsidianakis
tine_yield();
+aio_co_reschedule_self(iohandler_get_aio_context());
}
} else {
/*
--
2.43.0
Reviewed-by: Manos Pitsidianakis
ring ->realize() */
r = blk_set_aio_context(s->conf.conf.blk, s->vq_aio_context[0],
&local_err);
if (r < 0) {
--
2.43.0
Reviewed-by: Manos Pitsidianakis
static void virtio_blk_dma_restart_cb(void *opaque, bool
running,
VirtIOBlockReq *next = rq->next;
uint16_t idx = virtio_get_queue_index(rq->vq);
+assert(idx < num_queues);
rq->next = vq_rq[idx];
vq_rq[idx] = rq;
rq = next;
--
2.43
struct VirtIOBlockReq *rq; /* protected by rq_lock */
VirtIOBlkConf conf;
unsigned short sector_mask;
bool original_wce;
--
2.43.0
Reviewed-by: Manos Pitsidianakis
Good morning Alex,
Just one observation,
On Sun, 04 Feb 2024 13:06, Alex Bennée wrote:
Hi,
I'm trying to get an understanding of the blob allocation and mapping
flow for virtio-gpu for Vulkan and Rutabaga. Having gotten all the
various libraries setup I'm still seeing failures when running a
ted with that resource_id is then leaked.
This commit overrides the resource_destroy class method introduced in
the previous commit to fix this.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu-rutabaga.c | 47
1 file changed, 35 insertions(+), 12 d
: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
include/hw/virtio/virtio-gpu.h | 3 +++
hw/display/virtio-gpu.c| 25 ++---
2 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index
logic for implementations in the future.
Reviewed-by: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index f8a675eb30..2b73ae585b 100644
---
rences:
- addressed review comments re: using the Error API for the
resource_destroy method.
Manos Pitsidianakis (3):
hw/display/virtio-gpu.c: use reset_bh class method
virtio-gpu.c: add resource_destroy class method
virtio-gpu-rutabaga.c: override resource_destroy method
include/hw/virtio/virtio
On Tue, 30 Jan 2024 at 15:10, Marc-André Lureau
wrote:
>
> Hi
>
> On Tue, Jan 30, 2024 at 5:01 PM Manos Pitsidianakis
> wrote:
> >
> > On Tue, 30 Jan 2024 at 14:50, Marc-André Lureau
> > wrote:
> > >
> > > Hi
> > >
> >
On Tue, 30 Jan 2024 at 14:50, Marc-André Lureau
wrote:
>
> Hi
>
> On Mon, Jan 29, 2024 at 7:46 PM Manos Pitsidianakis
> wrote:
> >
> > When the Rutabaga GPU device frees resources, it calls
> > rutabaga_resource_unref for that resource_id. However, when th
On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote:
>
> On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis
> wrote:
> >
> > On Tue, 30 Jan 2024 at 12:42, Peter Maydell
> > wrote:
> > >
> > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis
> >
On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote:
>
> On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis
> wrote:
> >
> > On Tue, 30 Jan 2024 at 12:34, Peter Maydell
> > wrote:
> > >
> > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis
> >
On Tue, 30 Jan 2024 at 12:34, Peter Maydell wrote:
>
> On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis
> wrote:
> >
> > Check if a file argument is a cover letter patch produced by
> > git-format-patch --cover-letter; It is initialized with subject suffix "
&g
On Tue, 30 Jan 2024 12:15, "Daniel P. Berrangé" wrote:
On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote:
Check if a file argument is a cover letter patch produced by
git-format-patch --cover-letter; It is initialized with subject suffix "
*** SUBJECT HER
On Tue, 30 Jan 2024 11:59, "Daniel P. Berrangé" wrote:
On Tue, Jan 30, 2024 at 11:54:51AM +0200, Manos Pitsidianakis wrote:
On Tue, 30 Jan 2024 11:47, "Daniel P. Berrangé" wrote:
> On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote:
> > On Tue, 3
Check if a file argument is a cover letter patch produced by
git-format-patch --cover-letter; It is initialized with subject suffix "
*** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they
exist, warn the user.
Signed-off-by: Manos Pitsidianakis
---
Rang
On Tue, 30 Jan 2024 11:47, "Daniel P. Berrangé" wrote:
On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote:
On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote:
>
> On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote:
> > Check if a fi
-report.h"
@@ -21,6 +22,9 @@
#include "qemu/rcu_queue.h"
#include "hw/hyperv/hyperv.h"
#include "qom/object.h"
+#include "target/i386/kvm/hyperv-proto.h"
+#include "target/i386/cpu.h"
+#include "exec/cpu-all.h"
struct SynICState {
DeviceState parent_obj;
--
2.41.0
Reviewed-by: Manos Pitsidianakis
On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote:
>
> On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote:
> > Check if a file argument is a cover letter patch produced by
> > git-format-patch --cover-letter; It is initialized with subject suffix &quo
Check if a file argument is a cover letter patch produced by
git-format-patch --cover-letter; It is initialized with subject suffix "
*** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they
exist, warn the user.
Signed-off-by: Manos Pitsidianakis
---
script
ppropriate.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
include/hw/block/block.h | 4 ++--
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
hw/block/pflash_cfi01.c | 4 ++--
hw/block/pflash_cfi02.c | 2 +-
5 files c
Add a simple method to return some kind of human readable identifier for
use in error messages.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Manos Pitsidianakis
---
include/hw/qdev-core.h | 14 ++
hw/core/qdev.c | 8
2 files changed, 22 insertions(+)
diff --git a
s not NULL on qdev_get_human_name
(thanks Phil Mathieu-Daudé )
Manos Pitsidianakis (2):
hw/core/qdev.c: add qdev_get_human_name()
hw/block/block.c: improve confusing blk_check_size_and_read_all()
error
include/hw/block/block.h | 4 ++--
include/hw/qdev-core.h
On Tue, 30 Jan 2024 03:26, Gurchetan Singh wrote:
On Mon, Jan 29, 2024 at 7:46 AM Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> wrote:
When the Rutabaga GPU device frees resources, it calls
rutabaga_resource_unref for that resource_id. However, when the generic
VirtIOGPU fun
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..a65dc0e55f 100644
--- a/h
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xe
INTFs that report guest errors are logged with
LOG_GUEST_ERROR.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 7 +++
hw/arm/z2.c | 27 ---
2 files changed, 15 insertions(+), 19 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
INTFs that report guest errors are logged with
LOG_GUEST_ERROR.#
Signed-off-by: Manos Pitsidianakis
---
hw/arm/strongarm.c | 82 -
hw/arm/trace-events | 3 ++
2 files changed, 55 insertions(+), 30 deletions(-)
diff --git a/hw/arm/strongarm.c b/h
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index a65dc0e55f..d1b27f6c11 100644
--- a/hw/xen/
This series changes some printfs to use the trace event framework.
Additionally, it converts some error/warning reporting fprintfs to
error_report/warn_report.
v2 -> v3
:
- addressed Peter Maydells's review
v1 -> v2
:
- addressed Alex's review
Manos Pitsidianak
rs or warnings are converted to error_report and
warn_report calls.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 5 +
hw/arm/xen_arm.c| 23 +++
2 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
ted with that resource_id is then leaked.
This commit overrides the resource_destroy class method introduced in
the previous commit to fix this.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu-rutabaga.c | 51
1 file changed, 39 insertions(+), 12 d
logic for implementations in the future.
Reviewed-by: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index f8a675eb30..2b73ae585b 100644
---
-by: Manos Pitsidianakis
---
include/hw/virtio/virtio-gpu.h | 3 +++
hw/display/virtio-gpu.c| 25 ++---
2 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index 584ba2ed73..b28e7ef0d2 100644
to be destroyed as well.
This series adds a resource_destroy class method that the Rutabaga
device can override and do its own bookkeeping.
v1 -> v2 differences:
- addressed review comments re: using the Error API for the
resource_destroy method.
Manos Pitsidianakis (3):
hw/display/vir
On Fri, 26 Jan 2024 at 17:22, Philippe Mathieu-Daudé wrote:
>
> Hi Manos,
>
> On 26/1/24 15:41, Manos Pitsidianakis wrote:
> > When destroying/unrefing resources, devices such as virtio-gpu-rutabaga
> > need to do their own bookkeeping (free rutabaga resources that are
On Fri, 26 Jan 2024 at 20:09, Alex Bennée wrote:
>
> Manos Pitsidianakis writes:
>
> > When destroying/unrefing resources, devices such as virtio-gpu-rutabaga
> > need to do their own bookkeeping (free rutabaga resources that are
> > associated with the virtio_gpu_sim
ted with that resource_id is then leaked.
This commit overrides the resource_destroy class method introduced in
the previous commit to fix this.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu-rutabaga.c | 31 ---
1 file changed, 20 insertions(+), 11 d
-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c| 19 ---
include/hw/virtio/virtio-gpu.h | 2 ++
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 2b73ae585b..96420ba74f 100644
--- a/hw/display/virtio
logic for implementations in the future.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index f8a675eb30..2b73ae585b 100644
--- a/hw/display/virtio-gpu.c
+++
need to be destroyed as well.
This series adds a resource_destroy class method that the Rutabaga
device can override and do its own bookkeeping.
Manos Pitsidianakis (3):
hw/display/virtio-gpu.c: use reset_bh class method
virtio-gpu.c: add resource_destroy class method
virtio-gpu-rutabaga.c
+cpu_exec_exit(cpu);
+};
return ret;
}
--
2.41.0
Reviewed-by: Manos Pitsidianakis
_report("vfio_iommu_map_dirty_notify(%p,"
+ " 0x%"HWADDR_PRIx
+ ", 0x%"HWADDR_PRIx") = %d (%s)",
+ bcontainer, iova, iotlb->addr_mask + 1, ret,
+ strerror(-ret));
+}
+}
}
}
-rcu_read_unlock();
-out:
if (ret) {
vfio_set_migration_error(ret);
}
--
2.41.0
Reviewed-by: Manos Pitsidianakis
d to flag whether the bus is resetting; but there's
no check if a resetting is taking place before starting another. Is this
single threaded code so it's not necessary?
As for the patch:
Reviewed-by: Manos Pitsidianakis
qemu_log_mask(LOG_GUEST_ERROR, "translation "
--
2.41.0
Reviewed-by: Manos Pitsidianakis
;
-rcu_read_unlock();
+WITH_RCU_READ_LOCK_GUARD() {
+rb = qemu_ram_block_from_host(res->iov[i].iov_base, false,
&offset);
+}
if (!rb || rb->fd < 0) {
g_free(list);
--
2.41.0
Reviewed-by: Manos Pitsidianakis
ppropriate.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
hw/block/pflash_cfi01.c | 4 ++--
hw/block/pflash_cfi02.c | 2 +-
include/hw/block/block.h | 4 ++--
5 files c
Add a simple method to return some kind of human readable identifier for
use in error messages.
Signed-off-by: Manos Pitsidianakis
---
hw/core/qdev.c | 8
include/hw/qdev-core.h | 14 ++
2 files changed, 22 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core
name, the device id and device type name where appropriate.
Version 2:
- Assert dev is not NULL on qdev_get_human_name
(thanks Phil Mathieu-Daudé )
Manos Pitsidianakis (2):
hw/core/qdev.c: add qdev_get_human_name()
hw/block/block.c: improve confusing blk_check_size_and_read_all()
error
On Tue, 23 Jan 2024 10:13, Philippe Mathieu-Daudé wrote:
Hi Manos,
On 23/1/24 09:09, Manos Pitsidianakis wrote:
Add a simple method to return some kind of human readable identifier for
use in error messages.
Signed-off-by: Manos Pitsidianakis
---
hw/core/qdev.c | 10
ppropriate.
Signed-off-by: Manos Pitsidianakis
---
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
hw/block/pflash_cfi01.c | 4 ++--
hw/block/pflash_cfi02.c | 2 +-
include/hw/block/block.h | 4 ++--
5 files changed, 22 insertions(+), 16 deletion
name, the device id and device type name where appropriate.
Manos Pitsidianakis (2):
hw/core/qdev.c: add qdev_get_human_name()
hw/block/block.c: improve confusing blk_check_size_and_read_all()
error
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
Add a simple method to return some kind of human readable identifier for
use in error messages.
Signed-off-by: Manos Pitsidianakis
---
hw/core/qdev.c | 10 ++
include/hw/qdev-core.h | 15 +++
2 files changed, 25 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core
rs or warnings are converted to error_report and
warn_report calls.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 5 +
hw/arm/xen_arm.c| 23 +++
2 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..1b748dba09 100644
--- a/h
This series changes some printfs to use the trace event framework.
Additionally, it converts some error/warning reporting fprintfs to
error_report/warn_report.
Differences from v1
:
- addressed Alex's review
Manos Pitsidianakis (5):
hw/arm/z2: convert DPRINTF to trace events and
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 1b748dba09..dd5b5a7f35 100644
--- a/hw/xen/
INTFs that report guest errors are logged with
LOG_GUEST_ERROR.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/strongarm.c | 55 ++---
hw/arm/trace-events | 10 +
hw/arm/z2.c | 27 +++---
3 files changed, 45 insertions(+
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xen-mapcache.c | 5 ++---
2 files ch
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 1b748dba09..dd5b5a7f35 100644
--- a/hw/xen/
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..1b748dba09 100644
--- a/h
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xen-mapcache.c | 5 ++---
2 files ch
d-off-by: Manos Pitsidianakis
---
hw/arm/strongarm.c | 49 +++--
hw/arm/trace-events | 18 +
2 files changed, 39 insertions(+), 28 deletions(-)
diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c
index fef3638aca..3ff748e826 100644
--- a/h
d-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 8
hw/arm/z2.c | 26 +-
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index cdc1ea06a8..a262ad2e6a 100644
--- a/hw/arm/trace-events
+++ b/h
d-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 7 +++
hw/arm/xen_arm.c| 26 +++---
2 files changed, 22 insertions(+), 11 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index a6a67d5f16..e3f5d677d7 100644
--- a/hw/arm/trace-events
+++ b/h
This series changes some printfs to use the trace event framework.
Additionally, it converts some error/warning reporting fprintfs to
error_report/warn_report.
Manos Pitsidianakis (6):
hw/arm/z2: convert DPRINTF to tracepoints
hw/arm/strongarm.c: convert DPRINTF to tracepoints
hw/arm
| 1 +
> 1 file changed, 1 insertion(+)
Hello Volker!
I don't have the slightest clue on how migration works, but if this is
enough to prevent those bugs from happening, it sounds good to me.
Reviewed-by: Manos Pitsidianakis
On Fri, 24 Nov 2023 12:25, Kevin Wolf wrote:
Am 23.11.2023 um 15:56 hat Manos Pitsidianakis geschrieben:
On Thu, 23 Nov 2023 16:35, "Michael S. Tsirkin" wrote:
> On Thu, Nov 23, 2023 at 11:40:26AM +, Daniel P. Berrangé wrote:
> > There has been an explosion of intere
On Thu, 23 Nov 2023 16:35, "Michael S. Tsirkin" wrote:
On Thu, Nov 23, 2023 at 11:40:26AM +, Daniel P. Berrangé wrote:
There has been an explosion of interest in so called "AI" (LLM)
code generators in the past year or so. Thus far though, this is
has not been matched by a broadly accepted
On Thu, 23 Nov 2023 12:15, Michael Tokarev wrote:
21.11.2023 12:38, Manos Pitsidianakis :
In the minimal pixman API stub that is used when the real pixman
dependency is missing a NULL dereference happens when
virtio-gpu-rutabaga allocates a pixman image with bits = NULL and
rowstride_bytes
(&s->bios, OBJECT(s), "bios",
+ BIOS_SIZE, errp)) {
+return;
+}
memory_region_add_subregion(get_system_memory(), (uint32_t)(-BIOS_SIZE),
&s->bios);
if (s->bios_name) {
--
2.41.0
Reviewed-by: Manos Pitsidianakis
amp;s->flash, OBJECT(dev), &flash_ops, s,
+ "nrf51_soc.flash", s->flash_size,
errp)) {
return;
}
--
Reviewed-by: Manos Pitsidianakis
errp
+ !memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7,
&errp)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
arg4, &errp)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
arg4, &errp)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
Commit message missing but indeed there's not much to say
Reviewed-by: Manos Pitsidianakis
return;
}
}
-out:
-error_propagate(errp, local_err);
}
static bool
--
Reviewed-by: Manos Pitsidianakis
hieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
e'.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote:
In preparation of having HostMemoryBackendClass::alloc() handlers
return a boolean, have them use g_autofree.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
--
include/exec/memory.h | 4 +++-
Reviewed-by: Manos Pitsidianakis
r = NULL;
-memory_region_init_ram_nomigrate(mr, owner, name, size, &err);
-if (err) {
-error_propagate(errp, err);
+if (!memory_region_init_ram_nomigrate(mr, owner, name, size, errp)) {
return;
}
/* This will assert if owner is neither NULL nor a DeviceState.
--
2.41.0
Reviewed-by: Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote:
Following the example documented since commit e3fe3988d7 ("error:
Document Error API usage rules"), have cpu_exec_realizefn()
return a boolean indicating whether an error is set or not.
Signed-off-by: Philippe Mathieu-Daudé
---
include/e
,9 @@ void memory_region_init_ram_flags_nomigrate(MemoryRegion
*mr,
mr->size = int128_zero();
object_unparent(OBJECT(mr));
error_propagate(errp, err);
+return false;
}
+return true;
}
void memory_region_init_resizeable_ram(MemoryRegion *mr,
--
2.41.0
Revie
;
+return memory_region_init_ram_flags_nomigrate(mr, owner, name,
+ size, 0, errp);
}
bool memory_region_init_ram_flags_nomigrate(MemoryRegion *mr,
--
2.41.0
Reviewed-by: Manos Pitsidianakis
scenario pixman calculates a
new stride value based on given width, height and format size.
This commit adds a helper function that performs the same logic as
pixman.
Signed-off-by: Manos Pitsidianakis
---
include/ui/pixman-minimal.h | 48 +++--
1 file changed, 46
i adds the same property.
To resolve the error, remove the duplicate property from
vhost-user-input-pci.
Signed-off-by: Leo Yan
---
Reviewed-by: Manos Pitsidianakis
ity change.
Signed-off-by: Leo Yan
Reviewed-by: Manos Pitsidianakis
On Thu, 16 Nov 2023 10:54, Philippe Mathieu-Daudé wrote:
On 16/11/23 09:48, Manos Pitsidianakis wrote:
On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé
wrote:
On 16/11/23 08:33, Manos Pitsidianakis wrote:
On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé
wrote:
---
Notes:
Requires
On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé wrote:
On 16/11/23 08:33, Manos Pitsidianakis wrote:
On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé
wrote:
---
Notes:
Requires patch
<20231109162034.2108018-1-manos.pitsidiana...@linaro.org>
This is the 'Based-on: &#
On Wed, 15 Nov 2023 22:27, Volker Rümelin wrote:
Cc: qemu-devel
Hi Manos,
it's easy to trigger a segmentation fault with the virtio-sound device.
The basic problem is that in function virtio_snd_realize() there is no
code in the errror paths to undo the previous steps.
Thank you for the repo
On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé wrote:
---
Notes:
Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.org>
This is the 'Based-on: ' tag I guess.
There is
prerequisite-patch-id: 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
At the end of the patch, added
resources made in steps
1-3.
Reported-by: Volker Rümelin
Fixes: 2880e676c000 ("Add virtio-sound device stub")
Signed-off-by: Manos Pitsidianakis
---
Notes:
Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.org>
hw/audio/v
Hello Leo,
On Mon, 13 Nov 2023 03:16, Leo Yan wrote:
vhost-user-input is in the input folder. On the other hand, the folder
'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc).
This patch moves vhost-user-input into the virtio folder for better code
organization. No functiona
On Fri, 10 Nov 2023 13:23, "Daniel P. Berrangé" wrote:
On Fri, Nov 10, 2023 at 11:18:39AM +, Peter Maydell wrote:
On Fri, 10 Nov 2023 at 11:02, Manos Pitsidianakis
wrote:
>
> On Fri, 10 Nov 2023 12:21, Peter Maydell wrote:
> >This kind of thing is why Coverity'
On Fri, 10 Nov 2023 13:20, "Daniel P. Berrangé" wrote:
Your approach to the problem:
if (!AUD_register_card("OMAP EAC", &s->codec.card, &error_fatal)) {
exit(1);
}
is adding dead-code because the exit(1) will never be reachable. So while
it lets you squelch the unused result warning, it i
301 - 400 of 781 matches
Mail list logo
