so that people do not think it is not working at least basically.
Signed-off-by: Samuel Thibault
---
slirp/ip_icmp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c
index 5ffc7a683d..0b667a429a 100644
--- a/slirp/ip_icmp.c
+++ b/slirp
_str* functions that dynamically
allocate and use g_dir_make_tmp to make the directory.
(It's fairly new glib but we have a compat function for it).
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Eric Blake
Signed-off-by: Samuel Thibault
---
net/slirp.c | 30 +
emu-system-x86_64 -net user,hostfwd=127.0.0.1:0-:22 ...
Then, get your port with:
$ lsof -np 1474 | grep LISTEN
qemu-syst 31777 bernat 12u IPv4 [...] TCP 127.0.0.1:35145 (LISTEN)
Signed-off-by: Vincent Bernat
Signed-off-by: Samuel Thibault
---
net/slirp.c | 2 +-
1 file changed, 1
The following changes since commit 81b2d5ceb0cfb4cdc2163492e3169ed714b0cda9:
Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170426' into
staging (2017-04-26 20:50:49 +0100)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samue
sockaddr_in6 lhost on the
stack. Copy only the source addr size.
Signed-off-by: Marc-André Lureau
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/tftp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/tftp.c b/sl
so that people do not think it is not working at least basically.
Signed-off-by: Samuel Thibault
diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c
index 5ffc7a683d..0b667a429a 100644
--- a/slirp/ip_icmp.c
+++ b/slirp/ip_icmp.c
@@ -152,8 +152,9 @@ icmp_input(struct mbuf *m, int hlen)
switch
Hello,
FONNEMANN Mark, on mer. 19 avril 2017 18:11:59 +, wrote:
> I have tested 2.9-rc4 and the problem still exists there as well.
FONNEMANN Mark, on lun. 24 avril 2017 23:43:02 +, wrote:
> I just confirmed that the problem exists in 2.9 release using
> qemu-system-i386.exe as well.
FO
Hello,
Thomas Huth, on lun. 24 avril 2017 11:15:56 +0200, wrote:
> On 20.04.2017 22:43, Tao Wu wrote:
> > The current code looks buggy, we zero ti_i while we access
> > ti_dst/ti_src later.
Indeed.
> > Signed-off-by: Tao Wu
> > *mtod(m, struct tcpiphdr *) = *ti;
> > ti
Stefan Weil, on ven. 21 avril 2017 21:58:18 +0200, wrote:
> Am 17.04.2017 um 00:10 schrieb FONNEMANN Mark:
> > I hadn't seen the original report on the list, sorry. There is too much
> > traffic on qemu-devel for me to manage to catch these :/
> >
> > This problem was fixed by
> > e42f869b ("slir
Hello,
I hadn't seen the original report on the list, sorry. There is too much
traffic on qemu-devel for me to manage to catch these :/
This problem was fixed by
e42f869b ("slirp: Make RA build more flexible") and
a2f80fdf ("slirp: Send RDNSS in RA only if host has an IPv6 DNS server")
which wil
t; +
> > +case NCSI_PKT_CMD_GLS: {
> > +rnh->common.length = htons(16);
> > +break;
> > +}
> > +
> > +slirp_output(slirp->opaque, ncsi_reply, sizeof(ncsi_reply));
Are we really supposed to send sizeof(ncsi_reply), and not accordingly
to the size announced withing the packet?
Appart from that,
Acked-by: Samuel Thibault
Samuel
Hello,
Applied to my tree, thanks!
Samuel
Hello,
Thanks for the patch!
Laurent Vivier, on mar. 28 mars 2017 21:07:56 +0200, wrote:
> @@ -617,6 +621,10 @@ void slirp_pollfds_poll(GArray *pollfds, int
> select_error)
> * Check sockets for reading
> */
> else if (revents & (G_IO_IN | G_I
v <[2]g.danil.a...@gmail.com>
Acked-by: Samuel Thibault
> ---
> hw/usb/dev-serial.c | 17 +
> hw/usb/dev-storage.c | 17 +
> hw/usb/hcd-ehci.h | 10 +-
> hw/usb/hcd-xhci.c | 19 ---
> 4 files changed, 35 inser
Do not hardcode the RA size at all, use a pl_size variable which
accounts the accumulated size, and fill rip->ip_pl at the end.
This will allow to make some blocks optional.
Signed-off-by: Samuel Thibault
Reviewed-by: Philippe Mathieu-Daudé
---
slirp/ip6_icmp.c |
mp_addr, s, sizeof(s));
^
slirp/slirp.c:204:25: error: assignment discards 'const' qualifier from pointer
target type [-Werror=discarded-qualifiers]
res = "(string conversion error)";
Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathi
Previously we would always send an RDNSS option in the RA, making the guest
try to resolve DNS through IPv6, even if the host does not actually have
and IPv6 DNS server available.
This makes the RDNSS option enabled only when an IPv6 DNS server is
available.
Signed-off-by: Samuel Thibault
The following changes since commit df9046363220e57d45818312759b954c033c58ab:
Update version for v2.9.0-rc2 release (2017-03-28 19:11:16 +0100)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to
Hello,
Philippe Mathieu-Daudé, on lun. 27 mars 2017 11:56:00 -0300, wrote:
> Why don't declare at function begining and remove this { } ?
Oh, right, now I can. While working on the code I still had ifdef
WIN32, so it'd lead to an unused variable warning. But now that the
ifdef is gone, we can j
Do not hardcode the RA size at all, use a pl_size variable which
accounts the accumulated size, and fill rip->ip_pl at the end.
This will allow to make some blocks optional.
Signed-off-by: Samuel Thibault
---
slirp/ip6_icmp.c | 24 +---
1 file changed, 9 insertions(+),
Hello,
These two patches fix sending the IPv6 RDNSS announce only when
it can actually work, fixing the bug reported by Cole Robinson
. Could somebody review them before I can send
a pull update?
Samuel Thibault (2):
slirp: Make RA build more flexible
slirp: Send RDNSS in RA only if host
Previously we would always send an RDNSS option in the RA, making the guest
try to resolve DNS through IPv6, even if the host does not actually have
and IPv6 DNS server available.
This makes the RDNSS option enabled only when an IPv6 DNS server is
available.
Signed-off-by: Samuel Thibault
Hello,
Cole Robinson, on ven. 24 mars 2017 21:17:43 -0400, wrote:
> I bisected to this commit:
>
> slirp: Add RDNSS advertisement
Mmm, I see. Could you try the attached patch to confirm that it fixes
the issue for you too?
Samuel
diff --git a/slirp/ip6_icmp.c b/slirp/ip6_icmp.c
index 298a4
> [160, 200) 'save_ip' <== Memory access at offset 96 partially underflows
> this variable
>
> The sockaddr_storage pointer is the sockaddr_in6 lhost on the
> stack. Copy only the source addr size.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Samu
Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:40:19 +, wrote:
> * Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> > Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:09:26 +, wrote:
> > > but only for Linux.
> >
> > That's what I was referring to.
Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:09:26 +, wrote:
> but only for Linux.
That's what I was referring to.
Samuel
Dr. David Alan Gilbert, on mar. 28 févr. 2017 17:00:17 +, wrote:
> * Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> > Dr. David Alan Gilbert, on mar. 28 févr. 2017 16:54:46 +, wrote:
> > > I'm thinking one way to do it without changing the version would
>
Dr. David Alan Gilbert, on mar. 28 févr. 2017 16:54:46 +, wrote:
> I'm thinking one way to do it without changing the version would
> be to use the existing value for IPv4, and on reading allow any other
> value for IPv6 (or just the ones we know about); that would make
> it inwards migration c
Hello,
Max Reitz, on lun. 27 févr. 2017 17:12:47 +0100, wrote:
> > #ifdef CONFIG_FALLOCATE_PUNCH_HOLE
> > -if (s->has_discard && s->has_fallocate) {
> > +if (s->has_discard && (s->has_fallocate || open_flags &
> > BDRV_O_SPARSE)) {
>
> s->has_fallocate has a meaning. I wouldn't try to c
which does this, by disabling the
fallocate call.
Signed-off-by: Samuel Thibault
diff --git a/block.c b/block.c
index b663204f3f..e9cd83210a 100644
--- a/block.c
+++ b/block.c
@@ -665,12 +665,14 @@ static void bdrv_join_options(BlockDriverState *bs, QDict
*options,
*/
int
Samuel Thibault, on dim. 26 févr. 2017 21:34:27 +0100, wrote:
> since we'll want to change the size of the field
Ah, no, sorry, it was forced to be 16bit, so at least the size is fine.
But I guess we don't want to change the values to have cross-OS
compatibility without changin
Hello,
Dr. David Alan Gilbert, on jeu. 23 févr. 2017 11:40:45 +, wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > IOW if we transmit this data on the wire, we've effectively said that
> > our migration data format is *not* portable across different host OS
> > platforms. At that
From: "Dr. David Alan Gilbert"
Convert the migration of the struct tcpcb to use a VMStateDescription,
the rest of it will come later.
Mostly mechanical, except for conversion of some 'char' to uint8_t
to ensure portability.
Signed-off-by: Dr. David Alan Gilbert
Reviewed
From: "Dr. David Alan Gilbert"
This converts the remaining components, except for the top level
loop, to VMState.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Signed-off-by: Samuel Thibault
---
slirp/slirp.c | 48 +++---
d-by: Juan Quintela
Signed-off-by: Samuel Thibault
---
slirp/slirp.c | 170 ++---
slirp/socket.h | 6 +-
2 files changed, 93 insertions(+), 83 deletions(-)
diff --git a/slirp/slirp.c b/slirp/slirp.c
index 178c2b6d14..6583de8769 100644
--- a/sli
ned-off-by: Samuel Thibault
---
slirp/sbuf.h | 4 +-
slirp/slirp.c | 116 ++
2 files changed, 78 insertions(+), 42 deletions(-)
diff --git a/slirp/sbuf.h b/slirp/sbuf.h
index efcec39a6b..a722ecb629 100644
--- a/slirp/sbuf.h
+++ b/sl
la
Signed-off-by: Samuel Thibault
---
slirp/socket.h | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/slirp/socket.h b/slirp/socket.h
index 8feed2aea4..c1be77eaf3 100644
--- a/slirp/socket.h
+++ b/slirp/socket.h
@@ -15,6 +15,12 @@
* Our socket structure
*
The following changes since commit 685783c5b69c83c942d1fc21679311eeb8f79ab9:
Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
staging (2017-02-26 16:38:40 +)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git t
ydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/slirp/mbuf.c b/slirp/mbuf.c
index 7eddc217e4..5ff24559fd 100644
--- a/slirp/mbuf.c
+++ b/slirp/mbuf.c
@@ -10,7
The following changes since commit 6528a4c1f20c1ba5a22ab84bec6788a574ac04c8:
Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
staging (2017-02-26 11:47:00 +)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git t
complains (CID 1005723).
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/udp.c | 4
1 file changed, 4 insertions(+)
diff --git a/slirp/udp.c b/slirp/udp.c
index 93d7224792..227d779022 100644
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@
() to do the right
thing on Windows. Change to using the right function and only calling it if
needed.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/socket.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/
Hello,
Stefan Hajnoczi, on Mon 06 Feb 2017 11:55:05 +, wrote:
> I'm proposing this topic for discussion because there might be common
> ground for Samuel from QEMU and the VDE folks to collaborate.
>
> Samuel: Should QEMU join forces with libslirp?
Well, there are not that many forces from t
The curses and none possibilities are already documented on a separate line,
so documenting it on the sdl line was both unneeded and confusing.
Signed-off-by: Samuel Thibault
diff --git a/qemu-options.hx b/qemu-options.hx
index c534a2f7f9..9c81d3752d 100644
--- a/qemu-options.hx
+++ b/qemu
Hello,
Gerd Hoffmann, on Thu 12 Jan 2017 16:56:49 +0100, wrote:
> On Do, 2017-01-12 at 16:10 +0100, Stefan Weil wrote:
> > This commit breaks builds for Windows. See below for details.
>
> > Windows does not use X11. gcc fails:
> >
> > CC ui/sdl2.o
> > /qemu/ui/sdl2.c: In function ‘sdl_di
This moves the SDL bits for window ID from the baum driver to SDL, as
well as fixing the build for non-X11.
Signed-off-by: Samuel Thibault
---
Difference from v3: Use qemu_console_lookup_by_index and
qemu_console_is_graphic to access the console
---
backends/baum.c | 31
This uses the console API to record the window ID of the SDL2 windows.
Signed-off-by: Samuel Thibault
---
ui/sdl2.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 30d2a3c35d..9a79b17b92 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -761,6 +761,7 @@ void
This adds two console functions, qemu_console_set_window_id and
qemu_graphic_console_get_window_id, to let graphical backend record the
window id in the QemuConsole structure, and let the baum driver read it.
Signed-off-by: Samuel Thibault
---
Difference from v4: select console with a
QemuConsole* parameter instead of an
integer index,
Samuel
Samuel Thibault (3):
console: add API to get underlying gui window ID
console: move window ID code from baum to sdl
sdl2: set window ID
backends/baum.c | 31 ---
include/ui/console.h | 4
ui/console.c
no-re...@patchew.org, on Tue 20 Dec 2016 15:15:43 -0800, wrote:
> Your series seems to have some coding style problems. See output below for
> more information:
> ERROR: suspect code indent for conditional statements (10, 14)
> #90: FILE: slirp/tftp.c:393:
> + if (blksize > 0) {
> +
Hervé Poussineau, on Mon 21 Nov 2016 20:45:49 +0100, wrote:
> The blocksize option is defined in RFC 1783.
> We now support block sizes between 1 and 1432 bytes, instead of 512 only.
>
> Signed-off-by: Hervé Poussineau
I fixed a couple of trivial things and commited to my tree, thanks!
Samuel
From: Yuval Shaia
Signed-off-by: Yuval Shaia
Reviewed-by: Markus Armbruster
Reviewed-by: Laurent Vivier
Signed-off-by: Samuel Thibault
---
disas/m68k.c | 8 ++--
slirp/dhcpv6.c | 2 +-
slirp/ip6_icmp.c | 2 +-
slirp/slirp.c | 2 +-
slirp/slirp.h | 5
From: Hervé Poussineau
The blocksize option is defined in RFC 1783 and RFC 2348.
We now support block sizes between 1 and 1428 bytes, instead of 512 only.
Signed-off-by: Hervé Poussineau
Signed-off-by: Samuel Thibault
---
slirp/tftp.c | 26 ++
slirp/tftp.h | 8
The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c:
Open 2.9 development tree (2016-12-20 16:20:16 +)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to
I have applied it to my tree, thanks!
Samuel
Hello,
Dr. David Alan Gilbert, on Mon 28 Nov 2016 09:08:16 +, wrote:
> Hmm, I don't really know IPv6 but I'm thinking this code will become
> something like
> the following (says he not knowing whether a scope-id or a flowinfo
> is something that needs migrating) (untested):
>
>
> static co
Yuval Shaia, on Mon 28 Nov 2016 00:18:26 +0200, wrote:
> On Sun, Nov 27, 2016 at 03:10:04PM +0100, Samuel Thibault wrote:
> > Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote:
> > > -#ifndef _WIN32
> > > -#define min(x,y) ((x) < (y) ? (x) : (y))
> > >
Samuel Thibault, on Sun 27 Nov 2016 16:13:46 +0100, wrote:
> Dr. David Alan Gilbert (git), on Wed 23 Nov 2016 18:52:57 +, wrote:
> > +static const VMStateDescription vmstate_slirp_socket_addr = {
> > +.name = "slirp-socket-addr",
> > +.version_id = 4,
&
Hello,
Dr. David Alan Gilbert (git), on Wed 23 Nov 2016 18:52:57 +, wrote:
> +static const VMStateDescription vmstate_slirp_socket_addr = {
> +.name = "slirp-socket-addr",
> +.version_id = 4,
> +.fields = (VMStateField[]) {
> +VMSTATE_UINT16(ss.ss_family, union slirp_sockad
Hello,
Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote:
> -#ifndef _WIN32
> -#define min(x,y) ((x) < (y) ? (x) : (y))
> -#define max(x,y) ((x) > (y) ? (x) : (y))
> -#endif
This has protection against _WIN32, I guess that was on purpose.
Perhaps qemu should avoid risking a clash with OS-prov
Stefan Hajnoczi, on Mon 21 Nov 2016 14:46:16 +, wrote:
> On Sun, Nov 20, 2016 at 09:41:36AM +0100, Vincent Bernat wrote:
> > From: Vincent Bernat
> >
> > Some network equipments are requesting a file using the netascii
> > protocol and this is not configurable. Currently, qemu's tftpd only
>
n (LF ->
CR,LF) as it would be far more complex. The current implementation is
good enough. A user has always the choice to preencode the served file
correctly.
Signed-off-by: Vincent Bernat
Signed-off-by: Samuel Thibault
---
slirp/tftp.c | 11 ---
1 file changed, 8 insertions(+), 3 d
The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf:
Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to
Vincent Bernat, on Sat 19 Nov 2016 09:03:08 +0100, wrote:
> ❦ 19 novembre 2016 08:32 +0100, Thomas Huth :
>
> >> Some network equipments are requesting a file using the netascii
> >> protocol and this is not configurable. Currently, qemu's tftpd only
> >> supports the octet protocol. This commit
es.h in ui/curses.c is not needed
> and was removed.
>
> Those two modifications fix the redefinition warnings.
>
> Signed-off-by: Stefan Weil
Acked-by: Samuel Thibault
> ---
> include/ui/console.h | 3 +++
> ui/curses.c | 1 -
> 2 files changed, 3 ins
Hello,
Vincent Bernat, on Thu 17 Nov 2016 13:22:32 +0100, wrote:
> ❦ 17 novembre 2016 13:20 +0100, Vincent Bernat :
>
> > Some network equipments are requesting a file using the netascii
> > protocol and this is not configurable. Currently, qemu's tftpd only
> > supports the octet protocol. Thi
n (LF ->
CR,LF) as it would be far more complex. The current implementation is
good enough. A user has always the choice to preencode the served file
correctly.
Signed-off-by: Vincent Bernat
Signed-off-by: Samuel Thibault
---
slirp/tftp.c | 8 +---
1 file changed, 5 insertions(+), 3 d
The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf:
Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to
The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974:
Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging
(2016-11-11 12:51:50 +)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samuel-thibaul
socket any more.
Signed-off-by: Samuel Thibault
Tested-by: Brian Candler
Reviewed-by: Stefan Hajnoczi
---
slirp/socket.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/slirp/socket.c b/slirp/socket.c
index 280050a..6c18971 100644
--- a/slirp/socket.c
+++ b/slirp/socket.c
Hello,
Note:
no-re...@patchew.org, on Sun 13 Nov 2016 15:13:47 -0800, wrote:
> Your series seems to have some coding style problems. See output below for
> more information:
>
> === OUTPUT BEGIN ===
> fatal: unrecognized argument: --no-patch
> Checking PATCH 1/1: ...
> ERROR: suspect code indent
socket any more.
Signed-off-by: Samuel Thibault
Tested-by: Brian Candler
---
slirp/socket.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/slirp/socket.c b/slirp/socket.c
index 280050a..6c18971 100644
--- a/slirp/socket.c
+++ b/slirp/socket.c
@@ -66,6 +66,23 @@ void
sofre
Hello,
Brian Candler, on Sat 12 Nov 2016 09:33:55 +, wrote:
> On 11/11/2016 22:09, Samuel Thibault wrote:
> >Ooh, I see. Now it's obvious, now that it's not coming from the tcb
> >loop:) Could you try the attached patch?
>
> It looks like it now goes into an
Brian Candler, on Fri 11 Nov 2016 20:53:12 +, wrote:
> On 11/11/2016 16:17, Samuel Thibault wrote:
> >Could you increase the value given to valgrind's --num-callers= so we
> >can make sure the context of this call?
>
> OK: re-run with --num-callers=250. It to
Hello,
Brian Candler, on Fri 11 Nov 2016 16:02:44 +, wrote:
> Aha!! Looking carefully at valgrind output, I see some definite cases of
> use-after-free in tcp_output. Does the info below help?
Ok, that's interesting. I however still don't see how that could happen
:)
> ==18350== Invalid read
of e.g. the WACS_DEGREE macro.
We also want to stop at the first curses_inc_list configuration which works,
and make sure to set IFS to : at each new loop.
Signed-off-by: Samuel Thibault
Tested-by: Cornelia Huck
---
configure | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff
Sergey Smolov, on Wed 09 Nov 2016 13:15:18 +0300, wrote:
> Is it planned to publish this patch into master?
Yes.
Samuel
hor: Samuel Thibault
Date: Tue Nov 8 20:57:27 2016 +0100
Fix cursesw detection
On systems which do not provide ncursesw.pc and whose /usr/include/curses.h
does not include wide support, we should not only try with no -I, i.e.
/usr/include, but also with -I/usr/include/ncurs
Hello,
Cornelia Huck, on Wed 09 Nov 2016 10:12:36 +0100, wrote:
> On Wed, 9 Nov 2016 10:04:02 +0100
> Samuel Thibault wrote:
> > Please post config.log so we can have a clue about what is going
> > wrong. All these error messages are meant to be reported verbatim, not
Hello,
Cornelia Huck, on Wed 09 Nov 2016 09:58:59 +0100, wrote:
> On Tue, 8 Nov 2016 21:10:19 +0100
> Samuel Thibault wrote:
> > Cornelia Huck, on Tue 08 Nov 2016 12:34:49 +0100, wrote:
> > “
> > configure test passed without -Werror but failed with -Werror.
> >
nfig seems like a good
> idea, but I don't think it's related to this issue.
Actually it is: in your case it's the second config which will work, the
third one will fail. Not breaking would mean we keep the failing one.
Samuel
commit 4c5e78e8843fa919f2601d8e44029ed0e711c6d9
Author: Samuel Thibault
Hello,
On 7 November 2016 at 13:38, Michal Suchanek wrote:
> -curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
> +curses_inc_list="$($pkg_config --cflags ncursesw
> 2>/dev/null)-I/usr/include/ncursesw:"
Cornelia Huck, on Mon 07 Nov 2016 17:26:56 +0100, wrote:
> +if [
Hello,
Stefan Hajnoczi, on Fri 04 Nov 2016 11:14:19 +, wrote:
> CCing slirp maintainers to get attention on this bug
Thanks!
> > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
> > 0x76a1bb5b in _int_free (av=0x76d5fb20 ,
> > p=, have_lock=0) at malloc.c:4
bles so that the address
> passed to connect does not have random data in it.
>
> Signed-off-by: Bo Hu <[2]b...@google.com>
> + memset(&lhost, 0, sizeof(lhost);
> + memset(&fhost, 0, sizeof(fhost);
There is just a typo: missing closing parenthesis...
But apart from that,
Reviewed-by: Samuel Thibault
Samuel
Samuel Thibault, on Mon 31 Oct 2016 17:00:07 +0100, wrote:
> This uses the console API to record the window ID of the GTK windows.
Ah, sorry, I let this one through, please ignore it, it'll need rework
as discussed in the other thread.
Samuel
This moves the SDL bits for window ID from the baum driver to SDL, as
well as fixing the build for non-X11.
Signed-off-by: Samuel Thibault
---
backends/baum.c | 25 +++--
ui/sdl.c| 25 +
2 files changed, 28 insertions(+), 22 deletions(-)
diff
, where the window
handle needs to be explictly truncated to 32bit (such handles are
guaranteed to be 32bit)
Samuel
Samuel Thibault (4):
console: add API to get underlying gui window ID
console: move window ID code from baum to sdl
sdl2: set window ID
gtk: set window ID
backends/baum.c
This uses the console API to record the window ID of the SDL2 windows.
Signed-off-by: Samuel Thibault
---
ui/sdl2.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 30d2a3c..b464f16 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -761,6 +761,7 @@ void
This adds two console functions, qemu_console_set_window_id and
qemu_graphic_console_get_window_id, to let graphical backend record the
window id in the QemuConsole structure, and let the baum driver read it.
Signed-off-by: Samuel Thibault
---
include/ui/console.h | 3 +++
ui/console.c
This uses the console API to record the window ID of the GTK windows.
Signed-off-by: Samuel Thibault
---
ui/gtk.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index ca737c4..d75f255 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
Cornelia Huck, on Mon 31 Oct 2016 14:08:48 +0100, wrote:
> On Mon, 31 Oct 2016 15:03:33 +0100
> Samuel Thibault wrote:
>
> > Cornelia Huck, on Mon 31 Oct 2016 13:48:01 +0100, wrote:
> > > On Mon, 31 Oct 2016 13:39:30 +0100
> > > Samuel Thibault wrote:
> >
Cornelia Huck, on Mon 31 Oct 2016 13:48:01 +0100, wrote:
> On Mon, 31 Oct 2016 13:39:30 +0100
> Samuel Thibault wrote:
>
> > Cornelia Huck, on Mon 31 Oct 2016 13:08:06 +0100, wrote:
> > > You mean in configure, right? Including cursesw.h in the test program
> >
Cornelia Huck, on Mon 31 Oct 2016 13:08:06 +0100, wrote:
> You mean in configure, right? Including cursesw.h in the test program
> gets configure going again.
Could you try the attached patch which fixes both configure and
ui/curses.c?
Thanks,
Samuel
diff --git a/configure b/configure
index f83cd
Cornelia Huck, on Mon 31 Oct 2016 13:08:06 +0100, wrote:
> On Mon, 31 Oct 2016 13:01:59 +0100
> Samuel Thibault wrote:
>
> > Cornelia Huck, on Mon 31 Oct 2016 12:45:30 +0100, wrote:
> > > config-temp/qemu-conf.c:9:3: warning: implicit declaration of function
> > &g
Samuel Thibault, on Mon 31 Oct 2016 13:01:59 +0100, wrote:
> Cornelia Huck, on Mon 31 Oct 2016 12:45:30 +0100, wrote:
> > > From: Samuel Thibault
> > >
> > > Use ncursesw package instead of curses on non-mingw, and check a few
> > > functions.
> &
Cornelia Huck, on Mon 31 Oct 2016 12:45:30 +0100, wrote:
> > From: Samuel Thibault
> >
> > Use ncursesw package instead of curses on non-mingw, and check a few
> > functions.
> > Also take cflags from pkg-config, since cursesw headers may be in a
>
Gerd Hoffmann, on Wed 26 Oct 2016 12:17:44 +0200, wrote:
> > +/* All consoles share the same window */
>
> No. That is the default setup, but try "View / Detach tab". Window ID
> changing at runtime ...
So we would need to make baum register for notification of Window ID
change.
It cou
Hello,
This is a respin of moving getting XWindow ID from baum to actual
graphical backends. This only contains the new API, the move
of existing code to the new API, and the addition of support for
SDL2. Gtk will need more discussion and work.
Samuel
Samuel Thibault (3):
console: add API to
This moves the SDL bits for window ID from the baum driver to SDL, as
well as fixing the build for non-X11.
Signed-off-by: Samuel Thibault
---
backends/baum.c | 25 +++--
ui/sdl.c| 25 +
2 files changed, 28 insertions(+), 22 deletions(-)
diff
This adds two console functions, qemu_console_set_window_id and
qemu_graphic_console_get_window_id, to let graphical backend record the
window id in the QemuConsole structure, and let the baum driver read it.
Signed-off-by: Samuel Thibault
---
include/ui/console.h | 3 +++
ui/console.c
901 - 1000 of 1571 matches
Mail list logo
