Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181214105642.673-1-cferg...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-16 Thread Stefan Hajnoczi
On Fri, Dec 14, 2018 at 11:56:42AM +0100, Christophe Fergeau wrote: > This commit adds a qemu_init_logging() helper which calls > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) > are handled similarly to other QEMU logs. This means they will get a > timestamp if timestamps ar

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-15 Thread Christophe Fergeau
On Tue, Jan 15, 2019 at 02:09:12PM +, Stefan Hajnoczi wrote: > > In these codepaths, I'm confident up to > > void monitor_vfprintf(FILE *stream, const char *fmt, va_list ap) > > { > > if (cur_mon && !monitor_cur_is_qmp()) { > > monitor_vprintf(cur_mon, fmt, ap); > > } else { > >

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-15 Thread Stefan Hajnoczi
On Mon, Jan 14, 2019 at 12:54:20PM +0100, Christophe Fergeau wrote: > On Fri, Jan 04, 2019 at 03:40:34PM +, Stefan Hajnoczi wrote: > > On Thu, Jan 03, 2019 at 03:14:55PM +0100, Christophe Fergeau wrote: > > > Hey, > > > > > > On Thu, Jan 03, 2019 at 10:54:25AM +, Stefan Hajnoczi wrote: > >

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-14 Thread Christophe Fergeau
On Fri, Jan 04, 2019 at 03:40:34PM +, Stefan Hajnoczi wrote: > On Thu, Jan 03, 2019 at 03:14:55PM +0100, Christophe Fergeau wrote: > > Hey, > > > > On Thu, Jan 03, 2019 at 10:54:25AM +, Stefan Hajnoczi wrote: > > > On Fri, Dec 14, 2018 at 11:56:42AM +0100, Christophe Fergeau wrote: > > > >

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2019 at 03:14:55PM +0100, Christophe Fergeau wrote: > Hey, > > On Thu, Jan 03, 2019 at 10:54:25AM +, Stefan Hajnoczi wrote: > > On Fri, Dec 14, 2018 at 11:56:42AM +0100, Christophe Fergeau wrote: > > > +static void qemu_log_func(const gchar *log_domain, > > > +

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-03 Thread Christophe Fergeau
Hey, On Thu, Jan 03, 2019 at 10:54:25AM +, Stefan Hajnoczi wrote: > On Fri, Dec 14, 2018 at 11:56:42AM +0100, Christophe Fergeau wrote: > > +static void qemu_log_func(const gchar *log_domain, > > + GLogLevelFlags log_level, > > + const gchar *m

Re: [Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2019-01-03 Thread Stefan Hajnoczi
On Fri, Dec 14, 2018 at 11:56:42AM +0100, Christophe Fergeau wrote: > +static void qemu_log_func(const gchar *log_domain, > + GLogLevelFlags log_level, > + const gchar *message, > + gpointer user_data) > +{ > +switch (lo

[Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2018-12-14 Thread Christophe Fergeau
This commit adds a qemu_init_logging() helper which calls g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) are handled similarly to other QEMU logs. This means they will get a timestamp if timestamps are enabled, and they will go through the monitor if one is configured. This c