Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-01 Thread Stefan Hajnoczi
On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > explaining that share-rw=on can be used safely with format=raw if the > > guests are configured to

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-31 Thread Kevin Wolf
Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > On Tue, Jan 30, 2018 at 05:38:20PM +0100, Kevin Wolf wrote: > > Am 30.01.2018 um 15:23 hat Eric Blake geschrieben: > > > On 01/30/2018 12:34 AM, Fam Zheng wrote: > > > > Signed-off-by: Fam Zheng > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-31 Thread Stefan Hajnoczi
On Tue, Jan 30, 2018 at 05:38:20PM +0100, Kevin Wolf wrote: > Am 30.01.2018 um 15:23 hat Eric Blake geschrieben: > > On 01/30/2018 12:34 AM, Fam Zheng wrote: > > > Signed-off-by: Fam Zheng > > > Signed-off-by: Kevin Wolf > > > --- > > > qemu-img.texi | 7

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Kevin Wolf
Am 30.01.2018 um 15:23 hat Eric Blake geschrieben: > On 01/30/2018 12:34 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > Signed-off-by: Kevin Wolf > > --- > > qemu-img.texi | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Stefan Hajnoczi
On Tue, Jan 30, 2018 at 02:34:33PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > qemu-img.texi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Kashyap Chamarthy
On Tue, Jan 30, 2018 at 08:23:50AM -0600, Eric Blake wrote: > On 01/30/2018 12:34 AM, Fam Zheng wrote: [...] > > +If specified, @code{qemu-img} will open the image in shared mode, allowing > > +concurrent writers. For example, this can be used to get the image > > information > > Actually, we

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Eric Blake
On 01/30/2018 12:34 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > qemu-img.texi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index 60a0e080c6..ec7e2f5d1e 100644 > ---

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Eric Blake
On 01/30/2018 12:34 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > qemu-img.texi | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer

[Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-29 Thread Fam Zheng
Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 60a0e080c6..ec7e2f5d1e 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -86,6 +86,13 @@