Re: [Qemu-devel] [RFC 3/8] qapi-types.h doesn't really need to include qemu-common.h

2012-08-21 Thread Luiz Capitulino
On Tue, 21 Aug 2012 12:42:57 -0300 Eduardo Habkost wrote: > From: Igor Mammedov > > needed to prevent build breakage when CPU becomes a child of DeviceState > > Signed-off-by: Igor Mammedov > --- > scripts/qapi-types.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info

2012-08-21 Thread Luiz Capitulino
On Tue, 21 Aug 2012 17:00:20 +0200 Juan Quintela wrote: > Luiz Capitulino wrote: > > On Sat, 18 Aug 2012 07:02:50 -0600 > > Eric Blake wrote: > > > > I can cherry-pick this into the qmp branch. > > > > Juan, I can also fix myself the problem I poin

[Qemu-devel] [PATCH 1/3] qapi: Fix memory leak

2012-08-22 Thread Luiz Capitulino
-option.c:1114) ==24534==by 0x29E85B: net_init_clients (net.c:1008) ==24534==by 0x296F40: main (vl.c:3463) Signed-off-by: Stefan Weil Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- qapi/opts-visitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/opts

[Qemu-devel] [PULL for-1.2 0/3]: QMP queue

2012-08-22 Thread Luiz Capitulino
Three little fixes. Two for QMP and one for HMP. The changes (since 682527c00409d676c0d3b9fac99ca3b2fdfd6d2c) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Blue Swirl (1): monitor: avoid declaring unused variables Juan Quintela (1):

[Qemu-devel] [PATCH 2/3] monitor: avoid declaring unused variables

2012-08-22 Thread Luiz Capitulino
lags' /src/qemu/monitor.c:2574: warning: unused variable 'mon_fdset_fd' /src/qemu/monitor.c:2573: warning: unused variable 'mon_fdset' Signed-off-by: Blue Swirl Reviewed-by: Stefan Weil Signed-off-by: Luiz Capitulino --- monitor.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH 3/3] migration: move total_time from ram stats to migration info

2012-08-22 Thread Luiz Capitulino
From: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Luiz Capitulino --- hmp.c| 4 ++-- migration.c | 7 --- qapi-schema.json | 14 +++--- qmp-commands.hx | 6 +++--- 4 files changed, 16 insertions(+), 15 deletions(-) diff --git a/hmp.c b/hmp.c

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size (v2)

2012-08-22 Thread Luiz Capitulino
rse the binary name or -help output > > $ qmp-shell -p /tmp/qemu > (QEMU) query-target > { u'return': { u'arch': u'x86_64' }} > > Signed-off-by: Daniel P. Berrange > Signed-off-by: Anthony Liguori Reviewed-by: Luiz Capitulino >

Re: [Qemu-devel] [PATCH] Add guest-get-hostname to retrieve the guests current hostname

2012-08-23 Thread Luiz Capitulino
On Tue, 21 Aug 2012 13:57:54 +0200 Guido Günther wrote: > This allows to retrieve the guest's hostname via gethostname(2). > > This can be useful to identify a VM e.g. one without network. > > Signed-off-by: Guido Günther > --- > We have an API in libvirt for that (virDomainGetHostname). > Che

Re: [Qemu-devel] [PATCH for 1.2] qemu-ga: Fix null pointer passed to unlink in failure branch

2012-08-24 Thread Luiz Capitulino
On Fri, 24 Aug 2012 07:03:03 +0200 Stefan Weil wrote: > Clang reports this warning: > > Null pointer passed as an argument to a 'nonnull' parameter > > Signed-off-by: Stefan Weil Reviewed-by: Luiz Capitulino > --- > qemu-ga.c |4 +++- > 1 file ch

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-24 Thread Luiz Capitulino
On Thu, 23 Aug 2012 17:09:25 -0400 Jason Baron wrote: > While testing q35, I found that windows 7 (specifically, windows 7 ultimate > with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. > The failure message is: 'A required cd/dvd device driver is missing. If you > have

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-24 Thread Luiz Capitulino
On Fri, 24 Aug 2012 07:34:51 -0700 Alexander Graf wrote: > > > Am 24.08.2012 um 07:18 schrieb Luiz Capitulino : > > > On Thu, 23 Aug 2012 17:09:25 -0400 > > Jason Baron wrote: > > > >> While testing q35, I found that windows 7 (specifically, windows

Re: [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi

2012-08-27 Thread Luiz Capitulino
On Mon, 27 Aug 2012 15:23:31 +0800 Amos Kong wrote: > On 20/08/12 23:08, Luiz Capitulino wrote: > > On Mon, 20 Aug 2012 07:25:13 -0600 > > Eric Blake wrote: > > > >> On 08/19/2012 10:39 PM, Amos Kong wrote: > >>> This series converted 's

Re: [Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-28 Thread Luiz Capitulino
On Mon, 27 Aug 2012 09:36:05 +0200 Benoît Canet wrote: > Adding Luiz to the thread since he is concerned by migration. > > Luiz do you have any hints on doing this properly ? I don't. Juan is a better option though. But, we use exec migration for this, no? > > Benoît > > > Le Thursday 23 Au

[Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-24 Thread Luiz Capitulino
mands 'eject' and 'change' are not covered. Signed-off-by: Luiz Capitulino --- PS: Bugs are mine. QMP/qmp-events.txt | 18 ++ block.c| 12 block.h|5 + block_int.h|3 +++ blockdev.c |

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Luiz Capitulino
On Wed, 25 Jan 2012 09:41:20 +0100 Kevin Wolf wrote: > Am 24.01.2012 21:03, schrieb Eric Blake: > > On 01/24/2012 11:16 AM, Luiz Capitulino wrote: > >> Libvirt wants to be notified when the guest ejects a medium, so that > >> it can update its view of the guest. &

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Luiz Capitulino
On Wed, 25 Jan 2012 11:19:59 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Libvirt wants to be notified when the guest ejects a medium, so that > > it can update its view of the guest. > > > > This code has been originally written by Daniel Berr

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Luiz Capitulino
On Wed, 25 Jan 2012 14:23:55 +0100 Kevin Wolf wrote: > >> Also, I seem to remember that once we had discussed some kind of a "tray > >> status (open/closed) changed" event, which would be more generic. > > > > Yes, but my old series got complex and way beyond the original event. If we > > decide

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-26 Thread Luiz Capitulino
On Wed, 25 Jan 2012 10:42:04 -0200 Luiz Capitulino wrote: > On Wed, 25 Jan 2012 09:41:20 +0100 > Kevin Wolf wrote: > > > Am 24.01.2012 21:03, schrieb Eric Blake: > > > On 01/24/2012 11:16 AM, Luiz Capitulino wrote: > > >> Libvirt wants to be notified whe

Re: [Qemu-devel] [libvirt] libvirt doesn't work with qemu 1.0

2012-01-26 Thread Luiz Capitulino
On Wed, 25 Jan 2012 20:55:14 -0700 Eric Blake wrote: > On 12/02/2011 01:32 PM, Anthony Liguori wrote: > >> But we already have to call 'qemu -h' for other reasons; so we might as > >> well be efficient and learn as much as possible from that result than by > >> calling both 'qemu -h' and 'qemu -q

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Luiz Capitulino
On Thu, 26 Jan 2012 20:41:13 +0100 Michal Privoznik wrote: > On 26.01.2012 20:35, Luiz Capitulino wrote: > > On Thu, 26 Jan 2012 08:18:03 -0700 > > Eric Blake wrote: > > > >> [adding qemu-devel] > >> > >> On 01/26/2012 07:46 AM, Daniel P. Berran

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Luiz Capitulino
On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake wrote: > [adding qemu-devel] > > On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: > >> One thing, that you'll probably notice is this > >> 'set-support-level' command. Basically, it tells GA what qemu version > >> is it running on. Ideally, this sho

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguori wrote: > On 01/26/2012 01:35 PM, Luiz Capitulino wrote: > > On Thu, 26 Jan 2012 08:18:03 -0700 > > Eric Blake wrote: > > > >> [adding qemu-devel] > >> > >> On 01/26/2012 07:46 AM, Daniel P. Berran

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori wrote: > On 01/30/2012 06:57 AM, Luiz Capitulino wrote: > > On Thu, 26 Jan 2012 16:57:01 -0600 > > Anthony Liguori wrote: > > > >> On 01/26/2012 01:35 PM, Luiz Capitulino wrote: > >>> On Thu, 26 Jan 20

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-30 Thread Luiz Capitulino
On Fri, 27 Jan 2012 10:52:15 +0100 Kevin Wolf wrote: > Am 26.01.2012 18:57, schrieb Luiz Capitulino: > > On Wed, 25 Jan 2012 10:42:04 -0200 > > Luiz Capitulino wrote: > > > >> On Wed, 25 Jan 2012 09:41:20 +0100 > >> Kevin Wolf wrote: > >&g

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-30 Thread Luiz Capitulino
On Fri, 27 Jan 2012 13:10:39 +0100 Paolo Bonzini wrote: > On 01/24/2012 07:16 PM, Luiz Capitulino wrote: > > @@ -237,6 +238,17 @@ static bool do_check_io_limits(BlockIOLimit *io_limits) > > return true; > > } > > > > +static void on_medium_eject(Blo

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 11:07:10 -0600 Michael Roth wrote: > On 01/30/2012 09:58 AM, Eric Blake wrote: > > On 01/30/2012 07:44 AM, Luiz Capitulino wrote: > >> I think we should do the following then: > >> > >> 1. Drop the set-support-level command > >&

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 17:08:33 +0100 Michal Privoznik wrote: > On 30.01.2012 15:44, Luiz Capitulino wrote: > > On Mon, 30 Jan 2012 07:54:56 -0600 > > Anthony Liguori wrote: > > > >> On 01/30/2012 06:57 AM, Luiz Capitulino wrote: > >>> On Thu, 26 Jan

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-31 Thread Luiz Capitulino
On Tue, 31 Jan 2012 10:23:59 +0100 Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 30.01.2012 16:18, schrieb Luiz Capitulino: > >> On Fri, 27 Jan 2012 10:52:15 +0100 > >> Kevin Wolf wrote: > >> > >>> Am 26.01.2012 18:57, schrieb L

[Qemu-devel] [PATCH v8 0/4]: qemu-ga: add guest-suspend commands

2012-01-31 Thread Luiz Capitulino
v8 o Split the guest-suspend command into guest-suspend-disk, guest-suspend-ram and guest-suspend-hybrid (this required some refactorings) o Drop ga_has_support_level usage qapi-schema-guest.json | 75 qemu-ga.c | 20 - qga/guest-agent-commands.c |

[Qemu-devel] [PATCH 3/4] qemu-ga: add guest-suspend-ram

2012-01-31 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 28 qga/guest-agent-commands.c | 10 ++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index da2b240..cc914ad 100644 --- a

[Qemu-devel] [PATCH 4/4] qemu-ga: add guest-suspend-hybrid

2012-01-31 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 23 +++ qga/guest-agent-commands.c | 10 ++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index cc914ad..9b9ecc9 100644 --- a/qapi

[Qemu-devel] [PATCH 2/4] qemu-ga: add guest-suspend-disk

2012-01-31 Thread Luiz Capitulino
ing their exit status to qemu-ga is necessary. The approach explained above avoids that complexity. Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 24 ++ qemu-ga.c | 18 - qga/guest-agent-commands.c | 188 3

[Qemu-devel] [PATCH 1/4] qemu-ga: set O_NONBLOCK for serial channels

2012-01-31 Thread Luiz Capitulino
This fixes a bug when using -m isa-serial where qemu-ga will hang on a read()'s when communicating to the host via isa-serial. Original fix by Michael Roth. Signed-off-by: Luiz Capitulino --- qemu-ga.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-ga.c b

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-03 Thread Luiz Capitulino
On Thu, 2 Feb 2012 13:58:52 -0600 Michael Roth wrote: > These patches apply on top of qemu.git master, and can also be obtained from: > git://github.com/mdroth/qemu.git qga-win32-v2 > > Luiz/Gal, I decided not to roll the suspend/hibernate stuff into this series > since the s3 situation isn't f

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-03 Thread Luiz Capitulino
On Fri, 03 Feb 2012 10:37:25 -0600 Michael Roth wrote: > On 02/03/2012 08:18 AM, Luiz Capitulino wrote: > > On Thu, 2 Feb 2012 13:58:52 -0600 > > Michael Roth wrote: > > > >> These patches apply on top of qemu.git master, and can also be obtained > >

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-03 Thread Luiz Capitulino
On Fri, 03 Feb 2012 11:23:05 -0600 Michael Roth wrote: > On 02/03/2012 10:45 AM, Luiz Capitulino wrote: > > On Fri, 03 Feb 2012 10:37:25 -0600 > > Michael Roth wrote: > > > >> On 02/03/2012 08:18 AM, Luiz Capitulino wrote: > >>> On Thu, 2 Feb 2012

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-06 Thread Luiz Capitulino
On Sat, 4 Feb 2012 10:34:32 -0500 "Kevin O'Connor" wrote: > On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote: > > On Fri, 03 Feb 2012 11:23:05 -0600 > > Michael Roth wrote: > > > I'd been tracking Gerd's QMP wakeup series as the s

[Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-07 Thread Luiz Capitulino
I've tried to implement a BLOCK_MEDIUM_EJECT event that, as we discussed[1], would be emitted by guest-initiated ejects and by the QMP/HMP eject and change commands. However, that turned to be a bit problematic, because the eject and change commands don't exactly handle tray movements: they actual

[Qemu-devel] [PATCH 3/5] block: bdrv_eject(): Add tray_changed parameter

2012-02-07 Thread Luiz Capitulino
It's true if the tray has changed its state. This is going to be used by the next commit. Signed-off-by: Luiz Capitulino --- block.c|2 +- block.h|2 +- block/raw.c|2 +- hw/ide/atapi.c |2 +- hw/ide/core.c |2 +- hw/scsi-disk.c |2 +- 6

[Qemu-devel] [PATCH 1/5] block: Rename bdrv_mon_event() & BlockMonEventAction

2012-02-07 Thread Luiz Capitulino
They are QMP events, not monitor events. Rename them accordingly. Signed-off-by: Luiz Capitulino --- block.c |4 ++-- block.h |6 +++--- hw/ide/core.c |6 +++--- hw/scsi-disk.c |6 +++--- hw/virtio-blk.c |6 +++--- 5 files changed, 14 insertions(+), 14

[Qemu-devel] [PATCH 5/5] qmp: add the BLOCK_MEDIUM_CHANGED event

2012-02-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- QMP/qmp-events.txt | 17 + block.c| 12 monitor.c |3 +++ monitor.h |1 + 4 files changed, 33 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index

[Qemu-devel] [PATCH 4/5] qmp: add the GUEST_MEDIUM_EJECTED event

2012-02-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- QMP/qmp-events.txt | 21 + block.c| 15 +++ monitor.c |3 +++ monitor.h |1 + 4 files changed, 40 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index

[Qemu-devel] [PATCH 2/5] block: bdrv_eject(): Make eject_flag a real bool

2012-02-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- block.c |2 +- block.h |2 +- block/raw-posix.c |6 +++--- block/raw.c |2 +- block_int.h |2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c index 160b9de..4042ada 100644

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Luiz Capitulino
On Tue, 07 Feb 2012 14:34:12 +0100 Kevin Wolf wrote: > The other message types could possibly be implemented as QMP commands. I > guess we might need to attach multiple QMP monitors for this to work > (one for libvirt, one for the rephub). I'm not sure if there is a > fundamental problem with thi

Re: [Qemu-devel] [RFC Patch 1/7]Qemu: Enhance "info block" to display host cache setting

2012-02-08 Thread Luiz Capitulino
On Wed, 01 Feb 2012 08:36:14 +0530 Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. > > Example: > (qemu) info block > ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 > > Enhanced to display "hostcache" setting: > (qemu) inf

Re: [Qemu-devel] [RFC Patch 3/7]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-02-08 Thread Luiz Capitulino
On Wed, 01 Feb 2012 08:36:41 +0530 Supriya Kannery wrote: > New command "block_set_hostcache" added for dynamically changing > host pagecache setting of a block device. > > Usage: > block_set_hostcache > = block device > = on/off > > Example: > (qemu) block_set_hostcache ide0-hd0

Re: [Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers

2012-02-08 Thread Luiz Capitulino
On Tue, 07 Feb 2012 10:12:34 +0100 Paolo Bonzini wrote: > On 02/06/2012 03:16 PM, Anthony Liguori wrote: > > > >> Move the creation of QmpInputVisitor and QmpOutputVisitor from > >> qmp.c to qom/object.c, since it's the only practical way to access > >> object properties. > >> > >> Signed-off-by:

[Qemu-devel] [PATCH 0/6] QMP: add balloon-get-memory-stats command

2012-02-08 Thread Luiz Capitulino
This series re-enables the balloon memory statistics feature disabled long ago by commit 11724ff. The feature has been disabled because it added a severe bug: query-balloon would hang if the guest didn't respond. This, in turn, would also cause a hang in libvirt. To avoid that bug, the solution i

[Qemu-devel] [PATCH 1/6] balloon: qmp_balloon(): Use error_set()

2012-02-08 Thread Luiz Capitulino
Commit d72f326431e280a619a0fd55e27d3737747f8178 converted the balloon command to the QAPI, but forgot to convert one qerror_report() usage. Fix it. Signed-off-by: Luiz Capitulino --- balloon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/balloon.c b/balloon.c index

[Qemu-devel] [PATCH 2/6] balloon: Drop unused include

2012-02-08 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- balloon.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/balloon.h b/balloon.h index b60fd5d..17fe300 100644 --- a/balloon.h +++ b/balloon.h @@ -14,7 +14,6 @@ #ifndef _QEMU_BALLOON_H #define _QEMU_BALLOON_H -#include "moni

[Qemu-devel] [PATCH 3/6] balloon: Rename QEMUBalloonStatus to QEMUBalloonInfo

2012-02-08 Thread Luiz Capitulino
Next commit will introduce the QEMUBalloonStats type, it can cause confusion with QEMUBalloonStatus. Also, QEMUBalloonInfo matches better with BalloonInfo, which is the type used to return balloon information in QMP. Signed-off-by: Luiz Capitulino --- balloon.c | 18

[Qemu-devel] [PATCH 5/6] balloon: Drop old stats interface

2012-02-08 Thread Luiz Capitulino
It has never been used and next patches will introduce a new, usable interface. Note that dropping this won't break compatibility because all fields are optional. Signed-off-by: Luiz Capitulino --- hmp.c| 25 + qapi-schema.json |

[Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-08 Thread Luiz Capitulino
27;t block. When the memory stats are made available by the guest, they are returned to the client as an QMP event. Signed-off-by: Luiz Capitulino --- QMP/qmp-events.txt | 36 balloon.c | 30 +++- balloon.h |4 ++- hw/virtio

[Qemu-devel] [PATCH 4/6] balloon: Refactor kvm sync mmu check

2012-02-08 Thread Luiz Capitulino
qmp_query_balloon() and qmp_balloon() perform the same check, move it to check_kvm_sync_mmu(). Signed-off-by: Luiz Capitulino --- balloon.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/balloon.c b/balloon.c index b32b487..d340ae3 100644 --- a/balloon.c

[Qemu-devel] [TRIVIAL] virtio_cleanup(): Remove unneeded g_free() parameter check

2012-02-09 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/virtio.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 74cc038..064aecf 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -845,8 +845,7 @@ int virtio_load(VirtIODevice *vdev, QEMUFile *f) void

Re: [Qemu-devel] [Qemu-trivial] [TRIVIAL] virtio_cleanup(): Remove unneeded g_free() parameter check

2012-02-09 Thread Luiz Capitulino
On Thu, 9 Feb 2012 15:28:58 + Stefan Hajnoczi wrote: > On Thu, Feb 09, 2012 at 11:29:42AM -0200, Luiz Capitulino wrote: > > > > Signed-off-by: Luiz Capitulino > > --- > > hw/virtio.c |3 +-- > > 1 files changed, 1 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-09 Thread Luiz Capitulino
On Thu, 09 Feb 2012 16:01:21 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > I've tried to implement a BLOCK_MEDIUM_EJECT event that, as we discussed[1], > > would be emitted by guest-initiated ejects and by the QMP/HMP eject and > > change > &

Re: [Qemu-devel] [PATCH 10/19] qemu-char: Chardev open error reporting, !_WIN32 part

2012-02-09 Thread Luiz Capitulino
On Thu, 09 Feb 2012 17:19:00 +0100 Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 09.02.2012 16:16, schrieb Markus Armbruster: > >> Kevin Wolf writes: > >> > >>> Am 07.02.2012 15:09, schrieb Markus Armbruster: > This part takes care of backends "file", "pipe", "pty" and "stdio".

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Luiz Capitulino
On Fri, 10 Feb 2012 10:36:06 +0100 Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 02/09/2012 04:01 PM, Markus Armbruster wrote: > >> Your GUEST_MEDIUM_EJECTED does*not* track my open<-> closed. I think > >> it's more complex than a straight open<-> closed event. Evidence: your >

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-10 Thread Luiz Capitulino
On Thu, 9 Feb 2012 13:26:40 -0600 Adam Litke wrote: > On Wed, Feb 08, 2012 at 06:30:40PM -0200, Luiz Capitulino wrote: > > This commit adds a QMP API for the guest provided memory statistics > > (long disabled by commit 07b0403dfc2b2ac179ae5b48105096cc2d03375a). > > >

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Luiz Capitulino
On Fri, 10 Feb 2012 10:27:21 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 09 Feb 2012 16:01:21 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > I've tried to implement

Re: [Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor command

2012-02-10 Thread Luiz Capitulino
On Tue, 7 Feb 2012 14:38:40 + "Daniel P. Berrange" wrote: > From: "Daniel P. Berrange" > > This is a followup to > > http://patchwork.ozlabs.org/patch/121004/ > > With the acceptance of some new APIs to libspice-server.so it > is possible to add support for SPICE to the 'add_client' >

Re: [Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor command

2012-02-10 Thread Luiz Capitulino
On Fri, 10 Feb 2012 12:30:21 +0100 Gerd Hoffmann wrote: > On 02/07/12 15:38, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > This is a followup to > > > > http://patchwork.ozlabs.org/patch/121004/ > > > > With the acceptance of some new APIs to libspice-server.so it > > is

[Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-10 Thread Luiz Capitulino
This is a rebase of Anthony's conversion, from his glib branch; and this is also the beginning of the conversion of complex commands to the qapi. There are two important changes that should be observed: 1. patch 5/6 purges the 'mon' object from migration code. One of the consequences is that

[Qemu-devel] [PATCH 1/6] QError: Introduce new errors for the migration command

2012-02-10 Thread Luiz Capitulino
The new errors are QERR_MIGRATION_ACTIVE and QERR_MIGRATION_NOT_SUPPORTED, which are going to be used by the QAPI converted migration command. Signed-off-by: Luiz Capitulino --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a

[Qemu-devel] [PATCH 3/6] QDict: Introduce qdict_copy()

2012-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- check-qdict.c | 29 + qdict.c | 18 ++ qdict.h |1 + 3 files changed, 48 insertions(+), 0 deletions(-) diff --git a/check-qdict.c b/check-qdict.c index fc0d276..12c73ab 100644 --- a/check-qdict.c

[Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-10 Thread Luiz Capitulino
() calls have been converted into DPRINTF() ones. There are a few remaining Monitor objects, those are going to be dropped by the next commit. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- arch_init.c |2 +- block-migration.c | 58

[Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-10 Thread Luiz Capitulino
k is relased and the user can use it normally. All these changes should be transparent to the user. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +- hmp.c| 51 + hmp.h|1 +

[Qemu-devel] [PATCH 4/6] Error: Introduce error_copy()

2012-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- error.c | 12 error.h |5 + 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/error.c b/error.c index 990050f..d85e136 100644 --- a/error.c +++ b/error.c @@ -43,6 +43,18 @@ void error_set(Error **errp, const char *fmt

[Qemu-devel] [PATCH 2/6] monitor: Introduce qemu_get_fd()

2012-02-10 Thread Luiz Capitulino
Get the file-descriptor from 'cur_mon', will be used by the QAPI converted migration command. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- monitor.c |5 + monitor.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monit

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 09:59:07 +0100 Jan Kiszka wrote: > On 2012-02-10 20:31, Luiz Capitulino wrote: > > This is a rebase of Anthony's conversion, from his glib branch; and this is > > also the beginning of the conversion of complex commands to the qapi. > > > >

Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 10:02:54 +0100 Jan Kiszka wrote: > On 2012-02-10 20:31, Luiz Capitulino wrote: > > The Monitor object is passed back and forth within the migration/savevm > > code so that it can print errors and progress to the user. > > > > However, that app

Re: [Qemu-devel] [RFC][PATCH 01/16 v6] monitor: introduce qemu_suspend_monitor()/qemu_resume_monitor()

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 09:51:04 +0100 Jan Kiszka wrote: > On 2012-02-15 03:54, Wen Congyang wrote: > > At 02/15/2012 12:19 AM, Jan Kiszka Wrote: > >> On 2012-02-09 04:19, Wen Congyang wrote: > >>> Sync command needs these two APIs to suspend/resume monitor. > >>> > >>> Signed-off-by: Wen Congyang >

Re: [Qemu-devel] [PATCH 4/6] Error: Introduce error_copy()

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 10:04:50 +0100 Paolo Bonzini wrote: > On 02/10/2012 08:31 PM, Luiz Capitulino wrote: > > +err_new = g_malloc0(sizeof(*err)); > > +err_new->obj = qdict_copy(err->obj); > > +err_new->msg = g_strdup(err->msg); > > +err_new

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 17:07:16 +0800 Wen Congyang wrote: > At 02/11/2012 03:31 AM, Luiz Capitulino Wrote: > > The migrate command is one of those commands where HMP and QMP completely > > mix up together. This made the conversion to the QAPI (which separates the > > command i

Re: [Qemu-devel] [PATCH 3/6] QDict: Introduce qdict_copy()

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 14:10:32 +0100 Juan Quintela wrote: > Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > > > /** > > + * qdict_copy(): Build a new dictionary from an existing one. > > + */ > > +QDict *qdict_copy(const QDict *from

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 10:01:22 -0600 Michael Roth wrote: > On Wed, Feb 15, 2012 at 02:25:49PM +0100, Juan Quintela wrote: > > Luiz Capitulino wrote: > > > The migrate command is one of those commands where HMP and QMP completely > > > mix up together. This made the co

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 14:34:52 +0100 Jan Kiszka wrote: > On 2012-02-15 13:49, Luiz Capitulino wrote: > > On Wed, 15 Feb 2012 09:59:07 +0100 > > Jan Kiszka wrote: > > > >> On 2012-02-10 20:31, Luiz Capitulino wrote: > >>> This is a rebase of Anthony&#x

Re: [Qemu-devel] [PATCH v3] Add SPICE support to add_client monitor command

2012-02-15 Thread Luiz Capitulino
ptional' flag to new parameters documented > - Added no-op impl of qemu_spice_display_add_client when >SPICE is disabled during build > > Signed-off-by: Daniel P. Berrange FWIW: Acked-by: Luiz Capitulino > --- > monitor.c |9 +++-- > qmp-commands

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 18:39:31 +0100 Jan Kiszka wrote: > On 2012-02-15 18:23, Luiz Capitulino wrote: > > On Wed, 15 Feb 2012 14:34:52 +0100 > > Jan Kiszka wrote: > > > >> On 2012-02-15 13:49, Luiz Capitulino wrote: > >>> On Wed, 15 Feb 2012 09:59:07 +010

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 08:34:29 -0600 Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. I liked this one, but I think the emu and the Q are too dark.

Re: [Qemu-devel] [MASCOT CONTEST] Clare Liguori #1

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 08:46:28 -0600 Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. ACK

[Qemu-devel] [PATCH v2 0/4]: QMP: add BLOCK_MEDIUM_EJECT event

2012-02-15 Thread Luiz Capitulino
There's been one non-rfc patch and one or two rfc ones. This is v2 of the non-rfc one. I think this version does what Kevin and Markus were asking: the event is emitted whenever the tray moves, be it the guest or HMP/QMP commands. In a previous email I said that I'd be reviving an old series that

[Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-15 Thread Luiz Capitulino
It's emitted whenever the tray is moved by the guest or by HMP/QMP commands. Signed-off-by: Luiz Capitulino --- QMP/qmp-events.txt | 17 + block.c| 24 monitor.c |3 +++ monitor.h |1 + 4 files change

[Qemu-devel] [PATCH 2/4] block: bdrv_eject(): Make eject_flag a real bool

2012-02-15 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- block.c |2 +- block.h |2 +- block/raw-posix.c |6 +++--- block/raw.c |2 +- block_int.h |2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c index d867d0f..b5710e1 100644

[Qemu-devel] [PATCH 3/4] block: bdrv_eject(): Add tray_changed parameter

2012-02-15 Thread Luiz Capitulino
It's true if the tray has changed its state. This is going to be used by the next commit. Signed-off-by: Luiz Capitulino --- block.c|2 +- block.h|2 +- block/raw.c|2 +- hw/ide/atapi.c |2 +- hw/ide/core.c |2 +- hw/scsi-disk.c |2 +- 6

[Qemu-devel] [PATCH 1/4] block: Rename bdrv_mon_event() & BlockMonEventAction

2012-02-15 Thread Luiz Capitulino
They are QMP events, not monitor events. Rename them accordingly. Also, move bdrv_emit_qmp_error_event() up in the file. A new event will be added soon and it's good to have them next each other. Signed-off-by: Luiz Capitulino --- block.c |

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 10:25:43 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > It's emitted whenever the tray is moved by the guest or by HMP/QMP > > commands. > > I like the simplicity of this patch. A few remarks inline. > > > Signed-off

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 11:14:47 -0200 Luiz Capitulino wrote: > On Thu, 16 Feb 2012 10:25:43 +0100 > Markus Armbruster wrote: > > > Luiz Capitulino writes: > > > > > It's emitted whenever the tray is moved by the guest or by HMP/QMP > > > commands.

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 14:31:56 +0100 Kevin Wolf wrote: > Am 16.02.2012 14:14, schrieb Luiz Capitulino: > > On Thu, 16 Feb 2012 10:25:43 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >>> It's emitt

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-16 Thread Luiz Capitulino
On Thu, 16 Feb 2012 19:30:13 +0100 Markus Armbruster wrote: > > We're probably taking shortcuts so that this > > function really sees a closed -> closed transition when we really have > > closed -> open -> closed. > > Let's figure out how this stuff really works. > > 1. Gues

Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event

2012-02-17 Thread Luiz Capitulino
On Fri, 17 Feb 2012 12:44:28 +0100 Markus Armbruster wrote: > >> I figure Luiz's patch works. But maybe it could be simplified some by > >> replacing bdrv_dev_change_media_cb() by a "open/close tray" callback > >> that returns whether it moved. bdrv_dev_change_media_cb() would then > >> simply

Re: [Qemu-devel] [PATCH v2 0/4]: QMP: add BLOCK_MEDIUM_EJECT event

2012-02-17 Thread Luiz Capitulino
On Fri, 17 Feb 2012 11:49:21 +0100 Paolo Bonzini wrote: > On 02/15/2012 07:42 PM, Luiz Capitulino wrote: > > There's been one non-rfc patch and one or two rfc ones. This is v2 of the > > non-rfc one. > > > > I think this version does what Kevin and Markus were

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-17 Thread Luiz Capitulino
On Fri, 17 Feb 2012 10:55:41 -0600 Anthony Liguori wrote: > On 02/08/2012 02:30 PM, Luiz Capitulino wrote: > > This commit adds a QMP API for the guest provided memory statistics > > (long disabled by commit 07b0403dfc2b2ac179ae5b48105096cc2d03375a). > > > > The app

Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-17 Thread Luiz Capitulino
On Wed, 15 Feb 2012 11:28:21 +0100 Gerd Hoffmann wrote: > Send qmp events on suspend and wakeup so libvirt > has a chance to track the vm state. > > Signed-off-by: Gerd Hoffmann > --- > monitor.c |6 ++ > monitor.h |2 ++ > vl.c | 15 +++ > 3 files changed, 23 in

Re: [Qemu-devel] [PATCH v5 07/12] suspend: add system_wakeup monitor command

2012-02-17 Thread Luiz Capitulino
On Wed, 15 Feb 2012 11:28:16 +0100 Gerd Hoffmann wrote: > This patch adds the system_wakeup monitor command which will simply > wake up suspended guests. > > Signed-off-by: Gerd Hoffmann > --- > hmp-commands.hx | 14 ++ > hmp.c|5 + > hmp.h|1

[Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-17 Thread Luiz Capitulino
The event name changed, which caused the subject to change too, hope this won't cause confusion. v3 o Rename the event to DEVICE_TRAY_MOVED o Rename the 'ejected' event data to 'tray-open' o Only call bdrv_eject() if the tray state changed o Drop ide_tray_state_post_load() QMP/qmp-events.txt |

[Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load()

2012-02-17 Thread Luiz Capitulino
ed by the next commit. Signed-off-by: Luiz Capitulino --- hw/ide/core.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 0856385..ce570a7 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2077,15 +2077,6 @@ static

Re: [Qemu-devel] [PATCH 01/23] target-i386: return Error from cpu_x86_find_by_name()

2012-10-10 Thread Luiz Capitulino
On Wed, 10 Oct 2012 16:38:10 +0200 Igor Mammedov wrote: > On Wed, 10 Oct 2012 16:05:10 +0200 > Andreas Färber wrote: > > > Am 02.10.2012 17:36, schrieb Igor Mammedov: > > > it will allow to use property setters there later. > > > > > > Signed-off-by: Igor Mammedov > > > Reviewed-by: Don Slutz

Re: [Qemu-devel] [PATCH v3] target-i386: initialize APIC at CPU level

2012-10-10 Thread Luiz Capitulino
On Wed, 10 Oct 2012 12:01:29 +0200 Andreas Färber wrote: > Am 09.10.2012 19:17, schrieb Igor Mammedov: > > (L)APIC is a part of cpu [1] so move APIC initialization inside of > > x86_cpu object. Since cpu_model and override flags currently specify > > whether APIC should be created or not, APIC cr

<    1   2   3   4   5   6   7   8   9   10   >