Re: Review Board 1.6.10 released

2012-07-25 Thread Phil Hom
The problem turned out to be the RPM spec file for reviewboard listed Djblets 0.6.20, while we upgraded to 0.6.21. There were auth module errors in the reviewboard log. This has been fixed by re-rolling the reviewboard RPM. Thanks for your help. Phil On Wednesday, July 25, 2012 2:00:36 PM UTC

Re: Review Board 1.6.10 released

2012-07-25 Thread Christian Hammond
We make use of setuptools-provided Python Entrypoints, which register some scannable bits of data for things like authentication modules. It sounds like those registrations got lost somehow in your packaging. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewbo

Re: Review Board 1.6.10 released

2012-07-25 Thread Phil Hom
We grabed the gzips from the releases directory and created RPMs for DJblets 0.6.21 and reviewboard 1.6.10, then installed the RPMs, then ran rb-site upgrade. We used RPMs before for 1.6.3, so continued doing it this way just in case we need to back out. On Wednesday, July 25, 2012 1:05:27 PM

Re : Reviewer to close review request

2012-07-25 Thread Gilles Moris
"Edit review request" is the permission you are looking for. Envoyé depuis mon Xperia™ S Message original Objet : Reviewer to close review request De : Peter Konneker À : reviewboard@googlegroups.com Cc : Is there a permission that can be set on a user to allow them to close

Re: Reviewer to close review request

2012-07-25 Thread Peter Konneker
Okay. I tried playing with that, but will have to try again. :) So we have a post-commit hook running that is posting the review request, then we want the reviewer to be able to come in, look at the code and close it out. So the owner pushes up the code, then the review request is pushed up autom

Re: Reviewer to close review request

2012-07-25 Thread Christian Hammond
Yep, there's a Can Change Status permission you can set on a user that will allow them to do just that. Is it not the owner that's committing the code? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, J

Re: Review Board 1.6.10 released

2012-07-25 Thread Christian Hammond
Did you upgrade using pip or easy_install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:40 PM, Phil Hom wrote: > We upgraded from 1.6.3 to 1.6.10, everything looks good. > Except

Reviewer to close review request

2012-07-25 Thread Peter Konneker
Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is d

Re: Review Board 1.6.10 released

2012-07-25 Thread Phil Hom
We upgraded from 1.6.3 to 1.6.10, everything looks good. Except the Authentication Settings page only shows Standard Reg and Legacy, no LDAP, AD, or others. Is there something I'm misssing. THanks. Phil On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote: > > Hey everyone, > > We

Re: P4PythonInstaller issue on Ubuntu 11.10

2012-07-25 Thread Christian Hammond
Thanks. I've made the change upstream. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 3:56 AM, yIzeki __ wrote: > Hi, > > Sorry for the long delay. Was quite busy.. > Anyway I've trie

Re: P4PythonInstaller issue on Ubuntu 11.10

2012-07-25 Thread yIzeki __
Hi, Sorry for the long delay. Was quite busy.. Anyway I've tried the modified P4PythonInstaller in my Ubuntu 11.10, and it seems to be working fine for me. (I'm ignoring several warnings that occurred on during compilation) Here is diff of setup.py: --- ./setup.py 2009-07-30 18:02:38.0