Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110447 --- The comment here https://issues.apache.org/jira/browse/AURORA-330

Re: Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-15 Thread Bill Farner
> On Dec. 15, 2015, 11:46 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/HttpStatsFilter.java, line 57 > > > > > > Drive by post-commit comment. Can we not supress deprecation without a

Re: Review Request 41413: Add PMD coverage for test sources.

2015-12-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41413/#review110579 --- Ship it! Ship It! - Zameer Manji On Dec. 15, 2015, 3:31 p.m.,

Review Request 41413: Add PMD coverage for test sources.

2015-12-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41413/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description

Re: Review Request 41413: Add PMD coverage for test sources.

2015-12-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41413/#review110587 --- Ship it! Master (fe9b460) is green with this patch.

Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/ --- Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.

Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110577 --- ping? - Bill Farner On Dec. 14, 2015, 2:36 p.m., Bill Farner

Re: Review Request 41413: Add PMD coverage for test sources.

2015-12-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41413/ --- (Updated Dec. 15, 2015, 3:31 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110615 --- Ship it! Sigh.. - Maxim Khutornenko On Dec. 14, 2015, 10:36

Re: Review Request 41226: Handling task event race in updater.

2015-12-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41226/#review110614 --- Ping. - Maxim Khutornenko On Dec. 11, 2015, 1:33 a.m., Maxim

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110612 --- Looks good overall! A few comments below.

Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110616 --- Please, cleanup docs as well. There are quite a few "aurora job

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110598 --- Master (fb8155d) is red with this patch.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110603 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/ --- (Updated Dec. 16, 2015, 2:13 a.m.) Review request for Aurora, Maxim

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110635 --- Ship it! Master (fb8155d) is green with this patch.