Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96438 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 3:28 p.m., Max

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 25, 2015, 10:28 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96278 --- Ship it! Master (f202f2d) is green with this patch. ./build-suppo

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 25, 2015, 12:12 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TierManager.java, line 39 > > > > > > I suggest the 'prod' constant go in api.thrift. This will require deprecation cyc

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 25, 2015, 12:54 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 > > > > > > Will this attribute be required in the future? > > Maxim Khutornenko wrote: > Abs

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96229 --- src/main/java/org/apache/aurora/scheduler/TierManager.java (line 38

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 > > > > > > Will this attribute be required in the future? > > Maxim Khutornenko wrote: > Abs

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 > > > > > > Will this attribute be required in the future? > > Maxim Khutornenko wrote: > Abs

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 > > > > > > Will this attribute be required in the future? > > Maxim Khutornenko wrote: > Abs

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 24, 2015, 9:21 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > > > > > Revert? > > Maxim Khutornenko wrote: > There was a `production = True` kvarg added that required to reforma

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 > > > > > > Will this attribute be required in the future? Absolutely. Otherwise, how will users

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 1 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > > > > > Revert? > > Maxim Khutornenko wrote: > There was a `production = True` kvarg added that required to reforma

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > > > > > Revert? > > Maxim Khutornenko wrote: > There was a `production = True` kvarg added that required to reforma

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96199 --- Ship it! api/src/main/thrift/org/apache/aurora/gen/api.thrift (lin

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 1 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 191 > > > > > > consider `NOT NULL` here, and apply the implicit tier=defaut behavior

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 1 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > > > > > Revert? > > Maxim Khutornenko wrote: > There was a `production = True` kvarg added that required to reforma

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > > > > > Revert? > > Maxim Khutornenko wrote: > There was a `production = True` kvarg added that required to reforma

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > > > > > Revert? > > Maxim Khutornenko wrote: > There was a `production = True` kvarg added that required to reforma

Re: Review Request 37719: Revocable: schema changes.

> On Aug. 24, 2015, 8 p.m., Bill Farner wrote: > > examples/jobs/hello_world.aurora, line 29 > > > > > > Revert? There was a `production = True` kvarg added that required to reformat here. This is to enforce product

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96185 --- examples/jobs/hello_world.aurora (line 29)

Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1414