[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5940/3/common/thrift/generate_error_codes.py

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5940/3/common/thrift/generate_error_codes.py

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-09 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new patch set (#2). Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic This is part 2 of the

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-d

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#12). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of Imp

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/logging-support.cc

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 3: Code-Review+2 Rebase, keep Dan's +2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/259/

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File be/src/exp

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File be/src/expr

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs This uses the existing infr

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 23: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscri

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/3/be/src/exprs/decimal-operators-ir

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/4/be/src/udf/udf.h File be/src/udf

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/3/be/src/runtime/decimal-value.in

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-4809: Add Stability for codegen constants .. Abandoned Conflicts with Michael's constant injection refactor. -- To view, visit http://gerrit.cloudera.org:8080/5848

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. IMPALA-2020: Add rounding when casting from decimal to int First implementation of rounding mode on CAS

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-09 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new change for review. http://gerrit.cloudera.org:8080/5962 Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. IMPALA-3410 [DOCS] Rework Impala authentication t

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has submitted this change and it was merged. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky The test should allow Unpin() to fail with a

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5940 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-4809: Codegen support for DECIMAL V2

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5950/1/be/src/codegen/llvm-codegen.h File be/src/codegen

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches from

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches from

[Impala-ASF-CR] IMPALA-4809: Codegen support for DECIMAL V2

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5950/1/be/src/exec/partitioned-aggregation-node.cc File

[Impala-ASF-CR] IMPALA-4809: Codegen support for DECIMAL V2

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: (16 comments) Did you verify performance of the decimal->decimal CAST path to make sure constant inject

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches from

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/5816/4/be/src/exec/union-node.cc File be/src/exec/

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5940 To unsubscribe,

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 21: Is that just a rebase? Any fixes needed for the last failing run? -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#6). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL ret

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-09 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#21). Change subject: IMPALA-4729: Implement REPLACE()

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 1: > Why doesn't this change also pull in the validation of the > resulting Decimal types to validat

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#2). Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. IMPALA-4810: fix incorrect expr-test decimal types Many of the types for the decimal round/truncate and related t

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 2: Code-Review+2 Here is a screenshot from my dev box for the catalog/memz h

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 1: Why doesn't this change also pull in the validation of the resulting Decimal types to validate t

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 2: Code-Review+2 Do you have an example of what the /memz page now looks like while runni

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/5959 Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. IMPALA-4810: fix incorrect expr-test decimal types Many of the types f

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-02-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. Patch Set 1: (1 comment) Nice! I think it looks good, just a comment about some additional test cases a

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. IMPALA-3410 [DOCS] Rework Impala security topics to be generic This is part 1

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5931 To unsu

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-02-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5958 Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu This detect

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-09 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5931 To unsubscrib

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/38/ -

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 23: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/258/ --

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 23: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscr

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to latest Kudu master .. Bump Kudu version to latest Kudu master Change-Id: Ib72a0b63cdffb852bd17e69faa0a36edbfda22d7 Reviewed

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to latest Kudu master .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5929 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. IMPALA-4849: IllegalStateException from rewritten CASE expr In SelectList.reset()

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5917 To unsubsc

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-09 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new change for review. http://gerrit.cloudera.org:8080/5957 Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. IMPALA-3411 [DOCS] Rework Impala governance topics t

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/257/ -- To

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 11: (16 comments) http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/logging-support.cc File

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 2: > Uploaded patch set 2. buffer-block-mgr-test needed an update due to the error message text c

[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky

2017-02-09 Thread Dan Hecht (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5940 to look at the new patch set (#2). Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky ..

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/3/be/src/runtime/decimal-value.inli

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: > > I'm not opposed to cleaning up the AnyVal stuff like that, but > > given that udf.h s

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5784 To uns

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. IMPALA-4818: Ensure the same number of tests are run every time This is a par

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 11: Alex beat me to it. Yes this patch does it exactly like the URLs you mentioned. The UI

[Impala-ASF-CR] [DOCS] Release note updates for Impala 2.8

2017-02-09 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: [DOCS] Release note updates for Impala 2.8 .. Patch Set 9: (3 comments) Some nits you can think about. http://gerrit.cloudera.org:8080/#/c/5668/9/docs/topics/imp

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 11: Marcel, you can make changes like you described just with a URL, see test_web_pages.py which does

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to latest Kudu master .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/256/ -- To view, visit ht

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to latest Kudu master .. Patch Set 2: Code-Review+2 prev build failed due to IMPALA-3040. rebasing -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-02-09 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 2: Code-Review-1 (1 comment) Change the article before the keydef and you're golden. The va

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File be/src

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#5). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL ret

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#4). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL ret

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#3). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version .. IMPALA-4370: Divide and modulo result types for DECIMAL version Implement the new DECIMAL return typ

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/255/ -

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/254

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 1: Rather than using a web page for making those changes, why not simply do it through a URL? (