[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/7179/10/shell/option_parse

[Impala-ASF-CR] IMPALA-5605: [DOCS] New known issue for upping thread resource limits

2017-07-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5605: [DOCS] New known issue for upping thread resource limits .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7348/1/docs/topics/impala_

[Impala-ASF-CR] IMPALA-5605: [DOCS] New known issue for upping thread resource limits

2017-07-10 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-5605: [DOCS] New known issue for upping thread resource limits .. IMPALA-5605: [DOCS] New known issue for upping thread resource limits Change-Id: I4300fcb3

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2017-07-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7388/1/docs/topics/impala_known_issues.x

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 10: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerr

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2017-07-10 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7388 Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue Because

[Impala-ASF-CR] IMPALA-5629: avoid expensive list::size() call

2017-07-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5629: avoid expensive list::size() call .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7382/2//COMMIT_MSG Commit Message: Lin

[Impala-ASF-CR] [DOCS] Advise setting vm.overcommit memory=1 in various places

2017-07-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [DOCS] Advise setting vm.overcommit_memory=1 in various places .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7349/1/docs/shared/impala_common.

[Impala-ASF-CR] IMPALA-5583: [DOCS] Document default join distribution mode query option

2017-07-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5583: [DOCS] Document default_join_distribution_mode query option .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7300/3/docs/topics/i

[Impala-ASF-CR] IMPALA-5605: [DOCS] New known issue for upping thread resource limits

2017-07-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5605: [DOCS] New known issue for upping thread resource limits .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7348/1/docs/topics/impa

[Impala-ASF-CR] [DOCS] Advise setting vm.overcommit memory=1 in various places

2017-07-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: [DOCS] Advise setting vm.overcommit_memory=1 in various places .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7349/1/docs/shared/impala_commo

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/7223/14/common/thrift/Fronten

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-07-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7175 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Hi John - Thanks for taking the time to make this change! I'll probably do the first review round h

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-10 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Giving this a bump, since my updated patch might have slipped under the radar during the holiday. --

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-07-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. IMPALA-5333: [DOCS] Document Impala ADLS support Change-Id: Id5a98217741e5d540d9874e9b30e36f

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-07-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/137/ -- To view, v

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-07-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 4: Code-Review+2 Bumping to +2 based on Sailesh's and Laurel's comments. -- To view, visit http://

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 3: Yeah I think we should avoid reporting two different values for sure. Maybe we should then

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 3: > Yeah I think we should avoid reporting two different values for > sure. Maybe we should

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-07-10 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7175/3/docs/topics/impala_adls.xml

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 3: > Thanks Matt, that's a good point. We should probably just display > that metric's value

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 3: Thanks Matt, that's a good point. We should probably just display that metric's value dire

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-07-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 4: Code-Review+1 Thanks for working on this John! LGTM Feel free to upgrade to a +2 if Laurel has n

[native-toolchain-CR] Bump Kudu version to 1070e76

2017-07-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 1070e76 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7384 To unsubscribe, visit http://gerrit.c

[native-toolchain-CR] Bump Kudu version to 1070e76

2017-07-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 1070e76 .. Bump Kudu version to 1070e76 Change-Id: I0f3c99544a35ee47502e1b3aba8a9dfb048ac0ca --- M buildall.sh 1 file changed, 1 i

[native-toolchain-CR] Bump Kudu version to 1070e76

2017-07-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1070e76 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7384 To unsubscribe, visit http://gerrit.cloudera.org

[native-toolchain-CR] Bump Kudu version to 1070e76

2017-07-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7384 Change subject: Bump Kudu version to 1070e76 .. Bump Kudu version to 1070e76 Change-Id: I0f3c99544a35ee47502e1b3aba8a9dfb048ac0ca --- M

[Impala-ASF-CR] single node perf run.py: clean up newly-added testdata

2017-07-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: single_node_perf_run.py: clean up newly-added testdata .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/833/ -- To

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 3: We also have a metric (see http endpoint /metrics) called "impala-server.start-time", and

[Impala-ASF-CR] IMPALA-5623: Fix lag() on STRING cols to release UDF mem

2017-07-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/834/ --

[Impala-ASF-CR] single node perf run.py: clean up newly-added testdata

2017-07-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: single_node_perf_run.py: clean up newly-added testdata .. Patch Set 2: Code-Review+2 rebase carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7291 To unsu

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7179 To un

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#3). Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad, catalogd

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#3). Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad, catalogd

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad, catalogd

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7363/1/be/src/util/process-state-info.cc Fi

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-10 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 10: Thank you for your help. I have resolved the merger conflict through the f

<    1   2