[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File be/src/

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-08-01 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File be/src/se

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File be/src

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-08-01 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File be/src/s

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/rpc/TAcceptQueueServer.cpp File be/s

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-28 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/catalog/catalogd-main.cc File be/src/ca

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-28 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#4). Change subject: IMPALA-5394: Handle blocked HS2 connections .. IMPALA-5394: Handle blocked HS2 connections - TThreadPoolServer calls getTransport() on a client from the Server th

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-27 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Thanks, yeah I overthought it. I'll run this through run-all-tests and post the patch. > My instinc

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: My instinct would be just to use the size of tasks_ to control the coordination. In SetupConnection

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-27 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: I'd like some advice/feedback on the approach for enforcing fe_service_threads. In my local diff, I'v

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-20 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: It looks like it'll be next week (or this weekend) before I'm able to make some time to write/test th

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-14 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Yeah, I'll give it a go. > Do you think that's something you could add to this patch? -- To view, v

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: (1 comment) Patch looks pretty good. It would be great to still respect fe_service_threads, if pos

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Hi John - Thanks for taking the time to make this change! I'll probably do the first review round h

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-10 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Giving this a bump, since my updated patch might have slipped under the radar during the holiday. --

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-06-29 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7061/3/be/src/rpc/TAcceptQueueServer.cpp File be/src/

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-06-29 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Ran the latest patch through be/fe/e2e testing. be/fe ran clean. end to end mostly ran clean. I had on

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-06-29 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#3). Change subject: IMPALA-5394: Handle blocked HS2 connections .. IMPALA-5394: Handle blocked HS2 connections - TThreadPoolServer calls getTransport() on a client from the Server th