[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9840 To unsubscribe, v

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. KUDU-2385: Fix typo in KinitContext::DoRenewal() On platforms

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: Many tests failed with: Runtime error: Failed to start a

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 2: (1 comment) Hi Todd, good suggestion. It'd be better if

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9840 to look at the new patch set (#2). Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: > Patch Set 1: > > Todd, we use this macro here: > http

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Todd, we use this macro here: https://github.com/apache/

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Code-Review+2 lgtm. Wonder if there is a better #ifdef w

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Build failure doesn't look relevant: RaftConsensusQuorumT

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9840 Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. KUDU-2385: Fix typo in KinitContext::DoRenewal() On platforms without k