Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 4, 2015, 4:13 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/ --- (Updated Aug. 4, 2015, 1:49 p.m.) Review request for mesos and Till Toenshoff.

Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/ --- Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/#review94054 --- Re-based the PR - Chris Heller On July 29, 2015, 1:41 p.m., Chris

Re: Review Request 37072: Added test for allocator update on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/#review94050 --- Patch looks great! Reviews applied: [37072] All tests passed. - M

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/#review94048 --- Patch looks great! Reviews applied: [37065] All tests passed. - M

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 4, 2015, 10:57 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 4, 2015, 10:54 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94041 --- Ship it! Pending consistency with subsequent RRs in this chain, thi

Review Request 37072: Added test for allocator update on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.ap

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94040 --- 3rdparty/libprocess/include/process/http.hpp (line 747)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 10:40 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 10:34 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 4, 2015, 10:08 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 766 > > > > > > s/and / > > Bernd Mathiske wrote: > See my previous review. This is correct syntax IMHO. See Bernds comm

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 4, 2015, 3:08 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 766 > > > > > > s/and / See my previous review. This is correct syntax IMHO. - Bernd -

Re: Review Request 36911: Removed unnecessary using directive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36911/#review94036 --- Ship it! Ship It! - Alexander Rojas On Aug. 3, 2015, 4:58 p.m.,

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94037 --- src/master/master.hpp (line 766)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94033 --- src/master/master.hpp (line 764)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94030 --- src/master/master.hpp (line 766)

Re: Review Request 37046: Merged registerFramework() and reregisterFramework().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37046/#review94028 --- Patch looks great! Reviews applied: [37046] All tests passed. - M

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 9:52 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 36050: Added test authorizer module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review94027 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m., Al

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 4, 2015, 2:39 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 916 > > > > > > I think we don't need this instance any more. I think so, too. - Bernd ---

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 3, 2015, 2:21 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.hpp, lines 26-27 > > > > > > I think we should wrap it into `master` namespace as well. `quota_handler.cpp` still lacks the `maste

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94024 --- src/master/master.hpp (line 916)

Re: Review Request 36049: Added support for modularized Authorizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94023 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m., Al

Re: Review Request 36816: Support HTTP checks in Mesos health check program

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review93562 --- src/health-check/main.cpp (line 242)

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94019 --- Patch looks great! Reviews applied: [36402] All tests passed. - M

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94018 --- Patch looks great! Reviews applied: [37045] All tests passed. - M

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review94014 --- Patch looks great! Reviews applied: [36908] All tests passed. - M

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

> On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: > > I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be > > placed inside `include/mesos/master/` instead since the authorizer is only > > for the master. Does it make sense to do that? If it does, then should we > > also

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

> On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: > > I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be > > placed inside `include/mesos/master/` instead since the authorizer is only > > for the master. Does it make sense to do that? If it does, then should we > > also

<    1   2