Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/#review200518 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:52 a.m.

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/#review200603 --- Fix it, then Ship it! 3rdparty/stout/include/stout/os/posix/st

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

2018-04-05 Thread Andrew Schwartzmeyer
> On April 5, 2018, 4:58 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/posix/stat.hpp > > Lines 66 (patched) > > > > > > Did you mean `const int_fd& fd`? Not on POSIX, it's just an `int`. > On April

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

2018-04-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/#review201462 --- Ship it! Ship It! - Joseph Wu On April 3, 2018, 10:52 p.m.,